Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Fix stack-buffer overflow with VP9 VDPAU available

2020-10-10 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ccca62ef991f0a47dfa30c3e822d91294b8afe4c added new VP9 VDPAU profiles > and as a consequence AV_PIX_FMT_VDPAU can now be twice in the list of > pixel formats used for format negotiation by ff_thread_get_format(); yet > there is only one entry in said list reserved for VDPAU, l

[FFmpeg-devel] [PATCH] avcodec/vp9: Fix stack-buffer overflow with VP9 VDPAU available

2020-10-10 Thread Andreas Rheinhardt
ccca62ef991f0a47dfa30c3e822d91294b8afe4c added new VP9 VDPAU profiles and as a consequence AV_PIX_FMT_VDPAU can now be twice in the list of pixel formats used for format negotiation by ff_thread_get_format(); yet there is only one entry in said list reserved for VDPAU, leading to a stack-buffer ove

[FFmpeg-devel] [PATCH] avformat/rtsp: don't overwrite session control uri

2020-10-10 Thread Andriy Gelman
From: Andriy Gelman Fixes #1941 Currently the session control uri gets overwritten by the media's uri when mpegts is signalled in the media description. This happens because s->nb_streams doesn't count mpegts which is instead part of the private context in RTSPStream. Instead use rt->nb_rtsp_st

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/sheervideo: Avoid code duplication when creating VLC tables

2020-10-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sat, Oct 10, 2020 at 08:59:56PM +0200, Andreas Rheinhardt wrote: >> The SheerVideo decoder uses two VLC tables and these are in turn created >> from structures (called SheerTable) that are naturally paired. This >> commit unifies these pairs of SheerTables to arrays and unifies c

Re: [FFmpeg-devel] [PATCH 1/2] swscale/utils: split range override check into its own function

2020-10-10 Thread Michael Niedermayer
On Sat, Oct 10, 2020 at 03:20:28AM +0300, Jan Ekström wrote: > --- > libswscale/utils.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libswscale/utils.c b/libswscale/utils.c > index 9ca378bd3b..832c9f873c 100644 > --- a/libswscale/utils.c > +++ b/libswscale/uti

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/sheervideo: Avoid code duplication when creating VLC tables

2020-10-10 Thread Andreas Rheinhardt
Paul B Mahol: > On Sat, Oct 10, 2020 at 08:59:56PM +0200, Andreas Rheinhardt wrote: >> The SheerVideo decoder uses two VLC tables and these are in turn created >> from structures (called SheerTable) that are naturally paired. This >> commit unifies these pairs of SheerTables to arrays and unifies c

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/sheervideo: Avoid code duplication when creating VLC tables

2020-10-10 Thread Paul B Mahol
On Sat, Oct 10, 2020 at 08:59:56PM +0200, Andreas Rheinhardt wrote: > The SheerVideo decoder uses two VLC tables and these are in turn created > from structures (called SheerTable) that are naturally paired. This > commit unifies these pairs of SheerTables to arrays and unifies creating > the VLC t

[FFmpeg-devel] [PATCH 2/3] avcodec/sheervideo: Reduce the size of static arrays

2020-10-10 Thread Andreas Rheinhardt
The SheerVideo decoder uses VLC tables which are currently stored in large arrays that contain the length of each leaf of the corresponding tree from left to right, taking 15.5KB of space. But all these arrays follow a common pattern: First the entries are ascending and then they are descending wit

[FFmpeg-devel] [PATCH 3/3] avcodec/sheervideo: Avoid code duplication when creating VLC tables

2020-10-10 Thread Andreas Rheinhardt
The SheerVideo decoder uses two VLC tables and these are in turn created from structures (called SheerTable) that are naturally paired. This commit unifies these pairs of SheerTables to arrays and unifies creating the VLC tables. Signed-off-by: Andreas Rheinhardt --- libavcodec/sheervideo.c

[FFmpeg-devel] [PATCH 1/3] avcodec/sheervideo: Don't leave context in inconsistent state upon error

2020-10-10 Thread Andreas Rheinhardt
This has happened if the format changed midstream and if the new packet is so small that it is instantaneously rejected: In this case the VLC tables were for the new format, although the context says that they are still the ones for the old format. It can also happen if the format changed midstream

[FFmpeg-devel] [PATCH] avcodec/qsvenc: use color description for h264 and hevc

2020-10-10 Thread Zivkovic, Milos
Hello, I've attached a patch that forwards the color description from AVCodecContext to mfxExtVideoSignalInfo. It has been discussed on the #ffmpeg and #ffmpeg-devel IRC channel a couple of times in the last few days. 0001-avcodec-qsvenc-use-color-description-for-h264-and-hevc.patch Description:

[FFmpeg-devel] [PATCH] avcodec/qsvenc: clear mfx frame type in submit_frame

2020-10-10 Thread Zivkovic, Milos
Hello, I've attached a patch that clears the mfxEncodeCtrl::FrameType field. Since QSVFrames are reused, this field can affect not only the frame it was supposed to affect, but also the subsequent ones. It would be enough to force a keyframe only once and that QSVFrame will have the FrameType fie

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg12: Don't pretend reading dct_dc_size_* VLCs can fail

2020-10-10 Thread Andreas Rheinhardt
Michael Niedermayer: > On Sat, Oct 10, 2020 at 12:08:20AM +0200, Andreas Rheinhardt wrote: >> Michael Niedermayer: >>> On Thu, Oct 08, 2020 at 09:53:12PM +0200, Andreas Rheinhardt wrote: It can't because the corresponding trees don't have any loose ends. Removing the checks also remo

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg12: Don't pretend reading dct_dc_size_* VLCs can fail

2020-10-10 Thread Michael Niedermayer
On Sat, Oct 10, 2020 at 12:08:20AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Thu, Oct 08, 2020 at 09:53:12PM +0200, Andreas Rheinhardt wrote: > >> It can't because the corresponding trees don't have any loose ends. > >> > >> Removing the checks also removed an instance of av_lo

[FFmpeg-devel] [PATCH 1/2] Add support for building fuzzer tools for an individual demuxer

2020-10-10 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- Makefile | 4 tools/Makefile| 3 +++ tools/target_dem_fuzzer.c | 11 ++- 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 6a0dabfc5a..c8b548d126 100644 --- a/Makefile +++ b/M

[FFmpeg-devel] [PATCH 2/2] avformat/kvag: Fix integer overflow in bitrate computation

2020-10-10 Thread Michael Niedermayer
Fixes: signed integer overflow: 1077952576 * 4 cannot be represented in type 'int' Fixes: 26152/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5674758518341632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-10 Thread Nachiket Tarate
From: Nachiket Tarate Sent: Saturday, October 10, 2020 8:30 PM To: ffmpeg-devel@ffmpeg.org Subject: [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-10 Thread Nachiket Tarate
@Martin Storsj? If you get time, kindly review this patch. -- Best Regards, Nachiket Tarate From: ffmpeg-devel on behalf of Nachiket Tarate Sent: Saturday, October 10, 2020 8:30 PM To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] libavformat/hls: a

[FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-10 Thread Nachiket Tarate
Apple HTTP Live Streaming Sample Encryption: https://developer.apple.com/library/ios/documentation/AudioVideo/Conceptual/HLS_Sample_Encryption Signed-off-by: Nachiket Tarate --- libavformat/Makefile | 2 +- libavformat/hls.c| 132 ++--- libavformat/hls_sample_aes.c | 4

[FFmpeg-devel] [RFC] License for tools/uncoded_frame.c

2020-10-10 Thread Gyan Doshi
No license is attached to tools/uncoded_frame.c as of 11a6347f9e Does LGPL v2.1 apply, by default? Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/photocd: Use ff_set_dimensions()

2020-10-10 Thread Michael Niedermayer
On Mon, Sep 21, 2020 at 12:28:37AM +0200, Paul B Mahol wrote: > On Sun, Sep 20, 2020 at 10:26:08PM +0200, Michael Niedermayer wrote: > > Fixes: out of memory > > Fixes: > > 25588/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PHOTOCD_fuzzer-6612945080156160 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/takdsp: Fix negaive shift in decorrelate_sf()

2020-10-10 Thread Michael Niedermayer
On Thu, Sep 24, 2020 at 10:20:38PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -4 > Fixes: > 25723/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TAK_fuzzer-6250580752990208 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/celp_filters: Avoid invalid negation in ff_celp_lp_synthesis_filter()

2020-10-10 Thread Michael Niedermayer
On Thu, Sep 24, 2020 at 11:03:42AM +0200, Michael Niedermayer wrote: > Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to > an unsigned type to negate this value to itself > Fixes: > 25675/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G729_fuzzer-4786580731199488 > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/sheervideo: Inline compile-time constants

2020-10-10 Thread Paul B Mahol
On Sat, Oct 10, 2020 at 06:57:04AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/sheervideo.c | 343 > 1 file changed, 172 insertions(+), 171 deletions(-) > probably fine _

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/sheervideo: Improve creating VLC tables

2020-10-10 Thread Paul B Mahol
On Sat, Oct 10, 2020 at 06:57:03AM +0200, Andreas Rheinhardt wrote: > Don't needlessly copy an array around; don't create a table with > default symbols; and use smaller types to save stack space: The longest > code here is 16 bits, so one can store the codes in this type. > > Signed-off-by: Andre

[FFmpeg-devel] [PATCH] avformat/mpegts: support demuxing AVS3

2020-10-10 Thread hanbingjie
From: hanbingjie Signed-off-by: hanbingjie --- libavformat/mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 432b1c3ea2..fe891aa100 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -806,6 +806,7 @@ static const StreamT