Re: [FFmpeg-devel] [PATCH 04/13] avcodec/mss3: Remove unnecessary free of unallocated packet

On 8/30/20, Andreas Rheinhardt wrote: > Paul B Mahol: >> On 8/29/20, Andreas Rheinhardt wrote: >>> The packet will only be allocated a few lines below. >>> >> >> You mean frame? >> > Yes. Fixed locally. Thanks. LGTM > >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavcodec/mss3.c | 1 - >

Re: [FFmpeg-devel] [PATCH] doc/decoders: Clear up description of ac3's drc_scale option

On 30-08-2020 05:18 am, Jim DeLaHunt wrote: On 2020-08-29 15:10, Aman Verma wrote: ...As an aside, am I supposed to submit the revised patch in reply to this thread or should I submit it as a new thread? This is my first time contributing to a project that uses mailing lists. The instructi

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix infinite loop with udp transport

> On Aug 30, 2020, at 1:45 AM, Andriy Gelman wrote: > > Hi Zhao, > > On Tue, 25. Aug 01:17, Zhao Zhili wrote: >> Ping again. >> >>> On Aug 17, 2020, at 8:05 AM, zhilizhao wrote: >>> >>> Please help review the patch, thanks! >>> On Aug 6, 2020, at 4:50 PM, quinkbl...@foxmail.com wrote:

Re: [FFmpeg-devel] [PATCH] avcodec: add PhotoCD decoder

Paul B Mahol: > Signed-off-by: Paul B Mahol > --- > Probably need to be applied on top of moflex v2 patch set. > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/codec_id.h | 1 + > libavcodec/photocd.c| 468

Re: [FFmpeg-devel] [PATCH 04/13] avcodec/mss3: Remove unnecessary free of unallocated packet

Paul B Mahol: > On 8/29/20, Andreas Rheinhardt wrote: >> The packet will only be allocated a few lines below. >> > > You mean frame? > Yes. Fixed locally. Thanks. >> Signed-off-by: Andreas Rheinhardt >> --- >> libavcodec/mss3.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/libavc

Re: [FFmpeg-devel] [PATCH] doc/decoders: Clear up description of ac3's drc_scale option

On 2020-08-29 15:10, Aman Verma wrote: ...As an aside, am I supposed to submit the revised patch in reply to this thread or should I submit it as a new thread? This is my first time contributing to a project that uses mailing lists. The instructions are at

Re: [FFmpeg-devel] [PATCH] doc/decoders: Clear up description of ac3's drc_scale option

On Fri, Aug 28, 2020 at 11:15 PM Jim DeLaHunt wrote: > I don't know anything about the AC-3 format or the ac3 decoder in > FFmpeg. However, I can read technical writing. I don't understand what > you are trying to say differently with this change. But even more, I > don't understand what the exist

[FFmpeg-devel] [PATCH v2] avcodec/cfhd: More strictly check tag order

This is based on the encoder and a small number of CFHD sample files It should make the decoder more robust against crafted input. Due to the lack of a proper specification it is possible that this may be too strict and may need to be tuned as files not following this ordering are found. Signed-of

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: More strictly check tag order

On Sat, Aug 29, 2020 at 11:00:13PM +0200, Paul B Mahol wrote: > On 8/29/20, Michael Niedermayer wrote: > > This is based on the encoder and a small number of CFHD sample files > > It should make the decoder more robust against crafted input. > > Due to the lack of a proper specification it is poss

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: More strictly check tag order

On 8/29/20, Michael Niedermayer wrote: > This is based on the encoder and a small number of CFHD sample files > It should make the decoder more robust against crafted input. > Due to the lack of a proper specification it is possible that this > may be too strict and may need to be tuned as files n

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: Replace a few literal numbers by named constants

LGTM On 8/29/20, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/cfhd.c | 8 > libavcodec/cfhd.h | 4 > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index 036df00f72..ea35f03869 100644

[FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: More strictly check tag order

This is based on the encoder and a small number of CFHD sample files It should make the decoder more robust against crafted input. Due to the lack of a proper specification it is possible that this may be too strict and may need to be tuned as files not following this ordering are found. Signed-of

[FFmpeg-devel] [PATCH 1/2] avcodec/cfhd: Replace a few literal numbers by named constants

Signed-off-by: Michael Niedermayer --- libavcodec/cfhd.c | 8 libavcodec/cfhd.h | 4 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index 036df00f72..ea35f03869 100644 --- a/libavcodec/cfhd.c +++ b/libavcodec/cfhd.c @@ -593,20 +5

Re: [FFmpeg-devel] [PATCH] avcodec: add PhotoCD decoder

On 8/29/20, Paul B Mahol wrote: > Signed-Goff-by: Paul B Mahol > --- > Probably need to be applied on top of moflex v2 patch set. > --- [...] > + > +static av_cold int photocd_decode_init(AVCodecContext *avctx) > +{ > +avctx->pix_fmt = AV_PIX_FMT_YUV420P; > +avctx->colorspace

Re: [FFmpeg-devel] [PATCH 06/13] avcodec/roqvideodec: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/roqvideodec.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c > index a0c293f2f0..dd045ed5eb 100644 > --- a/libavcodec/r

Re: [FFmpeg-devel] [PATCH 07/13] avcodec/roqvideoenc: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/roqvideoenc.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > LGTM > diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c > index ac05123dc6..dc6a63099d 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH 05/13] avcodec/mss3: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mss3.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > LGTM > diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c > index a301675ec2..74f4b5e671 100644 > --- a/libavcodec/mss3.c > +++

[FFmpeg-devel] [PATCH] avcodec: add PhotoCD decoder

Signed-off-by: Paul B Mahol --- Probably need to be applied on top of moflex v2 patch set. --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/photocd.c| 468

Re: [FFmpeg-devel] [PATCH 04/13] avcodec/mss3: Remove unnecessary free of unallocated packet

On 8/29/20, Andreas Rheinhardt wrote: > The packet will only be allocated a few lines below. > You mean frame? > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mss3.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c > index 113af5ba37..a301675

Re: [FFmpeg-devel] [PATCH 09/13] avcodec/wnv1: Move temporary variables from context to stack

On 8/29/20, Andreas Rheinhardt wrote: > Here it even leads to the complete removal of the context. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/wnv1.c | 40 +--- > 1 file changed, 17 insertions(+), 23 deletions(-) LGTM

Re: [FFmpeg-devel] [PATCH 02/13] avcodec/eacmv: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/eacmv.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] [PATCH 03/13] avcodec/interplayvideo: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/interplayvideo.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH 13/13] avcodec/truemotion1: Cleanup generically after init failure

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/truemotion1.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mai

Re: [FFmpeg-devel] [PATCH 12/13] avcodec/y41penc: Remove empty close function

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/y41penc.c | 6 -- > 1 file changed, 6 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 11/13] avcodec/yuv4enc: Remove empty functions

On 8/29/20, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/yuv4enc.c | 12 > 1 file changed, 12 deletions(-) > LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinf

Re: [FFmpeg-devel] [PATCH 01/13] avcodec/cinepakenc: Cleanup generically after init failure

lör 2020-08-29 klockan 19:56 +0200 skrev Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cinepakenc.c | 36 ++-- > 1 file changed, 10 insertions(+), 26 deletions(-) > > diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c > ind

Re: [FFmpeg-devel] [PATCH 08/13] avcodec/wnv1: Use LE bitstream reader, avoid copying packet, fix memleak

On 8/29/20, Andreas Rheinhardt wrote: > The Winnov WNV1 format is designed for a little-endian bitstream reader; > yet our decoder reversed every byte bitwise (in a buffer only > allocated for this purpose) to use a big-endian bitstream reader. This > commit stops this. > > Two things needed to be

[FFmpeg-devel] [PATCH 11/13] avcodec/yuv4enc: Remove empty functions

Signed-off-by: Andreas Rheinhardt --- libavcodec/yuv4enc.c | 12 1 file changed, 12 deletions(-) diff --git a/libavcodec/yuv4enc.c b/libavcodec/yuv4enc.c index f21b1f36ce..63a7fae964 100644 --- a/libavcodec/yuv4enc.c +++ b/libavcodec/yuv4enc.c @@ -23,11 +23,6 @@ #include "avcodec.h

[FFmpeg-devel] [PATCH 10/13] avcodec/bitstream: Remove outdated comment

The comment referred to the INIT_VLC_USE_STATIC flag which has been removed in 2009 in 595324e143b57a52e2329eb47b84395c70f93087; the function it referred to was removed even earlier in commit 83422c1940d963d395a64bee0cbb9c637192ce8c in 2008. Signed-off-by: Andreas Rheinhardt --- libavcodec/bitst

[FFmpeg-devel] [PATCH 09/13] avcodec/wnv1: Move temporary variables from context to stack

Here it even leads to the complete removal of the context. Signed-off-by: Andreas Rheinhardt --- libavcodec/wnv1.c | 40 +--- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/libavcodec/wnv1.c b/libavcodec/wnv1.c index 857807a951..b5cd0f0f0c 100

[FFmpeg-devel] [PATCH 06/13] avcodec/roqvideodec: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/roqvideodec.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/roqvideodec.c b/libavcodec/roqvideodec.c index a0c293f2f0..dd045ed5eb 100644 --- a/libavcodec/roqvideodec.c +++ b/libavcodec/roqvideodec.c @@ -184,11

[FFmpeg-devel] [PATCH 07/13] avcodec/roqvideoenc: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/roqvideoenc.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c index ac05123dc6..dc6a63099d 100644 --- a/libavcodec/roqvideoenc.c +++ b/libavcodec/roqvideoenc.c @@ -100

[FFmpeg-devel] [PATCH 12/13] avcodec/y41penc: Remove empty close function

Signed-off-by: Andreas Rheinhardt --- libavcodec/y41penc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/y41penc.c b/libavcodec/y41penc.c index 63752e2b44..d7d301fab5 100644 --- a/libavcodec/y41penc.c +++ b/libavcodec/y41penc.c @@ -75,11 +75,6 @@ static int y41p_encode_frame

[FFmpeg-devel] [PATCH 08/13] avcodec/wnv1: Use LE bitstream reader, avoid copying packet, fix memleak

The Winnov WNV1 format is designed for a little-endian bitstream reader; yet our decoder reversed every byte bitwise (in a buffer only allocated for this purpose) to use a big-endian bitstream reader. This commit stops this. Two things needed to be done to achieve this: The codes in the table used

[FFmpeg-devel] [PATCH 13/13] avcodec/truemotion1: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/truemotion1.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/truemotion1.c b/libavcodec/truemotion1.c index b6481cbd7c..94782fef4b 100644 --- a/libavcodec/truemotion1.c +++ b/libavcodec/truemotion1.c @@ -491,10

[FFmpeg-devel] [PATCH 03/13] avcodec/interplayvideo: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/interplayvideo.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/libavcodec/interplayvideo.c b/libavcodec/interplayvideo.c index 274641c3d1..58400b6ace 100644 --- a/libavcodec/interplayvideo.c +++ b/libavcodec/interp

[FFmpeg-devel] [PATCH 05/13] avcodec/mss3: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/mss3.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c index a301675ec2..74f4b5e671 100644 --- a/libavcodec/mss3.c +++ b/libavcodec/mss3.c @@ -844,19 +844,13 @@ static av_cold int m

[FFmpeg-devel] [PATCH 02/13] avcodec/eacmv: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/eacmv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/eacmv.c b/libavcodec/eacmv.c index 6f39d72b88..b239acffda 100644 --- a/libavcodec/eacmv.c +++ b/libavcodec/eacmv.c @@ -50,11 +50,8 @@ static av_cold int cm

[FFmpeg-devel] [PATCH 04/13] avcodec/mss3: Remove unnecessary free of unallocated packet

The packet will only be allocated a few lines below. Signed-off-by: Andreas Rheinhardt --- libavcodec/mss3.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mss3.c b/libavcodec/mss3.c index 113af5ba37..a301675ec2 100644 --- a/libavcodec/mss3.c +++ b/libavcodec/mss3.c @@ -844,7 +844

[FFmpeg-devel] [PATCH 01/13] avcodec/cinepakenc: Cleanup generically after init failure

Signed-off-by: Andreas Rheinhardt --- libavcodec/cinepakenc.c | 36 ++-- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/libavcodec/cinepakenc.c b/libavcodec/cinepakenc.c index 6024df0fba..cc125ed39e 100644 --- a/libavcodec/cinepakenc.c +++ b/libavc

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix infinite loop with udp transport

Hi Zhao, On Tue, 25. Aug 01:17, Zhao Zhili wrote: > Ping again. > > > On Aug 17, 2020, at 8:05 AM, zhilizhao wrote: > > > > Please help review the patch, thanks! > > > >> On Aug 6, 2020, at 4:50 PM, quinkbl...@foxmail.com wrote: > >> > >> From: Zhao Zhili > >> > >> User report: > >> http:/

Re: [FFmpeg-devel] [PATCH v2 1/2] adtsenc: Add ability to write MPEG2 ID

On Sat, 29 Aug 2020 at 13:27, Marvin Scholz wrote: > --- > libavformat/adtsenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > Ok ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] avcodec/truemotion2: Avoid duplicating array, fix memleak

On 8/29/20, Andreas Rheinhardt wrote: > TrueMotion 2.0 uses Huffmann trees. To parse them, the decoder allocates > arrays for the codes, their lengths and their value; afterwards a VLC > table is initialized using these values. If everything up to this point > succeeds, a new buffer of the same si

[FFmpeg-devel] [PATCH v2 1/2] adtsenc: Add ability to write MPEG2 ID

--- libavformat/adtsenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c index 9e285752eb..44ff5a70ee 100644 --- a/libavformat/adtsenc.c +++ b/libavformat/adtsenc.c @@ -40,6 +40,7 @@ typedef struct ADTSContext { int pce_siz

[FFmpeg-devel] [PATCH v2 2/2] docs: muxers: document ADTS muxer options

--- doc/muxers.texi | 25 + 1 file changed, 25 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 813b4678f4..ae8dcdd145 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -19,6 +19,31 @@ enabled demuxers and muxers. A description of some of the curre

Re: [FFmpeg-devel] [PATCH v5 2/2] libavformat/mxfenc: color_range should be inclusive

mån 2020-08-24 klockan 12:02 +0100 skrev Harry Mallon: > > On 24 Aug 2020, at 09:30, Tomas Härdin wrote: > > > > tor 2020-08-20 klockan 14:58 +0100 skrev Harry Mallon: > > > MXF CDCI color range was being set to (1 > > 1 > > > for full range but it should be (1

[FFmpeg-devel] [PATCH 4/4][VERSION 2] avformat: add moflex demuxer

Signed-off-by: Paul B Mahol --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/moflex.c | 358 +++ 3 files changed, 360 insertions(+) create mode 100644 libavformat/moflex.c diff --git a/libavformat/Makefile b/libavformat/

[FFmpeg-devel] [PATCH 2/4][VERSION 2] avcodec: add FastAudio decoder

Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 ++ libavcodec/codec_id.h | 1 + libavcodec/fastaudio.c | 200 libavcodec/utils.c | 2 + 6 files changed, 212 insert

[FFmpeg-devel] [PATCH 3/4][VERSION 2] avcodec: add MobiClip video decoder

Signed-off-by: Paul B Mahol --- libavcodec/Makefile |1 + libavcodec/allcodecs.c |1 + libavcodec/codec_desc.c |7 + libavcodec/codec_id.h |1 + libavcodec/mobiclip.c | 1371 +++ 5 files changed, 1381 insertions(+) create mode 100644 l

[FFmpeg-devel] [PATCH 1/4][VERSION 2] avcodec: add ADPCM IMA MOFLEX decoder

Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 26 ++ libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/utils.c | 2 ++ 6 files changed, 38 insertions(+) diff -

[FFmpeg-devel] [PATCH] avcodec/truemotion2: Avoid duplicating array, fix memleak

TrueMotion 2.0 uses Huffmann trees. To parse them, the decoder allocates arrays for the codes, their lengths and their value; afterwards a VLC table is initialized using these values. If everything up to this point succeeds, a new buffer of the same size as the already allocated arrays for the valu