[FFmpeg-devel] [v2] dnn_backend_native_layer_mathbinary: add floormod support

2020-08-17 Thread Mingyu Yin
Signed-off-by: Mingyu Yin --- .../dnn/dnn_backend_native_layer_mathbinary.c | 17 + .../dnn/dnn_backend_native_layer_mathbinary.h | 1 + tests/dnn/dnn-layer-mathbinary-test.c | 5 + tools/python/convert_from_tensorflow.py | 2 +- tools/python/convert_h

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
On Mon, Aug 17, 2020 at 12:12 PM Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > Patch lacks the context for stream_size here - will it always be > correct? Only asking since the check for the coede below this will > have changed from avio_size(pb) to stream_size. > stream_size == avio_si

[FFmpeg-devel] [PATCH] configure: Add additional glslang libraries to make linking work

2020-08-17 Thread Philip Langdale
The latest builds of glslang introduce new libraries that need to be linked for all symbols to be fully resolved. Presumably, requiring these new libraries breaks building against older glslang releases? What range are we committing to supporting? Signed-off-by: Philip Langdale --- configure |

Re: [FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

2020-08-17 Thread myp...@gmail.com
On Mon, Aug 17, 2020 at 7:08 PM Joose Sainio wrote: > > On 7.8.2020 5.40, myp...@gmail.com wrote: > > On Sun, Jul 26, 2020 at 8:45 PM Jun Zhao wrote: > >> From: Jun Zhao > >> > >> Export choosen pict_type and qp. > >> > >> Signed-off-by: Jun Zhao > >> --- > >> libavcodec/libkvazaar.c | 30 +

[FFmpeg-devel] [PATCH] avformat/hlsenc: process hls_time value too small sence

2020-08-17 Thread Steven Liu
The target duration will be a negative value when there are some b frames after prevous frame, the pts after current packet is large than the pts of current packet, so the target duration will compute as 0.04 - 0.08, then the value of the target duration will be -0.04. so hls muxer shou

Re: [FFmpeg-devel] [PATCH V2] dnn/native: add log error message

2020-08-17 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年8月17日 13:35 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V2] dnn/native: add log error message > > Signed-off-by: Ting Fu > --- > V2: > Fix the issue in V1: make fate failed > > libavfil

Re: [FFmpeg-devel] RTSP Video Stream - Buffer Overflow!

2020-08-17 Thread Andriy Gelman
Hi Yeet, On Mon, 17. Aug 12:21, Yiğit (Yeet) Uyan wrote: > Hi everyone, > > RTSP/S links longer than 1024 characters are failing due to a buffer > overflow issue happening when parsing RTSP links (eg. ffplay ). > FFmpeg has a buffer definition in libavformat/Rtsp.h, where it defines the > control

Re: [FFmpeg-devel] RTSP Video Stream - Buffer Overflow!

2020-08-17 Thread Zane van Iperen
On Mon, 17 Aug 2020 12:21:46 -0700 Yiğit Uyan wrote: > Can somebody help with extending the rtsp/s link limit to match the web > urls (eg. 2048 characters) AFAICS this would work as a band-aid, but since the RFC doesn't specify a length limit (that I can find), in the long run it might be bette

Re: [FFmpeg-devel] [PATCH 2/2] lavc/ratecontrol: Fix error logging for parsing and evaluation of rc_eq

2020-08-17 Thread Michael Niedermayer
On Sun, Aug 16, 2020 at 10:57:26PM +0200, Alexander Strasser wrote: > On 2020-08-13 22:32 +0200, Michael Niedermayer wrote: > > On Wed, Aug 12, 2020 at 08:58:30PM +0200, Alexander Strasser wrote: > > > On 2020-08-09 14:56 +0200, Michael Niedermayer wrote: > [...] > > > > > > > > lib user > > > > >

[FFmpeg-devel] RTSP Video Stream - Buffer Overflow!

2020-08-17 Thread Yeet
Hi everyone, RTSP/S links longer than 1024 characters are failing due to a buffer overflow issue happening when parsing RTSP links (eg. ffplay ). FFmpeg has a buffer definition in libavformat/Rtsp.h, where it defines the control_uri as 1024 characters. RTSP/S links follow a similar pattern to com

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Derek Buitenhuis
On 13/08/2020 23:03, Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as complete. > > Instead we can just check if there's an mfra and if i

Re: [FFmpeg-devel] [mov] See if mfra makes up the difference for an incomplete sidx.

2020-08-17 Thread Dale Curtis
Bump. Thanks for consideration! - dale On Thu, Aug 13, 2020 at 3:03 PM Dale Curtis wrote: > A few popular sites have started generating MP4 files which have a > sidx plus an mfra. The sidx accounts for all size except the mfra, > so the old code did not mark the fragment index as complete. > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dvbsub: add "enc" suffix to encoder

2020-08-17 Thread Clément Bœsch
On Mon, Aug 17, 2020 at 05:09:12PM +0200, Carl Eugen Hoyos wrote: > > > > Am 17.08.2020 um 17:03 schrieb Clément Bœsch : > > > > --- > > libavcodec/Makefile | 2 +- > > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > > 2 files changed, 1 insertion(+), 1 deletion(-) > > rename libavcod

Re: [FFmpeg-devel] [PATCH 1/4] lavfi/vf_overlay_qsv: remove needs_fifo.

2020-08-17 Thread Nicolas George
Ping for the patch series. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: regroup formats lists in a single structure.

2020-08-17 Thread Nicolas George
Nicolas George (12020-08-13): > It will allow to refernce it as a whole without clunky macros. > > Most of the changes have been automatically made with sed: > > sed -i ' > s/-> *in_formats/->incfg.formats/g; > s/-> *out_formats/->outcfg.formats/g; > s/-> *in_channel_layouts/->incfg.channel

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dvbsub: add "enc" suffix to encoder

2020-08-17 Thread Carl Eugen Hoyos
> Am 17.08.2020 um 17:03 schrieb Clément Bœsch : > > --- > libavcodec/Makefile | 2 +- > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) Doesn’t this make using git blame harder? Carl

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dvbsub: add "enc" suffix to encoder

2020-08-17 Thread Nicolas George
Clement Boesch (12020-08-17): > --- > libavcodec/Makefile | 2 +- > libavcodec/{dvbsub.c => dvbsubenc.c} | 0 > 2 files changed, 1 insertion(+), 1 deletion(-) > rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) Both changes look good to me, but I do not maintain this. Regards;

[FFmpeg-devel] [PATCH 2/2] avcodec/dvbsub: add "enc" suffix to encoder

2020-08-17 Thread Clément Bœsch
--- libavcodec/Makefile | 2 +- libavcodec/{dvbsub.c => dvbsubenc.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavcodec/{dvbsub.c => dvbsubenc.c} (100%) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 3431ba2dca..f9c8c28d76 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 1/2] avcodec/dvbsub: remove useless indirection in dvbsub_encode.

2020-08-17 Thread Clément Bœsch
--- libavcodec/dvbsub.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/libavcodec/dvbsub.c b/libavcodec/dvbsub.c index 5c081f2b71..7b8ef41a7e 100644 --- a/libavcodec/dvbsub.c +++ b/libavcodec/dvbsub.c @@ -268,9 +268,8 @@ static int dvb_encode_rle8(uint8_t **pq

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-17 Thread Anamitra Ghorui
On Sat, 15 Aug 2020 00:29:10 +0530 Anamitra Ghorui wrote: > This patch fixes a few cosmetic errors mentioned in v3, an error in the > ColorBuckets reading function and removes a few redundancies in the > rangecoder initialisation. > > Co-authored-by: Anamitra Ghorui > Co-authored-by: Kartik K K

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-17 Thread James Almer
On 8/17/2020 10:50 AM, Paul B Mahol wrote: > On 8/16/20, Paul B Mahol wrote: >> On 8/16/20, Paul B Mahol wrote: >>> Hi, >>> >>> patch attached. >>> >>> Please help porting this to linux and 64bit calling convention. >>> >> >> New patch attached. >> >> This one does not allocate stack on x32. >> >

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-17 Thread Paul B Mahol
On 8/16/20, Paul B Mahol wrote: > On 8/16/20, Paul B Mahol wrote: >> Hi, >> >> patch attached. >> >> Please help porting this to linux and 64bit calling convention. >> > > New patch attached. > > This one does not allocate stack on x32. > This is latest patch for cfhd that should be reviewed. Pl

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-17 Thread Paul B Mahol
On 8/17/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-08-14 14:24:25) > >From 874fd9e604a6dcd55cca77c7256a633e5739da77 Mon Sep 17 00:00:00 2001 >>From: Paul B Mahol >>Date: Sun, 9 Aug 2020 17:47:34 +0200 >>Subject: [PATCH] avcodec/cfhd: add x86 SIMD >> >>--- >> libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-17 Thread Anton Khirnov
Quoting Paul B Mahol (2020-08-14 14:24:25) >From 874fd9e604a6dcd55cca77c7256a633e5739da77 Mon Sep 17 00:00:00 2001 >From: Paul B Mahol >Date: Sun, 9 Aug 2020 17:47:34 +0200 >Subject: [PATCH] avcodec/cfhd: add x86 SIMD > >--- > libavcodec/Makefile | 2 +- > libavcodec/cfhd.c

Re: [FFmpeg-devel] [PATCH V2] dnn_backend_openvino.c: parse options in openvino backend

2020-08-17 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of > Alexander Strasser > Sent: 2020年8月14日 20:47 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2] dnn_backend_openvino.c: parse options > in openvino backend > > > > Am 14. August 2020 14:07:

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Nicolas George
Ashutosh Pradhan (12020-08-17): > > > > $ ./ffmpeg_g -lavfi atone /tmp/atone.ogg > > ... > > > > zsh: segmentation fault ./ffmpeg_g -lavfi atone /tmp/atone.ogg > > > I am unable to understand the cause of this error. Are you using sdl2 as > the audio driver? I have shown the exact command I used,

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > Hello Nicolas, > Do you have other comments? This solution seems much better (except that &&= does not exist IIRC). But I would be happier if there was an analysis of the problem in the commit message. Also, please leave other people who know the code better some t

[FFmpeg-devel] [PATCH] avformat/dashdec: check the root url length

2020-08-17 Thread Steven Liu
if the length of the root url is 0, unnecessary process the root_url Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index c5a5ff607b..387d97fe42 100644 --- a/libavformat/dashdec

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix infinite loop with udp transport

2020-08-17 Thread zhilizhao
Please help review the patch, thanks! > On Aug 6, 2020, at 4:50 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > User report: http://ffmpeg.org/pipermail/ffmpeg-user/2020-August/049494.html > > server: > ./ffmpeg -i test.mp4 -c copy -f rtsp -rtsp_transport udp > rtsp://localhost:12

Re: [FFmpeg-devel] [PATCH V2] dnn_backend_openvino.c: parse options in openvino backend

2020-08-17 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Xu, > Guangxin > Sent: 2020年8月14日 20:07 > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2] dnn_backend_openvino.c: parse options > in openvino backend > > > > > -Original Message- >

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Paul B Mahol
On 8/17/20, Ashutosh Pradhan wrote: > On Mon, Aug 17, 2020 at 4:37 PM Nicolas George wrote: > >> Ashutosh Pradhan (12020-08-17): >> > I have provided the sample for $ ./ffplay -f lavfi -i atone >> > in the folder >> > >> https://drive.google.com/drive/folders/1manne188m5T-7wWZb7ZJBLZasLmsX05i?us

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

2020-08-17 Thread Steven Liu
Steven Liu 于2020年8月17日周一 下午7:52写道: > > zhilizhao 于2020年8月17日周一 下午7:50写道: > > > > > > > > > On Aug 17, 2020, at 5:53 PM, Steven Liu wrote: > > > > > > fix ticket: 8847 > > > check the timestamps of current packets minus last segment end_pts > > > if the duration is negative, plus the places where

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Ashutosh Pradhan
On Mon, Aug 17, 2020 at 4:37 PM Nicolas George wrote: > Ashutosh Pradhan (12020-08-17): > > I have provided the sample for $ ./ffplay -f lavfi -i atone > > in the folder > > > https://drive.google.com/drive/folders/1manne188m5T-7wWZb7ZJBLZasLmsX05i?usp=sharing > > Thank you. That was more helpfu

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

2020-08-17 Thread Steven Liu
zhilizhao 于2020年8月17日周一 下午7:50写道: > > > > > On Aug 17, 2020, at 5:53 PM, Steven Liu wrote: > > > > fix ticket: 8847 > > check the timestamps of current packets minus last segment end_pts > > if the duration is negative, plus the places where the muxer should split. > > > > Signed-off-by: Steven L

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

2020-08-17 Thread zhilizhao
> On Aug 17, 2020, at 5:53 PM, Steven Liu wrote: > > fix ticket: 8847 > check the timestamps of current packets minus last segment end_pts > if the duration is negative, plus the places where the muxer should split. > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 2 +- > 1 file ch

Re: [FFmpeg-devel] [PATCH v3]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Thilo Borgmann
Am 17.08.20 um 12:47 schrieb Ashutosh Pradhan: > On Mon, Aug 17, 2020 at 3:05 PM Paul B Mahol wrote: > >> On 8/17/20, Ashutosh Pradhan wrote: >>> Generate algorithmic music using riffs, lindenmayer systems, cellular >>> automaton and rhythm algorithms. >>> >> >> Do you allow to change seed of lf

Re: [FFmpeg-devel] [PATCH v3 4/4] lavc, doc: add libuavs3d video decoder wrapper

2020-08-17 Thread hwren
Fix the mail format of reply message from and reset it to the correct thread. Same content. At 2020-08-12 06:18:46, "Mark Thompson" wrote: >On 05/08/2020 17:18, hwr...@126.com wrote: >> From: hwren >> >> Signed-off-by: hbj >> Signed-off-by: hwren >> --- >> Changelog

Re: [FFmpeg-devel] [PATCH v3 2/4] lavc/avs3_paeser: add avs3 parser

2020-08-17 Thread hwren
Fix the mail format of reply message from and reset it to the correct thread. same content. At 2020-08-12 05:43:24, "Mark Thompson" wrote: > >Typo "paeser" in the title. > >On 05/08/2020 17:18, hwr...@126.com wrote: >> From: hwren >> >> Signed-off-by: hbj >> Signed-off-by: h

Re: [FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

2020-08-17 Thread Joose Sainio
On 7.8.2020 5.40, myp...@gmail.com wrote: On Sun, Jul 26, 2020 at 8:45 PM Jun Zhao wrote: From: Jun Zhao Export choosen pict_type and qp. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/libavcodec/libkvaz

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Nicolas George
Ashutosh Pradhan (12020-08-17): > I have provided the sample for $ ./ffplay -f lavfi -i atone > in the folder > https://drive.google.com/drive/folders/1manne188m5T-7wWZb7ZJBLZasLmsX05i?usp=sharing Thank you. That was more helpful. Honestly, this is not "nice", it is just boring. Which is not you

[FFmpeg-devel] 回复:Re: [PATCH v3 4/4] lavc, doc: add libuavs3d video decoder wrapper

2020-08-17 Thread hbj515
>On 08/12/2020 06:19, s...@jkqxz.net wrote:>>On 05/08/2020 17:18, >hwr...@126.com wrote:>> From: hwren Signed-off-by: hbj >>> Signed-off-by: hwren >> --->> Changelog | >1 +>> configure | 4 +>> doc/decoders.texi | 21 +++>> doc/general.texi | 8 ++>> >libavcodec/Makefile | 1 +>> libavcodec/al

[FFmpeg-devel] 回复:Re: [PATCH v3 2/4] lavc/avs3_paeser: add avs3 parser

2020-08-17 Thread hbj515
>On 08/12/2020 05:43, s...@jkqxz.net wrote:>Typo "paeser" in the title.>On >05/08/2020 17:18, hwr...@126.com wrote:>> From: hwren >> >> >Signed-off-by: hbj >> Signed-off-by: hwren >>> --->> libavcodec/Makefile | 1 +>> libavcodec/avs3_parser.c >| 184 +++>> lib

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add x86 SIMD

2020-08-17 Thread Alexander Strasser
Hi Paul, sorry, forgot to reply to this... On 2020-08-15 12:55 +0200, Paul B Mahol wrote: > On 8/15/20, Alexander Strasser wrote: > > On 2020-08-14 20:22 +0100, Derek Buitenhuis wrote: > >> On 14/08/2020 20:13, Paul B Mahol wrote: > >> > What specific insults in this thread? > >> > >> You wrote

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Ashutosh Pradhan
On Mon, Aug 17, 2020 at 3:38 PM Nicolas George wrote: > Paul B Mahol (12020-08-17): > > Yes could apply the patch and compile it and run it. > > Yes, requiring everybody who wants to make an opinion to do that, what > an excellent choice compared to uploading a sample somewhere. > Hi I have prov

Re: [FFmpeg-devel] [PATCH v3]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Ashutosh Pradhan
On Mon, Aug 17, 2020 at 3:05 PM Paul B Mahol wrote: > On 8/17/20, Ashutosh Pradhan wrote: > > Generate algorithmic music using riffs, lindenmayer systems, cellular > > automaton and rhythm algorithms. > > > > Do you allow to change seed of lfg generator or seed is always same? > Idea is to alway

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Nicolas George
Paul B Mahol (12020-08-17): > Yes could apply the patch and compile it and run it. Yes, requiring everybody who wants to make an opinion to do that, what an excellent choice compared to uploading a sample somewhere. Anyway: $ ./ffmpeg_g -lavfi atone -f alsa default - ffmpeg version N-98748-g4add

Re: [FFmpeg-devel] [PATCH v2] doc/encoders: Add all options for JPEG2000 encoder

2020-08-17 Thread Gyan Doshi
On 14-08-2020 11:21 am, Gyan Doshi wrote: Will apply. Pushed as 642404f28d39cefb7857c0d77c3a4e5ac98e62c6 with minor changes. Thanks, Gyan On 10-08-2020 10:14 pm, gautamr...@gmail.com wrote: From: Gautam Ramakrishnan This patch updates the documentation by adding all options for JPEG200

[FFmpeg-devel] [PATCH] avformat/hlsenc: check duration value correct before split segment

2020-08-17 Thread Steven Liu
fix ticket: 8847 check the timestamps of current packets minus last segment end_pts if the duration is negative, plus the places where the muxer should split. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
Nicolas George 于2020年8月17日周一 下午5:24写道: > > Steven Liu (12020-08-17): > > When hls muxer have beed support split_by_time flag add, the 8216 have > > not beed release, > > and there have some guys order this feature, for example me. > > And I saw lots of people are using this flag, so this maybe can

Re: [FFmpeg-devel] [PATCH v3]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Paul B Mahol
On 8/17/20, Ashutosh Pradhan wrote: > Generate algorithmic music using riffs, lindenmayer systems, cellular > automaton and rhythm algorithms. > Do you allow to change seed of lfg generator or seed is always same? Idea is to always have same output for same seed parameter. And also to be able to

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Paul B Mahol
On 8/17/20, Nicolas George wrote: > Paul B Mahol (12020-08-17): >> It is written in documentation of filter. > > "nice listenable": it is a bit short, and completely subjective. Nice > like what? Vivaldi? The Beatles? Can we have a sample to judge? Yes could apply the patch and compile it and run

[FFmpeg-devel] [PATCH] avformat/flvdec: RtmpSampleAccess no longer breaks stream detection

2020-08-17 Thread Peter van der Spek
Since release 4.2, FFmpeg fails to detect the correct streams in an RTMP stream that contains a |RtmpSampleAccess AMF object prior to the onMetaData AMF object. In the debug log it would show "[flv] Unknown type |RtmpSampleAccess". With this change the RTMP streams are correctly detected when ther

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Nicolas George
Paul B Mahol (12020-08-17): > It is written in documentation of filter. "nice listenable": it is a bit short, and completely subjective. Nice like what? Vivaldi? The Beatles? Can we have a sample to judge? -- Nicolas George ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Paul B Mahol
On 8/17/20, Nicolas George wrote: > Nicolas George (12020-08-12): >> Please document what use this algorithmic music is: is it nice to listen >> to? Or something else? > > You have not addressed this in the new patch. Are we to accept >100k of > code without knowing what it is useful for? It is w

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > As Zhili Zhao said, the problem is the user is using hls_time with too > short duration and want split not by keyframe. > I have been think about how to make the user know it don't support > short than 2 frames and with bframes, > but this is not the better way. > I thin

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > When hls muxer have beed support split_by_time flag add, the 8216 have > not beed release, > and there have some guys order this feature, for example me. > And I saw lots of people are using this flag, so this maybe cannot be > removed now. > So I think give a warning me

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
Nicolas George 于2020年8月17日周一 下午4:06写道: > > Steven Liu (12020-08-17): > > Output a warning message if the target duration of the segment is negative. > > Suggest user increase the hls_time value, > > and modify the target duration to one packet duration, > > because there maybe have bframe and then

Re: [FFmpeg-devel] [PATCH v2]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Nicolas George
Nicolas George (12020-08-12): > Please document what use this algorithmic music is: is it nice to listen > to? Or something else? You have not addressed this in the new patch. Are we to accept >100k of code without knowing what it is useful for? Regards, -- Nicolas George signature.asc Desc

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
zhilizhao 于2020年8月17日周一 下午5:06写道: > > > > > On Aug 17, 2020, at 4:05 PM, Nicolas George wrote: > > > > Steven Liu (12020-08-17): > >> Output a warning message if the target duration of the segment is negative. > >> Suggest user increase the hls_time value, > >> and modify the target duration to o

[FFmpeg-devel] [PATCH v3]libavfilter/asrc_atone.c : generate algorithmic music

2020-08-17 Thread Ashutosh Pradhan
Generate algorithmic music using riffs, lindenmayer systems, cellular automaton and rhythm algorithms. Changelog|1 + configure|4 + doc/filters.texi | 141 + libavfilter/Makefile |1 + libavfilter/allfilters.c |1 + libavfilter/as

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread zhilizhao
> On Aug 17, 2020, at 4:05 PM, Nicolas George wrote: > > Steven Liu (12020-08-17): >> Output a warning message if the target duration of the segment is negative. >> Suggest user increase the hls_time value, >> and modify the target duration to one packet duration, >> because there maybe have bf

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

2020-08-17 Thread Alexander Strasser
On 2020-08-16 23:12 +0200, Nicolas George wrote: > Alexander Strasser (12020-08-16): > > I dislike the negative name too, because like mentioned by Marton it > > doesn't work well with overriding the option to turn it off. > > > > On one hand for this option in particular it wouldn't be that import

Re: [FFmpeg-devel] [PATCH 1/2] ffmpeg: add disable_all_auto_conversion_filters option.

2020-08-17 Thread Alexander Strasser
Hi Nicolas! On 2020-08-16 23:03 +0200, Nicolas George wrote: > Alexander Strasser (12020-08-16): > > This was uncalled for and not nice at all! > > I will be correct, but I'm done being nice with him. It was an unneeded accusation. Thanks for trying to not repeat those. > > It's neither good fo

Re: [FFmpeg-devel] [PATCH v3 5/5] avformat/argo_asf: strip file extension from name

2020-08-17 Thread Alexander Strasser
Hi Zane, sorry for this late remark. On 2020-08-09 23:45 +, Zane van Iperen wrote: > Only when the user hasn't manually specified one. > Matches the original files more closely. > > Signed-off-by: Zane van Iperen > --- > libavformat/argo_asf.c | 20 +--- > 1 file changed, 17

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Nicolas George
Steven Liu (12020-08-17): > Output a warning message if the target duration of the segment is negative. > Suggest user increase the hls_time value, > and modify the target duration to one packet duration, > because there maybe have bframe and then split not by keyframe, > and the segment is very ve

[FFmpeg-devel] [PATCH] avformat/hlsenc: check the segment duration valid

2020-08-17 Thread Steven Liu
Output a warning message if the target duration of the segment is negative. Suggest user increase the hls_time value, and modify the target duration to one packet duration, because there maybe have bframe and then split not by keyframe, and the segment is very very small. Signed-off-by: Steven Liu