Re: [FFmpeg-devel] [PATCH v2 5/5] avformat/mpegtsenc: support 0x6a descriptor for AC-3 by side data if have

2020-08-06 Thread Moritz Barsnick
On Thu, Jul 30, 2020 at 22:58:58 +0800, lance.lmw...@gmail.com wrote: > if (codec_id == AV_CODEC_ID_AC3) { > +int len = 1; > + > +if (ts_st->desc6a.component_type_flag) len++; > +if (ts_st->desc6a.bsid_flag) len+

Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/dump: dump AV_PKT_DATA_MPEGTS_6A_DESC side data

2020-08-06 Thread Moritz Barsnick
On Thu, Jul 30, 2020 at 22:58:56 +0800, lance.lmw...@gmail.com wrote: > #include "libavutil/dovi_meta.h" > +#include "libavutil//mpegts_audio_desc_metadata.h" ^^ A duplicate slash slipped in there. > +av_log(ctx, AV_LOG_INFO, "component_type_flag: %u, bsid_flag: %u, " >

Re: [FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

2020-08-06 Thread Andreas Rheinhardt
myp...@gmail.com: > On Sun, Jul 26, 2020 at 8:45 PM Jun Zhao wrote: >> >> From: Jun Zhao >> >> Export choosen pict_type and qp. >> >> Signed-off-by: Jun Zhao >> --- >> libavcodec/libkvazaar.c | 30 ++ >> 1 file changed, 30 insertions(+) >> >> diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 3/5] lavf/libkvazaar: export encoded frame stats

2020-08-06 Thread myp...@gmail.com
On Sun, Jul 26, 2020 at 8:45 PM Jun Zhao wrote: > > From: Jun Zhao > > Export choosen pict_type and qp. > > Signed-off-by: Jun Zhao > --- > libavcodec/libkvazaar.c | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkv

Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread James Almer
On 8/6/2020 12:34 PM, Xu, Guangxin wrote: > Hi James, > Comment inline. > >> -Original Message- >> From: ffmpeg-devel On Behalf Of James >> Almer >> Sent: Thursday, August 6, 2020 10:09 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-ov

Re: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_mathunary: add floor support

2020-08-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Mingyu > Yin > Sent: 2020年8月6日 14:47 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH] dnn_backend_native_layer_mathunary: add > floor support > > It can be tested with the model generated with below python script: >

Re: [FFmpeg-devel] [PATCH V6 2/2] FATE/dnn: add unit test for dnn avgpool layer

2020-08-06 Thread Guo, Yejun
> V6: > Fix the issue of make fate failed in V4&V5 don't need such info in the commit log. > > tests/dnn/.gitignore | 1 + > tests/dnn/Makefile | 1 + > tests/dnn/dnn-layer-avgpool-test.c | 198 + > tests/fate/dnn.mak

Re: [FFmpeg-devel] [PATCH V6 1/2] dnn/native: add native support for avg_pool

2020-08-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Ting Fu > Sent: 2020年8月5日 14:54 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH V6 1/2] dnn/native: add native support for > avg_pool > > Not support pooling strides in channel dimension now. > It can be tested with t

Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread James Almer
On 8/6/2020 10:25 PM, Xu, Guangxin wrote: > >> -Original Message- >> From: ffmpeg-devel On Behalf Of James >> Almer >> Sent: Friday, August 7, 2020 1:38 AM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if >> we have size in obu

Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread Xu, Guangxin
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Friday, August 7, 2020 1:38 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if > we have size in obu header > > On 8/6/2020 12:15 PM, Xu, Guangxin wro

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add 3d transform support

2020-08-06 Thread Kieran Kunhya
On Thu, 6 Aug 2020 at 17:28, Paul B Mahol wrote: > Hi, > > patches attached. > Seems ok if tested on various samples. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

2020-08-06 Thread Yeet
Not quite. RTSP/S links follow a similar pattern as common web URIs, i.e. , and in many cases these links are generated, routed and modified by common underlying infrastructure. AFAIK, the common conception for the web when parsing a URI is to expect up to 2000 characters. https://stackoverflow.co

Re: [FFmpeg-devel] [PATCH v3 0/6] add adpcm_argo encoder and argo_asf muxer

2020-08-06 Thread Zane van Iperen
On Tue, 04 Aug 2020 23:08:50 + "Zane van Iperen" wrote: > > v3: > * fix FATE failure (lavf-asf) caused by "asf" extension conflict > > v2: [1] > * enforce the samples-per-block value in the demuxer > * remove unnecessary initialisers > * add missing return when stream isn't seekable > * cha

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Check bpp/bppcount for 0

2020-08-06 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: division by zero > Fixes: > 24253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6250318007107584 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

[FFmpeg-devel] [PATCH 2/2] avcodec/tiff: Check bpp/bppcount for 0

2020-08-06 Thread Michael Niedermayer
Fixes: division by zero Fixes: 24253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TIFF_fuzzer-6250318007107584 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 4 ++-- 1 file chan

[FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Sanity check hcoeff

2020-08-06 Thread Michael Niedermayer
Fixes: signed integer overflow: -2147483648 * -1 cannot be represented in type 'int' Fixes: 24011/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-5486376610168832 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mic

Re: [FFmpeg-devel] [PATCH 1/2] test: hlsenc: Don't generate test data with -re

2020-08-06 Thread Martin Storsjö
On Mon, 3 Aug 2020, Martin Storsjö wrote: On Mon, 3 Aug 2020, Michael Niedermayer wrote: is this removing the only test which tests the "-re" flag ? if so that would reduce test coverage Well, tehcnically yes, but this test doesn't actually test whether the "-re" flag does what it's suppose

[FFmpeg-devel] [PATCH] libavcodec/j2kenc: Support for all Progression orders

2020-08-06 Thread gautamramk
From: Gautam Ramakrishnan This patch allows for selecting the progression order in the j2k encoder. However, all components and resolution levels will use the same progression order and will not feature the use of progression order change markers. --- libavcodec/j2kenc.c | 223 ++

Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread James Almer
On 8/6/2020 12:40 PM, Xu, Guangxin wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of James >> Almer >> Sent: Thursday, August 6, 2020 10:09 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead >> bitstream format

Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread James Almer
On 8/6/2020 12:15 PM, Xu, Guangxin wrote: > Hi James, > Thanks for the review. > How about we add a new function in av1dec.c like this: > > static inline int read_obu_header_with_size_flag(const uint8_t *buf, int > buf_size, >int64_t *obu_size, int *type); > th

Re: [FFmpeg-devel] [PATCH 3/3] avformat/sierravmd: Don't return packets for non-existing stream

2020-08-06 Thread Michael Niedermayer
On Thu, Aug 06, 2020 at 01:33:58AM +0200, Andreas Rheinhardt wrote: > It leads to an assert in ff_read_packet(). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/sierravmd.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/sierravmd.c b/libavformat/sierravmd.c >

[FFmpeg-devel] [PATCH] avcodec/cfhd: add 3d transform support

2020-08-06 Thread Paul B Mahol
Hi, patches attached. 0001-avcodec-cfhd-remove-some-unused-or-only-write-items.patch Description: Binary data 0002-avcodec-cfhd-add-3d-transform-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread Xu, Guangxin
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Thursday, August 6, 2020 10:09 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead > bitstream format > > On 8/6/2020 5:04 AM, Xu Guangxin wrote: > > It's

Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread Xu, Guangxin
Hi James, Comment inline. > -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Thursday, August 6, 2020 10:09 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead > bitstream format > > On 8/6/2020 5:04 AM, Xu

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

2020-08-06 Thread Takio Yamaoka
2020年8月6日(木) 19:39 Jan Ekström : > > Cheers. Applied as cc6c56f5d900f86167f6592215e613a69341858a . > > Thanks for noticing that this was broken and sending out a patch. It's my pleasure! > > > P.S. Top-posting is frowned upon on this mailing list, so please reply > > > in-line or underneath in th

Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread Xu, Guangxin
Hi James, Thanks for the review. How about we add a new function in av1dec.c like this: static inline int read_obu_header_with_size_flag(const uint8_t *buf, int buf_size, int64_t *obu_size, int *type); then we can remove first two patches and check has_size_flag

Re: [FFmpeg-devel] [PATCH 2/5] avutil/mpegts_audio_desc_metadata: add helper function for AC3 descriptor 0x6a

2020-08-06 Thread Kieran Kunhya
On Thu, 6 Aug 2020 at 15:48, wrote: > On Thu, Aug 06, 2020 at 07:51:55AM +0100, Kieran Kunhya wrote: > > > > > > It's audio descriptor information although it's stored in PSI table, > but > > > it'll map to > > > specific audio packet in the end, so I don't think it's hacky. I have > > > tested >

Re: [FFmpeg-devel] [PATCH 2/5] avutil/mpegts_audio_desc_metadata: add helper function for AC3 descriptor 0x6a

2020-08-06 Thread lance . lmwang
On Thu, Aug 06, 2020 at 07:51:55AM +0100, Kieran Kunhya wrote: > > > > It's audio descriptor information although it's stored in PSI table, but > > it'll map to > > specific audio packet in the end, so I don't think it's hacky. I have > > tested > > with mpts with multiple audio stream, it's pass-b

Re: [FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread James Almer
On 8/6/2020 5:04 AM, Xu Guangxin wrote: > It's defined in Section 5.2, used by netflix. > see http://download.opencontent.netflix.com/?prefix=AV1/Chimera/ > --- > libavformat/allformats.c | 1 + > libavformat/av1dec.c | 193 +-- > 2 files changed, 185 inse

[FFmpeg-devel] [PATCH] avformat/mxfenc: Write color metadata to MXF

2020-08-06 Thread Harry Mallon
I attach a patch to apply the colour metadata that was read in my previous commit during mxf encoding. ffmpeg previously wrote the transfer characteristic only, and not for all supported transfer curves. Now it will do transfer characteristic, colour primaries and colour space. Best, Harry Fro

Re: [FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread James Almer
On 8/6/2020 5:04 AM, Xu Guangxin wrote: > for low overhead obu, we can't forsee the obu size. we can only get it > when we parsed the obu header. > --- > libavcodec/av1_parse.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/av1_parse.h b/libavcodec/av1_parse.h

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/put_bits: Make skip_put_bits() less dangerous

2020-08-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Before c63c303a1f2b58677d480505ec93a90f77dd25b5 (the commit which > introduced a typedef for the type of the buffer of a PutBitContext) > skip_put_bits() was as follows: > > static inline void skip_put_bits(PutBitContext *s, int n) > { > s->bit_left -= n; > s->buf_ptr

Re: [FFmpeg-devel] [PATCH] avutil/opt: Restore NULL input handling to set_string_video_rate()

2020-08-06 Thread Andreas Rheinhardt
Jack Haughton: > A NULL check in av_parse_video_rate() would certainly not be a bad idea. It > wouldn't (on its own) restore the NULL input robustness to > set_string_video_rate() though, as any error value returned from > av_parse_video_rate() would result in val being logged using %s, which is >

Re: [FFmpeg-devel] [PATCH] avutil/opt: Restore NULL input handling to set_string_video_rate()

2020-08-06 Thread Andreas Rheinhardt
Jack Haughton: > Commit a500b975 removed NULL input handling from this function, > moving the check higher up the call tree in one branch. However, > there is another call to set_string_video_rate() which may pass > NULL, and future users of the function may not be clear that > a NULL check is requ

Re: [FFmpeg-devel] [PATCH v2] avformat/mxfdec: Read color metadata from MXF

2020-08-06 Thread Tomas Härdin
lör 2020-08-01 klockan 16:17 +0200 skrev Tomas Härdin: > fre 2020-07-31 klockan 11:09 +0100 skrev Harry Mallon: > > Hi, > > > > V2 fixes all the fate tests (I didn't know to download the test > > footage before. Doh). > > > > The following patch adds reading colour metadata (transfer, primaries >

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264.c: Fix chromaoffset of libx264 doesn't work

2020-08-06 Thread Jan Ekström
On Thu, Aug 6, 2020 at 3:16 AM Takio Yamaoka wrote: > > 2020年8月6日(木) 7:24 Jan Ekström : > > > > Sorry, decided to take a look at the logic but didn't have the time to > > actually test it locally. > > Thank you for replying. It sounds good for me. > > > I have now tested it locally and it works as

Re: [FFmpeg-devel] [PATCH 2/3] avformat/vividas: Check allocation for success

2020-08-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Zane van Iperen: >> On Thu, 6 Aug 2020 01:33:57 +0200 >> "Andreas Rheinhardt" wrote: >> >>> >>> static void load_sb_block(AVFormatContext *s, VividasDemuxContext *viv, >>> unsigned expected_size) >>> @@ -608,7 +606,7 @@ static int viv_read_header(AVFormatContext *s) >>>

Re: [FFmpeg-devel] [PATCH 2/3] avformat/vividas: Check allocation for success

2020-08-06 Thread Andreas Rheinhardt
Zane van Iperen: > On Thu, 6 Aug 2020 01:33:57 +0200 > "Andreas Rheinhardt" wrote: > >> >> static void load_sb_block(AVFormatContext *s, VividasDemuxContext *viv, >> unsigned expected_size) >> @@ -608,7 +606,7 @@ static int viv_read_header(AVFormatContext *s) >> ret = track_index(viv, s, b

Re: [FFmpeg-devel] [PATCH] avutil/opt: Restore NULL input handling to set_string_video_rate()

2020-08-06 Thread Michael Niedermayer
On Wed, Aug 05, 2020 at 02:13:06PM +0100, Jack Haughton wrote: > Commit a500b975 removed NULL input handling from this function, > moving the check higher up the call tree in one branch. However, > there is another call to set_string_video_rate() which may pass > NULL, and future users of the funct

Re: [FFmpeg-devel] [PATCH] Increasing the max length of control URI to 2048 characters, as urls of some RTSP streams do exceed this limit.

2020-08-06 Thread myp...@gmail.com
On Thu, Aug 6, 2020 at 11:47 AM Yiğit (Yeet) Uyan wrote: > > Hey Zhilizhao, > > The RTSPState you mentioned is ok, but we need to get the char control_uri > buffer from 1024 characters to 2048. Some of the long rtsps links are > getting cut, and cannot play. Can you help getting this patch to the

[FFmpeg-devel] [PATCH] avformat/rtsp: fix infinite loop with udp transport

2020-08-06 Thread quinkblack
From: Zhao Zhili User report: http://ffmpeg.org/pipermail/ffmpeg-user/2020-August/049494.html server: ./ffmpeg -i test.mp4 -c copy -f rtsp -rtsp_transport udp rtsp://localhost:12345/live.sdp client: ./ffmpeg_g -y -rtsp_flags listen -timeout 100 -i rtsp://localhost:12345/live.sdp -c copy test

[FFmpeg-devel] [PATCH 5/5] fate: av1dec, add test clip for low overhead obu

2020-08-06 Thread Xu Guangxin
--- tests/fate/demux.mak | 3 +++ tests/ref/fate/av1-low-overhead-demux | 16 2 files changed, 19 insertions(+) create mode 100644 tests/ref/fate/av1-low-overhead-demux diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index 9f3a6be276..763452a533 100644

[FFmpeg-devel] [PATCH 4/5] avormat/av1dec: add low-overhead bitstream format

2020-08-06 Thread Xu Guangxin
It's defined in Section 5.2, used by netflix. see http://download.opencontent.netflix.com/?prefix=AV1/Chimera/ --- libavformat/allformats.c | 1 + libavformat/av1dec.c | 193 +-- 2 files changed, 185 insertions(+), 9 deletions(-) diff --git a/libavformat/

[FFmpeg-devel] [PATCH 3/5] avformat/av1dec: refact, do not overide return value in read_obu

2020-08-06 Thread Xu Guangxin
we need them later --- libavformat/av1dec.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/libavformat/av1dec.c b/libavformat/av1dec.c index 297e87cc52..ec66152e03 100644 --- a/libavformat/av1dec.c +++ b/libavformat/av1dec.c @@ -60,14 +60,9 @@ static int leb(AVIOCo

[FFmpeg-devel] [PATCH 2/5] av1_parser: do not check buf_size if we have size in obu header

2020-08-06 Thread Xu Guangxin
for low overhead obu, we can't forsee the obu size. we can only get it when we parsed the obu header. --- libavcodec/av1_parse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/av1_parse.h b/libavcodec/av1_parse.h index a3b39f039c..823bdedd5e 100644 --- a/libavcodec/

[FFmpeg-devel] [PATCH 0/5] avformat/av1dec: add low overhead obu demux

2020-08-06 Thread Xu Guangxin
Xu Guangxin (5): av1_parser: parser_obu_header, return has_size_flag av1_parser: do not check buf_size if we have size in obu header avformat/av1dec: refact, do not overide return value in read_obu avormat/av1dec: add low-overhead bitstream format fate: av1dec, add test clip for low over

[FFmpeg-devel] [PATCH 1/5] av1_parser: parser_obu_header, return has_size_flag

2020-08-06 Thread Xu Guangxin
From: Xu Guangxin we need check has_size_flag for low overhead obu --- libavcodec/av1_parse.c | 4 ++-- libavcodec/av1_parse.h | 8 libavformat/av1.c | 12 ++-- libavformat/av1dec.c | 10 +- 4 files changed, 17 insertions(+), 17 deletions(-) diff --git a/libavc