Re: [FFmpeg-devel] [PATCH] Support HDR10+ metadata for HEVC

2020-07-22 Thread Mohammad Izadi
Please see my answers inline: On Thu, Jul 16, 2020 at 1:30 PM Carl Eugen Hoyos wrote: > Am Do., 16. Juli 2020 um 21:24 Uhr schrieb Mohammad Izadi > : > > > -user_identifier = get_bits_long(gb, 32); > > - > > -switch (user_identifier) { > > -case MKBETAG('G', 'A', '9', '4'): > >

Re: [FFmpeg-devel] [PATCH 1/8] avformat/mpegts: add dvb ac3 descriptor metadata

2020-07-22 Thread lance . lmwang
On Wed, Jul 22, 2020 at 07:44:06PM +0200, Marton Balint wrote: > > > On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Below is one metadata information for the ts with dvb ac3 descriptor audio: > > ./ffmpeg -i ac3_desc.ts > >... > >Stream #0:1[0x294]: A

[FFmpeg-devel] [PATCH v2 1/2] libavcodec/libaomenc.c: Add command-line options for tx tools.

2020-07-22 Thread Wang Cao
From: Wang Cao Signed-off-by: Wang Cao --- doc/encoders.texi | 20 libavcodec/libaomenc.c | 30 ++ libavcodec/version.h | 2 +- 3 files changed, 51 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 235

[FFmpeg-devel] [PATCH v2 2/2] libavcodec/libaomenc.c: Add command-line options for inter-coding tools

2020-07-22 Thread Wang Cao
From: Wang Cao Signed-off-by: Wang Cao --- doc/encoders.texi | 36 + libavcodec/libaomenc.c | 60 ++ libavcodec/version.h | 2 +- 3 files changed, 97 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encode

[FFmpeg-devel] An idea to Mix re-encoding with copy to get a fast and precise cut

2020-07-22 Thread Mohammed Hamdy
Hi, I posted an idea to make ffmpeg do a fast and precise cut, by re-ncoding just shorts parts around the cut points, and copy the rest of the desired segment without re-encoding. I wish it can be done. Details in here: https://superuser.com/questions/1570180/can-i-mix-copy-and-encode-in-one

Re: [FFmpeg-devel] [RFC Patch 2/2] libavformat/rtpenc_jpeg2000 JPEG2000 RTP Muxer

2020-07-22 Thread Gautam Ramakrishnan
On Thu, Jul 23, 2020 at 12:56 AM wrote: > > From: Gautam Ramakrishnan > > This patch adds support to mux JPEG2000 streams over > RTP. > --- > libavformat/Makefile | 1 + > libavformat/rtpenc.c | 4 ++ > libavformat/rtpenc.h | 1 + > libavformat/rtpenc_jpeg2000.c

[FFmpeg-devel] [RFC Patch 2/2] libavformat/rtpenc_jpeg2000 JPEG2000 RTP Muxer

2020-07-22 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support to mux JPEG2000 streams over RTP. --- libavformat/Makefile | 1 + libavformat/rtpenc.c | 4 ++ libavformat/rtpenc.h | 1 + libavformat/rtpenc_jpeg2000.c | 121 ++ libavformat/sdp.c

[FFmpeg-devel] [RFC Patch 1/2] libavformat/rtpdec_jpeg2000: RTP Demuxing for JPEG2000

2020-07-22 Thread gautamramk
From: Gautam Ramakrishnan This patch adds support to receive JPEG2000 RTP streams. --- libavformat/Makefile | 1 + libavformat/rtpdec.c | 1 + libavformat/rtpdec_formats.h | 1 + libavformat/rtpdec_jpeg2000.c | 116 ++ 4 files changed, 119

Re: [FFmpeg-devel] [PATCH 5/8] avformat/mpegtsenc: use local variable store st->codecpar->codec_id

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 28d535a..718ddab 100644 ---

Re: [FFmpeg-devel] [PATCH 4/8] avformat/mpegtsenc: reindent the last commit

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 2d7a8ab..28d535a 100644 -

Re: [FFmpeg-devel] [PATCH 3/8] avformat/mpegtsenc: simplify code for condition checks

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index d827ba3..2d7a8ab 100644 --- a/libavforma

Re: [FFmpeg-devel] [PATCH 2/8] avformat/mpegts: decode and export ATSC AC-3 descriptor

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 1ed7eaf..d450507 100644 ---

Re: [FFmpeg-devel] [PATCH 1/8] avformat/mpegts: add dvb ac3 descriptor metadata

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Below is one metadata information for the ts with dvb ac3 descriptor audio: ./ffmpeg -i ac3_desc.ts ... Stream #0:1[0x294]: Audio: ac3 ([6][0][0][0] / 0x0006), 48000 Hz, 5.1(side), fltp, 448 kb/s Metadata: dvb

[FFmpeg-devel] [PATCH 1/8] avformat/mpegts: add dvb ac3 descriptor metadata

2020-07-22 Thread lance . lmwang
From: Limin Wang Below is one metadata information for the ts with dvb ac3 descriptor audio: ./ffmpeg -i ac3_desc.ts ... Stream #0:1[0x294]: Audio: ac3 ([6][0][0][0] / 0x0006), 48000 Hz, 5.1(side), fltp, 448 kb/s Metadata: dvb.ac3_desc.component_type: 68 dvb.ac3_desc.bsi

[FFmpeg-devel] [PATCH 2/8] avformat/mpegts: decode and export ATSC AC-3 descriptor

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegts.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 1ed7eaf..d450507 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@

[FFmpeg-devel] [PATCH 6/8] avformat/mpegtsenc: support dvb ac3 descriptor by metadata

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 45 +++-- 1 file changed, 43 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 718ddab..a5b45fb 100644 --- a/libavformat/mpegtsenc.c

[FFmpeg-devel] [PATCH 4/8] avformat/mpegtsenc: reindent the last commit

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 2d7a8ab..28d535a 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtse

[FFmpeg-devel] [PATCH 3/8] avformat/mpegtsenc: simplify code for condition checks

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index d827ba3..2d7a8ab 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -483,16

[FFmpeg-devel] [PATCH 7/8] avformat/mpegtsenc: add registration descriptor for AC-3 and EAC3

2020-07-22 Thread lance . lmwang
From: Limin Wang copy the atsc ac3 audio in ts like below: ./ffmpeg -i atsc_audio.ts -c:v copy -c:a copy out.ts Stream #0:6[0x64](eng): Audio: ac3 (AC-3 / 0x332D4341), 48000 Hz, stereo, fltp, 192 kb/s ./ffmpeg -i out.ts Before: Stream #0:1[0x101](eng): Audio: ac3 ([129][0][0][0] / 0x0081), 4800

[FFmpeg-devel] [PATCH 8/8] swscale/yuv2rgb: cosmetics

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/yuv2rgb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index e02d74f..6a3956e 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -983,9 +983,10 @@ av_

[FFmpeg-devel] [PATCH 5/8] avformat/mpegtsenc: use local variable store st->codecpar->codec_id

2020-07-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavformat/mpegtsenc.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 28d535a..718ddab 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/imgutils: add utility to get plane sizes

2020-07-22 Thread James Almer
On 7/13/2020 9:19 PM, Brian Kim wrote: > On Mon, Jul 13, 2020 at 11:22 AM James Almer wrote: > [...] >> You would need to cast height to size_t for this, i think, but seeing >> av_image_check_size() currently rejects line sizes and plane sizes >> bigger than INT_MAX, maybe we should just keep INT_

Re: [FFmpeg-devel] [PATCH 3/9] avformat/mxfdec: Simplify cleanup after read_header failure

2020-07-22 Thread Tomas Härdin
tis 2020-07-21 klockan 04:12 +0200 skrev Andreas Rheinhardt: > by setting the AVFMT_HEADER_CLEANUP flag. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mxfdec.c | 24 +++- > 1 file changed, 7 insertions(+), 17 deletions(-) I was confused for a while since "git gre

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mxfdec: Fix memleak when parsing tag fails

2020-07-22 Thread Tomas Härdin
mån 2020-07-20 klockan 08:15 +0200 skrev Andreas Rheinhardt: > --- a/libavformat/mxfdec.c > +++ b/libavformat/mxfdec.c > @@ -2714,6 +2714,7 @@ static const MXFMetadataReadTableEntry > mxf_metadata_read_table[] = { > > static int mxf_metadataset_init(MXFMetadataSet *ctx, enum MXFMetadataSetType

[FFmpeg-devel] working with file descriptors on Android

2020-07-22 Thread Alex Cohn
Usually, we employ the `pipe:` protocol to deal with the numerical file descriptors, and this answers all our needs. On Android, there is a different use case in which numerical file descriptors appear, and this is not covered well with `pipe:` protocol. This happens when a file is opened in scope

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: Fix memleak when adding element to array fails

2020-07-22 Thread Tomas Härdin
mån 2020-07-20 klockan 08:15 +0200 skrev Andreas Rheinhardt: > Said array contains pointers to other structs and both the designated > new element as well as other stuff contained in it (e.g. strings) > leak > if the new element can't be added to the array. > > Signed-off-by: Andreas Rheinhardt >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mxfdec: Fix memleak upon repeating tags

2020-07-22 Thread Tomas Härdin
mån 2020-07-20 klockan 08:15 +0200 skrev Andreas Rheinhardt: > When parsing MXF encountering some tags leads to allocations. And when > these tags were encountered repeatedly, this could lead to memleaks, > because the pointer to the old data got simply overwritten with a > pointer to the new data

Re: [FFmpeg-devel] [PATCH v2 1/3] libavutil/imgutils: add utility to get plane sizes

2020-07-22 Thread Nicolas George
James Almer (12020-07-20): > No, i'll push v3 soon if my argumentation below was not enough to > convince Nicolas or Michael. My intention is to use ints for the new > function, not to postpone committing it in any form indefinitely. Sorry, I missed you mail earlier, I only read your arguments now

[FFmpeg-devel] [PATCH v2 1/2] avformat/hls: support avio_seek in encryption mode

2020-07-22 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ba17c4ed96..5bc775cd8b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1291,7 +1291,7 @@ static int open_input(HLSContext *c,

[FFmpeg-devel] [PATCH v2 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-07-22 Thread Steven Liu
fix ticket: 8783 Because in single file by encryption mode, it cannot get the last one block of the file, it need ff_format_io_close for get full file size, then hlsenc can get the total size of the encryption content, so write the content into temp file first, and get the temp file content append

Re: [FFmpeg-devel] [PATCH 2/3] avutil/timecode: fix av_timecode_get_smpte_from_framenum with 50/60 fps

2020-07-22 Thread Marton Balint
On Wed, 22 Jul 2020, lance.lmw...@gmail.com wrote: On Mon, Jul 20, 2020 at 11:04:38PM +0200, Marton Balint wrote: 50/60 fps timecode is using the field bit (which is the same as the phase correction bit) to signal the least significant bit of a 50/60 fps timecode. See SMPTE ST 12-1:2014 secti

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-07-22 Thread Steven Liu
fix ticket: 8783 Because in single file by encryption mode, it cannot get the last one block of the file, it need ff_format_io_close for get full file size, then hlsenc can get the total size of the encryption content, so write the content into temp file first, and get the temp file content append

[FFmpeg-devel] [PATCH 1/2] avformat/hls: support avio_seek in encryption mode

2020-07-22 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ba17c4ed96..5bc775cd8b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1291,7 +1291,7 @@ static int open_input(HLSContext *c,