Re: [FFmpeg-devel] [Patch] vf_edgedetect: properly implement double_threshold()

2020-06-21 Thread Andriy Gelman
Hi Valery, Thanks for the patch. Please also update the fate test: https://patchwork.ffmpeg.org/project/ffmpeg/patch/cagtf1mncx2joo-vmtucdkjcp76y5jslnhubzat4mf48c2hf...@mail.gmail.com/ On Fri, 19. Jun 17:15, Valery Kot wrote: > vf_edgedetect video filter implements Canny algorithm > (https://e

[FFmpeg-devel] Support for dumping pgx for JPEG2000

2020-06-21 Thread Gautam Ramakrishnan
Hello, JPEG2000 uses .pgx format for conformance testing. Is it a good idea to allow the ffmpeg native decoder to have an option to dump .pgx files? This would help with testing additions to the code. -- - Gautam | ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Calculate average bitrate for adaptation sets in static manifest

2020-06-21 Thread Jeyapal, Karthick
On 6/22/20 2:13 AM, Przemysław Sobala wrote: > > On Wed, Jun 17, 2020 at 1:58 PM Jeyapal, Karthick wrote: > > > On 6/17/20 5:20 PM, Przemysław Sobala wrote: > > If stream's bitrate is not specified: > > - for static manifest: an average bitrate will be calculated and used, > > - f

Re: [FFmpeg-devel] To Speed Up thumbnail creation - picture & video

2020-06-21 Thread Gyan Doshi
On 22-06-2020 10:28 am, Arunava Banerjee wrote: Hello, We have been using FFMPEG library to create the following thumbnails from videos: a. picture b. video - for example a 60secs video thumbnail. Our video sizes are about 200 - 300 MB. We are using a PHP program to transfer command to the sh

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-21 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 1:54 AM Carl Eugen Hoyos wrote: > > Am So., 21. Juni 2020 um 21:11 Uhr schrieb : > > > > From: Gautam Ramakrishnan > > > > The log2_chroma_wh is derived from the sample separations of the > > codestream if the file is a j2k codestream. Not sure if sample > > separation is

Re: [FFmpeg-devel] [PATCH] oggdec: remove the oggparsedaala subdemuxer

2020-06-21 Thread Vittorio Giovara
On Fri, May 22, 2020 at 9:09 AM Derek Buitenhuis wrote: > On 22/05/2020 10:43, Lynne wrote: > > The Xiph foundation never standardized either Daala nor its mapping in > Ogg, > > and all files that were created are undecodable without knowledge of the > > git hash. > > > > Patch attached. > > +1 f

Re: [FFmpeg-devel] [PATCH v1 1/9] lavu/pix_fmt: add P012 pixel format

2020-06-21 Thread Wang, Fei W
> -Original Message- > From: ffmpeg-devel On Behalf Of Carl > Eugen Hoyos > Sent: Saturday, June 20, 2020 12:59 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v1 1/9] lavu/pix_fmt: add P012 pixel > format > > Am Fr., 19. Juni 2020 um 10:27 Uhr

[FFmpeg-devel] [PATCH] avfilter: add nonlinearstretch filter.

2020-06-21 Thread Mathias Rasmussen
--- Hi there! First time contributor here. I've made a filter for performing nonlinear stretching of videos, also known as dynamic stretch and similar to GoPro's SuperView. I left some questions as TODO's in the code that I hope you can help me answer. Also, how do you run the test or see the out

[FFmpeg-devel] [PATCH 1/2] avformat/avidec: Fix io_fsize overflow

2020-06-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 7958120835074169528 * 9 cannot be represented in type 'long long' Fixes: 23382/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6230683226996736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/2] avcodec/vp9dsp_template: Fix integer overflow in iadst8_1d()

2020-06-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 998938090 + 1169275991 cannot be represented in type 'int' Fixes: 23411/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP9_fuzzer-4644692330545152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_ladspa: check another directory for plugins

2020-06-21 Thread Alexander Strasser
On 2020-06-21 21:19 +0200, Alexander Strasser wrote: > On 2020-06-21 12:49 +, Paul B Mahol wrote: > > ffmpeg | branch: master | Paul B Mahol | Sun Jun 21 > > 14:46:29 2020 +0200| [842bc312ade8fab82465423b22c4fbe3bee63383] | > > committer: Paul B Mahol > > > > avfilter/af_ladspa: check anothe

Re: [FFmpeg-devel] [PATCH 2/2] avformat/dashenc: Calculate average bitrate for adaptation sets in static manifest

2020-06-21 Thread Przemysław Sobala
On Wed, Jun 17, 2020 at 1:58 PM Jeyapal, Karthick wrote: > > On 6/17/20 5:20 PM, Przemysław Sobala wrote: > > If stream's bitrate is not specified: > > - for static manifest: an average bitrate will be calculated and used, > > - for dynamic manifest: first segment's bitrate will be calculated and

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-21 Thread Carl Eugen Hoyos
Am So., 21. Juni 2020 um 21:11 Uhr schrieb : > > From: Gautam Ramakrishnan > > The log2_chroma_wh is derived from the sample separations of the > codestream if the file is a j2k codestream. Not sure if sample > separation is same is subsampling and whether using sample > separation values from the

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/af_ladspa: check another directory for plugins

2020-06-21 Thread Alexander Strasser
Hi Paul! On 2020-06-21 12:49 +, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Sun Jun 21 > 14:46:29 2020 +0200| [842bc312ade8fab82465423b22c4fbe3bee63383] | committer: > Paul B Mahol > > avfilter/af_ladspa: check another directory for plugins > > > http://git.videolan.org/g

[FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-21 Thread gautamramk
From: Gautam Ramakrishnan The log2_chroma_wh is derived from the sample separations of the codestream if the file is a j2k codestream. Not sure if sample separation is same is subsampling and whether using sample separation values from the codestream to determine pixel format. --- libavcodec/jpe

[FFmpeg-devel] [PATCH 3/5] libavcodec/jpeg2000dec.c Fixed WRITE_FRAME and tile co-ordinates:

2020-06-21 Thread gautamramk
From: Gautam Ramakrishnan libopenjpeg2000 uses ceiling division while dividing tile co-ordinates with the sample separation. Also, corrections were made to the WRITE_FRAME macro. --- libavcodec/jpeg2000dec.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH 5/5] libavcodec/jpeg2000dec.c: Remove log2_chroma check in pixel format selection

2020-06-21 Thread Gautam Ramakrishnan
On Mon, Jun 22, 2020 at 12:12 AM wrote: > > From: Gautam Ramakrishnan > > The log2_chroma_wh is derived from the sample separations of the > codestream if the file is a j2k codestream. Not sure if sample > separation is same is subsampling and whether using sample > separation values from the cod

[FFmpeg-devel] [PATCH 4/5] libavcodec/jpeg2000dec.c: Enable image offsets

2020-06-21 Thread gautamramk
From: Gautam Ramakrishnan This patch enables support for image offsets. --- libavcodec/jpeg2000dec.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavcodec/jpeg2000dec.c index 546a646668..c8c89803ac 100644 --- a/libavcodec/jpeg2000dec.c +++ b/libavcodec/jpeg

[FFmpeg-devel] [PATCH 2/5] libavcodec/jpeg2000dec.c: Modify image dimensions

2020-06-21 Thread gautamramk
From: Gautam Ramakrishnan Reduce image size of the image if all components have a non zero sample separation. This is to replicate the output of opj_decompress. --- libavcodec/jpeg2000dec.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/libavcodec/jpeg20

[FFmpeg-devel] [PATCH 1/5] libavcodec/jpeg2000.c: Precinct size check removed

2020-06-21 Thread gautamramk
From: Gautam Ramakrishnan This patch removes a check which throws an error if the log2 precinct width/height is 0. The standard allows the first component to have 0 as the log2 width/height. --- libavcodec/jpeg2000.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/libavcodec/jpeg2000.c b/l

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000: Make corrections jpeg2000 decoder

2020-06-21 Thread Carl Eugen Hoyos
Am So., 21. Juni 2020 um 19:51 Uhr schrieb Gautam Ramakrishnan : > When trying to perform fuzz testing, what kind of configuration would > you recommend using. > For example, I am taking some of the reference files and setting the > error rate to 0.01. Is that sufficient? You could test with diff

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000: Make corrections jpeg2000 decoder

2020-06-21 Thread Gautam Ramakrishnan
On Sat, Jun 20, 2020 at 9:48 AM Gautam Ramakrishnan wrote: > > On Sat, Jun 20, 2020 at 1:29 AM Michael Niedermayer > wrote: > > > > On Thu, Jun 18, 2020 at 11:55:20PM +0530, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > This is with reference to my previous email on the

[FFmpeg-devel] [PATCH] avformat/utils: reorder duration computation to avoid overflow

2020-06-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 8 * 9223372036854774783 cannot be represented in type 'long' Fixes: 23381/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4818340509122560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Hendrik Leppkes
On Sun, Jun 21, 2020 at 6:05 PM Carl Eugen Hoyos wrote: > > Am So., 21. Juni 2020 um 15:52 Uhr schrieb Hendrik Leppkes > : > > > > On Sun, Jun 21, 2020 at 1:41 PM Carl Eugen Hoyos wrote: > > > > > > Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol > > > : > > > > > > > > NAK. > > > > > >

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Carl Eugen Hoyos
Am So., 21. Juni 2020 um 15:52 Uhr schrieb Hendrik Leppkes : > > On Sun, Jun 21, 2020 at 1:41 PM Carl Eugen Hoyos wrote: > > > > Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol : > > > > > > NAK. > > > > Would you like to elaborate? > > It does seem a bit weird to set the default like this

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Hendrik Leppkes
On Sun, Jun 21, 2020 at 1:41 PM Carl Eugen Hoyos wrote: > > Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol : > > > > NAK. > > Would you like to elaborate? > It does seem a bit weird to set the default like this. Shouldn't the default come from the options table, which seems to default to

[FFmpeg-devel] [PATCH v2] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

2020-06-21 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- It's old patch, rebase with master, now have tested with the mpeg2 sample for ticket 6105, the output srt is same. libavcodec/mpeg12dec.c | 85 -- 1 file changed, 40 insertions(+), 45 deletions(-) d

[FFmpeg-devel] [PATCH] avcodec/ccaption_dec: add support for bacground colors

2020-06-21 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/ccaption_dec.c | 68 --- 1 file changed, 64 insertions(+), 4 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index c971c91693..a208e19b95 100644 --- a/libavcodec/ccaption_dec.c +++ b/li

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Paul B Mahol
On 6/21/20, Carl Eugen Hoyos wrote: > Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol : >> >> NAK. > > Would you like to elaborate? Need clear explanation why. Not just what is done. > > Carl Eugen > ___ > ffmpeg-devel mailing list > ffmpeg-dev

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Carl Eugen Hoyos
Am So., 21. Juni 2020 um 12:04 Uhr schrieb Paul B Mahol : > > NAK. Would you like to elaborate? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH] avformat/av1: Avoid using dynamic buffer when assembling av1c

2020-06-21 Thread Andreas Rheinhardt
Given that AV1 only has exactly one sequence header, it is unnecessary to copy the content of said sequence header into an intermediate dynamic buffer; instead the sequence header can be copied from where it is in the input buffer. Signed-off-by: Andreas Rheinhardt --- libavformat/av1.c | 18 +++

Re: [FFmpeg-devel] [PATCH]lavfi/subtitles: Fix subtitles default for ass option shaping

2020-06-21 Thread Paul B Mahol
NAK. On 6/20/20, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #8738 (and #3165) for me. > > Please comment, Carl Eugen > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showpalette: Don't pretend disp_palette can fail

2020-06-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It can't fail, yet it returns an int and other code checks whether it > failed; yet if it did fail, an AVFrame would leak. One could of course > add an av_frame_free for this (that compilers could optimize away), yet > it is easier to simply stop pretending that disp_palette c

Re: [FFmpeg-devel] [PATCH 27/35] avformat/mov: Check earlier whether reel_name string is empty

2020-06-21 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > This patch and all the following patches are not intended to be > backported to 4.3. > > libavformat/mov.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c >

[FFmpeg-devel] [PATCH 5/5] avcodec, avformat: Remove unnecessary initializations of side data size

2020-06-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/audiotoolboxdec.c | 2 +- libavcodec/decode.c | 2 +- libavcodec/libvpxdec.c | 2 +- libavformat/adtsenc.c| 2 +- libavformat/apngenc.c| 2 +- libavformat/flvenc.c | 2 +- libavformat/latmenc.c| 2 +-

Re: [FFmpeg-devel] [PATCH V3] avfilter/zoompan: add in_time variable

2020-06-21 Thread Paul B Mahol
LGTM On 6/19/20, exwm wrote: > Currently, the zoompan filter exposes a 'time' variable (missing from docs) > for use in > the 'zoom', 'x', and 'y' expressions. This variable is perhaps better named > 'out_time' as it represents the timestamp in seconds of each output frame > produced by zoompan.

[FFmpeg-devel] [PATCH 2/5] avformat/flvdec: Cosmetics

2020-06-21 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/flvdec.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 957acedf39..08622739f3 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -514,

[FFmpeg-devel] [PATCH 3/5] avcodec/packet: Improve documentation of av_packet_get_side_data

2020-06-21 Thread Andreas Rheinhardt
Document that it also sets the size in case the desired side data is absent (if the pointer has been supplied). Signed-off-by: Andreas Rheinhardt --- Do this and the next patch actually need a version bump and API change entry? libavcodec/packet.h | 3 ++- 1 file changed, 2 insertions(+), 1 del

[FFmpeg-devel] [PATCH 1/5] avcodec/nellymoserdec: Don't use invalid AVPacketSideDataType

2020-06-21 Thread Andreas Rheinhardt
Commits 957a593cd95b15a5dcb2f50306fbac59f09d8e9e and 11828b8885cc1d87ffc7b1b4bbe642ce9720b194 made the flv demuxer export a certain flag as side data to be used by the nellymoser decoder for mid-stream sample rate changes. It used a custom side data type 'F' that was never officially documented. Y

[FFmpeg-devel] [PATCH 4/5] avformat/avformat: Improve documentation of av_stream_get_side_data

2020-06-21 Thread Andreas Rheinhardt
Document that it also sets the size in case the desired side data is absent (if the pointer has been supplied). Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index