Re: [FFmpeg-devel] [PATCH] dnn/native: fix typo for definition of DOT_INTERMEDIATE

2020-06-02 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Wu, > Zhiwen > Sent: 2020年6月1日 9:01 > To: ffmpeg-devel@ffmpeg.org > Cc: Wu, Zhiwen > Subject: [FFmpeg-devel] [PATCH] dnn/native: fix typo for definition of > DOT_INTERMEDIATE > > From: Wu Zhiwen > > --- > libavfilter/dnn/dnn_bac

Re: [FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-02 Thread Marvin Scholz
Hi, thanks a lot for working on a fix for this. I've just tried it and it does not seem to work, I still can't pass options to the icecast protocol using tee. Command I tried was: ffmpeg -re -i input.mov -c copy -f tee -password hackme -content_type audio/ogg -map 0:v -map 0:a "icecast://sour

Re: [FFmpeg-devel] [PATCH v2 0/4] MIPS MSA & MMI Runtime detection support

2020-06-02 Thread Jiaxun Yang
On Tue, 2 Jun 2020 22:15:03 +0800 Jiaxun Yang wrote: > This series adds MIPS MSA & MMI runtime detection support > > Please review. > > Thanks! > > v2: > - Add CPUCFG support. > - Add "-mloongson-ext" to MMIFLAGS for Loongson-3 as well. > (Loongson2F don't need this flag) Sorry that I d

Re: [FFmpeg-devel] [PATCH] added sei side data

2020-06-02 Thread Brad Hards
Thanks. I have the same need. Brad ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/libdav1d: add support for closed captions stored in ITU-T T35 metadata

2020-06-02 Thread James Almer
Based on code from h264_sei.c Signed-off-by: James Almer --- configure | 2 +- libavcodec/libdav1d.c | 49 +++ 2 files changed, 50 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 8569a60bf8..2961118682 100755 --- a/confi

Re: [FFmpeg-devel] [PATCH] avcodec/ratecontrol: fix the integer overflow after long time run

2020-06-02 Thread lance . lmwang
On Tue, Jun 02, 2020 at 11:39:03PM +0200, Michael Niedermayer wrote: > On Mon, Jun 01, 2020 at 09:53:49PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/ratecontrol.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Lou Logan
On Tue, Jun 2, 2020, at 12:04 PM, Nicolas George wrote: > Lou Logan (12020-06-02): > > Why fixed-do solfège and not Music Macro Language which what was > > used in BASIC? > > Because Microsoft BASIC 1.0 used the fixed-do solfège, and I > implemented following its documentation carefully, and compar

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Nicolas George
Marton Balint (12020-06-02): > Those were the days!!! > > https://www.qbasic.net/en/reference/qb11/Statement/PLAY-006.htm > > This is SMX which seem to have a slight difference to MML according to this: > > https://electronicmusic.fandom.com/wiki/Music_Macro_Language Thanks for the pointers. T

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-02 Thread Michael Niedermayer
On Wed, Jun 03, 2020 at 12:49:10AM +0530, Gautam Ramakrishnan wrote: > On Tue, Jun 2, 2020 at 1:55 AM Carl Eugen Hoyos wrote: > > > > Am Mo., 1. Juni 2020 um 21:26 Uhr schrieb Gautam Ramakrishnan > > : > > > > > > > > can you add some test to fate for this ? > > > > > > (doesnt need to be related

Re: [FFmpeg-devel] [PATCH] avcodec/ratecontrol: fix the integer overflow after long time run

2020-06-02 Thread Michael Niedermayer
On Mon, Jun 01, 2020 at 09:53:49PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/ratecontrol.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611E

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Kieran O Leary
Hi On Tue 2 Jun 2020, 20:50 Nicolas George, wrote: > Paul B Mahol (12020-06-02): > > No need to reinvent yet another poor synthesizer. > > Which is precisely why what I implemented is something well established. > > Can somebody give a third opinion please? > I doubt my opinion means much but I

Re: [FFmpeg-devel] [PATCH] avformat: Find a fallback probe decoder that will also match a forced decoder's codec.

2020-06-02 Thread Michael Niedermayer
On Mon, Jun 01, 2020 at 10:57:08AM -0400, sfoss wrote: > Prevent codecpar->codec_id from getting out of sync with the codec > instantiated for probing. > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) is it intended that the author of this patch is sfoss instea

Re: [FFmpeg-devel] [PATCH] avcodec/h264: support sps/pps AV_PKT_DATA_NEW_EXTRADATA

2020-06-02 Thread Olly Woodman
On Fri, 8 May 2020 at 03:10, Oliver Woodman wrote: > https://github.com/FFmpeg/FFmpeg/commit/601c238 added support > for AV_PKT_DATA_NEW_EXTRADATA, but only for avcC extradata. > This commit adds support for sps/pps extradata as well. This > makes support consistent for passing new extradata cons

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Marton Balint
On Tue, 2 Jun 2020, Lou Logan wrote: On Tue, Jun 2, 2020, at 10:35 AM, Nicolas George wrote: Signed-off-by: Nicolas George [...] +@item DO, RE, MI, FA, SO, LA, SI +Note, named in fixed-do solfège. The note can possibly be followed by "#" or Why fixed-do solfège and not Music Macro Langua

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Nicolas George
Lou Logan (12020-06-02): > Why fixed-do solfège and not Music Macro Language which what was > used in BASIC? Because Microsoft BASIC 1.0 used the fixed-do solfège, and I implemented following its documentation carefully, and comparing the result with an emulator. If you have pointers to the docum

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Lou Logan
On Tue, Jun 2, 2020, at 10:35 AM, Nicolas George wrote: > Signed-off-by: Nicolas George [...] > +@item DO, RE, MI, FA, SO, LA, SI > +Note, named in fixed-do solfège. The note can possibly be followed by "#" or Why fixed-do solfège and not Music Macro Language which what was used in BASIC? This r

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Nicolas George
Paul B Mahol (12020-06-02): > No need to reinvent yet another poor synthesizer. Which is precisely why what I implemented is something well established. Can somebody give a third opinion please? Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

2020-06-02 Thread Gautam Ramakrishnan
On Tue, Jun 2, 2020 at 1:55 AM Carl Eugen Hoyos wrote: > > Am Mo., 1. Juni 2020 um 21:26 Uhr schrieb Gautam Ramakrishnan > : > > > > > > can you add some test to fate for this ? > > > > > (doesnt need to be related to the tests you did, but can of course) > > > > > such a test would also make it e

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Paul B Mahol
On 6/2/20, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > Changelog | 1 + > doc/filters.texi| 50 ++ > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + > libavfilter/asrc_basicplay.c| 309

[FFmpeg-devel] [PATCH] lavf/tee: pass options to protocol.

2020-06-02 Thread Nicolas George
Fix trac ticket #8705. Signed-off-by: Nicolas George --- libavformat/tee.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Not tested, I have no icecast server at hand. I will ask the reporter to test. diff --git a/libavformat/tee.c b/libavformat/tee.c index f2b11fcb35..c5c59975e6 1006

[FFmpeg-devel] [PATCH 3/3] lavfi: add basicplay filter.

2020-06-02 Thread Nicolas George
Signed-off-by: Nicolas George --- Changelog | 1 + doc/filters.texi| 50 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/asrc_basicplay.c| 309 libavfilter/version.h

[FFmpeg-devel] [PATCH 2/3] lavfi/sine: switch to activate.

2020-06-02 Thread Nicolas George
Allow to set the EOF timestamp. Signed-off-by: Nicolas George --- libavfilter/asrc_sine.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavfilter/asrc_sine.c b/libavfilter/asrc_sine.c index 8fff1dda8b..947bc9a288 100644 --- a/libavfilter/asrc_sine.c +++

[FFmpeg-devel] [PATCH 1/3] lavfi/asrc_sine: move sine table generation to a separate file.

2020-06-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/Makefile| 2 +- libavfilter/asrc_sine.c | 53 - libavfilter/intsine.c | 65 + libavfilter/intsine.h | 44 4 files changed, 115 insertions(+),

[FFmpeg-devel] [PATCH v4 24/24] avutil/internal: remove FF_ALLOCx{_ARRAY}_OR_GOTO macros

2020-06-02 Thread lance . lmwang
From: Limin Wang Nicolas George comments for the macros: These functions have a terrible design, let us fix them before extending them. First design mistake: no error code. A helper function for testing memory allocation failure where AVERROR(ENOMEM) does not appear is absurd. Second design mist

[FFmpeg-devel] [PATCH v4 23/24] swscale/utils: remove FF_ALLOC_ARRAY_OR_GOTO macros

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/utils.c | 55 +++--- 1 file changed, 32 insertions(+), 23 deletions(-) diff --git a/libswscale/utils.c b/libswscale/utils.c index 111062e..961750e 100644 --- a/libswscale/utils.c +++ b/lib

[FFmpeg-devel] [PATCH v4 22/24] avcodec/alac: remove FF_ALLOC_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/alac.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 3b41373..bf05406 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -489,6 +489,7 @@ static int

[FFmpeg-devel] [PATCH v4 19/24] avcodec/mpegvideo: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 132 ++--- 1 file changed, 60 insertions(+), 72 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 58fc850..76fb381 100644 --- a/libavcodec/mpegvideo

[FFmpeg-devel] [PATCH v4 20/24] avcodec/mpegpicture: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegpicture.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index be90ece..83426bb 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c

[FFmpeg-devel] [PATCH v4 18/24] avcodec/mpegvideo: simplify check for av_frame_alloc

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 34dfda5..58fc850 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -

[FFmpeg-devel] [PATCH v4 21/24] avcodec/mpegvideo_enc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo_enc.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 5a499fb..eba041f 100644 --- a/libavcodec/mpegvideo_enc

[FFmpeg-devel] [PATCH v4 17/24] avcodec/iirfilter: remove FF_ALLOCZ_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/iirfilter.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/iirfilter.c b/libavcodec/iirfilter.c index 749fa57..ddd42c2 100644 --- a/libavcodec/iirfilter.c +++ b/libavcodec/iirfilter.c @@ -17

[FFmpeg-devel] [PATCH v4 16/24] avcodec/aacenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and failed gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 189f5e0..e65b76c 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -941,15 +941,1

[FFmpeg-devel] [PATCH v4 13/24] avcodec/snow: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/snow.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index a3e6afc..066efc5 100644 --- a/libavcodec/snow.c +++ b/libavcodec/snow.c @@ -487,28 +487,2

[FFmpeg-devel] [PATCH v4 15/24] avcodec/ac3enc_template: remove FF_ALLOC_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc_template.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c index be65987..985b35e 100644 --- a/libavcodec/ac3enc_template.c +++ b/l

[FFmpeg-devel] [PATCH v4 14/24] avcodec/ac3enc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 94 ++--- 1 file changed, 38 insertions(+), 56 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 4fb2dd9..37dc0fb 100644 --- a/libavcodec/ac3enc.c +++ b/

[FFmpeg-devel] [PATCH v4 12/24] avcodec/dnxhdenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dnxhdenc.c | 65 +-- 1 file changed, 22 insertions(+), 43 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index fad8400..bcf4f39 100644 --- a/libavcodec/dnxhdenc.c

[FFmpeg-devel] [PATCH v4 10/24] avcodec/apedec: remove FF_ALLOC_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 0bee9d8..a817673 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -262,9 +262,8 @@ static av

[FFmpeg-devel] [PATCH v4 08/24] avcodec/alac: Add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/alac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 82689da..3b41373 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -511,7 +511,6 @@ static int allocate_buffer

[FFmpeg-devel] [PATCH v4 11/24] avcodec/twinvq: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/twinvq.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavcodec/twinvq.c b/libavcodec/twinvq.c index 34ca184..6dfaf06 100644 --- a/libavcodec/twinvq.c +++ b/libavcodec/twinvq.c @@ -538,

[FFmpeg-devel] [PATCH v4 09/24] avcodec: add FF_CODEC_CAP_INIT_CLEANUP for all codecs which use ff_mpv_common_init()

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h261dec.c | 1 + libavcodec/h263dec.c | 4 ++-- libavcodec/mpeg12dec.c | 9 - libavcodec/mpeg4videodec.c | 3 ++- libavcodec/mpegpicture.c | 1 - libavcodec/mpegvideo.c | 2 -- libavcodec/msmpeg4dec.c| 8

[FFmpeg-devel] [PATCH v4 06/24] avcodec/ac3enc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 1 - libavcodec/ac3enc_fixed.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index ddbc7b2..4fb2dd9 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc

[FFmpeg-devel] [PATCH v4 03/24] avcodec/h264dec: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 60 +++- libavutil/internal.h | 3 +++ 2 files changed, 20 insertions(+), 43 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 66f45e6..dc3d6ad 10064

[FFmpeg-devel] [PATCH v4 05/24] avcodec/apedec: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 65c07d0..0bee9d8 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -301,7 +301,6 @@ static av_cold i

[FFmpeg-devel] [PATCH v4 07/24] avcodec/aacenc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c| 3 +-- libavcodec/iirfilter.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index db11e0c..189f5e0 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c

[FFmpeg-devel] [PATCH v4 04/24] avcodec/adpcmenc: remove FF_ALLOC_OR_GOTO macros for gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index d5fbc0b..1fe1aef 100644 --- a/libavcodec/adpcmenc.c +++ b/libavco

[FFmpeg-devel] [PATCH v4 01/24] avcodec/h264dec: cosmetics

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 6270ea8..4d8c0b1 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -253,8 +253,7 @@ int ff_h2

[FFmpeg-devel] [PATCH v4 02/24] avcodec/h264dec: store count of the tables into const variable for long lines

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 4d8c0b1..66f45e6 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -182,6 +182,7 @@ int

Re: [FFmpeg-devel] [PATCH v3 01/24] avcodec/h264dec: cosmetics

2020-06-02 Thread lance . lmwang
On Tue, Jun 02, 2020 at 11:16:29PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/h264dec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c > index 6270ea8..4d8c0b1

[FFmpeg-devel] [PATCH v3 01/24] avcodec/h264dec: cosmetics

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 6270ea8..4d8c0b1 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -253,8 +253,7 @@ int ff_h2

[FFmpeg-devel] [PATCH v3 01/22] avcodec/h264dec: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 60 +++- libavutil/internal.h | 3 +++ 2 files changed, 20 insertions(+), 43 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 66f45e6..dc3d6ad 10064

[FFmpeg-devel] [PATCH v3 18/24] avcodec/mpegvideo: simplify check for av_frame_alloc

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 34dfda5..58fc850 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -

[FFmpeg-devel] [PATCH v3 19/22] avcodec/mpegvideo_enc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo_enc.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index 5a499fb..eba041f 100644 --- a/libavcodec/mpegvideo_enc

[FFmpeg-devel] [PATCH v3 16/24] avcodec/aacenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and failed gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 189f5e0..e65b76c 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -941,15 +941,1

[FFmpeg-devel] [PATCH v3 18/22] avcodec/mpegpicture: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegpicture.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegpicture.c b/libavcodec/mpegpicture.c index be90ece..83426bb 100644 --- a/libavcodec/mpegpicture.c +++ b/libavcodec/mpegpicture.c

[FFmpeg-devel] [PATCH v3 16/22] avcodec/mpegvideo: simplify check for av_frame_alloc

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 34dfda5..58fc850 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -

[FFmpeg-devel] [PATCH v3 14/24] avcodec/ac3enc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 94 ++--- 1 file changed, 38 insertions(+), 56 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 4fb2dd9..37dc0fb 100644 --- a/libavcodec/ac3enc.c +++ b/

[FFmpeg-devel] [PATCH v3 17/24] avcodec/iirfilter: remove FF_ALLOCZ_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/iirfilter.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/iirfilter.c b/libavcodec/iirfilter.c index 749fa57..ddd42c2 100644 --- a/libavcodec/iirfilter.c +++ b/libavcodec/iirfilter.c @@ -17

[FFmpeg-devel] [PATCH v3 17/22] avcodec/mpegvideo: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 132 ++--- 1 file changed, 60 insertions(+), 72 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 58fc850..76fb381 100644 --- a/libavcodec/mpegvideo

[FFmpeg-devel] [PATCH v3 15/24] avcodec/ac3enc_template: remove FF_ALLOC_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc_template.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c index be65987..985b35e 100644 --- a/libavcodec/ac3enc_template.c +++ b/l

[FFmpeg-devel] [PATCH v3 15/22] avcodec/iirfilter: remove FF_ALLOCZ_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/iirfilter.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/iirfilter.c b/libavcodec/iirfilter.c index 749fa57..ddd42c2 100644 --- a/libavcodec/iirfilter.c +++ b/libavcodec/iirfilter.c @@ -17

[FFmpeg-devel] [PATCH v3 14/22] avcodec/aacenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and failed gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index 189f5e0..e65b76c 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c @@ -941,15 +941,1

[FFmpeg-devel] [PATCH v3 12/22] avcodec/ac3enc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 94 ++--- 1 file changed, 38 insertions(+), 56 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 4fb2dd9..37dc0fb 100644 --- a/libavcodec/ac3enc.c +++ b/

[FFmpeg-devel] [PATCH v3 13/22] avcodec/ac3enc_template: remove FF_ALLOC_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc_template.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c index be65987..985b35e 100644 --- a/libavcodec/ac3enc_template.c +++ b/l

[FFmpeg-devel] [PATCH v3 13/24] avcodec/snow: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/snow.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index a3e6afc..066efc5 100644 --- a/libavcodec/snow.c +++ b/libavcodec/snow.c @@ -487,28 +487,2

[FFmpeg-devel] [PATCH v3 12/24] avcodec/dnxhdenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dnxhdenc.c | 65 +-- 1 file changed, 22 insertions(+), 43 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index fad8400..bcf4f39 100644 --- a/libavcodec/dnxhdenc.c

[FFmpeg-devel] [PATCH v3 11/24] avcodec/twinvq: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/twinvq.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavcodec/twinvq.c b/libavcodec/twinvq.c index 34ca184..6dfaf06 100644 --- a/libavcodec/twinvq.c +++ b/libavcodec/twinvq.c @@ -538,

[FFmpeg-devel] [PATCH v3 10/22] avcodec/dnxhdenc: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/dnxhdenc.c | 65 +-- 1 file changed, 22 insertions(+), 43 deletions(-) diff --git a/libavcodec/dnxhdenc.c b/libavcodec/dnxhdenc.c index fad8400..bcf4f39 100644 --- a/libavcodec/dnxhdenc.c

[FFmpeg-devel] [PATCH v3 11/22] avcodec/snow: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/snow.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/libavcodec/snow.c b/libavcodec/snow.c index a3e6afc..066efc5 100644 --- a/libavcodec/snow.c +++ b/libavcodec/snow.c @@ -487,28 +487,2

[FFmpeg-devel] [PATCH v3 10/24] avcodec/apedec: remove FF_ALLOC_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 0bee9d8..a817673 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -262,9 +262,8 @@ static av

[FFmpeg-devel] [PATCH v3 09/22] avcodec/twinvq: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos label

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/twinvq.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavcodec/twinvq.c b/libavcodec/twinvq.c index 34ca184..6dfaf06 100644 --- a/libavcodec/twinvq.c +++ b/libavcodec/twinvq.c @@ -538,

[FFmpeg-devel] [PATCH v3 09/24] avcodec: add FF_CODEC_CAP_INIT_CLEANUP for all codecs which use ff_mpv_common_init()

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h261dec.c | 1 + libavcodec/h263dec.c | 4 ++-- libavcodec/mpeg12dec.c | 9 - libavcodec/mpeg4videodec.c | 3 ++- libavcodec/mpegpicture.c | 1 - libavcodec/mpegvideo.c | 2 -- libavcodec/msmpeg4dec.c| 8

[FFmpeg-devel] [PATCH v3 08/24] avcodec/alac: Add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/alac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 82689da..3b41373 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -511,7 +511,6 @@ static int allocate_buffer

[FFmpeg-devel] [PATCH v3 07/24] avcodec/aacenc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c| 3 +-- libavcodec/iirfilter.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index db11e0c..189f5e0 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c

[FFmpeg-devel] [PATCH v3 06/22] avcodec/alac: Add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/alac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 82689da..3b41373 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -511,7 +511,6 @@ static int allocate_buffer

[FFmpeg-devel] [PATCH v3 07/22] avcodec: add FF_CODEC_CAP_INIT_CLEANUP for all codecs which use ff_mpv_common_init()

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h261dec.c | 1 + libavcodec/h263dec.c | 4 ++-- libavcodec/mpeg12dec.c | 9 - libavcodec/mpeg4videodec.c | 3 ++- libavcodec/mpegpicture.c | 1 - libavcodec/mpegvideo.c | 2 -- libavcodec/msmpeg4dec.c| 8

[FFmpeg-devel] [PATCH v3 08/22] avcodec/apedec: remove FF_ALLOC_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 0bee9d8..a817673 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -262,9 +262,8 @@ static av

[FFmpeg-devel] [PATCH v3 06/24] avcodec/ac3enc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 1 - libavcodec/ac3enc_fixed.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index ddbc7b2..4fb2dd9 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc

[FFmpeg-devel] [PATCH v3 04/24] avcodec/adpcmenc: remove FF_ALLOC_OR_GOTO macros for gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index d5fbc0b..1fe1aef 100644 --- a/libavcodec/adpcmenc.c +++ b/libavco

[FFmpeg-devel] [PATCH v3 04/22] avcodec/ac3enc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/ac3enc.c | 1 - libavcodec/ac3enc_fixed.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index ddbc7b2..4fb2dd9 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc

[FFmpeg-devel] [PATCH v3 05/24] avcodec/apedec: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 65c07d0..0bee9d8 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -301,7 +301,6 @@ static av_cold i

[FFmpeg-devel] [PATCH v3 03/24] avcodec/h264dec: remove FF_ALLOCZ_ARRAY_OR_GOTO and gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 60 +++- libavutil/internal.h | 3 +++ 2 files changed, 20 insertions(+), 43 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 66f45e6..dc3d6ad 10064

[FFmpeg-devel] [PATCH v3 05/22] avcodec/aacenc: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/aacenc.c| 3 +-- libavcodec/iirfilter.c | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c index db11e0c..189f5e0 100644 --- a/libavcodec/aacenc.c +++ b/libavcodec/aacenc.c

[FFmpeg-devel] [PATCH v3 02/22] avcodec/adpcmenc: remove FF_ALLOC_OR_GOTO macros for gotos lable

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/adpcmenc.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c index d5fbc0b..1fe1aef 100644 --- a/libavcodec/adpcmenc.c +++ b/libavco

[FFmpeg-devel] [PATCH v3 03/22] avcodec/apedec: add FF_CODEC_CAP_INIT_CLEANUP

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 65c07d0..0bee9d8 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -301,7 +301,6 @@ static av_cold i

[FFmpeg-devel] [PATCH v3 02/24] avcodec/h264dec: store count of the tables into const variable for long lines

2020-06-02 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/h264dec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index 4d8c0b1..66f45e6 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -182,6 +182,7 @@ int

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Paul B Mahol
On 6/2/20, Nicolas George wrote: > James Almer (12020-06-02): >> Suggesting a name for both the filter and the options would help quite a >> bit. It would for starters prevent him from coming up with new ones that >> you may also end up not liking. > > For the option, the correct name is obvious:

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Nicolas George
James Almer (12020-06-02): > Suggesting a name for both the filter and the options would help quite a > bit. It would for starters prevent him from coming up with new ones that > you may also end up not liking. For the option, the correct name is obvious: frame_size. For the filter, I would need

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread James Almer
On 6/2/2020 11:18 AM, Nicolas George wrote: > Paul B Mahol (12020-06-02): > > > I have nothing to add to what I have already written. This filter is > rejected until the problem I have pointed are resolved: better name, > better doc, better options name, comments on the magic numbers. Suggesting

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Nicolas George
Paul B Mahol (12020-06-02): I have nothing to add to what I have already written. This filter is rejected until the problem I have pointed are resolved: better name, better doc, better options name, comments on the magic numbers. Regards, -- Nicolas George signature.asc Description: PGP si

[FFmpeg-devel] [PATCH v2 3/4] libavutil: Detect MMI and MSA flags for MIPS

2020-06-02 Thread Jiaxun Yang
Add MMI & MSA runtime detection for MIPS. Basically there are two code pathes. For systems that natively support CPUCFG instruction or kernel emulated that instruction, we'll sense this feature from HWCAP and report the flags according to values grab from CPUCFG. For systems that have no CPUCFG (o

[FFmpeg-devel] [PATCH v2 0/4] MIPS MSA & MMI Runtime detection support

2020-06-02 Thread Jiaxun Yang
This series adds MIPS MSA & MMI runtime detection support Please review. Thanks! v2: - Add CPUCFG support. - Add "-mloongson-ext" to MMIFLAGS for Loongson-3 as well. (Loongson2F don't need this flag) Jiaxun Yang (4): ffbuild: Refine MIPS handling libavutils: Add parse_r helper for MIPS

[FFmpeg-devel] [PATCH v2 2/4] libavutils: Add parse_r helper for MIPS

2020-06-02 Thread Jiaxun Yang
That helper grab from kernel code can allow us to inline newer instructions (not implemented by the assembler) in a elegant manner. Signed-off-by: Jiaxun Yang --- libavutil/mips/asmdefs.h | 42 1 file changed, 42 insertions(+) diff --git a/libavutil/mips

[FFmpeg-devel] [PATCH v2 1/4] ffbuild: Refine MIPS handling

2020-06-02 Thread Jiaxun Yang
To enable runtime detection for MIPS, we need to refine ffbuild part to support buildding these feature together. Firstly, we fixed configure, let it probe native ability of toolchain to decide wether a feature can to be enabled, also clearly marked the conflictions between loongson2 & loongson3 a

[FFmpeg-devel] [PATCH v2 4/4] libavcodec: Enable runtime detection for MIPS MMI & MSA

2020-06-02 Thread Jiaxun Yang
Apply optimized functions according to cpuflags. MSA is always put after MMI as it's usually faster than MMI. Signed-off-by: Jiaxun Yang --- libavcodec/mips/blockdsp_init_mips.c| 22 +- libavcodec/mips/cabac.h | 2 +- libavcodec/mips/h263dsp_init_mips

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Paul B Mahol
Hi, On 6/2/20, Nicolas George wrote: > Paul B Mahol (12020-06-02): >> Your opinion is not technical one. > > It pertains to usability. Filter is already very usable. > >> > Insufficient: users have no idea what it means. >> They need only to experiment, we can not teach them whole wavelet >> th

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Nicolas George
Paul B Mahol (12020-06-02): > Your opinion is not technical one. It pertains to usability. > > Insufficient: users have no idea what it means. > They need only to experiment, we can not teach them whole wavelet > theory in 5 minutes. You need to explain the practical facts, not the theory. > fr

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Paul B Mahol
On 6/2/20, Nicolas George wrote: > Paul B Mahol (12020-06-02): >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 41 +++ >> libavfilter/Makefile | 1 + > >> libavfilter/af_afwtdn.c | 653 +++ > > I still oppose strongly to the name of

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Nicolas George
Lou Logan (12020-05-31): > Got any suggestions? We have 3 existing "audio-3 letter algorithm name- > denoise" filters so there is sort of a naming convention already. I do not consider something that was pushed by a single developer, mostly without review, to be a binding convention. And we proba

Re: [FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Nicolas George
Paul B Mahol (12020-06-02): > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 41 +++ > libavfilter/Makefile | 1 + > libavfilter/af_afwtdn.c | 653 +++ I still oppose strongly to the name of the filter. > libavfilter/allfilters.c |

[FFmpeg-devel] [PATCH] avfilter: add afwtdn filter

2020-06-02 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 41 +++ libavfilter/Makefile | 1 + libavfilter/af_afwtdn.c | 653 +++ libavfilter/allfilters.c | 1 + 4 files changed, 696 insertions(+) create mode 100644 libavfilter/af_afwtdn.c diff --gi

  1   2   >