Re: [FFmpeg-devel] [PATCH 2/2] dnn-layer-mathbinary-test: add unit test for minimum

2020-05-06 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel On Behalf Of Guo, > Yejun > Sent: 2020年4月30日 19:39 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/2] dnn-layer-mathbinary-test: add unit > test for minimum > > > > > -Original Message- > > From: Guo, Yejun > > Se

Re: [FFmpeg-devel] [PATCH 1/3] avformat/matroskadec: Sanitize SeekHead entries

2020-05-06 Thread Andreas Rheinhardt
Andreas Rheinhardt: > A Seek element in a Matroska SeekHead should contain a SeekID and a > SeekPosition element and upon reading, they should be sanitized: > > Given that IDs are restricted to 32 bit, longer SeekIDs should be treated > as invalid. Instead currently the lower 32 bits have been use

Re: [FFmpeg-devel] [PATCH v2] avcodec/v4l2_m2m: Adapt to call close() on init fail

2020-05-06 Thread Andriy Gelman
On Tue, 28. Apr 22:54, Andriy Gelman wrote: > From: Andriy Gelman > > This fixes several mem leaks when init of encoder/decoder failed. > > Fixes ticket #8285 > > Signed-off-by: Andriy Gelman > --- > > Changes in v2: > - Use FF_CODEC_CAP_INIT_CLEANUP > > This patch supersedes: > > http

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12enc: replace return -1 with proper error codes

2020-05-06 Thread lance . lmwang
On Thu, May 07, 2020 at 01:21:44AM +0200, Nicolas George wrote: > lance.lmw...@gmail.com (12020-05-07): > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/mpeg12enc.c | 10 +- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/exr: add option to output pixels in float

2020-05-06 Thread Mark Reid
On Wed, May 6, 2020 at 1:07 PM Anton Khirnov wrote: > Quoting mindm...@gmail.com (2020-04-29 05:02:35) > > From: Mark Reid > > > > --- > > libavcodec/exr.c | 103 +++ > > 1 file changed, 86 insertions(+), 17 deletions(-) > > > > diff --git a/libavcode

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-06 Thread lance . lmwang
On Wed, May 06, 2020 at 09:43:32PM +0200, Marton Balint wrote: > > > On Tue, 5 May 2020, lance.lmw...@gmail.com wrote: > > > On Mon, May 04, 2020 at 09:34:02PM +0200, Marton Balint wrote: > > > > > > > > > On Mon, 4 May 2020, lance.lmw...@gmail.com wrote: > > > > > > > On Sun, May 03, 2020 at

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12enc: replace return -1 with proper error codes

2020-05-06 Thread Nicolas George
lance.lmw...@gmail.com (12020-05-07): > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mpeg12enc.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c > index 643ba81..f317c63 100644 > --- a/liba

[FFmpeg-devel] [PATCH] avcodec/mpeg12enc: replace return -1 with proper error codes

2020-05-06 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpeg12enc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c index 643ba81..f317c63 100644 --- a/libavcodec/mpeg12enc.c +++ b/libavcodec/mpeg12enc.c @@ -142,13

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread lance . lmwang
On Wed, May 06, 2020 at 07:12:23PM +0200, Marton Balint wrote: > > > On Wed, 6 May 2020, lance.lmw...@gmail.com wrote: > > > On Wed, May 06, 2020 at 10:11:22AM +0200, Marton Balint wrote: > > > > > > > > > On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: > > > > > > > From: Limin Wang > >

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/exr: add option to output pixels in float

2020-05-06 Thread Anton Khirnov
Quoting mindm...@gmail.com (2020-04-29 05:02:35) > From: Mark Reid > > --- > libavcodec/exr.c | 103 +++ > 1 file changed, 86 insertions(+), 17 deletions(-) > > diff --git a/libavcodec/exr.c b/libavcodec/exr.c > @@ -1888,6 +1955,8 @@ static const AVOp

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-06 Thread Marton Balint
On Tue, 5 May 2020, lance.lmw...@gmail.com wrote: On Mon, May 04, 2020 at 09:34:02PM +0200, Marton Balint wrote: On Mon, 4 May 2020, lance.lmw...@gmail.com wrote: > On Sun, May 03, 2020 at 07:10:07PM +0200, Marton Balint wrote: > > > > > > On Sun, 3 May 2020, lance.lmw...@gmail.com wrote

Re: [FFmpeg-devel] Reporting bugs

2020-05-06 Thread Lou Logan
On Tue, May 5, 2020, at 4:07 AM, Nico Coesel wrote: > Hello all, > I want to report a bug in the jpeg encoding but I can't seem to register > to trac. > > Is there a special trick to it? Are you having trouble getting past the antispam check? Or did not not receive the verification email? __

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread Marton Balint
On Wed, 6 May 2020, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of lance.lmw...@gmail.com Sent: Wednesday, May 6, 2020 22:57 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles On Wed, May 06, 2020 at 06:13:10PM +0800,

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: Add myself to libopenh264enc

2020-05-06 Thread Michael Niedermayer
On Thu, Apr 30, 2020 at 09:12:44AM +0800, Linjie Fu wrote: > Reviewed-by: Martin Storsjö > Signed-off-by: Linjie Fu > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times m

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread Marton Balint
On Wed, 6 May 2020, lance.lmw...@gmail.com wrote: On Wed, May 06, 2020 at 10:11:22AM +0200, Marton Balint wrote: On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The patch will make audio and subtitle packets be marked as AV_PKT_FLAG_KEY. Why the subtitles? Is

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > lance.lmw...@gmail.com > Sent: Wednesday, May 6, 2020 22:57 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic > candidate h264 profiles > > On Wed, May 06, 2020 at 06:13:10PM +0800, myp...@gmail.com wrote: >

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-06 Thread James Almer
On 5/6/2020 12:22 PM, Neil Birkbeck wrote: > On Tue, May 5, 2020 at 5:11 AM Kieran O Leary > wrote: > >> Hi, >> >> I broke the threading with my last reply, i apologise. Here goes another >> attempt: >> >> On Tue, Apr 28, 2020 at 6:23 PM Neil Birkbeck >> wrote: >> >>> On Tue, Apr 28, 2020 at 3:1

Re: [FFmpeg-devel] [PATCH] libavutil: add clean aperture (CLAP) side data.

2020-05-06 Thread Neil Birkbeck
On Tue, May 5, 2020 at 5:11 AM Kieran O Leary wrote: > Hi, > > I broke the threading with my last reply, i apologise. Here goes another > attempt: > > On Tue, Apr 28, 2020 at 6:23 PM Neil Birkbeck > wrote: > > > On Tue, Apr 28, 2020 at 3:18 AM Nicolas George wrote: > > > > > Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/ftp: Fix for invalid use of av_strtok

2020-05-06 Thread lance . lmwang
On Sat, Apr 18, 2020 at 12:19:30PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > By the av_strtok() description: > * On the first call to av_strtok(), s should point to the string to > * parse, and the value of saveptr is ignored. In subsequent calls, s > * should be NULL, and sa

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread lance . lmwang
On Wed, May 06, 2020 at 06:13:10PM +0800, myp...@gmail.com wrote: > On Wed, May 6, 2020 at 6:04 PM myp...@gmail.com wrote: > > > > On Wed, May 6, 2020 at 5:40 PM Martin Storsjö wrote: > > > > > > On Wed, 6 May 2020, Linjie Fu wrote: > > > > > > > Allows specifying avctx->profile with string type

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread lance . lmwang
On Wed, May 06, 2020 at 10:11:22AM +0200, Marton Balint wrote: > > > On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > The patch will make audio and subtitle packets be marked as AV_PKT_FLAG_KEY. > > Why the subtitles? Is it possible that the patch description

Re: [FFmpeg-devel] [PATCH] [libavutil] Add saturated add/sub operations for int64_t.

2020-05-06 Thread Michael Niedermayer
On Mon, May 04, 2020 at 04:06:56PM -0700, Dale Curtis wrote: > On Mon, May 4, 2020 at 3:39 PM Michael Niedermayer > wrote: > > > On Mon, May 04, 2020 at 02:19:47PM -0700, Dale Curtis wrote: > > > On Mon, May 4, 2020 at 1:48 PM Michael Niedermayer > > > > [...] > > > > You snipped out the exampl

[FFmpeg-devel] [PATCH v5 1/3] lavc/libopenh264enc: Rewrite profile handling

2020-05-06 Thread Linjie Fu
Support the profiles "constrained_baseline" and "high" for libopenh264 version >= 1.8, support "constrained_baseline" and "main" for earlier version. If option not supported with current version, convert to constrained baseline with a warning for users. Signed-off-by: Linjie Fu --- libavcodec/l

[FFmpeg-devel] [PATCH v5 2/3] lavc/libopenh264enc: Allow specifying the profile through AVCodecContext

2020-05-06 Thread Linjie Fu
And determine the profile with following priority: 1. s->profile; then 2. avctx->profile; then 3. s->cabac; then 4. a default profile. This seems more natural in case user somehow sets both avctx->profile and s->profile. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 15

[FFmpeg-devel] [PATCH v5 3/3] lavc/libopenh264enc: Add coder option to replace cabac

2020-05-06 Thread Linjie Fu
Set DEPRECATED flag to option cabac, replace with coder. The priority logic is: 1. s->coder; then 2. avctx->coder_type; then 3. s->cabac. Change the default option to -1 and allow the default cabac to be determined by profile. Add FF_API_OPENH264_CABAC macro for cabac to remove this option after

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-05-06 Thread Nicolas George
Andreas Rheinhardt (12020-05-05): > (This proposal would increase sizeof(AVOutputFormat) and would therefore > cause problems when one uses a new libavformat together with an old > libavdevice (despite no libavdevice muxer using custom interleavement > functions) Can I count you among the develope

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread Fu, Linjie
> From: myp...@gmail.com > Sent: Wednesday, May 6, 2020 18:13 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic > candidate h264 profiles > > On Wed, May 6, 2020 at 6:04 PM myp...@gmail.co

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: compute the segment size use current pos minus offset plus one

2020-05-06 Thread myp...@gmail.com
On Wed, May 6, 2020 at 2:53 PM Steven Liu wrote: > > because the offset should use one byte > > Reported-by: Zhao Jun > > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread myp...@gmail.com
On Wed, May 6, 2020 at 6:04 PM myp...@gmail.com wrote: > > On Wed, May 6, 2020 at 5:40 PM Martin Storsjö wrote: > > > > On Wed, 6 May 2020, Linjie Fu wrote: > > > > > Allows specifying avctx->profile with string type profile for > > > h264 encoders. > > > > > > Private field/option "profile" may

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread myp...@gmail.com
On Wed, May 6, 2020 at 5:40 PM Martin Storsjö wrote: > > On Wed, 6 May 2020, Linjie Fu wrote: > > > Allows specifying avctx->profile with string type profile for > > h264 encoders. > > > > Private field/option "profile" may be abled to be removed for basic > > h264 profiles, directly for encoders

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread Martin Storsjö
On Wed, 6 May 2020, Linjie Fu wrote: Allows specifying avctx->profile with string type profile for h264 encoders. Private field/option "profile" may be abled to be removed for basic h264 profiles, directly for encoders like libopenh264/h264_vaapi, or with an map to hardware profile like h264_qs

Re: [FFmpeg-devel] [PATCH v3] Add support for playing Audible AAXC (.aaxc) files

2020-05-06 Thread Vesselin Bontchev
08.04.2020, 06:54, "Vesselin Bontchev" : > The AAXC container format is the same as the (already supported) Audible > AAX format but it uses a different encryption scheme. > > Note: audible_key and audible_iv values are variable (per file) and are > externally fed. Can we please merge this patch?

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread Marton Balint
On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: From: Limin Wang The patch will make audio and subtitle packets be marked as AV_PKT_FLAG_KEY. Why the subtitles? Is it possible that the patch description is outdated? I don't see from the code how would this apply to subtitles, after all

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Improve checks for invalid stream mappings

2020-05-06 Thread Andreas Rheinhardt
Steven Liu: > > >> 2020年5月6日 下午12:17,Andreas Rheinhardt 写道: >> >> The mapping of streams to the various variant streams to be created by >> the HLS muxer is roughly as follows: Space and tab separate variant >> stream group maps while the entries in each variant stream group map are >> separated

[FFmpeg-devel] [PATCH] avformat/hlsenc: Don't segfault on uncommon names

2020-05-06 Thread Andreas Rheinhardt
The parsing process of the AVOpt-enabled string controlling the mapping of input streams to variant streams is roughly as follows: Space and tab separate variant stream group maps while the entries in each variant stream group map are separated by ','. The parsing process of each variant stream gr