[FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-06 Thread Steven Liu
add option for resend init file after m3u8 refresh everytime. Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 41 - 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH 13/23] lavc/movtextenc: keep values in native byte order till written

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:08 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 38 ++ > 1 file changed, 22 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index 8638e303fe..5e5b786f44 100644 > ---

Re: [FFmpeg-devel] [PATCH 12/23] lavc/movtextenc: use correct color component order

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:07 -0600 John Stebbins wrote: > --- > libavcodec/movtextenc.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c > index c19ef384bc..8638e303fe 100644 > --- a/libavcodec/movtextenc.c > ++

[FFmpeg-devel] [PATCH] avfilter/vf_drawtext: only test available exceptions

2020-04-06 Thread Rosen Penev
soft float systems do not define these macros under musl. Fixes: Ticket7102 Signed-off-by: Rosen Penev --- libavfilter/vf_drawtext.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index 887a686d16..abe1ca6c35 100644 --- a/libavfilter/

Re: [FFmpeg-devel] [PATCH 09/23] lavc/movtextdec: restore active style color after hilite

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:04 -0600 John Stebbins wrote: > --- > libavcodec/movtextdec.c | 14 +- > 1 file changed, 9 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 4d5dcdf5e7..f3a504b47b 100644 > --- a/libavcodec/movtextdec.c

Re: [FFmpeg-devel] [PATCH 08/23] lavc/movtextdec: add color and alpha style tags

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:03 -0600 John Stebbins wrote: > --- > libavcodec/movtextdec.c | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index eb9c7f5755..4d5dcdf5e7 100644 > --- a/libavcodec/movtextdec.

Re: [FFmpeg-devel] [PATCH 06/23] lavc/movtextdec: make sure default font name is set

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:01 -0600 John Stebbins wrote: > --- > libavcodec/movtextdec.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 6c7d93702e..2481c71af6 100644 > --- a/libavcodec/movtextdec.c > +++ b/liba

Re: [FFmpeg-devel] [PATCH 07/23] lavc/movtextdec: add alpha default to ass header colors

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:02 -0600 John Stebbins wrote: > --- > libavcodec/movtextdec.c| 14 ++ > tests/ref/fate/sub-movtext | 2 +- > 2 files changed, 11 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 2481c71af6..eb9c7f5

Re: [FFmpeg-devel] [PATCH 02/23] lavc/movtextdec: simplify style record walk

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 22:09:22 + John Stebbins wrote: > > I went back and double checked this in the spec before changing the > code. > > "The styles shall be ordered by starting character offset, and the > starting offset of one style record shall be greater than or equal to > the ending char

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: fix compilation under soft float MIPS

2020-04-06 Thread Rosen Penev
On Mon, Apr 6, 2020 at 2:42 PM Carl Eugen Hoyos wrote: > > Am Mo., 6. Apr. 2020 um 07:29 Uhr schrieb Rosen Penev : > > > > Place HAVE_MIPSFPU further up so that functions that use floating point > > ASM are defined away. Otherwise compilation failures result when soft > > float in enabled on the t

Re: [FFmpeg-devel] [PATCH 11/14] h264_sei: parse the picture timing SEIs correctly

2020-04-06 Thread Michael Niedermayer
On Fri, Mar 27, 2020 at 01:57:45PM +0100, Anton Khirnov wrote: > Those SEIs refer to the currently active SPS. However, since the SEI > NALUs precede the coded picture data in the bitstream, the active SPS is > in general not known when we are decoding the SEI. > > Therefore, store the content of

Re: [FFmpeg-devel] [PATCH 12/14] h264_ps: make the PPS hold a reference to its SPS

2020-04-06 Thread Michael Niedermayer
On Fri, Mar 27, 2020 at 01:57:46PM +0100, Anton Khirnov wrote: > It represents the relationship between them more naturally and will be > useful in the following commits. > > Allows significantly more frames in fate-h264-attachment-631 to be > decoded. > --- > libavcodec/h264_parser.c |

Re: [FFmpeg-devel] [PATCH 13/14] h264dec: rename flush_dpb()

2020-04-06 Thread Michael Niedermayer
On Fri, Mar 27, 2020 at 01:57:47PM +0100, Anton Khirnov wrote: > The name is misleading, this function does a lot more than just flushing > the DPB. > --- > libavcodec/h264dec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) still LGTM thx [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 14/14] h264dec: do not set picture_structure on init

2020-04-06 Thread Michael Niedermayer
On Fri, Mar 27, 2020 at 01:57:48PM +0100, Anton Khirnov wrote: > This has been cargo culted from mpegvideo and serves no useful purpose. > It will be initialize correctly in h264_field_start() > --- > libavcodec/h264dec.c | 1 - > 1 file changed, 1 deletion(-) LGTM thx [...] -- Michael Gnu

Re: [FFmpeg-devel] ERROR: avisynth/avisynth_c.h not found

2020-04-06 Thread Helmut K. C. Tessarek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 2020-04-05 20:02, Marton Balint wrote: > The headers got removed because the ffmpeg source tree is no place for > third party library headers. I get that and it makes sense. > Yes, avisynth was an exception, not anymore. I also get that, but t

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread Nicolas George
phunkyfish (12020-04-06): > --- > libavformat/rtsp.c | 50 +- > 1 file changed, 41 insertions(+), 9 deletions(-) > > diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c > index cd6fc32a29..2b59a9330d 100644 > --- a/libavformat/rtsp.c > +++ b/libavforma

Re: [FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

2020-04-06 Thread Carl Eugen Hoyos
Am Fr., 21. Dez. 2018 um 19:48 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/photocd.c| 493 +

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread Ross Nicholson
Ok, latest patch uses AVBPrint. Please let me know if my usage is correct, I have not used it before. In the meantime I will get some users to test this. On Mon, 6 Apr 2020 at 20:57, Marton Balint wrote: > > > On Mon, 6 Apr 2020, phunkyfish wrote: > > > --- > > libavformat/rtsp.c | 47 +

Re: [FFmpeg-devel] [PATCH 02/23] lavc/movtextdec: simplify style record walk

2020-04-06 Thread John Stebbins
On Mon, 2020-04-06 at 14:46 -0700, Philip Langdale wrote: > On Mon, 6 Apr 2020 11:51:57 -0600 > John Stebbins wrote: > > > It's not necessary to walk the style record list twice per subtitle > > character. style records are in order and do not overlap. > > --- > > libavcodec/movtextdec.c | 38 +

Re: [FFmpeg-devel] [PATCH 05/23] lavc/movtextdec: only write fontsize, fontID tags if not default

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:52:00 -0600 John Stebbins wrote: > --- > libavcodec/movtextdec.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index a3e37d013d..6c7d93702e 100644 > --- a/libavcodec/movtex

Re: [FFmpeg-devel] [PATCH 04/23] lavc/movtextdec: handle changes to default style flags

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:59 -0600 John Stebbins wrote: > Style flags were only being turned on. If the default was on and > style record turned off, style flag remained on. > --- > libavcodec/movtextdec.c | 24 +++- > 1 file changed, 15 insertions(+), 9 deletions(-) > > dif

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-06 Thread John Stebbins
On Mon, 2020-04-06 at 13:16 -0700, Philip Langdale wrote: > On Mon, 6 Apr 2020 11:51:55 -0600 > John Stebbins wrote: > > > Patch series adds more complete decoding and encoding of color, > > alpha, > > font size, font name, and style tags for movtext. It also fixes a > > number of bugs. > > >

Re: [FFmpeg-devel] [PATCH 03/23] lavc/movtextdec: fix bold, italic, underline flags

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:58 -0600 John Stebbins wrote: > They should be 0 or 1 so that 0 or -1 is written to the ass header > --- > libavcodec/movtextdec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index 47

Re: [FFmpeg-devel] [PATCH 02/23] lavc/movtextdec: simplify style record walk

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:57 -0600 John Stebbins wrote: > It's not necessary to walk the style record list twice per subtitle > character. style records are in order and do not overlap. > --- > libavcodec/movtextdec.c | 38 -- > 1 file changed, 20 insertions(+

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:56 -0600 John Stebbins wrote: > A conversion from rgb to bgr is necessary > --- > libavcodec/movtextdec.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index c38c5edce6..05becaf64

[FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread phunkyfish
--- libavformat/rtsp.c | 50 +- 1 file changed, 41 insertions(+), 9 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..2b59a9330d 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -21,6 +21,7 @@ #include "li

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: fix compilation under soft float MIPS

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 07:29 Uhr schrieb Rosen Penev : > > Place HAVE_MIPSFPU further up so that functions that use floating point > ASM are defined away. Otherwise compilation failures result when soft > float in enabled on the toolchain. Could this fix ticket #7102? If yes, please mention it in

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 23:13 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > Thank you, I had never realized this in all the years I (thought I) had > > to specify --enable-decoder=rawvideo,wrapped_avframe... > > I am not sure exactly what you are saying. I tried to explain t

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > Thank you, I had never realized this in all the years I (thought I) had > to specify --enable-decoder=rawvideo,wrapped_avframe... I am not sure exactly what you are saying. You would need the corresponding encoder, of course, whatever it is. And if it's not the de

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 19:58 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > Is it possible to support both codecs? > > Of course it it possible. And this is exactly the right thing to do > (modulo the question of which raw frame API we keep). > > > Commit 64ceeac2 changed the

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:55 -0600 John Stebbins wrote: > Patch series adds more complete decoding and encoding of color, alpha, > font size, font name, and style tags for movtext. It also fixes a > number of bugs. > Hi John, Thanks for doing all of this! I'll try and take a look at these over

[FFmpeg-devel] [PATCH v13] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-06 Thread gautamramk
From: Gautam Ramakrishnan This patch adds functional changes to support the PPT marker. This patch fixes bug ticket #4610. --- libavcodec/jpeg2000dec.c | 85 ++-- 1 file changed, 74 insertions(+), 11 deletions(-) diff --git a/libavcodec/jpeg2000dec.c b/libavc

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread Marton Balint
On Mon, 6 Apr 2020, phunkyfish wrote: --- libavformat/rtsp.c | 47 ++ 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..0d0bc2be0d 100644 --- a/libavformat/rtsp.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > avdevice/xv and avdevice/opengl are rarely used outside of ffmpeg CLI > invocations, so I don't think it is worth supporting the inferior rawvideo. They are used. > If you feel strongly about this then let's drop rawvideo support after the > API bump. No, let's kee

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Marton Balint
On Mon, 6 Apr 2020, Nicolas George wrote: Marton Balint (12020-04-06): Signed-off-by: Marton Balint --- libavdevice/xv.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) Thanks for working on this. Adding support for the more efficient API is a good idea. On the ot

[FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-06 Thread John Stebbins
The [Script Info] section was skipped if starts with UTF8 BOM --- libavcodec/ass_split.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 67da7c6d84..c2c388d9f0 100644 --- a/libavcodec/ass_split.c +++ b/libavcodec/ass_split.c @@ -376,6 +37

Re: [FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-06 Thread Nicolas George
John Stebbins (12020-04-06): > Oh, whoops, I missed that ass_split gets called for a number of things. > This belongs at the beginning of ff_ass_split() I believe? I think so too. > In the sample I ran into this with, there's a BOM at the beginning of > the mkv private data for the track. I thin

Re: [FFmpeg-devel] [PATCH v13] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-06 Thread Gautam Ramakrishnan
On Mon, Apr 6, 2020 at 5:41 PM Michael Niedermayer wrote: > > On Mon, Apr 06, 2020 at 09:23:26AM +0530, Gautam Ramakrishnan wrote: > > On Mon, Apr 6, 2020 at 1:16 AM Michael Niedermayer > > wrote: > > > > > > On Sun, Apr 05, 2020 at 04:13:28PM +0530, gautamr...@gmail.com wrote: > > > > From: Gaut

Re: [FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-06 Thread John Stebbins
On Mon, 2020-04-06 at 20:08 +0200, Nicolas George wrote: > John Stebbins (12020-04-06): > > The [Script Info] section was skipped if starts with UTF8 BOM > > --- > > libavcodec/ass_split.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/ass_split.c b/libavcodec/ass_sp

Re: [FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-06 Thread Nicolas George
John Stebbins (12020-04-06): > The [Script Info] section was skipped if starts with UTF8 BOM > --- > libavcodec/ass_split.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c > index 67da7c6d84..94c32667af 100644 > --- a/libavcodec/ass_spli

Re: [FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread Nicolas George
John Stebbins (12020-04-06): > A conversion from rgb to bgr is necessary > --- > libavcodec/movtextdec.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c > index c38c5edce6..05becaf64d 100644 > --- a/libavcodec/

Re: [FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread Ross Nicholson
> sdp_length is used uninitialized here it is used uninitialized in the > version that was merged as b71685865fe761925feedda3cd0b288224d9a509. The > newer versions [2], [3] don't exhibit this flaw. > > [3] and [1] also have a flaw in common that [2] and this one are > lacking: The semicolon of the

[FFmpeg-devel] [PATCH 22/23] lavc/movtextenc: add font name handling

2020-04-06 Thread John Stebbins
Initializes the mov text sample description from the ASS header and creates an mov font table from the fonts available in the ASS Styles. --- libavcodec/ass_split.c | 5 + libavcodec/ass_split.h | 8 ++ libavcodec/movtextenc.c | 253 3 files changed,

[FFmpeg-devel] [PATCH 23/23] lavc/movtextenc: add option to scale fontsize with height

2020-04-06 Thread John Stebbins
If the video dimensions are different than the ASS play_res then the font sizes need to be adjusted to get the same apparent render size. --- libavcodec/movtextenc.c | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/libavcodec/movtextenc.c b/libavco

[FFmpeg-devel] [PATCH 21/23] lavc/movtextenc: simplify initialization of new style record

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 2e65489c4d..167dffee6a 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -96,8 +96,7 @@ static void mov_text_cle

[FFmpeg-devel] [PATCH 20/23] lavc/movtextenc: handle cancel overrides callback

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 9e657c9635..2e65489c4d 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -396,9 +396,8 @

[FFmpeg-devel] [PATCH 19/23] lavc/movtextenc: add font size tag handling

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 39 ++- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index e82393dde7..9e657c9635 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -128,7 +128,

[FFmpeg-devel] [PATCH 18/23] lavc/movtextenc: add alpha tag handling

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 090536b887..e82393dde7 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -351,6 +351,26 @@ static vo

[FFmpeg-devel] [PATCH 17/23] lavc/movtextenc: add color tag handling

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 28 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 4e7d55efcb..090536b887 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -121,7 +121,7 @@ static

[FFmpeg-devel] [PATCH 16/23] lavc/movtextenc: init style record from ASS dialog style

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 60 ++--- 1 file changed, 50 insertions(+), 10 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index d389111419..4e7d55efcb 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -39,6 +39

[FFmpeg-devel] [PATCH 14/23] lavc/movtextenc: simplify style record updates

2020-04-06 Thread John Stebbins
Makes style update code easier to extend for style types not yet handled --- libavcodec/movtextenc.c | 131 +++- 1 file changed, 62 insertions(+), 69 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 5e5b786f44..05532cd544 100644

[FFmpeg-devel] [PATCH 15/23] lavc/movtextenc: fix unclosed style records

2020-04-06 Thread John Stebbins
The last record at the end of each dialog was never closed --- libavcodec/movtextenc.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 05532cd544..d389111419 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -30

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > Is it possible to support both codecs? Of course it it possible. And this is exactly the right thing to do (modulo the question of which raw frame API we keep). > Commit 64ceeac2 changed the only supported format for the > null muxer without any version bump. > (

[FFmpeg-devel] [PATCH 13/23] lavc/movtextenc: keep values in native byte order till written

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index 8638e303fe..5e5b786f44 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -68,7 +68,6

[FFmpeg-devel] [PATCH 10/23] lavc/movtextdec: allow setting subtitle frame dimensions

2020-04-06 Thread John Stebbins
Font sizes are relative to the subtitle frame dimensions. If the expected frame dimensions are not known, the font sizes will most likely be incorrect. --- libavcodec/ass.c| 30 +++--- libavcodec/ass.h| 28 libavcodec/movtextdec.

[FFmpeg-devel] [PATCH 11/23] lavc/ass_split: fix parsing utf8 scripts

2020-04-06 Thread John Stebbins
The [Script Info] section was skipped if starts with UTF8 BOM --- libavcodec/ass_split.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/ass_split.c b/libavcodec/ass_split.c index 67da7c6d84..94c32667af 100644 --- a/libavcodec/ass_split.c +++ b/libavcodec/ass_split.c @@ -354,6 +3

[FFmpeg-devel] [PATCH 12/23] lavc/movtextenc: use correct color component order

2020-04-06 Thread John Stebbins
--- libavcodec/movtextenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c index c19ef384bc..8638e303fe 100644 --- a/libavcodec/movtextenc.c +++ b/libavcodec/movtextenc.c @@ -39,6 +39,7 @@ #define HLIT_BOX (1<<1)

[FFmpeg-devel] [PATCH 08/23] lavc/movtextdec: add color and alpha style tags

2020-04-06 Thread John Stebbins
--- libavcodec/movtextdec.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index eb9c7f5755..4d5dcdf5e7 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@ -76,6 +76,8 @@ typedef struct {

[FFmpeg-devel] [PATCH 09/23] lavc/movtextdec: restore active style color after hilite

2020-04-06 Thread John Stebbins
--- libavcodec/movtextdec.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 4d5dcdf5e7..f3a504b47b 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@ -376,6 +376,7 @@ static int text_to_as

[FFmpeg-devel] [PATCH 07/23] lavc/movtextdec: add alpha default to ass header colors

2020-04-06 Thread John Stebbins
--- libavcodec/movtextdec.c| 14 ++ tests/ref/fate/sub-movtext | 2 +- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 2481c71af6..eb9c7f5755 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c

[FFmpeg-devel] [PATCH 06/23] lavc/movtextdec: make sure default font name is set

2020-04-06 Thread John Stebbins
--- libavcodec/movtextdec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 6c7d93702e..2481c71af6 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@ -52,7 +52,7 @@ typedef struct { uint16_t f

[FFmpeg-devel] [PATCH 04/23] lavc/movtextdec: handle changes to default style flags

2020-04-06 Thread John Stebbins
Style flags were only being turned on. If the default was on and style record turned off, style flag remained on. --- libavcodec/movtextdec.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index d6896

[FFmpeg-devel] [PATCH 05/23] lavc/movtextdec: only write fontsize, fontID tags if not default

2020-04-06 Thread John Stebbins
--- libavcodec/movtextdec.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index a3e37d013d..6c7d93702e 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@ -51,8 +51,9 @@ #define RGB_TO_

[FFmpeg-devel] [PATCH 03/23] lavc/movtextdec: fix bold, italic, underline flags

2020-04-06 Thread John Stebbins
They should be 0 or 1 so that 0 or -1 is written to the ass header --- libavcodec/movtextdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index 47a8401119..d6896562c2 100644 --- a/libavcodec/movtextdec.c +++ b/libavco

[FFmpeg-devel] [PATCH 02/23] lavc/movtextdec: simplify style record walk

2020-04-06 Thread John Stebbins
It's not necessary to walk the style record list twice per subtitle character. style records are in order and do not overlap. --- libavcodec/movtextdec.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcod

[FFmpeg-devel] [PATCH 01/23] lavc/movtextdec: fix ass header colors

2020-04-06 Thread John Stebbins
A conversion from rgb to bgr is necessary --- libavcodec/movtextdec.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavcodec/movtextdec.c b/libavcodec/movtextdec.c index c38c5edce6..05becaf64d 100644 --- a/libavcodec/movtextdec.c +++ b/libavcodec/movtextdec.c @@

[FFmpeg-devel] movtext decode/encode improvements

2020-04-06 Thread John Stebbins
Patch series adds more complete decoding and encoding of color, alpha, font size, font name, and style tags for movtext. It also fixes a number of bugs. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-dev

[FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

2020-04-06 Thread John Stebbins
This was inadvertantly removed in 4a9d32baca --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 16a40debc7..eee98fb69c 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4813,6 +4813,11 @@ static int mov_read_trun(MOVC

[FFmpeg-devel] [PATCH] avformat/rtp: Pass sources and block filter addresses via sdp file for rtp

2020-04-06 Thread phunkyfish
--- libavformat/rtsp.c | 47 ++ 1 file changed, 39 insertions(+), 8 deletions(-) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index cd6fc32a29..0d0bc2be0d 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -2447,8 +2447,8 @@ static int

Re: [FFmpeg-devel] [PATCH v7 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Andreas Rheinhardt
Zane van Iperen: > Signed-off-by: Zane van Iperen > --- > Changelog| 1 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/pp_bnk.c | 271 +++ > libavformat/version.h| 2 +- > 5 files changed, 275

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 16:39 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12020-04-06): > > We have done that in the past (for output formats that are not > > testing-only as xv). > > Xv is not testing only. OpenGL even less. This would be > breaking actual features. Is it possible to suppo

[FFmpeg-devel] [PATCH v7 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-06 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. Please CC for review. v7: - Fix empty lines - Use av_malloc_array() instead of av_reallocp_array() - Replace multiple av_freep()'s with a goto - Minor comment cleanups - Ask for a sample if unexpected header v

[FFmpeg-devel] [PATCH v7 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-06 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c |

[FFmpeg-devel] [PATCH v7 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 271 +++ libavformat/version.h| 2 +- 5 files changed, 275 insertions(+), 1 deletion(-) cr

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Carl Eugen Hoyos (12020-04-06): > We have done that in the past (for output formats that are not > testing-only as xv). Xv is not testing only. OpenGL even less. This would be breaking actual features. What formats are you thinking of? Even if we did, it is entirely possible we were wrong then. R

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 14:31 Uhr schrieb Nicolas George : > > Marton Balint (12020-04-06): > > Signed-off-by: Marton Balint > > --- > > libavdevice/xv.c | 15 +-- > > 1 file changed, 5 insertions(+), 10 deletions(-) > > Thanks for working on this. > > Adding support for the more effi

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-06 Thread Paul B Mahol
On 4/6/20, James Almer wrote: > On 4/6/2020 7:01 AM, Paul B Mahol wrote: >> On 3/20/20, Paul B Mahol wrote: >>> Signed-off-by: Paul B Mahol >>> --- >>> configure |1 + >>> libavcodec/Makefile |1 + >>> libavcodec/allcodecs.c |1 + >>> libavcodec/avcodec.h|

Re: [FFmpeg-devel] [PATCH] avcodec: add bink2 video decoder

2020-04-06 Thread James Almer
On 4/6/2020 7:01 AM, Paul B Mahol wrote: > On 3/20/20, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> configure |1 + >> libavcodec/Makefile |1 + >> libavcodec/allcodecs.c |1 + >> libavcodec/avcodec.h|1 + >> libavcodec/bink2.c | 869 +

Re: [FFmpeg-devel] [PATCH] mov: Support fake moov boxes disguised as hoov

2020-04-06 Thread Derek Buitenhuis
On 12/08/2019 20:37, Michael Niedermayer wrote: > probably ok, but same oppinion as you, cleaner solution preferred if anyone > has a cleaner one We're seeing some more of these 'hoov' files show up as more apps misuse iOS APIs, so since this seems to have been OK'd but never pushed, I'll go ahead

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Paul B Mahol
On 4/6/20, Zane van Iperen wrote: > On Mon, 06 Apr 2020 15:00:01 +0200 > "Anton Khirnov" wrote: > >> Quoting Zane van Iperen (2020-03-29 19:18:20) >> > Signed-off-by: Zane van Iperen >> > +static int pp_bnk_read_header(AVFormatContext *s) >> > +{ >> > +int ret; >> > +AVStream *st; >> > +

Re: [FFmpeg-devel] [PATCH v3] avutil/frame: Use av_realloc_array()

2020-04-06 Thread Limin Wang
ping. On Thu, Dec 26, 2019 at 08:33:38AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavutil/frame.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index e403809..2e76

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

2020-04-06 Thread Carl Eugen Hoyos
Am So., 5. Apr. 2020 um 02:05 Uhr schrieb Carl Eugen Hoyos : > > Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos > : > > > > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos > > : > > > > > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > > > > > > > On 4/3/2020

Re: [FFmpeg-devel] [PATCH]lavc/amrwb: Output silence for frames marked as broken

2020-04-06 Thread Carl Eugen Hoyos
Am Mo., 6. Apr. 2020 um 10:42 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-05 17:37:15) > > Am So., 5. Apr. 2020 um 02:01 Uhr schrieb Carl Eugen Hoyos > > : > > > > > Attached patch makes the output of the file in ticket #7113 very > > > similar to the reference decoder. > > >

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Zane van Iperen
On Mon, 06 Apr 2020 15:00:01 +0200 "Anton Khirnov" wrote: > Quoting Zane van Iperen (2020-03-29 19:18:20) > > Signed-off-by: Zane van Iperen > > +static int pp_bnk_read_header(AVFormatContext *s) > > +{ > > +int ret; > > +AVStream *st; > > +AVCodecParameters *par; > > +PPBnkCtx *

Re: [FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-06 Thread Zane van Iperen
On Mon, 6 Apr 2020 15:03:50 +0200 "Andreas Rheinhardt" wrote: > > > > I have a few minor changes but they're just slight comment changes, > > which aren't worth sending as a v7. I can send them as a separate > > patch afterwards. > > > This is not good as this separate patch would essentially j

Re: [FFmpeg-devel] [PATCH 1/2] avformat/oggparsevorbis: Update context on double init

2020-04-06 Thread Michael Niedermayer
On Mon, Apr 06, 2020 at 12:00:21PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-05 00:38:41) > > Fixes: memleak > > Memleak of what/where/why? This is highly non-obvious. yes, i tend to be terse on "security" fixes so as not to provide a "how to exploit" what leaks is the

Re: [FFmpeg-devel] [PATCH 12/20] avformat/matroskaenc: Improve Cues in case of no video

2020-04-06 Thread Andreas Rheinhardt
Jan Chren (rindeal): > On Sun, 5 Apr 2020 at 16:01, Andreas Rheinhardt > wrote: >> >> The Matroska muxer currently only adds CuePoints in three cases: >> a) For video keyframes. b) For the first audio frame in a new Cluster if >> in DASH-mode. c) For subtitles. This means that ordinary Matroska au

Re: [FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-06 Thread Andreas Rheinhardt
Zane van Iperen: > On Sun, 29 Mar 2020 17:18:08 + > "Zane van Iperen" wrote: > >> Adds support for the soundbank files used by the Pro Pinball series >> of games. >> >> Please CC for review. >> >> v6: >> - fix tools/probetest failure >> >> v5: >> - add probe function >> - add flag #defi

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Anton Khirnov
Quoting Zane van Iperen (2020-03-29 19:18:20) > Signed-off-by: Zane van Iperen > +static int pp_bnk_read_header(AVFormatContext *s) > +{ > +int ret; > +AVStream *st; > +AVCodecParameters *par; > +PPBnkCtx *ctx = s->priv_data; > +uint8_t buf[FFMAX(PP_BNK_FILE_HEADER_SIZE, PP_BNK

Re: [FFmpeg-devel] [PATCH 3/3] avformat: deprecate muxing uncoded frames

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > The same goal can be achieved using the WRAPPED_AVFRAME codec with the > existing > API. These two APIs are somewhat redundant, but we need to discuss which one we want to keep. WRAPPED_AVFRAME is nice because it goes through the normal code path, and therefore req

Re: [FFmpeg-devel] [PATCH 2/3] avdevice/opengl: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > Signed-off-by: Marton Balint > --- > libavdevice/opengl_enc.c | 54 > +--- > 1 file changed, 10 insertions(+), 44 deletions(-) Same remark as for xv: adding support for the more efficient API is useful; removing support

Re: [FFmpeg-devel] [PATCH 1/3] avdevice/xv: change codec to wrapped avframe

2020-04-06 Thread Nicolas George
Marton Balint (12020-04-06): > Signed-off-by: Marton Balint > --- > libavdevice/xv.c | 15 +-- > 1 file changed, 5 insertions(+), 10 deletions(-) Thanks for working on this. Adding support for the more efficient API is a good idea. On the other hand, if applications use this device

Re: [FFmpeg-devel] [PATCH v13] libavcodec/jpeg2000dec.c: Add support for PPT marker

2020-04-06 Thread Michael Niedermayer
On Mon, Apr 06, 2020 at 09:23:26AM +0530, Gautam Ramakrishnan wrote: > On Mon, Apr 6, 2020 at 1:16 AM Michael Niedermayer > wrote: > > > > On Sun, Apr 05, 2020 at 04:13:28PM +0530, gautamr...@gmail.com wrote: > > > From: Gautam Ramakrishnan > > > > > > This patch adds functional changes to suppor

Re: [FFmpeg-devel] [PATCH 2/4] decode: make sure ff_get_buffer() cleans the frame on failure

2020-04-06 Thread Michael Niedermayer
On Sun, Apr 05, 2020 at 10:32:39PM +0200, Anton Khirnov wrote: > Merge ff_get_buffer() and get_buffer_internal() to simplify the code. > --- > libavcodec/decode.c | 37 +++-- > 1 file changed, 15 insertions(+), 22 deletions(-) LGTM thx [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 00/10] Patch set for the enhancement of libopenh264 encoder

2020-04-06 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Monday, April 6, 2020 17:00 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 00/10] Patch set for the enhancement > of libopenh264 encoder > > Quoting Linjie Fu (2020-04-05 12:49:38)

[FFmpeg-devel] [PATCH 10/10] lavc/libopenh264enc: replace cabac option with coder

2020-04-06 Thread Linjie Fu
Change the default option to -1 and allow the default cabac to be decided by profile. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc

[FFmpeg-devel] [PATCH 06/10] lavc/libopenh264enc: set slice_mode option to deprecated

2020-04-06 Thread Linjie Fu
"slice mode" seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE mode with limited size slices. This could be r

[FFmpeg-devel] [PATCH 07/10] lavc/libopenh264enc: separate svc_encode_init() into several functions

2020-04-06 Thread Linjie Fu
Separate the initialization procedure into different functions. Make it more readable and easier to be extended. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 283 +++- 1 file changed, 174 insertions(+), 109 deletions(-) diff --git a/libavco

[FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

2020-04-06 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index c7ae5b1..3ff5be7 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -335,6 +335,8 @@ static int

[FFmpeg-devel] [PATCH 09/10] lavc/libopenh264enc: allow specifying the profile through AVCodecContext

2020-04-06 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index d331cfd..70ded55 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -111,6 +111

  1   2   >