Re: [FFmpeg-devel] [PATCH] web/download: update min. kernel version for linux binaries

2020-03-19 Thread Lou Logan
On Thu, Mar 19, 2020, at 3:07 PM, Carl Eugen Hoyos wrote: > > How good to know that all comments are taken seriously on this > mailing list. Gyan took the initiative to update the description with a trivial, very minor, insignificant patch. It was a simple improvement and seemed fine to me. If it

[FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-19 Thread Steven Liu
These member will be used for get more correct information of the MPD Suggested-by: Andreas Rheinhardt Suggested-by: Nicolas George Signed-off-by: Steven Liu --- libavformat/dashdec.c | 180 +++--- 1 file changed, 151 insertions(+), 29 deletions(-) diff --g

Re: [FFmpeg-devel] [PATCH 1/3] lavformat: Prepare to make avio_enum_protocols const correct

2020-03-19 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Wednesday, March 18, 2020 21:29 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavformat: Prepare to make > avio_enum_protocols const correct > > Fu, Linjie: > Yes, updating the callers is necessary (as I alre

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Fu, Linjie
> From: Ronald S. Bultje > Sent: Thursday, March 19, 2020 20:10 > To: FFmpeg development discussions and patches > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame > dimensions check for SINGLE_REFERENCE mode > > Hi, > > On Tue, Mar 17, 2020 at 10:59 AM Lin

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Friday, March 20, 2020 00:47 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame > dimensions check for SINGLE_REFERENCE mode > > Am Do., 19. März 2

Re: [FFmpeg-devel] [PATCH] lavf/mux: bypass interleave delay early when waiting on subtitle streams

2020-03-19 Thread rcombs
> On Mar 12, 2020, at 02:51, Andreas Rheinhardt > wrote: > > rcombs: >> This avoids long delays when converting live streams that have sparse >> subtitles >> --- >> libavformat/avformat.h | 9 + >> libavformat/mux.c | 25 + >> libavformat/options_

Re: [FFmpeg-devel] [PATCH]lavf/subviewerdec: Support higher sub-second precision

2020-03-19 Thread Michael Niedermayer
On Thu, Mar 19, 2020 at 10:18:33PM +0100, Carl Eugen Hoyos wrote: > Am Do., 19. März 2020 um 19:32 Uhr schrieb Michael Niedermayer > : > > > > On Wed, Mar 18, 2020 at 02:16:30AM +0100, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes ticket #8575 for me, Google describes such file

[FFmpeg-devel] [PATCH 2/2] avcodec/wavpack: Prevent frame format from being wrong

2020-03-19 Thread Michael Niedermayer
Fixes: out of array access Fixes: 21193/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVPACK_fuzzer-5125168956702720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 1 + 1 fil

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_jpeg: Fix infinite loop in cbs_jpeg_split_fragment()

2020-03-19 Thread Michael Niedermayer
Fixes: Timeout Fixes: 21104/clusterfuzz-testcase-minimized-ffmpeg_BSF_TRACE_HEADERS_fuzzer-5129580475318272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_jpeg.c | 5 ++--- 1 file changed

Re: [FFmpeg-devel] [PATCH] web/download: update min. kernel version for linux binaries

2020-03-19 Thread Carl Eugen Hoyos
Am Do., 19. März 2020 um 20:00 Uhr schrieb Lou Logan : > > On Wed, Mar 18, 2020, at 10:39 PM, Lou Logan wrote: > > Sure, I’ll be able push it in about 12 hours or so. > > Pushed How good to know that all comments are taken seriously on this mailing list. Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]lavf/subviewerdec: Support higher sub-second precision

2020-03-19 Thread Carl Eugen Hoyos
Am Do., 19. März 2020 um 19:32 Uhr schrieb Michael Niedermayer : > > On Wed, Mar 18, 2020 at 02:16:30AM +0100, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #8575 for me, Google describes such files. > > > > Please comment, Carl Eugen > > > subviewerdec.c | 10 +++--- >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Fix [u]int64_t specifier string

2020-03-19 Thread Marton Balint
On Wed, 18 Mar 2020, Anton Khirnov wrote: Quoting Andreas Rheinhardt (2020-03-18 03:56:18) PRId64 and PRIu64 already expand to the complete specifier; adding another 'd' at the end is wrong and just leads to warnings that say that only an option like '-frames:v 2d' will be used, although said

Re: [FFmpeg-devel] [PATCH] doc/general: Fix entry for AMQP

2020-03-19 Thread Marton Balint
On Thu, 19 Mar 2020, Andriy Gelman wrote: From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/general.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/general.texi b/doc/general.texi index 14878f4dcf3..752618a00b4 100644 --- a/doc/general.texi +++ b/doc/gener

Re: [FFmpeg-devel] [PATCH] web/download: update min. kernel version for linux binaries

2020-03-19 Thread Lou Logan
On Wed, Mar 18, 2020, at 10:39 PM, Lou Logan wrote: > Sure, I’ll be able push it in about 12 hours or so. Pushed ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH]lavf/subviewerdec: Support higher sub-second precision

2020-03-19 Thread Michael Niedermayer
On Wed, Mar 18, 2020 at 02:16:30AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #8575 for me, Google describes such files. > > Please comment, Carl Eugen > subviewerdec.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > 1a6133ed3dbb66945d6bf16e212c0

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Timo Rothenpieler
On 19.03.2020 15:59, Yaroslav Pogrebnyak wrote: Got it, thanks! I'll re-do it and submit updated patch soon. I'm looking into adding hardware-frame support to make_writable, so modifications might not be needed. ___ ffmpeg-devel mailing list ffmpe

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Carl Eugen Hoyos
Am Do., 19. März 2020 um 16:12 Uhr schrieb Fu, Linjie : > > > From: ffmpeg-devel On Behalf Of > > Carl Eugen Hoyos > > Sent: Thursday, March 19, 2020 22:13 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference fr

Re: [FFmpeg-devel] [PATCH] doc/general: Fix entry for AMQP

2020-03-19 Thread Paul B Mahol
LGTM On 3/19/20, Andriy Gelman wrote: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > doc/general.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/general.texi b/doc/general.texi > index 14878f4dcf3..752618a00b4 100644 > --- a/doc/general.texi >

Re: [FFmpeg-devel] [PATCH] avformat/avformat: Remove redundant "NOT PART OF PUBLIC API"

2020-03-19 Thread Derek Buitenhuis
On 18/03/2020 14:31, Andreas Rheinhardt wrote: > I initially also wanted to remove the internal note for AVStream's private > fields ("be aware that physically removing these fields will break > ABI"), but then I became aware that ffmpeg.c uses several of them > (pts_wrap_bits, first_dts, cur_dts,

Re: [FFmpeg-devel] [PATCH v2 1/2] avutil/hwcontext_cuda: add YUVA420P pixel format

2020-03-19 Thread Timo Rothenpieler
applied ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/2] avformat/yuv4mpegdec: add support for 444alpha

2020-03-19 Thread Jan Ekström
On Thu, Mar 19, 2020 at 12:19 PM Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > --- > libavformat/yuv4mpegdec.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c > index addc03057e..980de7d145 100644 > --- a/l

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Thursday, March 19, 2020 22:13 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame > dimensions check for SINGLE_REFERENCE mode > > Am Do., 19. März

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Yaroslav Pogrebnyak
On 19.03.20 22:41, Timo Rothenpieler wrote: h264_cuvid copies frames back to normal VRAM, and does not pass around mapped nvdec surfaces, like nvdec does. Writing around in these is documented as disallowed. You can call av_frame_is_writable() on the frame. If it returns true, it's safe to wr

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Timo Rothenpieler
On 19.03.2020 15:11, Yaroslav Pogrebnyak wrote: On 19.03.20 21:40, Timo Rothenpieler wrote: For what I'm aware, make_writable does not work on hardware frames. And the nvdec hwaccel returns frames that are mapped device memory, and thus hard read-only. You will need to manually allocate outp

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Carl Eugen Hoyos
Am Do., 19. März 2020 um 14:45 Uhr schrieb Fu, Linjie : > This fix [v4] intended to report errors and exit decode_frame() for the exact > frame witch has > invalid mvscale factors used, and didn't mean to break the decoding for > subsequent frames if > they could be decoded correctly. How does

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Yaroslav Pogrebnyak
On 19.03.20 21:40, Timo Rothenpieler wrote: For what I'm aware, make_writable does not work on hardware frames. And the nvdec hwaccel returns frames that are mapped device memory, and thus hard read-only. You will need to manually allocate output frames from the hw_frames_ctx. Yes I see. So

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Fu, Linjie
Hi Carl, > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Thursday, March 19, 2020 21:04 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame > dimensions check for SINGLE_REFERENCE mode > > > > >

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Timo Rothenpieler
On 19.03.2020 14:35, Yaroslav Pogrebnyak wrote: Oh, I didn't noticed that h264_cuvid is legacy. It seems the problem in this line: ret = av_frame_make_writable(input_main); If removed, it starts to work with -hwaccel cuda. I'll take a closed look why and what happens but any advice would be

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Yaroslav Pogrebnyak
Oh, I didn't noticed that h264_cuvid is legacy. It seems the problem in this line: ret = av_frame_make_writable(input_main); If removed, it starts to work with -hwaccel cuda. I'll take a closed look why and what happens but any advice would be helpful. Thanks! On 19.03.20 21:15, Timo Rothe

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter: add vf_overlay_cuda

2020-03-19 Thread Timo Rothenpieler
I'm currently trying to get this to work with nvdec, but seemingly can't: ./ffmpeg_g.exe -v verbose -hwaccel_output_format cuda -hwaccel cuda -i test_h264.mp4 -hwaccel_output_format cuda -hwaccel cuda -i test2_h264.mp4 -filter_complex "[0:v]scale_cuda=640:-2[p],[1:v][p]overlay_cuda=x=100:y=100:

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Carl Eugen Hoyos
> Am 19.03.2020 um 13:10 schrieb Ronald S. Bultje : > > Hi, > >> On Tue, Mar 17, 2020 at 10:59 AM Linjie Fu wrote: >> >> With the description in frame size with refs semantics (SPEC 7.2.5), >> it is a requirement of bitstream conformance that for at least one >> reference frame has the valid

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Ronald S. Bultje
Hi, On Tue, Mar 17, 2020 at 10:59 AM Linjie Fu wrote: > With the description in frame size with refs semantics (SPEC 7.2.5), > it is a requirement of bitstream conformance that for at least one > reference frame has the valid dimensions. > > Modify the check to make sure the decoder works well i

[FFmpeg-devel] [PATCH] doc/general: Fix entry for AMQP

2020-03-19 Thread Andriy Gelman
From: Andriy Gelman Signed-off-by: Andriy Gelman --- doc/general.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/general.texi b/doc/general.texi index 14878f4dcf3..752618a00b4 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -1336,7 +1336,7 @@ performance on

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-19 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c |

[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-19 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 229 +++ libavformat/version.h| 2 +- 5 files changed, 233 insertions(+), 1 deletion(-) cr

[FFmpeg-devel] [PATCH v3 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-19 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. Please ping for review. v3: - fix potential memory leak if read_header() fails - fix a buffer overread - attempt seek before updating state - remove unneeded check - naming fixes v2: - Add sanity checks in

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-19 Thread Zane van Iperen
On Wed, 18 Mar 2020 16:05:40 +0100 "Andreas Rheinhardt" wrote: > > + > > +typedef struct PPBnkCtx { > > +int track_count; > > +PPBnkCtxTrack *tracks; > > +uint32_ti; > > How about using a more descriptive name for this like current_track? > Done. > > + > >

[FFmpeg-devel] [PATCH 1/2] avformat/yuv4mpegdec: use proper error codes

2020-03-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/yuv4mpegdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c index a11567e5ca..addc03057e 100644 --- a/libavformat/yuv4mpegdec.c +++ b/libavformat/yuv4mpegdec.c @@ -142,7 +14

[FFmpeg-devel] [PATCH 2/2] avformat/yuv4mpegdec: add support for 444alpha

2020-03-19 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/yuv4mpegdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c index addc03057e..980de7d145 100644 --- a/libavformat/yuv4mpegdec.c +++ b/libavformat/yuv4mpegdec.c @@ -124,9 +124

Re: [FFmpeg-devel] [PATCH v4 1/2] avformat: Add AMQP version 0-9-1 protocol support

2020-03-19 Thread Paul B Mahol
On 3/8/20, Andriy Gelman wrote: > From: Andriy Gelman > > Supports connecting to a RabbitMQ broker via AMQP version 0-9-1. > > Signed-off-by: Andriy Gelman > --- > > Changes in v4: > - Fixed leak from user_decoded/password_decoded when > amqp_new_connection() > fails > > Changes in v3: