Hello,
March 15, 2020 2:15 AM, "Jai Luthra" wrote:
>On Fri, Mar 06, 2020 at 06:10:04PM +, Anamitra Ghorui wrote:
>>The parser has been tested and is able to correctly identify the start
>>of the compressed bitstream. The patch has a set of printf statements
>>which print a "tracing table" of
On 15-03-2020 12:47 am, Lou Logan wrote:
On Fri, Mar 13, 2020, at 10:23 PM, Gyan Doshi wrote:
Do you mind if I continue with my own patch? I started reviewing this
and noticed that many of the option description should have caveats
since they can be silently (i.e. unlogged) modified based on o
On Fri, Mar 13, 2020 at 11:28:41AM +0100, Anton Khirnov wrote:
> It is very fragile against fields being moved and hides what is actually
> being copied. Copy all the fields explicitly instead.
> ---
> libavcodec/vp3.c | 12 +---
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff
On Sat, 14 Mar 2020, Tomas Härdin wrote:
tor 2020-03-12 klockan 22:21 +0100 skrev Marton Balint:
On Sat, 7 Mar 2020, Tomas Härdin wrote:
> tor 2020-03-05 klockan 22:56 +0100 skrev Marton Balint:
> > There was no consensus wheter or not to allow unofficial frame rates due to
> > possible int
On Thu, Dec 26, 2019 at 11:53:28AM +0100, Andreas Rheinhardt wrote:
> If an AVFormatContext could be allocated, but white-/blacklists couldn't
> be copied, the AVFormatContext would leak as it was only accessible
> through a local variable that goes out of scope when one goes to fail.
>
> Furtherm
On Sun, Jan 26, 2020 at 06:10:27AM +0100, Andreas Rheinhardt wrote:
> Don't read a 64bit number before having checked that the data is at
> least 8 bytes long.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/matroskaenc.c | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(
On Sat, Mar 14, 2020 at 05:32:17PM +0100, Andreas Rheinhardt wrote:
> Should writing the header fail, the allocations already performed will
> be freed during deinit so remove the frees in nut_write_header().
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/nutenc.c | 6 +-
> 1 file
On Sat, Mar 14, 2020 at 06:08:45PM +0100, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/avienc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Man
Hi Anamitra,
Good progres on the parser, I tested it on the samples you provided, lgtm.
Comments inline.
On Fri, Mar 06, 2020 at 06:10:04PM +, Anamitra Ghorui wrote:
The parser has been tested and is able to correctly identify the start
of the compressed bitstream. The patch has a set of
On Fri, Mar 13, 2020, at 10:23 PM, Gyan Doshi wrote:
>
> Do you mind if I continue with my own patch? I started reviewing this
> and noticed that many of the option description should have caveats
> since they can be silently (i.e. unlogged) modified based on other
> options. I think it's best f
Andreas Rheinhardt:
> On Sun, Jan 19, 2020 at 3:44 PM Andreas Rheinhardt <
> andreas.rheinha...@gmail.com> wrote:
>
>> Michael Niedermayer:
>>> On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote:
vobsub_read_packet() didn't check whether an index in array of AVPackets
was
On Sat, Mar 14, 2020 at 11:21:51AM +0100, Tomas Härdin wrote:
> fre 2020-03-13 klockan 11:18 +0100 skrev Andreas Rheinhardt:
> > Signed-off-by: Andreas Rheinhardt
> > ---
> > libavformat/mxfenc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/mxfenc.c
On Fri, Mar 13, 2020 at 02:06:01PM +0100, Andreas Rheinhardt wrote:
> as well as includes of libavutil/timer.h.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/cabac.c | 1 -
> libavcodec/dnxhddec.c | 3 --
> libavcodec/dnxhdenc.c | 4 +-
> l
On Thu, Mar 12, 2020 at 06:54:07PM +0100, Andreas Rheinhardt wrote:
> If writing a packet didn't directly return an error, the AVIOContext's
> error flag is checked for errors (if existing) by write_packet(). And if
> write_packet() didn't indicate an error, its callers checked the error
> flag of
Signed-off-by: Andreas Rheinhardt
---
libavformat/avienc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/avienc.c b/libavformat/avienc.c
index 07e1c3319e..297d5b8964 100644
--- a/libavformat/avienc.c
+++ b/libavformat/avienc.c
@@ -268,8 +268,8 @@ static int a
On Sat, 14 Mar 2020, Tomas Härdin wrote:
fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint:
The packet durations might not be set properly which can cause the MXF muxer
to write more than one packet of a stream to an edit unit messing up the
constant byte per element index...
Shouldn't
Should writing the header fail, the allocations already performed will
be freed during deinit so remove the frees in nut_write_header().
Signed-off-by: Andreas Rheinhardt
---
libavformat/nutenc.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/libavformat/nutenc.c b/liba
Reviewed-by: Carl Eugen Hoyos
Signed-off-by: numberwolf
---
libavcodec/mpegutils.c | 4 ++--
libavcodec/mpegutils.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c
index c0ee3aa..819293c 100644
--- a/libavcodec/mpegutils.c
+
Signed-off-by: numberwolf
---
libavcodec/mpegutils.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c
index c0ee3aa..148d3e7 100644
--- a/libavcodec/mpegutils.c
+++ b/libavcodec/mpegutils.c
@@ -34,6 +34,12 @@ static int
Am Fr., 13. März 2020 um 00:54 Uhr schrieb Carl Eugen Hoyos
:
> Attached patch fixes ticket #8568 for me.
Patch applied.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe,
On Sun, 23. Feb 13:47, Andriy Gelman wrote:
> From: Andriy Gelman
>
> Currently the user gets unhelpful warnings when some default parameters
> are not supported by the device. The verbosity of these log messages has
> been changed to AV_LOG_DEBUG.
>
> Signed-off-by: Andriy Gelman
> ---
> liba
Am Sa., 14. März 2020 um 14:24 Uhr schrieb Gyan Doshi :
>
>
>
> On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote:
> > Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi :
> >>
> >>
> >> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote:
> >>> Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi :
>
On 14-03-2020 06:11 pm, Carl Eugen Hoyos wrote:
Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi :
On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote:
Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi :
As per https://johnvansickle.com/ffmpeg/
---
src/download | 2 +-
1 file chan
Am Sa., 14. März 2020 um 12:58 Uhr schrieb Paul B Mahol :
>
> On 3/14/20, Carl Eugen Hoyos wrote:
> > Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov
> > :
> >>
> >> This is extremely fragile against reordering and hides what is actually
> >> being copied. Copy all the fields manually ins
Am Sa., 14. März 2020 um 13:19 Uhr schrieb Gyan Doshi :
>
>
>
> On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote:
> > Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi :
> >> As per https://johnvansickle.com/ffmpeg/
> >> ---
> >> src/download | 2 +-
> >> 1 file changed, 1 insertion(+), 1 dele
On 3/14/20, Andreas Rheinhardt wrote:
> Paul B Mahol:
>> Signed-off-by: Paul B Mahol
>> ---
>> libavformat/Makefile | 1 +
>> libavformat/allformats.c | 1 +
>> libavformat/fwse.c | 88
>> 3 files changed, 90 insertions(+)
>> create mode 1006
On 14-03-2020 04:29 pm, Carl Eugen Hoyos wrote:
Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi :
As per https://johnvansickle.com/ffmpeg/
---
src/download | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/download b/src/download
index 6292a7e..d9155ee 100644
---
Paul B Mahol:
> Signed-off-by: Paul B Mahol
> ---
> libavformat/Makefile | 1 +
> libavformat/allformats.c | 1 +
> libavformat/fwse.c | 88
> 3 files changed, 90 insertions(+)
> create mode 100644 libavformat/fwse.c
>
> diff --git a/libavfor
Audio tones source filter to generate random audio tones using fluidsynth
diff --git a/Makefile b/Makefile
index 45a22b0cb3..44cf1b5710 100644
--- a/Makefile
+++ b/Makefile
@@ -111,7 +111,7 @@ else
endif
%$(PROGSSUF)_g$(EXESUF): $(FF_DEP_LIBS)
- $(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(O
On 3/14/20, Carl Eugen Hoyos wrote:
> Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov
> :
>>
>> This is extremely fragile against reordering and hides what is actually
>> being copied. Copy all the fields manually instead.
>> ---
>> libavcodec/mpeg4videodec.c | 27 +++
Signed-off-by: Paul B Mahol
---
libavcodec/Makefile | 1 +
libavcodec/adpcm.c | 33 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 7 +++
5 files changed, 43 insertions(+)
diff --git a/libavcodec/Makefile
Signed-off-by: Paul B Mahol
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/fwse.c | 88
3 files changed, 90 insertions(+)
create mode 100644 libavformat/fwse.c
diff --git a/libavformat/Makefile b/libavformat/Makef
Suggested-by: Carl Eugen Hoyos
Reviewed-by: Lou Logan
Signed-off-by: Steven Liu
---
generate-doc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generate-doc.sh b/generate-doc.sh
index d8d01d3..45a9901 100755
--- a/generate-doc.sh
+++ b/generate-doc.sh
@@ -34,7 +34,7 @@ e
Am Sa., 14. März 2020 um 10:57 Uhr schrieb numberwolf :
>
> ---
> libavcodec/mpegutils.c | 4 ++--
> libavcodec/mpegutils.h | 3 +++
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c
> index c0ee3aa..819293c 100644
> --- a/libavcode
> 2020年3月14日 下午6:58，Carl Eugen Hoyos 写道：
>
> Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu :
>>
>> Reviewed-by: Lou Logan
>> Signed-off-by: Steven Liu
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/generate-doc.sh b/generate-doc.
> 2020年3月14日 下午6:58，Carl Eugen Hoyos 写道：
>
> Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu :
>>
>> Reviewed-by: Lou Logan
>> Signed-off-by: Steven Liu
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/generate-doc.sh b/generate-doc.
Am Fr., 13. März 2020 um 11:30 Uhr schrieb Anton Khirnov :
>
> This is extremely fragile against reordering and hides what is actually
> being copied. Copy all the fields manually instead.
> ---
> libavcodec/mpeg4videodec.c | 27 ++-
> 1 file changed, 26 insertions(+), 1 de
Am Sa., 14. März 2020 um 07:31 Uhr schrieb Gyan Doshi :
>
> As per https://johnvansickle.com/ffmpeg/
> ---
> src/download | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/download b/src/download
> index 6292a7e..d9155ee 100644
> --- a/src/download
> +++ b/src/download
>
Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu :
>
> Reviewed-by: Lou Logan
> Signed-off-by: Steven Liu
> ---
> generate-doc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/generate-doc.sh b/generate-doc.sh
> index d8d01d3..2da5e64 100755
> --- a/generate-doc.s
Please follow coding style from http://ffmpeg.org/developer.html
Otherwise patch looks fine.
Could you make note on/off switching not depend on number of output
samples per frame?
On 3/14/20, Marshall Murmu wrote:
> Author:Marshall Murmu
>
>
> ---
> Changelog| 1 +
> con
Author:Marshall Murmu
---
Changelog| 1 +
configure| 4 +
doc/filters.texi | 29 +++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/asrc_atone.c | 172 +++
libavfilter/vers
fre 2020-03-13 klockan 02:31 +0100 skrev Marton Balint:
> The packet durations might not be set properly which can cause the MXF muxer
> to write more than one packet of a stream to an edit unit messing up the
> constant byte per element index...
Shouldn't this be fixed "higher up"?
> Also warn t
fre 2020-03-13 klockan 11:18 +0100 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index 5e0dc0e889..55c715d776 100644
> --- a/libavfo
tor 2020-03-12 klockan 22:21 +0100 skrev Marton Balint:
>
> On Sat, 7 Mar 2020, Tomas Härdin wrote:
>
> > tor 2020-03-05 klockan 22:56 +0100 skrev Marton Balint:
> > > There was no consensus wheter or not to allow unofficial frame rates due
> > > to
> > > possible interoperability issues, a comp
---
libavcodec/mpegutils.c | 4 ++--
libavcodec/mpegutils.h | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c
index c0ee3aa..819293c 100644
--- a/libavcodec/mpegutils.c
+++ b/libavcodec/mpegutils.c
@@ -34,8 +34,8 @@ static int a
Reviewed-by: Lou Logan
Signed-off-by: Steven Liu
---
generate-doc.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/generate-doc.sh b/generate-doc.sh
index d8d01d3..2da5e64 100755
--- a/generate-doc.sh
+++ b/generate-doc.sh
@@ -34,7 +34,7 @@ export FA_ICONS=true
rm -rf bu
> 2020年3月14日 下午3:08，Hendrik Leppkes 写道：
>
> On Sat, Mar 14, 2020 at 2:37 AM Steven Liu wrote:
>>
>> Reviewed-by: Lou Logan
>> Signed-off-by: Steven Liu
>> ---
>> generate-doc.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/generate-doc.sh b/generate-doc.sh
>>
On Sat, Mar 14, 2020 at 2:37 AM Steven Liu wrote:
>
> Reviewed-by: Lou Logan
> Signed-off-by: Steven Liu
> ---
> generate-doc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/generate-doc.sh b/generate-doc.sh
> index d8d01d3..e316c05 100755
> --- a/generate-doc.sh
> +
48 matches
Mail list logo
