Re: [FFmpeg-devel] [PATCH V1 1/3] lavf/dashenc: add 3GPP TS26.247 probe in dash demuxer

2020-03-01 Thread myp...@gmail.com
On Mon, Mar 2, 2020 at 11:54 AM Jeyapal, Karthick wrote: > > > On 3/1/20 6:08 PM, Jun Zhao wrote: > > From: Jun Zhao > > > > Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile > > to dash demuxer probe. > > > > Signed-off-by: Jun Zhao > > --- > > libavformat/dashdec.c |4 +++-

Re: [FFmpeg-devel] [PATCH 4/17] avformat/segment: Don't set extradata size twice

2020-03-01 Thread Gyan Doshi
On 02-03-2020 10:05 am, Andreas Rheinhardt wrote: ff_alloc_extradata() already sets the size of the extradata so doing it again is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavformat/segment.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat

[FFmpeg-devel] [PATCH 4/17] avformat/segment: Don't set extradata size twice

2020-03-01 Thread Andreas Rheinhardt
ff_alloc_extradata() already sets the size of the extradata so doing it again is unnecessary. Signed-off-by: Andreas Rheinhardt --- libavformat/segment.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 5f7fe76600..d565183349 100644 --- a/lib

[FFmpeg-devel] [PATCH 12/17] avformat/webm_chunk: Don't copy header filename

2020-03-01 Thread Andreas Rheinhardt
Instead just reuse the filename string that is given via an option for the child muxer's url field. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/libavformat/webm_chunk.c b/l

[FFmpeg-devel] [PATCH 11/17] avformat/webm_chunk: Don't keep pointer to AVOutputFormat

2020-03-01 Thread Andreas Rheinhardt
It is no longer needed given that the function pointers of the child muxer's AVOutputFormat are no longer called directly. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/webm_chunk.c b/lib

[FFmpeg-devel] [PATCH 13/17] avformat/webm_chunk: Remove unnecessary variable

2020-03-01 Thread Andreas Rheinhardt
chunk_start_index (which was set via an option) was only used to initialize chunk_index and otherwise unused. So initialize chunk_index directly via the option and remove chunk_start_index. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 4 +--- 1 file changed, 1 insertion(+), 3

[FFmpeg-devel] [PATCH 14/17] avformat/webm_chunk: Add init function

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 8abfc2870b..efdce62391 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_ch

[FFmpeg-devel] [PATCH 17/17] avformat/webm_chunk: Cosmetics

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 8f1f884c98..d173a4a5ce 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @

[FFmpeg-devel] [PATCH 09/17] avformat/webm_chunk: Use API functions for child muxer

2020-03-01 Thread Andreas Rheinhardt
instead of calling the write_header/packet/trailer functions directly via the function pointers. Also, use distinct AVStreams for the child AVFormatContext (up until now the two AVFormatContexts shared their AVStreams because allocating their own was deemed too onerous). Using the function pointer

[FFmpeg-devel] [PATCH 10/17] avformat/webm_chunk: Avoid unnecessary flushes

2020-03-01 Thread Andreas Rheinhardt
The webm_chunk muxer caches its output to a dynamic buffer and when it outputs anything, it explicitly flushes it. So set the flags indicating that flushing after each packet should not be done automatically (basically avoiding avio_write_marker() to be called by flush_if_needed() in libavformat/mu

[FFmpeg-devel] [PATCH 16/17] avformat/webm_chunk: Check unchecked functions for errors

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 24 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 6ffe952eff..8f1f884c98 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/web

[FFmpeg-devel] [PATCH 07/17] avformat/webm_chunk: Copy more information to the child AVFormatContext

2020-03-01 Thread Andreas Rheinhardt
In particular the flags are important so that AVFMT_FLAG_BITEXACT can be honoured by the child muxer. Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index d42f46aab2..63c00d

[FFmpeg-devel] [PATCH 15/17] avformat/webm_chunk: Add deinit function

2020-03-01 Thread Andreas Rheinhardt
This fixes memleaks if an error happens after one of the allocations in init; or if the trailer isn't written (e.g. because there was an error when writing a packet). Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 20 +++- 1 file changed, 15 insertions(+), 5 del

[FFmpeg-devel] [PATCH 06/17] avformat/webm_chunk: Close IO if writing header fails

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 0d4e3598ed..d42f46aab2 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@ -150,9 +150,9

[FFmpeg-devel] [PATCH 08/17] avformat/webm_chunk: Use appropriate initializer for AV_OPT_TYPE_STRING

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 63c00d22e4..08d825449e 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@ -267,7 +267,7

[FFmpeg-devel] [PATCH 05/17] avformat/webm_chunk: Don't use child AVFormatContext for logging

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/webm_chunk.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index bc3d346a00..0d4e3598ed 100644 --- a/libavformat/webm_chunk.c +++ b/libavformat/webm_chunk.c @@ -87,25

[FFmpeg-devel] [PATCH 2/17] avformat/hlsenc: Remove redundant setting of output format

2020-03-01 Thread Andreas Rheinhardt
avformat_alloc_output_context2() already sets the oformat member, so that there is no reason to overwrite it again with the value it already has. Signed-off-by: Andreas Rheinhardt --- libavformat/hlsenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hls

[FFmpeg-devel] [PATCH 3/17] avformat/avformat: Allow const AVOutputFormat where possible

2020-03-01 Thread Andreas Rheinhardt
9461e4bc made preparations to constify the various AVOutputFormat pointers because the underlying AVOutputFormats should not be changed. To do this, a preprocessor directive (ff_const59) is used that will add const to certain AVOutputFormat * after the next major version bump. This approach has th

[FFmpeg-devel] [PATCH 1/17] avformat: Use correct error in case muxer is not found

2020-03-01 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/mpegtsenc.c | 2 +- libavformat/mux.c | 4 ++-- libavformat/rtpenc_chain.c | 2 +- libavformat/rtpenc_mpegts.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c

Re: [FFmpeg-devel] [PATCH V1 1/3] lavf/dashenc: add 3GPP TS26.247 probe in dash demuxer

2020-03-01 Thread Jeyapal, Karthick
On 3/1/20 6:08 PM, Jun Zhao wrote: > From: Jun Zhao > > Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile > to dash demuxer probe. > > Signed-off-by: Jun Zhao > --- > libavformat/dashdec.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/libavforma

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the core encoding code

2020-03-01 Thread James Almer
On 3/1/2020 2:36 AM, Andriy Gelman wrote: > On Thu, 27. Feb 15:02, James Almer wrote: >> This commit follows the same logic as 061a0c14bb, but for the encode API: The >> new public encoding API will no longer be a wrapper around the old deprecated >> one, and the internal API used by the encoders n

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: Fix invalid shift in AV_CODEC_ID_ADPCM_PSX

2020-03-01 Thread Michael Niedermayer
Fixes: left shift of negative value -1 Fixes: 20859/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_PSX_fuzzer-5720391507247104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adpcm.c

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Clip step index for ADPCM_IMA_APM

2020-03-01 Thread Michael Niedermayer
Fixes: out of array access Fixes: 20828/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_APM_fuzzer-5712770106654720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adpcm.c | 4 ++--

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mpeg: Don't use unintialized value

2020-03-01 Thread Andreas Rheinhardt
On Sun, Jan 19, 2020 at 3:44 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Michael Niedermayer: > > On Tue, Oct 22, 2019 at 03:16:45PM +0200, Andreas Rheinhardt wrote: > >> vobsub_read_packet() didn't check whether an index in array of AVPackets > >> was valid and therefore used u

Re: [FFmpeg-devel] [PATCH V2] [RFC] GSoC: FLIF16 Image format parser

2020-03-01 Thread Nicolas George
Anamitra Ghorui (12020-03-01): > Hello, > The parser can now deduce the structure of the format upto the point where the > compressed bitstream actually starts. It also includes functions for handling > the variable integers (varints). The parsing code has not been tested yet and > I'll be doing th

[FFmpeg-devel] [PATCH V2] [RFC] GSoC: FLIF16 Image format parser

2020-03-01 Thread Anamitra Ghorui
Hello, The parser can now deduce the structure of the format upto the point where the compressed bitstream actually starts. It also includes functions for handling the variable integers (varints). The parsing code has not been tested yet and I'll be doing that later. I am posting this now just to v

[FFmpeg-devel] [PATCH V1 3/3] doc/filters: add missed framesync part in filter docs

2020-03-01 Thread Jun Zhao
From: Jun Zhao Add missed framesync part in filter docs. Signed-off-by: Jun Zhao --- doc/filters.texi |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 1453ecd..73f9f0a 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@

[FFmpeg-devel] [PATCH V1 2/3] lavf/dashdec: Add ts to the list of allowed extensions.

2020-03-01 Thread Jun Zhao
From: Jun Zhao Dashdec can able to handle MPEG-2 TS streams by default as well, used MP4Box to create the segmented MPEG-2 TS files for verification. Signed-off-by: Jun Zhao --- libavformat/dashdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavformat/dashdec.

[FFmpeg-devel] [PATCH V1 1/3] lavf/dashenc: add 3GPP TS26.247 probe in dash demuxer

2020-03-01 Thread Jun Zhao
From: Jun Zhao Enabled the 3GP-DASH Release-10/Relase-11(3GPP TS26.247) profile to dash demuxer probe. Signed-off-by: Jun Zhao --- libavformat/dashdec.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 15e79fd..7be3

[FFmpeg-devel] Splitting or merging libraries (was: Status and Plans for Subtitle Filters)

2020-03-01 Thread Nicolas George
Vittorio Giovara (12020-02-28): > err a monsterlibrary is a monsterlibrary regardless of how it is linked, > and it's good that you mention static linking since that would be one of > the best reason to keep library separated You seem to have some basic misconceptions about how linking works, whic

[FFmpeg-devel] [PATCH] diracdec: rewrite golomb reader

2020-03-01 Thread Lynne
This version is able to output multiple coefficients at a time and is able to altogether remove actual golomb code parsing. Its also able to partially recover the last coefficient in case the packet is incomplete. Total decoder performance gain for 8bit 420 1080p lossless: 40%. Total decoder perfo

Re: [FFmpeg-devel] [PATCH 4/4] libavutil: AVEncodeInfo data structures

2020-03-01 Thread Asaf Kave
On Sat, Feb 29, 2020 at 2:23 PM Michael Niedermayer wrote: > From: Juan De León > > AVEncodeInfoFrame data structure to store as AVFrameSideData of type > AV_FRAME_DATA_ENCODE_INFO. > The structure stores quantization index for each plane, DC/AC deltas > for luma and chroma planes, and an array

Re: [FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_opt: remove bogus warning of multiple -af and -vf usage

2020-03-01 Thread Paul B Mahol
lgtm On 2/29/20, Marton Balint wrote: > This is redundant after the last patch and also fixes ticket #7712. > > Signed-off-by: Marton Balint > --- > fftools/ffmpeg_opt.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index 3d6fafe073..d