Linjie Fu 于2020年2月28日周五 下午11:34写道:
>
> There are frame droppings in frc while converting into a lower framerate,
> and MSDK returns ERROR_MORE_DATA which should be ignored.
Should be fixed in MSDK instead of working around in FFmpeg?
___
ffmpeg-devel ma
Hello,
I have been reading through the parsing API and other things and here's what
I've managed to gather (I will be ignoring overruns in these functions for now).
Please tell me if I am right or wrong:
1. As long as the parse function determines next == END_NOT_FOUND,
ff_combine_frame will
> -Original Message-
> From: Guo, Yejun
> Sent: Wednesday, February 19, 2020 12:24 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: RE: [PATCH 2/3] libavcodec/libx264.c: refine code to extract function
> x264_encode_set_roi
>
>
>
> > -Original Message-
> > From: Guo, Yejun
> > Sent:
> -Original Message-
> From: Guo, Yejun
> Sent: Tuesday, February 25, 2020 2:07 PM
> To: Pedro Arthur ; FFmpeg development discussions
> and patches
> Subject: RE: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_sr.c: refine code to use
> AVPixFmtDescriptor.log2_chroma_h/w
>
>
>
> > -Origi
From: Damiano Galassi
Signed-off-by: Nomis101
---
libavcodec/videotoolboxenc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index cc08cf6a50..32d893e485 100644
--- a/libavcodec/videotoolboxenc.c
+++ b/libavcodec/videotoolboxenc.
Am Sa., 29. Feb. 2020 um 00:47 Uhr schrieb Nomis101 :
> >> The fix is adopted from HandBrake's FFmpeg patch set:
> >> https://github.com/HandBrake/HandBrake/blob/master/contrib/ffmpeg/A04-videotoolbox.patch
> >
> > Then please fix the attribution.
>
> OK, will do. But, where in send-email can I ch
Am 28.02.20 um 19:19 schrieb Carl Eugen Hoyos:
> Am Fr., 28. Feb. 2020 um 19:08 Uhr schrieb Nomis101 :
>>
>> Am 27.02.20 um 19:13 schrieb Nomis101:
>>> Signed-off-by: Nomis101
>>> ---
>>> libavcodec/videotoolboxenc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavcodec/videot
Make possible to parse expressions and store results as arguments
for target filters.
Signed-off-by: Paul B Mahol
---
doc/filters.texi| 19
libavfilter/f_sendcmd.c | 48 ++---
2 files changed, 64 insertions(+), 3 deletions(-)
diff --g
lgtm
On 2/28/20, Andreas Rheinhardt wrote:
> The second ; in a double ;; is actually a null statement. It triggers
> the typical declaration-after-statement compiler-warnings if it occurs
> in the middle of several declarations (like here).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavfil
lgtm
On 2/28/20, Andreas Rheinhardt wrote:
> Fixes #8094.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> fftools/ffmpeg_opt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
> index 12d44886ee..3bf90bd20c 100644
> --- a/fftools/ffmpeg_opt.c
>
The second ; in a double ;; is actually a null statement. It triggers
the typical declaration-after-statement compiler-warnings if it occurs
in the middle of several declarations (like here).
Signed-off-by: Andreas Rheinhardt
---
libavfilter/vf_cas.c | 4 ++--
1 file changed, 2 insertions(+), 2
Fixes #8094.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffmpeg_opt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 12d44886ee..3bf90bd20c 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -3278,6 +3278,7 @@ static int open_
From: Andriy Gelman
Signed-off-by: Andriy Gelman
---
libavformat/libzmq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/libzmq.c b/libavformat/libzmq.c
index 8c8b294c921..1b0d8638dbf 100644
--- a/libavformat/libzmq.c
+++ b/libavformat/libzmq.c
@@ -40,7 +40,7 @@
From: Andriy Gelman
Supports connecting to a RabbitMQ broker via AMQP version 0-9-1.
Signed-off-by: Andriy Gelman
---
Changes in v2:
- Addressed comments from Marton
- Updated documentation
Compilation notes:
- Requires librabbitmq-dev package (on ubuntu).
- The pkg-config li
On Fri, Feb 28, 2020 at 6:58 AM Nicolas George wrote:
> Anton Khirnov (12020-02-28):
> > avpriv is not a necessary result of having multiple libraries. It is a
> > bug caused by bad API design. There is no fundamental reason for having
> > private interfaces.
> >
> > In my view, no new private in
On Thu, Feb 27, 2020 at 06:15:26AM +, Fu, Linjie wrote:
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of
> > Andreas Rheinhardt
> > Sent: Thursday, February 27, 2020 13:34
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Andreas Rheinhardt
> > Subject: [FFmpeg-devel] [PATCH 2/2] avco
On Fri, Feb 28, 2020 at 12:24:27AM -0500, Andriy Gelman wrote:
> On Fri, 28. Feb 00:14, Linjie Fu wrote:
> > Signed-off-by: Linjie Fu
> > ---
> > libavcodec/v4l2_context.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavcodec/v4l2_context.c b/libavcodec/v4l2_c
On Thu, Feb 27, 2020 at 09:44:05AM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Opposition brings concord. Out of discord comes the fairest harmony.
-- Heraclitus
signature.asc
Description: PGP signature
___
On Fri, Feb 28, 2020 at 12:13:28AM +0800, Linjie Fu wrote:
> "In both cases.." and "Repeat this call until.." would be better to
> be in a separate line.
>
> http://ffmpeg.org/doxygen/trunk/group__lavc__encdec.html
>
> Signed-off-by: Linjie Fu
> ---
> libavcodec/avcodec.h | 2 ++
> 1 file chang
On Thu, Feb 27, 2020 at 01:03:26PM +0100, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2020-02-26 19:15:03)
> > Fixes: regression
> > Fixes: Ticket8511
> >
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavformat/mp3dec.c | 12 +---
> > 1 file changed, 9 insertions(+), 3 del
Am Fr., 28. Feb. 2020 um 19:08 Uhr schrieb Nomis101 :
>
> Am 27.02.20 um 19:13 schrieb Nomis101:
> > Signed-off-by: Nomis101
> > ---
> > libavcodec/videotoolboxenc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> > inde
Am 27.02.20 um 19:13 schrieb Nomis101:
> Signed-off-by: Nomis101
> ---
> libavcodec/videotoolboxenc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
> index cc08cf6a50..32d893e485 100644
> --- a/libavcodec/videotoolboxenc.c
> +
> -Original Message-
> From: ffmpeg-devel On Behalf Of Fu,
> Linjie
> Sent: Wednesday, December 18, 2019 09:55
> To: FFmpeg development discussions and patches de...@ffmpeg.org>; alexan...@khirnov.net; c...@passwd.hu; Paul B Mahol
> ; jamr...@gmail.com; u...@pkh.me
> Subject: Re: [FFmpeg-
There are frame droppings in frc while converting into a lower framerate,
and MSDK returns ERROR_MORE_DATA which should be ignored.
Reported-by: Gupta, Pallavi
Signed-off-by: Linjie Fu
---
Could be reproduced by:
ffmpeg -hwaccel qsv -c:v hevc_qsv -i input_25fps.h265
-vf vpp_qsv=framerate
On 2/28/2020 8:52 AM, Michael Niedermayer wrote:
> On Thu, Feb 27, 2020 at 03:02:00PM -0300, James Almer wrote:
>> This commit follows the same logic as 061a0c14bb, but for the encode API: The
>> new public encoding API will no longer be a wrapper around the old deprecated
>> one, and the internal
> -Original Message-
> From: ffmpeg-devel On Behalf Of
> Michael Niedermayer
> Sent: Friday, February 28, 2020 19:53
> To: FFmpeg development discussions and patches de...@ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 2/4] avcodec/encode: restructure the
> core encoding code
>
> On Th
Anton Khirnov (12020-02-28):
> avpriv is not a necessary result of having multiple libraries. It is a
> bug caused by bad API design. There is no fundamental reason for having
> private interfaces.
>
> In my view, no new private interfaces should be accepted and all of the
> existing ones should b
On Thu, Feb 27, 2020 at 03:02:00PM -0300, James Almer wrote:
> This commit follows the same logic as 061a0c14bb, but for the encode API: The
> new public encoding API will no longer be a wrapper around the old deprecated
> one, and the internal API used by the encoders now consists of a single
> re
Jean-Baptiste Kempf (12020-02-27):
> Separating I/O from demuxers would bring a lot of interesting things
> for security and for custom protocols.
At the API level, yes, indeed. I personally would like demuxers to use
the same push/pull API the decoders have been made to use.
But that does not mea
The check will be true at most once anyway.
Signed-off-by: Andreas Rheinhardt
---
libavformat/hlsenc.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index e3a310dbc1..317b1a6f5e 100644
--- a/libavformat/hlsenc.c
Before this commit, the checks were unnecessarily scattered.
Signed-off-by: Andreas Rheinhardt
---
Now not moving variables into a smaller scope.
libavformat/hlsenc.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index
Mainly includes reindentation and returning directly (i.e. without
a goto fail when possible).
Signed-off-by: Andreas Rheinhardt
---
Now keeping the scope of variables alone.
libavformat/hlsenc.c | 129 +--
1 file changed, 52 insertions(+), 77 deletions(-
hls_init() would at first allocate the vtt_basename string, then
allocate the vtt_m3u8_name string followed by several operations that
may fail and then open the subtitles' output context. Yet upon freeing,
these strings were only freed when the subtitles' output context
existed, ensuring that they
This fixes memleaks in instances such as:
a) When an allocation fails at one of the two places in hls_init() where
the error is returned immediately without goto fail first.
b) When an error happens when writing the header.
c) When an allocation fails at one of the three places in
hls_write_trailer
Signed-off-by: Andreas Rheinhardt
---
libavformat/hlsenc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index a281c379f0..18f40ff3ed 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -1610,6 +1610,8 @@
Several variables which are only used when the HLS_SINGLE_FILE flag is
unset have been set even when this flag is set. This has been changed.
Signed-off-by: Andreas Rheinhardt
---
Now not moving variables into a smaller scope.
libavformat/hlsenc.c | 16
1 file changed, 8 insert
On Fri, 28 Feb 2020, Carl Eugen Hoyos wrote:
Am Fr., 28. Feb. 2020 um 01:38 Uhr schrieb Marton Balint :
Fixes ticket #8523.
Signed-off-by: Marton Balint
---
libavformat/mxf.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libavformat/mxf.c b/libavformat/mxf.c
index 140
Am Di., 11. Feb. 2020 um 00:24 Uhr schrieb Carl Eugen Hoyos
:
> Attached patch probably fixes ticket #8518 and definitely simplifies
> *ac3* encoding usage.
Ping.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailm
On Fri, Feb 28, 2020 at 05:55:19AM +0100, Anton Khirnov wrote:
> Quoting Clément Bœsch (2020-02-27 19:36:24)
> > On Thu, Feb 27, 2020 at 12:35:03PM +0100, Anton Khirnov wrote:
> > [...]
> > > AFAIU one of the still-open questions for the subtitle redesign is what
> > > does it mean to decode or enc
Am Fr., 28. Feb. 2020 um 01:38 Uhr schrieb Marton Balint :
>
> Fixes ticket #8523.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/mxf.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/libavformat/mxf.c b/libavformat/mxf.c
> index 14056647c5..987410258a 100644
> --- a
40 matches
Mail list logo