Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT

2020-02-08 Thread Gyan Doshi
On 9 February 2020 10:40:05 AM IST, Steven Liu wrote: >because it cannot get result now. > >Signed-off-by: Steven Liu >--- > libavcodec/h264_metadata_bsf.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/libavcodec/h264_metadata_bsf.c >b/libavcodec/h264_metadata_bsf.c >index d96a50dbf7

[FFmpeg-devel] [PATCH] avcodec/h264_metadata_bsf: give warning when display_orientation set to EXTRACT

2020-02-08 Thread Steven Liu
because it cannot get result now. Signed-off-by: Steven Liu --- libavcodec/h264_metadata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h264_metadata_bsf.c b/libavcodec/h264_metadata_bsf.c index d96a50dbf7..712b54dacc 100644 --- a/libavcodec/h264_metadata_bsf.c +++ b/liba

Re: [FFmpeg-devel] [PATCH 06/12] avformat/http: use AVBPrint to construct HTTP request

2020-02-08 Thread Andreas Rheinhardt
Marton Balint: > Signed-off-by: Marton Balint > --- > libavformat/http.c | 79 > -- > 1 file changed, 29 insertions(+), 50 deletions(-) > > diff --git a/libavformat/http.c b/libavformat/http.c > index d0df1b6d58..5fd36baab8 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/h264_pc: Return error if pps has FMO parameters

2020-02-08 Thread James Almer
On 2/8/2020 7:20 PM, Andriy Gelman wrote: > From: Andriy Gelman > > FMO is not supported and fields related to FMO are not parsed, meaning > that any fields which follow will be corrupt. > --- > libavcodec/h264_ps.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/h264_ps.c

[FFmpeg-devel] [PATCH] lavu/tx: implement 32 bit fixed point FFT and MDCT

2020-02-08 Thread Lynne
Patch attached. Commit message: Required minimal changes to the code so made sense to implement. FFT and MDCT tested, the output of both was properly rounded. Fun fact: the non-power-of-two fixed-point FFT and MDCT are the fastest ever non-power-of-two fixed-point FFT and MDCT written. This can re

Re: [FFmpeg-devel] [PATCH] avcodec/h264_pc: Return error if pps has FMO parameters

2020-02-08 Thread Andriy Gelman
On Sat, 08. Feb 17:20, Andriy Gelman wrote: > From: Andriy Gelman > > FMO is not supported and fields related to FMO are not parsed, meaning > that any fields which follow will be corrupt. > --- > libavcodec/h264_ps.c | 2 ++ > 1 file changed, 2 insertions(+) > I have a typo in the commit mess

[FFmpeg-devel] [PATCH] avcodec/h264_pc: Return error if pps has FMO parameters

2020-02-08 Thread Andriy Gelman
From: Andriy Gelman FMO is not supported and fields related to FMO are not parsed, meaning that any fields which follow will be corrupt. --- libavcodec/h264_ps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c index edbaa96b64e..80216854079 10064

[FFmpeg-devel] [PATCH 11/12] avformat/ftp: do not break protocol on username or password with newlines

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/ftp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/ftp.c b/libavformat/ftp.c index 860dd7d8dc..ab7368256c 100644 --- a/libavformat/ftp.c +++ b/libavformat/ftp.c @@ -18,6 +18,8 @@ * Foundation, Inc., 51 Franklin Street, Fifth

[FFmpeg-devel] [PATCH 12/12] avformat/ftp: slightly rework file retrieval with seeking

2020-02-08 Thread Marton Balint
- do not require a known file size for seek to work - read the files till the actual end, do not limit data at the queried file size - fix a bug which causes reading 0 byte files for non-existing files - properly check the return status of the FTP server at the end of the file retrieval Signed

[FFmpeg-devel] [PATCH 08/12] avformat/urldecode: add the ability to not decode plus sign to space

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/httpauth.c | 4 ++-- libavformat/urldecode.c | 4 ++-- libavformat/urldecode.h | 3 ++- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c index 2d42ab2190..54d0322c6a 100644 --- a/libavforma

[FFmpeg-devel] [PATCH 07/12] avformat/http: escape unsafe URL path in HTTP request

2020-02-08 Thread Marton Balint
This avoids generating invalid HTTP requests if the path contains space or other special characters. Signed-off-by: Marton Balint --- libavformat/http.c | 36 +++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.

[FFmpeg-devel] [PATCH 10/12] avformat/ftp: add support for escaped credentials

2020-02-08 Thread Marton Balint
Properly fixes ticket #7816. Signed-off-by: Marton Balint --- libavformat/Makefile | 2 +- libavformat/ftp.c| 26 +- 2 files changed, 18 insertions(+), 10 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 710cc4d088..a9972fd99a 100644 --- a

[FFmpeg-devel] [PATCH 09/12] avformat/httpauth: do not decode plus sign to space in credentials

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/httpauth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/httpauth.c b/libavformat/httpauth.c index 54d0322c6a..4f79c78edc 100644 --- a/libavformat/httpauth.c +++ b/libavformat/httpauth.c @@ -255,7 +255,7 @@ char *f

[FFmpeg-devel] [PATCH 05/12] avformat/http: make sure URL path contains a slash

2020-02-08 Thread Marton Balint
It is explicitly required by the HTTP RFC. Without this patch URLs like http://example.com?query will not work. Fixes ticket #8466. Signed-off-by: Marton Balint --- libavformat/http.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/http.c b/libavformat

[FFmpeg-devel] [PATCH 04/12] avformat/http: split the fragment part from the HTTP URL before the request

2020-02-08 Thread Marton Balint
RFC 3986 states that the fragment identifier is separated from the rest of the URI prior to a dereference, and thus the identifying information within the fragment itself is dereferenced solely by the user agent. Signed-off-by: Marton Balint --- libavformat/http.c | 5 + 1 file changed, 5 in

[FFmpeg-devel] [PATCH 06/12] avformat/http: use AVBPrint to construct HTTP request

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/http.c | 79 -- 1 file changed, 29 insertions(+), 50 deletions(-) diff --git a/libavformat/http.c b/libavformat/http.c index d0df1b6d58..5fd36baab8 100644 --- a/libavformat/http.c +++ b/libavformat/h

[FFmpeg-devel] [PATCH 03/12] avformat/utils: make av_url_split search for hashmark as well to separate hostname

2020-02-08 Thread Marton Balint
RFC 3986 states that the generic syntax uses the slash ("/"), question mark ("?"), and number sign ("#") characters to delimit components that are significant to the generic parser's hierarchical interpretation of an identifier. Signed-off-by: Marton Balint --- libavformat/tests/url.c | 1 + li

[FFmpeg-devel] [PATCH 01/12] avformat/tests/url: make format more readable

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/tests/url.c | 3 ++- tests/ref/fate/url | 27 ++- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 1623179128..11ed5bb0b7 100644 --- a/libavformat/tes

[FFmpeg-devel] [PATCH 02/12] avformat/tests/url: add av_url_split tests

2020-02-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/tests/url.c | 24 tests/ref/fate/url | 10 ++ 2 files changed, 34 insertions(+) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 11ed5bb0b7..d99876f02c 100644 --- a/libavformat/tests/url.c +++

Re: [FFmpeg-devel] [PATCH 1/5] avutil/log: drop support for NO_COLOR environment variable

2020-02-08 Thread Marton Balint
On Sun, 2 Feb 2020, Marton Balint wrote: Deprecated for more than 9 years now. Signed-off-by: Marton Balint --- doc/fftools-common-opts.texi | 4 +--- libavutil/log.c | 8 +++- 2 files changed, 4 insertions(+), 8 deletions(-) Ping for the series, will apply soon. Regards, M

Re: [FFmpeg-devel] [PATCH] avcodec/mlpdec: use get_bits_long for huff lsbs

2020-02-08 Thread Michael Niedermayer
On Sat, Feb 08, 2020 at 01:46:12AM +0530, Jai Luthra wrote: > lsb bits may go beyond 25 bits, so to be safe use get_bits_long > > Signed-off-by: Jai Luthra > --- > libavcodec/mlpdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply thx [...] -- Michael GnuPG fingerprin

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_paletteuse: Fix potential double-free of AVFrame

2020-02-08 Thread Michael Niedermayer
On Fri, Feb 07, 2020 at 08:35:23PM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Asymptotically faster algorithms should always be preferred if you have asymptotical amounts of data signature.asc Description:

[FFmpeg-devel] [PATCH] avfilter/vf_fade: add >8 bit support for black and alpha fade

2020-02-08 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_fade.c | 169 ++ 1 file changed, 138 insertions(+), 31 deletions(-) diff --git a/libavfilter/vf_fade.c b/libavfilter/vf_fade.c index 26a81ee8d0..c4fb0bb058 100644 --- a/libavfilter/vf_fade.c +++ b/libavfilter/

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: Fix bug #8204

2020-02-08 Thread Gyan Doshi
Worth noting, but should be rephrased. I'll do that in a few days. Gyan On 8 February 2020 10:31:09 AM IST, gautamr...@gmail.com wrote: >From: Gautam Ramakrishnan > >Change the documentation of -hwaccels as mentioned in bug #8204 > >Signed-off-by: Gautam Ramakrishnan >--- > doc/ffmpeg.texi | 1