Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-06 Thread James Zern
On Thu, Feb 6, 2020 at 8:58 AM Wonkap Jang wrote: > > Hi James, > > On Wed, Feb 5, 2020 at 5:29 PM James Zern > wrote: > > > On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang > > wrote: > > > > > > Hi > > > > > > On Mon, Feb 3, 2020 at 12:45 PM James Zern < > > jzern-at-google@ffmpeg.org> > > > wro

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tty: Fix division by 0 in probe

2020-02-06 Thread Hendrik Leppkes
On Fri, Feb 7, 2020 at 12:16 AM Michael Niedermayer wrote: > > On Thu, Feb 06, 2020 at 03:27:11PM +0100, Paul B Mahol wrote: > > Nonsense, why would this code be called with 0 buffer? > > I guess because code calls av_probe_input_format3() with a 0 buffer > its a public function and called by mult

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-02-06 Thread Michael Niedermayer
On Thu, Jan 30, 2020 at 11:23:07AM -0800, Dale Curtis wrote: > On Wed, Jan 29, 2020 at 10:23 PM Michael Niedermayer > wrote: > > > so i think it works but maybe ive missed something, for which values > > of e2_pts do you see a problem with e1_pts = INT64_MIN? > > > > For e1_pts = INT64_MIN and e

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tty: Fix division by 0 in probe

2020-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2020 at 03:27:11PM +0100, Paul B Mahol wrote: > Nonsense, why would this code be called with 0 buffer? I guess because code calls av_probe_input_format3() with a 0 buffer its a public function and called by multiple places from our code base as well. Theres even code in it to handl

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Fix invalid left shifts in cavs_idct8_add_c()

2020-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2020 at 05:33:00PM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: left shift of negative value -107 > > Fixes: > > 20398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5725389278412800 > > > > Found-by: continuous fuzzing process > > https://git

[FFmpeg-devel] GSoC 2020

2020-02-06 Thread Michael Niedermayer
Hi all please help fill the 2020 GSoC Ideas page https://trac.ffmpeg.org/wiki/SponsoringPrograms/GSoC/2020 (This page is key to being acccepted to GSoC) Thank you -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB When the tyrant has disposed of foreign enemies by conq

Re: [FFmpeg-devel] Fix undefined behavior in ff_configure_buffers_for_index()

2020-02-06 Thread Dale Curtis
Bump to apply? - dale On Thu, Jan 30, 2020 at 3:21 PM Dale Curtis wrote: > On Thu, Jan 30, 2020 at 11:23 AM Dale Curtis > wrote: > >> On Wed, Jan 29, 2020 at 10:23 PM Michael Niedermayer >> wrote: >> >>> so i think it works but maybe ive missed something, for which values >>> of e2_pts do you

[FFmpeg-devel] [PATCH] avfilter: add pad opencl filter

2020-02-06 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure | 1 + doc/filters.texi| 29 libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/opencl/pad.cl | 34 + libavfilter/opencl_source.h | 1 + libavfilter/vf_pad_opencl.c | 289 ++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Fix invalid left shifts in cavs_idct8_add_c()

2020-02-06 Thread Andreas Rheinhardt
Michael Niedermayer: > Fixes: left shift of negative value -107 > Fixes: > 20398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5725389278412800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niede

Re: [FFmpeg-devel] [PATCH v7 0/3] Fix mpeg1/2 stream copy

2020-02-06 Thread Gaullier Nicolas
>Envoyé : vendredi 31 janvier 2020 09:59 >Objet : Re: [FFmpeg-devel] [PATCH v7 0/3] Fix mpeg1/2 stream copy > >I have not received any feedback yet on this latest version that does not >affect the public API. >The 3 patches are still available in patchwork: >https://patchwork.ffmpeg.org/project/ff

Re: [FFmpeg-devel] [PATCH v5 2/2] avcodec/libvpxenc: add a way to explicitly set temporal layer id

2020-02-06 Thread Wonkap Jang
Hi James, On Wed, Feb 5, 2020 at 5:29 PM James Zern wrote: > On Mon, Feb 3, 2020 at 5:45 PM Wonkap Jang > wrote: > > > > Hi > > > > On Mon, Feb 3, 2020 at 12:45 PM James Zern < > jzern-at-google@ffmpeg.org> > > wrote: > > > > > On Mon, Feb 3, 2020 at 10:02 AM Wonkap Jang > > > wrote: > > >

Re: [FFmpeg-devel] [PATCH v2 0/2] Simon & Schuster Interactive VAG demuxer + decoder.

2020-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2020 at 09:55:41AM +0100, Paul B Mahol wrote: > LGTM will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB "You are 36 times more likely to die in a bathtub than at the hands of a terrorist. Also, you are 2.5 times more likely to become

Re: [FFmpeg-devel] [PATCH 2/3] avformat/tty: Fix division by 0 in probe

2020-02-06 Thread Paul B Mahol
Nonsense, why would this code be called with 0 buffer? On 2/6/20, Michael Niedermayer wrote: > Fixes: division by zero > Fixes: > 20436/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5763229752229888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-06 Thread Lynne
Feb 6, 2020, 11:17 by kavea...@gmail.com: > On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave wrote: > >> >> >> On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave wrote: >> >>> >>> >>> On Sun, Jan 26, 2020, 12:31 Asaf Kave wrote: >>> On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave wrote: > >

Re: [FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-06 Thread Michael Niedermayer
On Thu, Feb 06, 2020 at 02:59:03PM +0530, Jai Luthra wrote: > On Tue, Feb 04, 2020 at 10:24:50PM +0100, Michael Niedermayer wrote: > >On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote: > >>When no codebook is used, huff_lsbs can be more than 24 and still decode to > >>original values once

[FFmpeg-devel] [PATCH 2/3] avformat/tty: Fix division by 0 in probe

2020-02-06 Thread Michael Niedermayer
Fixes: division by zero Fixes: 20436/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5763229752229888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/tty.c | 3 +++ 1 file changed, 3 ins

[FFmpeg-devel] [PATCH 3/3] avcodec/intrax8: Check for end of bitstream in ff_intrax8_decode_picture()

2020-02-06 Thread Michael Niedermayer
Fixes: Timeout (105sec -> 1sec) Fixes: 20479/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5769846937878528 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/intrax8.c | 2 ++ 1 f

[FFmpeg-devel] [PATCH 1/3] avcodec/cavsdsp: Fix invalid left shifts in cavs_idct8_add_c()

2020-02-06 Thread Michael Niedermayer
Fixes: left shift of negative value -107 Fixes: 20398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CAVS_fuzzer-5725389278412800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cavsdsp.c |

Re: [FFmpeg-devel] [PATCH] Support for Frame Duplication(Doubling/Tripling) by FFmpeg's HEVC Decoder by parsing the picture_struct SEI

2020-02-06 Thread Praveen Kumar
Hi Kieren, Request you to kindly accept the patch and merge it. Thanks & Regards, Praveen From: Praveen Kumar Sent: Wednesday, February 5, 2020 11:40 AM To: Kieran Kunhya Cc: ffmpeg-devel@ffmpeg.org ; Thilo Borgmann ; Michael Niedermayer ; Praveen Kumar Karad

Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-02-06 Thread Robert Deibel
Would appreciate further review or info. On 29.01.20 10:54, Robert Deibel wrote: Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- Fixed a typo/bug where dy was dx. Removed request for oversized frame from filter, instead al

Re: [FFmpeg-devel] [PATCH v2] HEVC: Export motion vectors to frame side data.

2020-02-06 Thread Asaf Kave
On Sun, Feb 2, 2020 at 11:15 AM Asaf Kave wrote: > > > On Tue, Jan 28, 2020 at 11:44 PM Asaf Kave wrote: > >> >> >> On Sun, Jan 26, 2020, 12:31 Asaf Kave wrote: >> >>> >>> >>> On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave wrote: >>> On Tue, Jan 21, 2020 at 8:17 PM Lynne wrote:

Re: [FFmpeg-devel] [PATCH v2 0/2] Simon & Schuster Interactive VAG demuxer + decoder.

2020-02-06 Thread Paul B Mahol
LGTM On 2/6/20, Zane van Iperen wrote: > Hi all, > > This patchset adds support for the VAG container and ADPCM variant used > by some Simon & Schuster Interactive games such as 'Real War', > and 'Real War: Rogue States'. > > It has been tested against VAG files from both games. > > v2: > - sim

Re: [FFmpeg-devel] [PATCH 7/7] mlp: check huff_lsbs only when codebook is used

2020-02-06 Thread Jai Luthra
On Tue, Feb 04, 2020 at 10:24:50PM +0100, Michael Niedermayer wrote: On Mon, Feb 03, 2020 at 12:33:00AM +0530, Jai Luthra wrote: When no codebook is used, huff_lsbs can be more than 24 and still decode to original values once filters are applied. huff_lsbs can but get_bits() is limited to 25,

Re: [FFmpeg-devel] [EXTREMELY IMPORTANT] [PLEASE DO NOT IGNORE] [PATCH] avfilter/framesync: do not pick AV_TIME_BASE for time base when not needed.

2020-02-06 Thread Paul B Mahol
On 2/6/20, Nicolas George wrote: > Paul B Mahol (12020-02-05): >> I will write patch that fixes this. As unnecessary changing time-base >> is wrong way around. > > I do not want several code paths, requiring extra testing in case of > change, unless it is necessary. There is no mystique about the