Hello fellow developers,
As a reminder, this week-end is the FOSDEM, in Brussels.
As promised, we will do a FFmpeg developer meeting, where we will vote on the
decisions taken during VDD.
Notably, re-elect the committees, and the voted will now be done by the new
electors.
This will take plac
Besides the obvious advantages this also fixes a potential memleak:
If only one of the arrays had been successfully allocated, the other
would leak. This also fixes Coverity issues #1440386 and #1440387.
Signed-off-by: Andreas Rheinhardt
---
During testing with -f lavfi -i sinc all I got is one o
Hi all,
Could you please review and take this patch forward.
Thanks & Regards,
Praveen
From: Praveen Kumar
Sent: Thursday, January 23, 2020 7:12 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH] Support for Frame
Duplication(
The pad filter is currently broken for cases where all of the following hold:
(1) chroma subsampling exists (very common),
(2) an input dimension is odd (uncommon), and
(3) the corresponding output dimension is either the same as the input,
or an expression like "ow-iw" or "oh-ih" is used to pla
On 1/26/2020 10:45 PM, Andreas Rheinhardt wrote:
> On Sun, Jan 26, 2020 at 5:28 PM James Almer wrote:
>
>> On 1/24/2020 7:48 PM, Andreas Rheinhardt wrote:
>>> If it is desired, I can add a commit to switch ff_mov_write_packet() to
>>> not use a pointer just for reformatted_data (that is of course
On Sun, Jan 26, 2020 at 5:28 PM James Almer wrote:
> On 1/24/2020 7:48 PM, Andreas Rheinhardt wrote:
> > If it is desired, I can add a commit to switch ff_mov_write_packet() to
> > not use a pointer just for reformatted_data (that is of course
> > initialized to NULL), but to replace it by a data
On Sun, Jan 26, 2020 at 4:54 PM James Almer wrote:
> On 1/23/2020 1:08 PM, Andreas Rheinhardt wrote:
> >
> > +buf = av_malloc((size_t)len + AV_INPUT_BUFFER_PADDING_SIZE);
>
> We never cast the arguments to av_malloc() to size_t, and len here is
> guaranteed to be <= size by parse_obu_header()
On Mon, 27 Jan 2020, Carl Eugen Hoyos wrote:
Am Mo., 27. Jan. 2020 um 00:45 Uhr schrieb Michael Niedermayer
:
On Sun, Jan 26, 2020 at 09:57:59PM +0100, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch is supposed to fix ticket #7068.
>
> Please comment, Carl Eugen
> ffmpeg.c |2 +-
> 1
Am Mo., 27. Jan. 2020 um 00:45 Uhr schrieb Michael Niedermayer
:
>
> On Sun, Jan 26, 2020 at 09:57:59PM +0100, Carl Eugen Hoyos wrote:
> > Hi!
> >
> > Attached patch is supposed to fix ticket #7068.
> >
> > Please comment, Carl Eugen
>
> > ffmpeg.c |2 +-
> > 1 file changed, 1 insertion(+), 1
On Sun, Jan 26, 2020 at 09:57:59PM +0100, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch is supposed to fix ticket #7068.
>
> Please comment, Carl Eugen
> ffmpeg.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 5a59a8ef62b4bfcde812f8ce81aee5c0f39c02db
> 0001-ffmpeg-Do-not-prin
On Sun, Jan 26, 2020 at 8:49 PM Michael Niedermayer
wrote:
> A score of 0 is possible
> Fixes: Ticket8500
>
> Signed-off-by: Michael Niedermayer
> ---
> libavfilter/vf_find_rect.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
> i
Fixes: assertion failure
Fixes: Ticket 8172
Signed-off-by: Michael Niedermayer
---
libavformat/avienc.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavformat/avienc.c b/libavformat/avienc.c
index d6cfb1b783..07e1c3319e 100644
--- a/libavformat/avienc.c
+++ b/libavformat/avienc.
recvfrom() is not a cancellation point in pthreads-win32, see
https://sourceware.org/pthreads-win32/manual/pthread_cancel.html
In order to be able to cancel the reader thread on Win32 properly we first
shutdown the socket then call CancelIoEx to abort pending IO. Subsequent
recvfrom() calls will f
Write mode does not use cancellation.
Signed-off-by: Marton Balint
---
libavformat/udp.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavformat/udp.c b/libavformat/udp.c
index dce4cf76c7..85c9e3a900 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -520,14 +520,12 @@ static v
Hi!
Attached patch is supposed to fix ticket #7068.
Please comment, Carl Eugen
From ab80ef51e9ea87a3d3d0796aabd23b4bef85a4c3 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos
Date: Sun, 26 Jan 2020 21:47:26 +0100
Subject: [PATCH] ffmpeg: Do not print "SDP:" on top of sdp files.
Fixes ticket #7068
Noah Bergbauer (12020-01-26):
> Capturing with DXGI essentially *must* be done on a separate thread, as it is
> extremely time sensitive and starts dropping frames at the slightest delays.
> Dropping and duplicating frames also happens on that thread. This is why
> my DXGI device implements pts as
Am So., 26. Jan. 2020 um 21:44 Uhr schrieb Federico Simoncelli
:
>
> On Sun, Jan 26, 2020 at 8:27 PM Carl Eugen Hoyos wrote:
> >
> > Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli
> > :
> > >
> > > This patch adds the attempt to identify the pulseaudio channel map and
> > > when po
> Devices that do live capture should, at least as an option, use the
> absolute clock as pts. With that information, syncing becomes easy.
Capturing with DXGI essentially *must* be done on a separate thread, as it is
extremely time sensitive and starts dropping frames at the slightest delays.
Dr
On Sun, Jan 26, 2020 at 8:27 PM Carl Eugen Hoyos wrote:
>
> Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli
> :
> >
> > This patch adds the attempt to identify the pulseaudio channel map and
> > when possible set the relevant channel_layout parameter of the codec.
> >
> > The result
Noah Bergbauer (12020-01-26):
> I am currently working on a patch that implements DXGI desktop
> capturing and WASAPI audio capturing for Windows.
>
> For this, I implemented two new devices in libavdevice.
>
> The basics work, but now I'm not sure how to synchronize the audio
> stream with the v
Hello,
I am currently working on a patch that implements DXGI desktop capturing and
WASAPI audio capturing for Windows.
For this, I implemented two new devices in libavdevice.
The basics work, but now I'm not sure how to synchronize the audio stream with
the video stream. Specifically, the t
lgtm
On 1/26/20, Michael Niedermayer wrote:
> A score of 0 is possible
> Fixes: Ticket8500
>
> Signed-off-by: Michael Niedermayer
> ---
> libavfilter/vf_find_rect.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
> index 458252a7ba
score could be 1.0 which lead to uninitialized values
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_find_rect.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
index d7e6579af7..458252a7ba 100644
--- a/libavf
A score of 0 is possible
Fixes: Ticket8500
Signed-off-by: Michael Niedermayer
---
libavfilter/vf_find_rect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
index 458252a7ba..dbe6a07c28 100644
--- a/libavfilter/vf_find_rect.c
+++ b/libav
Am So., 26. Jan. 2020 um 18:13 Uhr schrieb Federico Simoncelli
:
>
> This patch adds the attempt to identify the pulseaudio channel map and
> when possible set the relevant channel_layout parameter of the codec.
>
> The result is an improvement over the current behavior of guessing the
> layout bas
On 1/26/2020 3:29 PM, Michael Niedermayer wrote:
> On Sun, Jan 26, 2020 at 02:59:42PM -0300, James Almer wrote:
>> Should fix fate-lavf-fate-av1.mkv failures on builds without an AV1 decoder.
>>
>> Signed-off-by: James Almer
>> ---
>> libavcodec/av1_parser.c | 5 +
>> 1 file changed, 5 insert
On Sun, Jan 26, 2020 at 02:59:42PM -0300, James Almer wrote:
> Should fix fate-lavf-fate-av1.mkv failures on builds without an AV1 decoder.
>
> Signed-off-by: James Almer
> ---
> libavcodec/av1_parser.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/av1_parser.c b/liba
Signed-off-by: Paul B Mahol
---
configure | 1 +
doc/filters.texi | 97
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/opencl/xfade.cl | 136 +++
libavfilter/opencl_source.h | 1 +
libavfilter/vf
On Sun, Jan 26, 2020 at 6:18 PM Carl Eugen Hoyos wrote:
>
> > Am 26.01.2020 um 17:42 schrieb Federico Simoncelli
> > :
> >
> > On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos
> > wrote:
> >> Can you confirm that with the existing code, user could set the
> >> channel_layout
> >> for everything
Should fix fate-lavf-fate-av1.mkv failures on builds without an AV1 decoder.
Signed-off-by: James Almer
---
libavcodec/av1_parser.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libavcodec/av1_parser.c b/libavcodec/av1_parser.c
index 131a05fd72..68b7a78abe 100644
--- a/libavcodec/av1_
> Am 26.01.2020 um 17:42 schrieb Federico Simoncelli
> :
>
> On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos
> wrote:
>> Can you confirm that with the existing code, user could set the
>> channel_layout
>> for everything >= 3 channels? Does this still work after your patch?
>
> Hi Carl, than
This patch adds the attempt to identify the pulseaudio channel map and
when possible set the relevant channel_layout parameter of the codec.
The result is an improvement over the current behavior of guessing the
layout based on the number of channels (for more information see
guess_layout_max).
--
On Sun, Jan 26, 2020 at 4:33 PM Carl Eugen Hoyos
wrote:
> Can you confirm that with the existing code, user could set the
> channel_layout
> for everything >= 3 channels? Does this still work after your patch?
>
> Carl Eugen
Hi Carl, thanks for asking, actually I caught a segfault with >= 3
chann
Am So., 26. Jan. 2020 um 17:13 Uhr schrieb Zhao Zhili :
>
> ---
> Or specify an upper limit on volume. What do you think?
>
> libavfilter/af_volume.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
> index 213c57195a..02992
On 24/01/2020 10:46, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> configure | 1 +
> doc/filters.texi | 97
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/opencl/xfade.cl | 150 +++
On 1/24/2020 7:48 PM, Andreas Rheinhardt wrote:
> Certain types of OBUs are stripped away before muxing into Matroska and
> ISOBMFF; there are two functions to do this: One that outputs by
> directly writing in an AVIOContext and one that returns a freshly
> allocated buffer with the units not stri
On Sun, Jan 26, 2020 at 10:12:16AM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights
On Sun, Jan 26, 2020 at 10:11:03AM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is le
On Sun, Jan 26, 2020 at 11:38:17AM +0100, Paul B Mahol wrote:
> lgtm
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity o
On Sun, Jan 26, 2020 at 11:27:37AM +0100, Andreas Rheinhardt wrote:
> It will be freed when the AVStream is freed later anyway.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 12
> 1 file changed, 12 deletions(-)
will apply
thx
[...]
--
Michael GnuPG fi
On Sun, Jan 26, 2020 at 11:27:38AM +0100, Andreas Rheinhardt wrote:
> Fixes memleaks when allocating the private data of the timecode_track
> fails or when the trailer is never written.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 34 +-
>
On 1/24/2020 7:48 PM, Andreas Rheinhardt wrote:
> ff_av1_filter_obus_buf() and ff_avc_parse_nal_units_buf() both have a
> pointer-to-pointer parameter which they use to pass a newly allocated
> buffer to the caller. And both functions freed what this pointer points to
> before overwriting it. But n
On 26-01-2020 08:57 pm, Carl Eugen Hoyos wrote:
Am So., 26. Jan. 2020 um 16:25 Uhr schrieb Gyan Doshi :
Allows demuxing UHD 3/1001 fps yuvj420p files
---
libavformat/yuv4mpegdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/yuv4mpegdec.c b/libavformat
On 26-01-2020 08:58 pm, Carl Eugen Hoyos wrote:
Am So., 26. Jan. 2020 um 16:22 Uhr schrieb Gyan Doshi :
---
libavformat/yuv4mpegdec.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
index eceb945bb1..d7b4
On Sun, Jan 26, 2020 at 11:27:39AM +0100, Andreas Rheinhardt wrote:
> Fixes memleaks when the trailer is never written (e.g. if the call to
> gxf_write_map_packet() at the end of gxf_write_header() fails).
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/gxfenc.c | 14 ++
>
On Tue, Aug 13, 2019 at 04:47:14AM +0200, Andreas Rheinhardt wrote:
> In the common case that the input packet was already refcounted,
> ff_interleave_add_packet would allocate a new AVPacketList, use
> av_packet_ref to create a new reference to the buffer for the
> AVPacketList's packet, interleav
---
Or specify an upper limit on volume. What do you think?
libavfilter/af_volume.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavfilter/af_volume.c b/libavfilter/af_volume.c
index 213c57195a..029925cbfb 100644
--- a/libavfilter/af_volume.c
+++ b/libavfilter/af_volume.c
On Tue, Aug 13, 2019 at 04:47:15AM +0200, Andreas Rheinhardt wrote:
> If no error occurs and this AVPacketList is used at all, its packet
> substructure will be overwritten and its next pointer explicitly set, so
> every field will still be initialized even when using av_malloc.
>
> Signed-off-by:
Am So., 26. Jan. 2020 um 16:25 Uhr schrieb Gyan Doshi :
>
> Allows demuxing UHD 3/1001 fps yuvj420p files
> ---
> libavformat/yuv4mpegdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
> index d7b472e6c7..ccd3da1
On 1/24/2020 7:48 PM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/av1.h | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/av1.h b/libavformat/av1.h
> index 52d0814e86..6cc3fcaad2 100644
> --- a/libavformat/av1.h
> +++
On 1/23/2020 1:08 PM, Andreas Rheinhardt wrote:
> Both ISOBMFF as well as Matroska require certain OBUs to be stripped
> before muxing them. There are two functions for this purpose; one writes
> directly into an AVIOContext, the other returns a freshly allocated
> buffer with the undesired units s
Am So., 26. Jan. 2020 um 16:23 Uhr schrieb Federico Simoncelli
:
>
> This patch adds the attempt to identify the pulseaudio channel map and
> when possible set the relevant channel_layout parameter of the codec.
>
> The result is an improvement over the current behavior of guessing the
> layout bas
Am So., 26. Jan. 2020 um 16:22 Uhr schrieb Gyan Doshi :
>
> ---
> libavformat/yuv4mpegdec.c | 12
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
> index eceb945bb1..d7b472e6c7 100644
> --- a/libavformat/yuv4mpeg
Allows demuxing UHD 3/1001 fps yuvj420p files
---
libavformat/yuv4mpegdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
index d7b472e6c7..ccd3da1af8 100644
--- a/libavformat/yuv4mpegdec.c
+++ b/libavformat/yuv4mpegde
This patch adds the attempt to identify the pulseaudio channel map and
when possible set the relevant channel_layout parameter of the codec.
The result is an improvement over the current behavior of guessing the
layout based on the number of channels (for more information see
guess_layout_max).
--
---
libavformat/yuv4mpegdec.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavformat/yuv4mpegdec.c b/libavformat/yuv4mpegdec.c
index eceb945bb1..d7b472e6c7 100644
--- a/libavformat/yuv4mpegdec.c
+++ b/libavformat/yuv4mpegdec.c
@@ -53,10 +53,14 @@ static int yu
The check_x86asm() checks would force enable these variables on success,
bypassing any --disable-* command line option.
This is important in the case of AVX512, where the relevant define is used
to choose between different values for memory alignment and strides in
some allocations.
Signed-off-by:
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 31 ++
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_xfade.c | 613 +++
4 files changed, 646 insertions(+)
create mode 100644 libavfilter/vf_xfade.c
diff --git
On Wed, Jan 15, 2020 at 10:41 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> On Tue, Oct 8, 2019 at 12:42 PM Andreas Rheinhardt <
> andreas.rheinha...@gmail.com> wrote:
>
>> Andreas Rheinhardt:
>> > Andreas Rheinhardt:
>> >> In the common case that the input packet was already refc
lgtm
On 1/26/20, Andreas Rheinhardt wrote:
> In order to use ff_audio_rechunk_interleave() (a special interleavement
> function for situations where the ordinary "interleave by dts" is not
> appropriate), the AVStreams must have private data and this private data
> must begin with an AudioInterle
On Wed, Jan 22, 2020 at 1:09 PM Asaf Kave wrote:
>
>
> On Tue, Jan 21, 2020 at 8:17 PM Lynne wrote:
>
>> Jan 20, 2020, 08:42 by kavea...@gmail.com:
>>
>> > Ping
>> >
>>
>> https://ffmpeg.org/pipermail/ffmpeg-devel/2019-August/248836.html
>>
>>
>> I've okayed it, its just not been pushed yet.
>>
It will be freed when the AVStream is freed later anyway.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mxfenc.c | 12
1 file changed, 12 deletions(-)
diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index 374a83d069..bd3b8bb2d0 100644
--- a/libavformat/mxfenc.c
+++ b/l
Fixes memleaks when the trailer is never written (e.g. if the call to
gxf_write_map_packet() at the end of gxf_write_header() fails).
Signed-off-by: Andreas Rheinhardt
---
libavformat/gxfenc.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/libavformat/gxfenc.
In order to use ff_audio_rechunk_interleave() (a special interleavement
function for situations where the ordinary "interleave by dts" is not
appropriate), the AVStreams must have private data and this private data
must begin with an AudioInterleaveContext which contains a fifo that may
need to be
Fixes memleaks when allocating the private data of the timecode_track
fails or when the trailer is never written.
Signed-off-by: Andreas Rheinhardt
---
libavformat/mxfenc.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/libavformat/mxfenc
lgtm
On 1/26/20, Andreas Rheinhardt wrote:
> The muxing context has already been zeroed when it was allocated, hence
> it is unnecessary to do it again.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/dvenc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavformat/dvenc
lgtm
On 1/26/20, Andreas Rheinhardt wrote:
> The old write_trailer only freed memory, so it is better to make a
> dedicated deinit function out of it. Given that this function will also
> be called when writing the header fails, one can also remove code that
> frees already allocated fifos when a
67 matches
Mail list logo
