Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: warn users if codec isn't supported

2019-12-22 Thread Gyan
On 20-12-2019 04:55 pm, Gyan wrote: Regards, Gyan Will push tonight. Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpe

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Andreas Rheinhardt
On Mon, Dec 23, 2019 at 6:03 AM Limin Wang wrote: > On Mon, Dec 23, 2019 at 02:00:10AM +0100, Andreas Rheinhardt wrote: > > On Mon, Dec 23, 2019 at 1:53 AM Limin Wang > wrote: > > > > > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > > > Signed-off-by: Zhong Li > > > > --- > > > >

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Limin Wang
On Mon, Dec 23, 2019 at 02:00:10AM +0100, Andreas Rheinhardt wrote: > On Mon, Dec 23, 2019 at 1:53 AM Limin Wang wrote: > > > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > > Signed-off-by: Zhong Li > > > --- > > > libavcodec/midivid.c | 9 ++--- > > > 1 file changed, 6 inser

[FFmpeg-devel] [PATCH v1] avfilter/vf_readeia608: fix check for failed av_calloc

2019-12-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_readeia608.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_readeia608.c b/libavfilter/vf_readeia608.c index ff096189a9..43c57268fa 100644 --- a/libavfilter/vf_readeia608.c +++ b/libavfilter/vf_r

Re: [FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_convolution: Add X86 SIMD optimizations for filter_column()

2019-12-22 Thread chen
comments inlined At 2019-12-22 16:37:03, xuju...@sjtu.edu.cn wrote: >From: Xu Jun > >Performance improves about 10% compared to v1. > >Tested using this command: >./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 >6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5

Re: [FFmpeg-devel] [PATCH 07/16] avformat/hlsenc: Fix potential segfault upon allocation failure

2019-12-22 Thread Steven Liu
> 在 2019年12月16日,08:04,Andreas Rheinhardt 写道: > > The hls muxer allocates an array of VariantStreams, a structure that > contains pointers to objects that need to be freed on their own. This > means that the number of allocated VariantStreams needs to be correct > when they are freed; yet the nu

Re: [FFmpeg-devel] [PATCH 09/16] avformat/hlsenc: Check some unchecked allocations

2019-12-22 Thread Steven Liu
> 在 2019年12月16日,08:04,Andreas Rheinhardt 写道: > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlsenc.c | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 8f142fd475..b3f9582267 100644 > --- a/libav

Re: [FFmpeg-devel] [PATCH 05/16] avformat/hlsenc: Fix leak of options when writing packets

2019-12-22 Thread Steven Liu
> 在 2019年12月16日,08:04,Andreas Rheinhardt 写道: > > Under certain circumstances hls_write_packet() would add options to an > AVDictionary. Said dictionary was never explicitly freed, instead it was > presumed that these options would be consumed when opening a new > IO-context. This left several p

Re: [FFmpeg-devel] [PATCH 04/16] avformat/hlsenc: Fix leak of options when initializing muxing fails

2019-12-22 Thread Steven Liu
> 在 2019年12月16日,08:04,Andreas Rheinhardt 写道: > > hls_mux_init() currently leaks an AVDictionary if opening a dynamic > buffer fails or if avformat_init_output fails. This has been fixed by > moving the initialization resp. the freeing of the dictionary around: > In the former case to a place af

Re: [FFmpeg-devel] [PATCH 03/16] avformat/hlsenc: Only allocate when data is known to be needed

2019-12-22 Thread Steven Liu
> 在 2019年12月16日,08:04,Andreas Rheinhardt 写道: > > hls_init() would allocate a buffer, although it is only needed in one of > two branches that follow. This commit moves the allocation to the branch > that actually needs the buffer. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/hlse

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Andreas Rheinhardt
On Mon, Dec 23, 2019 at 1:53 AM Limin Wang wrote: > On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > > Signed-off-by: Zhong Li > > --- > > libavcodec/midivid.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/midivid.c b/libavcodec/mi

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Limin Wang
On Sun, Dec 22, 2019 at 03:26:58PM +, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..3dac3f1 100644 > --- a/libavcodec/midivi

Re: [FFmpeg-devel] [PATCH v1] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

2019-12-22 Thread Limin Wang
On Sun, Dec 22, 2019 at 05:37:21PM +, Kieran Kunhya wrote: > On Sun, 22 Dec 2019 at 13:27, wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > libavcodec/mpeg12dec.c | 73 > > +++--- > > 1 file changed, 40 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-22 Thread alexandre.schm...@gmail.com
> > not sure why i just now realize it but > > Storing the source path is problematic privacy and security wise > > Thanks > What does this means? That it won't be applied? Can you give an example on why this would be a security issue, considering you already have it anywhere, only not available

Re: [FFmpeg-devel] [PATCH] avfilter/image2: Add source file path and basename to each packet side data.

2019-12-22 Thread Michael Niedermayer
On Sat, Dec 21, 2019 at 05:32:26PM +, Alexandre Heitor Schmidt wrote: > > In the commit msg, > > > >> libavformat/img2dec.c: Modify image2 demuxer to make available > >> two special metadata entries called lavf.image2dec.source_basename > >> and lavf.image2dec.source_basename, which represents,

Re: [FFmpeg-devel] [PATCH V4] avfilter: Add tonemap vaapi filter for H2S

2019-12-22 Thread Marton Balint
On Thu, 12 Dec 2019, Ruiling Song wrote: From: Xinpeng Sun It performs HDR(High Dynamic Range) to SDR(Standard Dynamic Range) conversion with tone-mapping. It only supports HDR10 as input temporarily. An example command to use this filter with vaapi codecs: FFMPEG -hwaccel vaapi -vaapi_devi

[FFmpeg-devel] [PATCHv2 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-22 Thread Marton Balint
In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation overrides the normal opaque parameter but also saves it so it is accessible). v2: add assertion check before dereferencing the BufferPoolEntry. Signed-off-by: Marton Balint --- doc/A

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-22 Thread Michael Niedermayer
On Sun, Dec 22, 2019 at 12:18:28PM +0100, Ulrich Spörlein wrote: > Am Sa., 21. Dez. 2019 um 09:07 Uhr schrieb Ulrich Spörlein > : > > > > Source: https://en.wikipedia.org/wiki/List_of_ID3v1_Genres and taglib. > > > > Further patches to harmonize the spelling have been sent to taglib and > > libid3t

Re: [FFmpeg-devel] [PATCH v1] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

2019-12-22 Thread Kieran Kunhya
On Sun, 22 Dec 2019 at 13:27, wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/mpeg12dec.c | 73 > +++--- > 1 file changed, 40 insertions(+), 33 deletions(-) > Does this fix a particular issue? My patch to H.264 fixed a par

Re: [FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_convolution: Add x86 SIMD optimizations for filter_row()

2019-12-22 Thread Andriy Gelman
Xu, On Sun, 22. Dec 16:37, xuju...@sjtu.edu.cn wrote: > From: Xu Jun > > Read 16 elements from memory, shuffle and parallally compute 4 rows at a > time, shuffle and parallelly write 16 results to memory. > Performance improves about 15% compared to v1. > > Tested using this command: > ./ffmp

Re: [FFmpeg-devel] [PATCH 11/15] avformat/movenc: add a flag to enable CMAF compatability

2019-12-22 Thread Andriy Gelman
James, On Sat, 21. Dec 15:02, James Almer wrote: > Sets some required constrains and reports compatibility with the relevant > compatible brand. > > Signed-off-by: James Almer > --- > libavformat/movenc.c | 25 +++-- > libavformat/movenc.h | 1 + > 2 files changed, 24 inser

Re: [FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread James Almer
On 12/22/2019 12:26 PM, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..3dac3f1 100644 > --- a/libavcodec/midivid.c > +++ b/libavc

[FFmpeg-devel] [PATCH V2] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/midivid.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c index 38465c5..3dac3f1 100644 --- a/libavcodec/midivid.c +++ b/libavcodec/midivid.c @@ -63,17 +63,20 @@ static int decode_mvdv(

[FFmpeg-devel] [PATCH] avcodec/wmavoice: sanity check block_align

2019-12-22 Thread Michael Niedermayer
This limit is roughly based on the bitreader limit, its likely a much tighter limit could be used Fixes: left shift of 1965039647 by 1 places cannot be represented in type 'int' Fixes: 19545/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMAVOICE_fuzzer-5695391899320320 Found-by: continuous

Re: [FFmpeg-devel] [PATCH] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Paul B Mahol
Not ok, please use ret variable. On 12/22/19, Zhong Li wrote: > Signed-off-by: Zhong Li > --- > libavcodec/midivid.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c > index 38465c5..6877c60 100644 > --- a/libavcodec/midivid.

[FFmpeg-devel] [PATCH] lavc/midivid: FIX CID 1456088

2019-12-22 Thread Zhong Li
Signed-off-by: Zhong Li --- libavcodec/midivid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/midivid.c b/libavcodec/midivid.c index 38465c5..6877c60 100644 --- a/libavcodec/midivid.c +++ b/libavcodec/midivid.c @@ -73,7 +73,8 @@ static int decode_mvdv(MidiVidCo

[FFmpeg-devel] [PATCH v1] avcodec/mpeg12dec: switch to AVBufferRef buffer for a53 caption

2019-12-22 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpeg12dec.c | 73 +++--- 1 file changed, 40 insertions(+), 33 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 775579f..86cdebd 100644 --- a/libavcodec/mpeg12dec

Re: [FFmpeg-devel] [PATCH] Fix spelling in ID3v1 genres and extend the list of Winamp extensions.

2019-12-22 Thread Ulrich Spörlein
Am Sa., 21. Dez. 2019 um 09:07 Uhr schrieb Ulrich Spörlein : > > Source: https://en.wikipedia.org/wiki/List_of_ID3v1_Genres and taglib. > > Further patches to harmonize the spelling have been sent to taglib and > libid3tag. > --- > Note that neither taglib nor libid3tag use the typos for Psychedeli

[FFmpeg-devel] [DISCUSS]

2019-12-22 Thread vivien anglesio
Hi, I would like to work on a "per output" -progress option in order to get real-time encoding reports for multiple outputs encoding. I will try to implement this myself but before putting my hands on it I wanted to discuss about the different solutions with the community. I have three of them in

[FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_convolution: Add X86 SIMD optimizations for filter_column()

2019-12-22 Thread xujunzz
From: Xu Jun Performance improves about 10% compared to v1. Tested using this command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1/45:1/45:1/45:1/45:1:2:3:4:column:column:column:column" -an -vfra

[FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_convolution: add 16-column operation for filter_column() and modify filter_slice().

2019-12-22 Thread xujunzz
From: chen Replace the existing C code for filter_column() with chen's code. Modify filter_slice() to be compatible with this change. Tested using the command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6 7 8 9:1 2 3 4 5 6

[FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_convolution: Add x86 SIMD optimizations for filter_row()

2019-12-22 Thread xujunzz
From: Xu Jun Read 16 elements from memory, shuffle and parallally compute 4 rows at a time, shuffle and parallelly write 16 results to memory. Performance improves about 15% compared to v1. Tested using this command: ./ffmpeg_g -s 1280*720 -pix_fmt yuv420p -i test.yuv -vf convolution="1 2 3 4 5