Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_histogram: clean up code

2019-12-13 Thread zhilizhao
Hi Paul, > On Dec 13, 2019, at 10:00 PM, Paul B Mahol wrote: > > Please provide some explanation. No functional changes, just use temporary variables to make code more readable, and may improve a little bit of performance. > > On 12/13/19, quinkbl...@foxmail.com wrote: >> From: Zhao Zhili >

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/h2645_parse: Don't automatically remove nuh_layer_id > 0 packets

2019-12-13 Thread Andriy Gelman
On Thu, 05. Dec 22:15, Andriy Gelman wrote: > From: Andriy Gelman > > HEVC standard supports multi-layer streams (ITU-T H.265 02/2018 Annex > F). Each NAL unit belongs to a particular layer defined by nuh_layer_id > in the header. > > Currently, all NAL units that do not belong to a base layer a

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread James Almer
On 12/13/2019 8:07 PM, Martin Storsjö wrote: > On Fri, 13 Dec 2019, James Almer wrote: > >> On 12/13/2019 7:22 PM, Martin Storsjö wrote: >>> On Fri, 13 Dec 2019, Carl Eugen Hoyos wrote: >>> > Am 13.12.2019 um 09:34 schrieb Martin Storsjö : > >> On Thu, 12 Dec 2019, James Alme

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread Martin Storsjö
On Fri, 13 Dec 2019, James Almer wrote: On 12/13/2019 7:22 PM, Martin Storsjö wrote: On Fri, 13 Dec 2019, Carl Eugen Hoyos wrote: Am 13.12.2019 um 09:34 schrieb Martin Storsjö : On Thu, 12 Dec 2019, James Almer wrote: On 12/12/2019 7:03 PM, Martin Storsjö wrote: On Wed, 11 Dec 2019, M

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread James Almer
On 12/13/2019 7:22 PM, Martin Storsjö wrote: > On Fri, 13 Dec 2019, Carl Eugen Hoyos wrote: > >> >> >>> Am 13.12.2019 um 09:34 schrieb Martin Storsjö : >>> On Thu, 12 Dec 2019, James Almer wrote: > On 12/12/2019 7:03 PM, Martin Storsjö wrote: >> On Wed, 11 Dec 2019, Martin Storsj

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Skip all 0 NAL units

2019-12-13 Thread James Almer
On 12/13/2019 7:17 PM, Michael Niedermayer wrote: > Fixes: assertion failure > Fixes: > 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread Martin Storsjö
On Fri, 13 Dec 2019, Carl Eugen Hoyos wrote: Am 13.12.2019 um 09:34 schrieb Martin Storsjö : On Thu, 12 Dec 2019, James Almer wrote: On 12/12/2019 7:03 PM, Martin Storsjö wrote: On Wed, 11 Dec 2019, Martin Storsjö wrote: On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: Am Mi., 11. Dez. 201

[FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Skip all 0 NAL units

2019-12-13 Thread Michael Niedermayer
Fixes: assertion failure Fixes: 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cbs_h2645.c | 5 -

Re: [FFmpeg-devel] [PATCH] avcodec/simple_idct_template: fix integer overflow

2019-12-13 Thread Michael Niedermayer
On Fri, Dec 13, 2019 at 03:22:17PM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/simple_idct_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us caref

Re: [FFmpeg-devel] [PATCH]lavc/pnmdec: Fix 16bit decoding

2019-12-13 Thread Michael Niedermayer
On Fri, Dec 13, 2019 at 07:13:20PM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes decoding a sample provided on irc. > > Please comment, Carl Eugen > pnmdec.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > b5422d22058919ba63c80c3070660ab1f0908069 > 0001-lavc-pnmde

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread Carl Eugen Hoyos
> Am 13.12.2019 um 09:34 schrieb Martin Storsjö : > >> On Thu, 12 Dec 2019, James Almer wrote: >> >>> On 12/12/2019 7:03 PM, Martin Storsjö wrote: On Wed, 11 Dec 2019, Martin Storsjö wrote: > On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: > > Am Mi., 11. Dez. 2019 um 09:39 Uhr s

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread James Almer
On 12/13/2019 5:34 AM, Martin Storsjö wrote: > On Thu, 12 Dec 2019, James Almer wrote: > >> On 12/12/2019 7:03 PM, Martin Storsjö wrote: >>> On Wed, 11 Dec 2019, Martin Storsjö wrote: >>> On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: > Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: add missing valid range of values for num_cb_points and num_cr_points

2019-12-13 Thread James Almer
It is a requirement of bitstream conformance that num_cr_points is less than or equal to 10. It is a requirement of bitstream conformance that num_cb_points is less than or equal to 10. Signed-off-by: James Almer --- libavcodec/cbs_av1.h | 8 libavcodec/cbs_av1_syntax_

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevc_mp4toannexb_bsf: check that nalu size doesnt overflow

2019-12-13 Thread Andriy Gelman
On Fri, 13. Dec 18:51, Michael Niedermayer wrote: > On Thu, Dec 12, 2019 at 07:36:50PM -0500, Andriy Gelman wrote: > > On Fri, 13. Dec 01:28, Michael Niedermayer wrote: > > > Fixes: Out of array access > > > Fixes: > > > 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-51691

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_mp4toannexb_bsf: Check that there is enough input left for nalu size

2019-12-13 Thread Michael Niedermayer
On Fri, Dec 13, 2019 at 06:05:21PM +0100, Andreas Rheinhardt wrote: > On Fri, Dec 13, 2019 at 5:56 PM Michael Niedermayer > wrote: > > > On Fri, Dec 13, 2019 at 12:24:04PM +0100, Andreas Rheinhardt wrote: > > > On Fri, Dec 13, 2019 at 3:07 AM Michael Niedermayer > > > > > wrote: > > > > > > > No

[FFmpeg-devel] [PATCH]lavc/pnmdec: Fix 16bit decoding

2019-12-13 Thread Carl Eugen Hoyos
Hi! Attached patch fixes decoding a sample provided on irc. Please comment, Carl Eugen From 9bf070aab1a88fb37db3c9322665edee9f90919f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 13 Dec 2019 19:10:15 +0100 Subject: [PATCH] lavc/pnmdec: Fix 16bit decoding. Regression since cdb5479c

[FFmpeg-devel] [PATCH] FATE/hevc.mak: cosmetic for fate-hevc-paired-fields

2019-12-13 Thread Linjie Fu
Adjust the order of fate-hevc-paired-fields. Signed-off-by: Linjie Fu --- tests/fate/hevc.mak | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index 735949a..35af3e4 100644 --- a/tests/fate/hevc.mak +++ b/tests/fate/hevc.mak @@ -

[FFmpeg-devel] [PATCH, v3] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-13 Thread Linjie Fu
5 cabac states for cbf_cb and cbf_cr are supported according to Table 9-4. Add a test for 64x64 4:4:4 8bit HEVC clips with TUDepth = 4, cbf_cr > 0. Signed-off-by: Xu Guangxin Signed-off-by: Linjie Fu --- tests/fate/hevc.mak | 3 +++ tests/ref/fate/hevc-cabac-tudepth | 6 ++ 2

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/hevc_mp4toannexb_bsf: check that nalu size doesnt overflow

2019-12-13 Thread Michael Niedermayer
On Thu, Dec 12, 2019 at 07:36:50PM -0500, Andriy Gelman wrote: > On Fri, 13. Dec 01:28, Michael Niedermayer wrote: > > Fixes: Out of array access > > Fixes: > > 19299/clusterfuzz-testcase-minimized-ffmpeg_BSF_HEVC_MP4TOANNEXB_fuzzer-5169193398042624 > > > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h2645: Fail on all 0 NAL units

2019-12-13 Thread Michael Niedermayer
On Thu, Dec 12, 2019 at 05:15:12PM -0500, Andriy Gelman wrote: > On Thu, 12. Dec 18:43, Michael Niedermayer wrote: > > Fixes: assertion failure > > Fixes: > > 19286/clusterfuzz-testcase-minimized-ffmpeg_BSF_H264_REDUNDANT_PPS_fuzzer-5707990724509696 > > > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_mp4toannexb_bsf: Check that there is enough input left for nalu size

2019-12-13 Thread Andreas Rheinhardt
On Fri, Dec 13, 2019 at 5:56 PM Michael Niedermayer wrote: > On Fri, Dec 13, 2019 at 12:24:04PM +0100, Andreas Rheinhardt wrote: > > On Fri, Dec 13, 2019 at 3:07 AM Michael Niedermayer > > > wrote: > > > > > No testcase > > > > > > Signed-off-by: Michael Niedermayer > > > --- > > > libavcodec/

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_mp4toannexb_bsf: Check that there is enough input left for nalu size

2019-12-13 Thread Michael Niedermayer
On Fri, Dec 13, 2019 at 12:24:04PM +0100, Andreas Rheinhardt wrote: > On Fri, Dec 13, 2019 at 3:07 AM Michael Niedermayer > wrote: > > > No testcase > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/hevc_mp4toannexb_bsf.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH v2 1/2] fftools: add global option to dump filter graph to stderr

2019-12-13 Thread Limin Wang
ping, please help to review it and push it. It's useful to check the auto insert filters for debug. On Tue, Nov 26, 2019 at 09:41:30AM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > It's useful for debugging filter graph purposes, now only lavfi can do that. > > Reviewed-by: Carl

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reset some members of loop filter

2019-12-13 Thread James Almer
On 12/13/2019 6:08 AM, Fei Wang wrote: > According to spec 6.8.10, loop_filter_ref_deltas & loop_filter_mode_deltas > should be keep same as its previous value if it is not presented in current > syntax. > > Signed-off-by: Fei Wang > --- > libavcodec/cbs_av1.h | 3 +++ > libavco

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_dnn_processing: add format GRAY8 and GRAYF32 support

2019-12-13 Thread Pedro Arthur
Em sex., 13 de dez. de 2019 às 08:23, Guo, Yejun escreveu: > > > From: Pedro Arthur [mailto:bygran...@gmail.com] > > Sent: Friday, December 13, 2019 12:45 AM > > To: FFmpeg development discussions and patches > > Cc: Guo, Yejun > > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_dnn_processi

Re: [FFmpeg-devel] [PATCH] fate/cbs: use the rawvideo muxer for AV1 tests

2019-12-13 Thread James Almer
On 12/11/2019 10:14 PM, James Almer wrote: > The IVF muxer autoinserts the av1_metadata filter unconditionally, which is > not desirable for these tests. > > Signed-off-by: James Almer > --- > tests/fate/cbs.mak | 6 +++--- > tests/ref/fate/cbs-av1-av1-1-b10-23-fi

[FFmpeg-devel] [PATCH] avcodec/simple_idct_template: fix integer overflow

2019-12-13 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/simple_idct_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/simple_idct_template.c b/libavcodec/simple_idct_template.c index d8fcfd7c53..5ddd0b45a2 100644 --- a/libavcodec/simple_idct_template.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_histogram: clean up code

2019-12-13 Thread Paul B Mahol
Please provide some explanation. On 12/13/19, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libavfilter/vf_histogram.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c > index 5185992de

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_histogram: fix color value

2019-12-13 Thread quinkblack
From: Zhao Zhili --- libavfilter/vf_histogram.c | 4 +- tests/ref/fate/filter-histogram-levels | 100 - 2 files changed, 52 insertions(+), 52 deletions(-) diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c index 0d2d087beb..d6928d6b08 1006

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_histogram: clean up code

2019-12-13 Thread quinkblack
From: Zhao Zhili --- libavfilter/vf_histogram.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c index 5185992de6..0d2d087beb 100644 --- a/libavfilter/vf_histogram.c +++ b/libavfilter/vf_histogram.c @@ -2

Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for hevc files with 4 TUDepth(0..4) of cbf_cb/cbf_cr

2019-12-13 Thread James Almer
On 12/13/2019 4:05 AM, Fu, Linjie wrote: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Carl Eugen Hoyos >> Sent: Friday, December 13, 2019 10:47 >> To: FFmpeg development discussions and patches > de...@ffmpeg.org> >> Subject: Re: [FFmpeg-devel] [PATCH, v2] FATE: add test for

Re: [FFmpeg-devel] [PATCH 1/4] avfilter/vf_interlace: restore lowpass mode constants

2019-12-13 Thread Marton Balint
On Fri, 6 Dec 2019, Marton Balint wrote: The documentation still mentions numerical constants in addition to textual ones. It is also wrong to use distinct modes as flags and it disallows us to actually use the flags field for real flags in the future. Ping for the series. Will apply soon.

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/hevc_mp4toannexb_bsf: Check that there is enough input left for nalu size

2019-12-13 Thread Andreas Rheinhardt
On Fri, Dec 13, 2019 at 3:07 AM Michael Niedermayer wrote: > No testcase > > Signed-off-by: Michael Niedermayer > --- > libavcodec/hevc_mp4toannexb_bsf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/hevc_mp4toannexb_bsf.c > b/libavcodec/hevc_mp4toannexb

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_dnn_processing: add format GRAY8 and GRAYF32 support

2019-12-13 Thread Guo, Yejun
> From: Pedro Arthur [mailto:bygran...@gmail.com] > Sent: Friday, December 13, 2019 12:45 AM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH 3/4] avfilter/vf_dnn_processing: add > format GRAY8 and GRAYF32 support > Hi, > > how should I test

[FFmpeg-devel] [PATCH] avcodec/cbs_av1: avoid reset some members of loop filter

2019-12-13 Thread Fei Wang
According to spec 6.8.10, loop_filter_ref_deltas & loop_filter_mode_deltas should be keep same as its previous value if it is not presented in current syntax. Signed-off-by: Fei Wang --- libavcodec/cbs_av1.h | 3 +++ libavcodec/cbs_av1_syntax_template.c | 24

Re: [FFmpeg-devel] [PATCHv2] fate: Add an option for disabling the 2k/4k tests

2019-12-13 Thread Martin Storsjö
On Thu, 12 Dec 2019, James Almer wrote: On 12/12/2019 7:03 PM, Martin Storsjö wrote: On Wed, 11 Dec 2019, Martin Storsjö wrote: On Wed, 11 Dec 2019, Carl Eugen Hoyos wrote: Am Mi., 11. Dez. 2019 um 09:39 Uhr schrieb Martin Storsjö : When testing on a memory limited system, these tests co

Re: [FFmpeg-devel] [PATCH] lavc/x265: set preferred_transfer_characteristics for HLG

2019-12-13 Thread Zhong Li
James Almer 于2019年12月13日周五 上午12:14写道: > > On 12/4/2019 11:24 AM, Zhong Li wrote: > > "HEVC HDR UHDTV Bitstreams using HLG10 shall also contain the > > alternative_transfer_characteristics SEI message. The > > alternative_transfer_characteristics SEI message shall be inserted on > > the HEVC DVB_RA