Re: [FFmpeg-devel] [PATCH] avfilter/scale.c: factorize ff_scale_eval_dimensions

2019-12-07 Thread Gyan
On 07-12-2019 11:47 pm, Michael Niedermayer wrote: On Sat, Dec 07, 2019 at 12:08:53PM +0530, Gyan wrote: doc/filters.texi | 40 + libavfilter/scale.c | 59 ++- libavfilter/scale.h | 20

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Add a fate test for CodecPrivate compression

2019-12-07 Thread James Almer
On 12/7/2019 1:35 PM, Andreas Rheinhardt wrote: > This test contains a track with zlib compressed CodecPrivate in addition > to compressed frames; the former was unchecked before. > > Signed-off-by: Andreas Rheinhardt > --- > tests/fate/matroska.mak| 5 + > tests/ref/fate

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-07 Thread Tao Zhang
Paul B Mahol 于2019年12月7日周六 下午11:21写道: > > On 12/7/19, Tao Zhang wrote: > > I'm sorry for the late reply. > > > > Paul B Mahol 于2019年12月7日周六 上午2:48写道: > >> > >> On 12/5/19, Paul B Mahol wrote: > >> > On 12/5/19, Tao Zhang wrote: > >> >> Hello everyone, > >> >> Can I assume this patch is ok if n

[FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix undefined integer overflow in decode_array_0000()

2019-12-07 Thread Michael Niedermayer
Fixes: signed integer overflow: -2143289344 - 6246400 cannot be represented in type 'int' Fixes: 19239/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5173755680915456 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

[FFmpeg-devel] [PATCH 2/4] avcodec/alac: Fix integer overflow in LPC coefficient adaption

2019-12-07 Thread Michael Niedermayer
Fixes: signed integer overflow: 267693597 * 10 cannot be represented in type 'int' Fixes: 19237/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALAC_fuzzer-5755407700328448 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Micha

[FFmpeg-devel] [PATCH 3/4] Remove redundant ;

2019-12-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavfilter/af_axcorrelate.c | 4 ++-- libavfilter/vf_drawbox.c | 2 +- libavformat/dashdec.c| 2 +- libavformat/hlsenc.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_axcorrelate.c b/libavfilter/af

[FFmpeg-devel] [PATCH 1/4] avcodec/g729postfilter: Optimize out overflowing multiplication from apply_tilt_comp()

2019-12-07 Thread Michael Niedermayer
Fixes: signed integer overflow: -1114392282 * 2 cannot be represented in type 'int' Fixes: 19236/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_G729_fuzzer-5741678938030080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Mich

Re: [FFmpeg-devel] [PATCH 2/7] avformat/id3v2: Fix double-free on error

2019-12-07 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ff_id3v2_parse_priv_dict() uses av_dict_set() with the flags > AV_DICT_DONT_STRDUP_KEY and AV_DICT_DONT_STRDUP_VAL. In this case both > key and value are freed on error (and owned by the destination > dictionary on success), so that freeing them again on error is a > double-fr

[FFmpeg-devel] [PATCH 1/2] avutil/buffer: add av_buffer_pool_buffer_get_opaque

2019-12-07 Thread Marton Balint
In order to access the original opaque parameter of a buffer in the buffer pool. (The buffer pool implementation overrides the normal opaque parameter but also saves it so it is accessible). Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/buffer.c | 6 ++ libavutil

[FFmpeg-devel] [PATCH 2/2] avdevice/xcbgrab: use a buffer pool for shared memory segments

2019-12-07 Thread Marton Balint
Also by wrapping the SHM buffer in an AVBufferRef we eliminate yet another possible memcpy improving performance. Signed-off-by: Marton Balint --- libavdevice/xcbgrab.c | 79 ++- 1 file changed, 47 insertions(+), 32 deletions(-) diff --git a/libav

Re: [FFmpeg-devel] [PATCH 001/244] Add a new channel layout API

2019-12-07 Thread Nicolas George
Anton Khirnov (12019-12-06): > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just uint64_t bitmasks. > > Expanded

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: set request_channel_layout

2019-12-07 Thread Michael Niedermayer
On Fri, Dec 06, 2019 at 08:31:09PM -0300, James Almer wrote: > On 12/6/2019 8:08 PM, Michael Niedermayer wrote: > > On Fri, Dec 06, 2019 at 11:56:13AM -0300, James Almer wrote: > >> Should increase coverage of some decoders. > >> > >> Signed-off-by: James Almer > >> --- > >> Passing 6 to av_get_de

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as libxavs2 maintainer

2019-12-07 Thread Michael Niedermayer
On Sat, Oct 12, 2019 at 09:28:44AM +0800, hwren wrote: > From: hwrenx > > Signed-off-by: hwrenx > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things app

Re: [FFmpeg-devel] [PATCH] avfilter/scale.c: factorize ff_scale_eval_dimensions

2019-12-07 Thread Michael Niedermayer
On Sat, Dec 07, 2019 at 12:08:53PM +0530, Gyan wrote: > > > On 07-12-2019 12:36 am, Michael Niedermayer wrote: > >On Wed, Dec 04, 2019 at 02:14:35PM +0530, Gyan wrote: > >>Will help reduce code duplication when adding animation support to vf_scale. > >>See Michael's last comment in https://patchw

Re: [FFmpeg-devel] [PATCH 3/6] avformat/matroskadec: Fix use-after-free when demuxing ProRes

2019-12-07 Thread James Almer
On 12/6/2019 8:16 PM, Andreas Rheinhardt wrote: > ProRes in Matroska is supposed to not contain the first atom header > (containing a size field and the tag "icpf") and therefore the Matroska > demuxer has to recreate it; this involves an allocation and copy, of > course. Whether the old buffer (co

[FFmpeg-devel] [PATCH] avformat/matroskadec: Add a fate test for CodecPrivate compression

2019-12-07 Thread Andreas Rheinhardt
This test contains a track with zlib compressed CodecPrivate in addition to compressed frames; the former was unchecked before. Signed-off-by: Andreas Rheinhardt --- tests/fate/matroska.mak| 5 + tests/ref/fate/matroska-zlib-decompression | 5 + 2 files changed, 10 in

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-07 Thread Paul B Mahol
On 12/7/19, Tao Zhang wrote: > I'm sorry for the late reply. > > Paul B Mahol 于2019年12月7日周六 上午2:48写道: >> >> On 12/5/19, Paul B Mahol wrote: >> > On 12/5/19, Tao Zhang wrote: >> >> Hello everyone, >> >> Can I assume this patch is ok if no comments or objections? >> > >> > Yes, give some time for

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/atrac9dec: Check q_unit_cnt more completely before using it to access at9_tab_band_ext_group

2019-12-07 Thread Michael Niedermayer
On Fri, Dec 06, 2019 at 02:22:32PM +0100, Lynne wrote: > Dec 3, 2019, 21:23 by mich...@niedermayer.cc: > > > Fixes: index 8 out of bounds for type 'const uint8_t [8][3]' > > Fixes: > > 19127/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5709394985091072 > > > > Found-by: continu

Re: [FFmpeg-devel] [PATCH] avfilter/vf_yaepblur: add yaepblur filter

2019-12-07 Thread Tao Zhang
I'm sorry for the late reply. Paul B Mahol 于2019年12月7日周六 上午2:48写道: > > On 12/5/19, Paul B Mahol wrote: > > On 12/5/19, Tao Zhang wrote: > >> Hello everyone, > >> Can I assume this patch is ok if no comments or objections? > > > > Yes, give some time for it to be applied. > > I'm busy with other

[FFmpeg-devel] [PATCH 2/2] avfilter: Fix type in av_log for random_seed in cellauto and life

2019-12-07 Thread Michael Niedermayer
Fixes CID 1456556 / 1456555 Signed-off-by: Michael Niedermayer --- libavfilter/vsrc_cellauto.c | 2 +- libavfilter/vsrc_life.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vsrc_cellauto.c b/libavfilter/vsrc_cellauto.c index c75460334e..6fd812c54f 100644

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Fix overflow in FFABS() IMA_EA_EACS

2019-12-07 Thread Michael Niedermayer
Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself Fixes: 19235/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_IMA_EA_EACS_fuzzer-5680878952382464 Found-by: continuous fuzzing process https://github.com/google/oss