[FFmpeg-devel] [PATCH] avcodec/extract_extradata_bsf: Don't unref uninitialized buffers

This happens if allocating extradata fails and s->remove is unset. Signed-off-by: Andreas Rheinhardt --- libavcodec/extract_extradata_bsf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index ff111

Re: [FFmpeg-devel] [PATCH] lavc/extract_extradata: Use bytestream api

Andriy Gelman: > From: Andriy Gelman > > Signed-off-by: Andriy Gelman > --- > libavcodec/extract_extradata_bsf.c | 27 +-- > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/extract_extradata_bsf.c > b/libavcodec/extract_extradata_bsf.c > i

[FFmpeg-devel] FFMPEG with exo-player fails on cross-compile

Hi, I was trying to build FFMPEG by following these steps, Step 1: cloned Exo-player Step 2: cd Exo-player && FFMPEG_EXT_PATH="$(pwd)/extensions/ffmpeg/src/main/jni" Step 3: Downloaded NDK

Re: [FFmpeg-devel] [PATCH v5 2/4] lavc/libxavs2: optimize data access

At 2019-11-30 02:39:07, "Michael Niedermayer" wrote: >On Mon, Oct 14, 2019 at 09:22:43PM +0800, hwren wrote: >> Optimize data access from multiplication to iteration. >> >> Signed-off-by: hwren >> --- >> libavcodec/libxavs2.c | 45 + >> 1 fil

[FFmpeg-devel] [PATCH] lavc/extract_extradata: Use bytestream api

From: Andriy Gelman Signed-off-by: Andriy Gelman --- libavcodec/extract_extradata_bsf.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index ff111de48cb..4a9f6608734 10064

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself to libavfilter/dnn

Signed-off-by: Guo, Yejun --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7f60ef0..5d02520 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -369,6 +369,8 @@ Filters: Sources: vsrc_mandelbrot.c Michael Niedermayer +dnn

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

On 29/11/19 15:35, Michael Niedermayer wrote: also, do we have a testcase where this loop hangs ? if not please provide a testcase I don't have an easy testcase, but it can be seen with any rtmp stream.  A full test case can be reproduced like this: Compile and create a nginx server like it i

[FFmpeg-devel] [PATCH 1/6] avcodec/sonic: Check e in get_symbol()

Fixes: signed integer overflow: 1721520852 + 1721520852 cannot be represented in type 'int' Fixes: 18346/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5709623893426176 Fixes: 18753/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5663299131932672 Found-by: continu

[FFmpeg-devel] [PATCH 5/6] tools/target_dec_fuzzer: Support fuzzing error detection

This should increase coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 1c4fb11b8a..9dbe025db9 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_de

[FFmpeg-devel] [PATCH 6/6] tools/target_dec_fuzzer: Support setting AV_CODEC_FLAG2_FAST

This should improve coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 9dbe025db9..dcf47b0f4d 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuz

[FFmpeg-devel] [PATCH 3/6] avformat/options_table: err_detect compliant and aggressive should also enable the weaker checks

Signed-off-by: Michael Niedermayer --- libavformat/options_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/options_table.h b/libavformat/options_table.h index 432818f80d..e26b512440 100644 --- a/libavformat/options_table.h +++ b/libavformat/options_tabl

[FFmpeg-devel] [PATCH 4/6] avcodec/options_table: err_detect compliant and aggressive should also enable the weaker checks

Signed-off-by: Michael Niedermayer --- libavcodec/options_table.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index 4b9f3fff2b..d4c0cdeb48 100644 --- a/libavcodec/options_table.h +++ b/libavcodec/options_table.h @

[FFmpeg-devel] [PATCH 2/6] avcodec/wmalosslessdec: Fixes undefined overflow in dequantization in decode_subframe()

Fixes: signed integer overflow: 47875596 * 45 cannot be represented in type 'int' Fixes: 19082/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-5687766512041984 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

Am Sa., 30. Nov. 2019 um 00:52 Uhr schrieb : > > From: Gonzalo Garramuño > > Moved the check inside and at the end of the if (pktl) as per Michael > Niedermayer's suggestion. > This patch is based on one from bsenftner at earthlink.net. Please mention his name as suggested. Carl Eugen

[FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

From: Gonzalo Garramuño Moved the check inside and at the end of the if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from bsenftner at earthlink.net. The hanging in av_read_frame can be reproduced with an rtmp stream that is aborted midway and ffplay (for example)

Re: [FFmpeg-devel] [PATCH 3/3] fate/demux: add an AV1 Annex B test

On 11/18/2019 11:48 AM, James Almer wrote: > Signed-off-by: James Almer > --- > tests/fate/demux.mak| 3 +++ > tests/ref/fate/av1-annexb-demux | 16 > 2 files changed, 19 insertions(+) > create mode 100644 tests/ref/fate/av1-annexb-demux > > diff --git a/tests/fate

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/av1_parser: export stream dimensions in avctx

On 11/18/2019 11:48 AM, James Almer wrote: > This is required to demux annexb samples when a decoder isn't available. > > Signed-off-by: James Almer > --- > libavcodec/av1_parser.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavcodec/av1_parser.c b/libavcodec/av1_parser.c

[FFmpeg-devel] [PATCH 2/3] avformat/flac_picture: Switch to bytestream2 API

ff_flac_parse_picture() parses a buffer containing a flac metadata picture block by wrapping it in an AVIOContext and using the AVIOContext API. Consequently, when not enough data could be read AVERROR(EIO) was returned although reading didn't really fail: A block that contains a subfield whose siz

[FFmpeg-devel] [PATCH 3/3] avformat/flac_picture: Return directly if nothing has been allocated

Signed-off-by: Andreas Rheinhardt --- libavformat/flac_picture.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/flac_picture.c b/libavformat/flac_picture.c index ccb0ee613e..81ddf80465 100644 --- a/libavformat/flac_picture.c +++ b/libavformat/flac_pic

[FFmpeg-devel] [PATCH 1/3] avformat/flac_picture: Simplify checks

During parsing a flac picture metadata block, the mimetype is read as follows: Its 32b size field is read and checked for being in the range 1..63; afterwards, the actual mimetype-string is read into a buffer of size 64, where the length to read is the minimum of the length field and the size of th

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/utils: make avformat_free_context safety

On Fri, Nov 29, 2019 at 10:38:46 -0300, James Almer wrote: > It's not worth adding that at all. And i really want to avoid numbered > replacement functions where possible. It could be "complemented" instead of replaced, by something like avformat_freep_context() (analog av_free() and avfreep()). B

Re: [FFmpeg-devel] [PATCH] libavdevice/lavfi: check avfilter_graph_dump return value

On Thu, Nov 21, 2019 at 03:08:18PM +0800, quinkbl...@foxmail.com wrote: > From: Zhao Zhili > > --- > libavdevice/lavfi.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No huma

Re: [FFmpeg-devel] [PATCH v5 2/4] lavc/libxavs2: optimize data access

On Mon, Oct 14, 2019 at 09:22:43PM +0800, hwren wrote: > Optimize data access from multiplication to iteration. > > Signed-off-by: hwren > --- > libavcodec/libxavs2.c | 45 + > 1 file changed, 29 insertions(+), 16 deletions(-) I think the change is ok

Re: [FFmpeg-devel] [PATCH] avformat/avio: Use ffurl_closep

On Fri, Nov 29, 2019 at 10:42:48AM +0100, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avio.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB While t

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

On Thu, Nov 28, 2019 at 08:58:54PM -0300, ggarr...@gmail.com wrote: > From: Gonzalo Garramuño > > Moved the check inside if (pktl) as per Michael Niedermayer's suggestion. > This patch is based on one from bsenftner at earthlink.net. > --- > libavformat/utils.c | 5 + > 1 file changed, 5 ins

Re: [FFmpeg-devel] [PATCH v1 3/4] avformat/rtpenc_mpegts: removed unused check of avformat_free_context

On Fri, Nov 29, 2019 at 01:15:59PM +0800, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavformat/rtpenc_mpegts.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c > index 45ba6fffe5..7d7377db7a 100644 >

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/utils: make avformat_free_context safety

James Almer 于 2019年11月29日周五 下午9:39写道： > On 11/29/2019 4:53 AM, Andreas Rheinhardt wrote: > > 1. This is both an ABI as well as an API break and so this is > > absolutely unacceptable. Instead, avformat_free_context() should be > > deprecated (but kept!) and a new function avformat_free_context2()

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/utils: make avformat_free_context safety

On 11/29/2019 4:53 AM, Andreas Rheinhardt wrote: > 1. This is both an ABI as well as an API break and so this is > absolutely unacceptable. Instead, avformat_free_context() should be > deprecated (but kept!) and a new function avformat_free_context2() > should be added. It's not worth adding that

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

On Fri, 29 Nov 2019, manuelyuan wrote: Of course I did，and I can give you the bad case videos for your analysis if you need. How can I give them to you？ FWIW, I would like to have a closer look at this patch when I get time (within a couple days), so a detailed explanation (including samples)

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

> Am 29.11.2019 um 08:44 schrieb manuelyuan : > > Of course I did，and I can give you the bad case videos for your analysis if > you need. > How can I give them to you? I don’t have access to a stream analyser so it won’t necessarily help (me) to provide the samples but you could mention in t

Re: [FFmpeg-devel] [PATCH] libavdevice/lavfi: check avfilter_graph_dump return value

Ping for review, thanks! > On Nov 21, 2019, at 3:08 PM, quinkbl...@foxmail.com wrote: > > From: Zhao Zhili > > --- > libavdevice/lavfi.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/libavdevice/lavfi.c b/libavdevice/lavfi.c > index ca8f05f3f7..c949ff7e12 1

[FFmpeg-devel] [PATCH v3] avfilter/vf_showinfo: Fix erroneous results for mean and stdev with pixel bits >8

From: Limin Wang Have tested with be and le pixel format on be and le system for >8bit. System: lmwang@ubuntu:~/ffmpeg.git.mips$ grep HAVE_BIGENDIAN config.h #define HAVE_BIGENDIAN 1 ffmpeg.git git:(showinfo) ??? grep HAVE_BIGENDIAN config.h #define HAVE_BIGENDIAN 0 Test result: 1, yuv420p ./ffm

[FFmpeg-devel] [PATCH] avformat/avio: Use ffurl_closep

Signed-off-by: Andreas Rheinhardt --- libavformat/avio.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index c1bad312cd..2dd2312296 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -346,8 +346,7 @@ int ffurl_open_whitelist

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Replace dts by pts to calculate duration

On Fri, Nov 29, 2019 at 3:44 PM manuelyuan wrote: > > Of course I did，and I can give you the bad case videos for your analysis if > you need. > How can I give them to you？ > > At 2019-11-28 14:38:34, "Carl Eugen Hoyos" wrote: > > > > > >> Am 28.11.2019 um 03:34 schrieb manuelyuan : > >> > >> In