Re: [FFmpeg-devel] [PATCH] avformat/hls: Set AVFMT_TS_DISCONT flag on HLS input format

2019-10-28 Thread Steven Liu
> 在 2019年10月29日,01:09,Dennis Mungai 写道: > > On Mon, 28 Oct 2019 at 05:45, Steven Liu wrote: >> >> >> >>> 在 2019年10月28日,02:39,Philip Langdale 写道: >>> >>> There have been many reports over the years about problems when >>> taking an HLS stream as input to `ffmpeg` where there are timestamp

Re: [FFmpeg-devel] [PATCH v2] avcodec/mips: msa optimizations for vc1dsp

2019-10-28 Thread Shiyou Yin
>-Original Message- >From: ffmpeg-devel-boun...@ffmpeg.org [mailto:ffmpeg-devel-boun...@ffmpeg.org] >On Behalf Of gxw >Sent: Monday, October 21, 2019 3:57 PM >To: ffmpeg-devel@ffmpeg.org >Subject: [FFmpeg-devel] [PATCH v2] avcodec/mips: msa optimizations for vc1dsp > >Performance of WMV3 d

Re: [FFmpeg-devel] [PATCH] Add a new channel layout API

2019-10-28 Thread Michael Niedermayer
On Mon, Oct 28, 2019 at 02:48:21PM +0100, Paul B Mahol wrote: > The new API is more extensible and allows for custom layouts. > More accurate information is exported, eg for decoders that do not > set a channel layout, lavc will not make one up for them. > > Deprecate the old API working with just

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-28 Thread Paul B Mahol
Will apply slightly improved version soon. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/apedec: Only clear the needed buffer space, instead of all

2019-10-28 Thread Paul B Mahol
probably ok On 10/28/19, Michael Niedermayer wrote: > Fixes: Timeout (15sec -> 0.4sec) > Fixes: > 18396/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5730080487112704 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wmalosslessdec: Fix some integer anomalies

2019-10-28 Thread Paul B Mahol
Trivial change, LGTM On 10/28/19, Michael Niedermayer wrote: > Fixes: left shift of negative value -341180 > Fixes: > 18401/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-568638013440 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/adpcm: Fix invalid shifts in ADPCM DTK

2019-10-28 Thread Paul B Mahol
Trivial change, LGTM On 10/28/19, Michael Niedermayer wrote: > Fixes: left shift of negative value -1 > Fixes: > 18397/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_DTK_fuzzer-5675653487132672 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/proj

[FFmpeg-devel] [PATCH 3/3] avcodec/wmalosslessdec: Fix some integer anomalies

2019-10-28 Thread Michael Niedermayer
Fixes: left shift of negative value -341180 Fixes: 18401/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMALOSSLESS_fuzzer-568638013440 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/w

[FFmpeg-devel] [PATCH 1/3] avcodec/apedec: Only clear the needed buffer space, instead of all

2019-10-28 Thread Michael Niedermayer
Fixes: Timeout (15sec -> 0.4sec) Fixes: 18396/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5730080487112704 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 2 +- 1 f

[FFmpeg-devel] [PATCH 2/3] avcodec/adpcm: Fix invalid shifts in ADPCM DTK

2019-10-28 Thread Michael Niedermayer
Fixes: left shift of negative value -1 Fixes: 18397/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ADPCM_DTK_fuzzer-5675653487132672 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/adpcm.c

Re: [FFmpeg-devel] [PATCH] avformat/hls: Set AVFMT_TS_DISCONT flag on HLS input format

2019-10-28 Thread Dennis Mungai
On Mon, 28 Oct 2019 at 05:45, Steven Liu wrote: > > > > > 在 2019年10月28日,02:39,Philip Langdale 写道: > > > > There have been many reports over the years about problems when > > taking an HLS stream as input to `ffmpeg` where there are timestamp > > discontinuities present. This is explicitly support

Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Zhao Zhili
> On Oct 28, 2019, at 9:15 PM, Moritz Barsnick wrote: > > On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote: >>> -unsigned flags; >> >> Since this is a public header, this is part of the API and cannot be >> removed without a deprecation period. > > Sorry, I missed that it say

[FFmpeg-devel] [PATCH] Add a new channel layout API

2019-10-28 Thread Paul B Mahol
The new API is more extensible and allows for custom layouts. More accurate information is exported, eg for decoders that do not set a channel layout, lavc will not make one up for them. Deprecate the old API working with just uint64_t bitmasks. Original commit by Anton Khirnov . Expanded and com

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-28 Thread Paul B Mahol
On 10/28/19, Moritz Barsnick wrote: > On Sat, Oct 26, 2019 at 21:44:02 +0200, Paul B Mahol wrote: >> +Pick median pixel from certain rectangle defined by radius. > > Is radius the correct term within a rectangle? (Just wondering, I do > understand the intent.) > >> +memset(coarse, 0, sizeo

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-28 Thread Paul B Mahol
On 10/28/19, Moritz Barsnick wrote: > On Sat, Oct 26, 2019 at 21:44:02 +0200, Paul B Mahol wrote: >> +Pick median pixel from certain rectangle defined by radius. > > Is radius the correct term within a rectangle? (Just wondering, I do > understand the intent.) Correct term. > >> +memset(

Re: [FFmpeg-devel] [PATCH] avfilter/vf_sr: correct flags since the filter changes frame w/h

2019-10-28 Thread Paul B Mahol
LGTM On 10/28/19, Guo, Yejun wrote: > If filter changes frame w/h, AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC > cannot be supported. > > Signed-off-by: Guo, Yejun > --- > libavfilter/vf_sr.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c > index 04

[FFmpeg-devel] [PATCH] avfilter/vf_sr: correct flags since the filter changes frame w/h

2019-10-28 Thread Guo, Yejun
If filter changes frame w/h, AVFILTER_FLAG_SUPPORT_TIMELINE_GENERIC cannot be supported. Signed-off-by: Guo, Yejun --- libavfilter/vf_sr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/vf_sr.c b/libavfilter/vf_sr.c index 0433246..b90643c 100644 --- a/libavfilter/vf_sr.c +++ b/li

Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Moritz Barsnick
On Mon, Oct 28, 2019 at 14:09:53 +0100, Moritz Barsnick wrote: > > -unsigned flags; > > Since this is a public header, this is part of the API and cannot be > removed without a deprecation period. Sorry, I missed that it says "Applications must not normally access the link structure directly."

Re: [FFmpeg-devel] [PATCH] avfilter: add median filter

2019-10-28 Thread Moritz Barsnick
On Sat, Oct 26, 2019 at 21:44:02 +0200, Paul B Mahol wrote: > +Pick median pixel from certain rectangle defined by radius. Is radius the correct term within a rectangle? (Just wondering, I do understand the intent.) > +memset(coarse, 0, sizeof(coarse)); > +memset(fine, 0, sizeof(f

Re: [FFmpeg-devel] [PATCH] avfilter: remove unused private field of AVFilterLink

2019-10-28 Thread Moritz Barsnick
On Fri, Oct 18, 2019 at 14:36:31 +0800, quinkbl...@foxmail.com wrote: > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h > index 3eaa8a4089..3c87f4864a 100644 > --- a/libavfilter/avfilter.h > +++ b/libavfilter/avfilter.h > @@ -572,11 +572,6 @@ struct AVFilterLink { > */ > int

Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a generic filter for image proccessing with dnn networks

2019-10-28 Thread Guo, Yejun
> -Original Message- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Monday, October 28, 2019 8:01 PM > To: Guo, Yejun > Cc: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a > generic filter for image procce

Re: [FFmpeg-devel] [PATCH 2/2] tools/probetest: replace the deprecated API

2019-10-28 Thread Moritz Barsnick
On Sat, Oct 26, 2019 at 22:18:32 +0800, zhongli_...@126.com wrote: > AVInputFormat *fmt = NULL; > +void *fmt_opaque = NULL; > > -while ((fmt = av_iformat_next(fmt))) { > +while ((fmt = av_demuxer_iterate(&fmt_opaque))) { Doesn't this give you (new) warnings? fmt needs to be const

Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a generic filter for image proccessing with dnn networks

2019-10-28 Thread Paul B Mahol
On 10/28/19, Paul B Mahol wrote: > On 10/28/19, Guo, Yejun wrote: >> >> >>> -Original Message- >>> From: Paul B Mahol [mailto:one...@gmail.com] >>> Sent: Monday, October 28, 2019 4:00 PM >>> To: FFmpeg development discussions and patches >>> Cc: Guo, Yejun >>> Subject: Re: [FFmpeg-devel

Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a generic filter for image proccessing with dnn networks

2019-10-28 Thread Paul B Mahol
On 10/28/19, Guo, Yejun wrote: > > >> -Original Message- >> From: Paul B Mahol [mailto:one...@gmail.com] >> Sent: Monday, October 28, 2019 4:00 PM >> To: FFmpeg development discussions and patches >> Cc: Guo, Yejun >> Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing:

Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a generic filter for image proccessing with dnn networks

2019-10-28 Thread Guo, Yejun
> -Original Message- > From: Paul B Mahol [mailto:one...@gmail.com] > Sent: Monday, October 28, 2019 4:00 PM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a > generic filter for image procce

[FFmpeg-devel] [PATCH] avformat/rtsp: fix wrong codec setup for some sdp

2019-10-28 Thread Hyun Yoo
rtsp_st->sdp_payload_type is the first codec in 'm=' tag st->codecpar->id is the first supported codec in 'a=' tag the two is not guaranteed to be same for example when 1) the order between attributes is random(rfc4566 doesn't force it) 2) the first codec is same for 'm=' and 'a=' but it is unsuppo

Re: [FFmpeg-devel] [PATCH V2 4/4] avfilter/vf_dnn_processing: add a generic filter for image proccessing with dnn networks

2019-10-28 Thread Paul B Mahol
On 10/21/19, Guo, Yejun wrote: > This filter accepts all the dnn networks which do image processing. > Currently, frame with formats rgb24 and bgr24 are supported. Other > formats such as gray and YUV will be supported next. The dnn network > can accept data in float32 or uint8 format. And the dnn

Re: [FFmpeg-devel] [PATCH V3] avfilter/vf_bilateral: process command to set the parameter at runtime

2019-10-28 Thread Tao Zhang
ping leozhang 于2019年10月24日周四 下午5:18写道: > > Reviewed-by: Paul B Mahol > Reviewed-by: Jun Zhao > Signed-off-by: leozhang > --- > libavfilter/vf_bilateral.c | 57 > ++ > 1 file changed, 43 insertions(+), 14 deletions(-) > > diff --git a/libavfilter/vf