Re: [FFmpeg-devel] [PATCH 3/5] avcodec/smacker: cleanup on errors in smka_decode_frame()

On 10/10/2019 7:40 PM, Michael Niedermayer wrote: > Fixes: multiple memleaks > Fixes: > 17660/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5689769928949760 > Fixes: > 18064/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5631086809317376 > > Found-by: conti

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

On Sat, Oct 12, 2019 at 06:53:05PM -0300, James Almer wrote: > On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > >>> Fixes: signed integer overflow: 1092624416

Re: [FFmpeg-devel] [PATCH v4 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

On Sat, Oct 12, 2019 at 11:41:53PM +0200, Michael Niedermayer wrote: > On Sat, Oct 12, 2019 at 09:39:14AM +0800, Limin Wang wrote: > > On Fri, Oct 11, 2019 at 08:13:02PM +0200, Michael Niedermayer wrote: > > > On Thu, Oct 10, 2019 at 10:11:10PM +0800, Limin Wang wrote: > > > > On Thu, Oct 10, 2019

Re: [FFmpeg-devel] [PATCH v5] avcodec/v210dec: add the frame and slice threading support

On Sat, Oct 12, 2019 at 11:46:58PM +0200, Michael Niedermayer wrote: > On Sat, Oct 12, 2019 at 06:58:21PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > The multithread is avoid one core cpu is full with other filter like scale > > etc. > > About the performance, the gain is v

Re: [FFmpeg-devel] [PATCH v5] avcodec/v210dec: add the frame and slice threading support

On Sat, Oct 12, 2019 at 07:36:29PM +0800, myp...@gmail.com wrote: > On Sat, Oct 12, 2019 at 6:58 PM wrote: > > > > From: Limin Wang > > > > The multithread is avoid one core cpu is full with other filter like scale > > etc. > > About the performance, the gain is very small, below is my testing f

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

On 10/12/2019 5:47 PM, Michael Niedermayer wrote: > On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: >> On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: >>> Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in >>> type 'int' >>> Fixes: >>> 18045/c

Re: [FFmpeg-devel] [PATCH v5] avcodec/v210dec: add the frame and slice threading support

On Sat, Oct 12, 2019 at 06:58:21PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The multithread is avoid one core cpu is full with other filter like scale > etc. > About the performance, the gain is very small, below is my testing for > performance. > In order to avoid the disk bo

Re: [FFmpeg-devel] [PATCH v4 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

On Sat, Oct 12, 2019 at 09:39:14AM +0800, Limin Wang wrote: > On Fri, Oct 11, 2019 at 08:13:02PM +0200, Michael Niedermayer wrote: > > On Thu, Oct 10, 2019 at 10:11:10PM +0800, Limin Wang wrote: > > > On Thu, Oct 10, 2019 at 01:52:56PM +0200, Michael Niedermayer wrote: > > > > On Tue, Oct 08, 2019

Re: [FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Also fuzz keyframe & disposal flags

On 10/12/2019 5:34 PM, Michael Niedermayer wrote: > This should improve coverage > > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c > index 0047c9eed6..4d0315

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/binkaudio: Check sample rate

On Fri, Oct 11, 2019 at 08:51:54PM +1100, Peter Ross wrote: > On Fri, Oct 11, 2019 at 12:40:07AM +0200, Michael Niedermayer wrote: > > Fixes: signed integer overflow: 1092624416 * 2 cannot be represented in > > type 'int' > > Fixes: > > 18045/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK

[FFmpeg-devel] [PATCH 1/4] tools/target_dec_fuzzer: Also fuzz block_align

This should improve coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index a2c59be318..99e89ab092 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzze

[FFmpeg-devel] [PATCH 3/4] tools/target_dec_fuzzer: Also fuzz codec_tag

This should improve coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 8def3c9015..0047c9eed6 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzze

[FFmpeg-devel] [PATCH 2/4] tools/target_dec_fuzzer: Also fuzz FF_COMPLIANCE_EXPERIMENTAL

This should improve coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 99e89ab092..8def3c9015 100644 --- a/tools/target_dec_fuzzer.c +++ b/t

[FFmpeg-devel] [PATCH 4/4] tools/target_dec_fuzzer: Also fuzz keyframe & disposal flags

This should improve coverage Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 0047c9eed6..4d03151735 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_f

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix filtering of >8 bit data

This is what reference does. Signed-off-by: Paul B Mahol --- libavfilter/vf_libvmaf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 249e50c720..ed3a383709 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix filtering of >8 bit data

This is what reference does. Signed-off-by: Paul B Mahol --- libavfilter/vf_libvmaf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 249e50c720..e071df77c5 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/wmaprodec: Check that the streams channels do not exceed the overall channels

lgtm On 10/12/19, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: > 18075/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5708262036471808 > Fixes: > 18087/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5740627634946048 > > Found-by: continuous f

[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix filtering of >8 bit data

This is what reference does. Signed-off-by: Paul B Mahol --- libavfilter/vf_libvmaf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_libvmaf.c b/libavfilter/vf_libvmaf.c index 249e50c720..e071df77c5 100644 --- a/libavfilter/vf_libvmaf.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 3/3] avcodec/wmaprodec: Check that the streams channels do not exceed the overall channels

Fixes: NULL pointer dereference Fixes: 18075/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5708262036471808 Fixes: 18087/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA1_fuzzer-5740627634946048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/ma

[FFmpeg-devel] [PATCH 2/3] avcodec/vc1dec: Allocate only as much space as is unescaped

Fixes: OOM Fixes: 18137/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1IMAGE_fuzzer-5723834900021248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 4 ++-- 1 file changed, 2

[FFmpeg-devel] [PATCH 1/3] avcodec/vc1_block: Check input in the block decode loops

Fixes: Timeout (196sec -> 2sec) Fixes: 18026/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5640941108461568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 17

Re: [FFmpeg-devel] [PATCH] avfilter/vf_colorconstancy: fix overreads in gauss array

On 10/12/19 11:09 AM, Paul B Mahol wrote: Fixes #8250 Signed-off-by: Paul B Mahol --- libavfilter/vf_colorconstancy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorconstancy.c b/libavfilter/vf_colorconstancy.c index e3bb39e51b..cc081e957f 100644

Re: [FFmpeg-devel] [PATCH] avutil/eval: add sgn()

> Am 12.10.2019 um 11:42 schrieb James Darnley : > >> On 2019-10-11 21:45, Paul B Mahol wrote: >> >> diff --git a/doc/utils.texi b/doc/utils.texi >> index d55dd315c3..4e2e713505 100644 >> --- a/doc/utils.texi >> +++ b/doc/utils.texi >> @@ -920,6 +920,9 @@ corresponding input value will be retur

Re: [FFmpeg-devel] [PATCH] lavf/mpegtsenc: add stream type AVS2

On Sat, Oct 12, 2019 at 10:00 AM hwren wrote: > > From: hwrenx > > Signed-off-by: hwrenx > --- > libavformat/mpegts.h| 1 + > libavformat/mpegtsenc.c | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/libavformat/mpegts.h b/libavformat/mpegts.h > index ecc3d33..78abe72 100644 > --

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: parse sdtp atom and set the pkt disposable flag accordingly

On Mon, Oct 07, 2019 at 10:19:59PM +0100, Derek Buitenhuis wrote: > On 07/10/2019 16:06, Matthieu Bouron wrote: > > Ping. > > > > No objections from me. Pushed (with the patch updating fate squashed into this patch). Thanks, -- Matthieu B. ___ ffmpe

Re: [FFmpeg-devel] [PATCH] avfilter/vf_geq: Use av_clipd() instead of av_clipf()

lgtm On 10/12/19, Michael Niedermayer wrote: > With floats we cannot represent all 32bit integer dimensions > > Signed-off-by: Michael Niedermayer > --- > libavfilter/vf_geq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.

[FFmpeg-devel] [PATCH] avfilter/vf_geq: Use av_clipd() instead of av_clipf()

With floats we cannot represent all 32bit integer dimensions Signed-off-by: Michael Niedermayer --- libavfilter/vf_geq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_geq.c b/libavfilter/vf_geq.c index 91eb9685f9..8b1c7726dc 100644 --- a/libavfilter/vf_ge

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mpjpegdec: fix strict boundary search string

On Thu, Oct 10, 2019 at 11:28:47AM +0200, Moritz Barsnick wrote: > On Wed, Oct 09, 2019 at 16:34:37 +0200, Michael Niedermayer wrote: > > > If you want to support both interpretations, you'd need to search for > > > two different boundaries now. Quite some bloat, if you ask me. I don't > > > know i

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/qdmc: Check input space in qdmc_get_vlc()

On Fri, Oct 11, 2019 at 10:54:18AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_geq: allow user to set interpolation method

On Fri, Oct 11, 2019 at 06:29:45PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 8 > libavfilter/vf_geq.c | 27 +++ > 2 files changed, 35 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 55a8eb

Re: [FFmpeg-devel] [PATCH v5] avcodec/v210dec: add the frame and slice threading support

On Sat, Oct 12, 2019 at 6:58 PM wrote: > > From: Limin Wang > > The multithread is avoid one core cpu is full with other filter like scale > etc. > About the performance, the gain is very small, below is my testing for > performance. > In order to avoid the disk bottleneck, I'll use stream_loop

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Improve streamcopy

On Fri, Oct 11, 2019 at 06:06:58AM +0200, Andreas Rheinhardt wrote: > do_streamcopy() has a packet that gets zero-initialized first, then gets > initialized via av_init_packet() after which some of its fields are > oerwritten again with the actually desired values (unless it's EOF): The > side data

Re: [FFmpeg-devel] [PATCH] avcodec/zmbvenc: Correct offset in buffer

On Thu, Oct 10, 2019 at 01:38:32PM +0200, Tomas Härdin wrote: > tor 2019-10-10 klockan 11:47 +0200 skrev Andreas Rheinhardt: > > zmbvenc allocates a buffer for a picture with padding on all four sides: > > The stride is choosen so large that it already contains padding on the > > right; the height

Re: [FFmpeg-devel] [PATCH v4 2/2] avcodec/v210dec: add the frame and slice threading support

On Fri, Oct 11, 2019 at 09:05:27PM +0200, Michael Niedermayer wrote: > On Sun, Sep 22, 2019 at 11:55:49AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > > The multithread is avoid one core cpu is full with other filter like scale > > etc. > > About the performance, the gain is v

[FFmpeg-devel] [PATCH v5] avcodec/v210dec: add the frame and slice threading support

From: Limin Wang The multithread is avoid one core cpu is full with other filter like scale etc. About the performance, the gain is very small, below is my testing for performance. In order to avoid the disk bottleneck, I'll use stream_loop mode for 10 frame only. ./ffmpeg -y -i ~/Movies/4k_Rec7

Re: [FFmpeg-devel] [PATCH] avutil/eval: add sgn()

On 2019-10-11 21:45, Paul B Mahol wrote: > diff --git a/doc/utils.texi b/doc/utils.texi > index d55dd315c3..4e2e713505 100644 > --- a/doc/utils.texi > +++ b/doc/utils.texi > @@ -920,6 +920,9 @@ corresponding input value will be returned. > @item round(expr) > Round the value of expression @var{e

[FFmpeg-devel] [PATCH] avfilter/vf_colorconstancy: fix overreads in gauss array

Fixes #8250 Signed-off-by: Paul B Mahol --- libavfilter/vf_colorconstancy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_colorconstancy.c b/libavfilter/vf_colorconstancy.c index e3bb39e51b..cc081e957f 100644 --- a/libavfilter/vf_colorconstancy.c +++ b/li