Re: [FFmpeg-devel] [PATCH V2 0/5] add some information for duration issue debug

On Sun, Sep 29, 2019 at 5:28 PM Jun Zhao wrote: > > V2: - split the duration estimate as function, only update the patch 5/5 > the other patches 1-4 same as the V1. > > Jun Zhao (5): > lavf/utils: change the log level to warning if can't get duration > lavf/nutdec: add logging context to

Re: [FFmpeg-devel] [PATCH 8/8] lavfi/vf_*_vaapi: Fix error case

On Mon, Sep 30, 2019 at 12:54 AM Mark Thompson wrote: > > Fixes CID 1452400, 1452416, 1452550, 1452590, 1452760. > --- > libavfilter/vf_deinterlace_vaapi.c | 2 +- > libavfilter/vf_misc_vaapi.c| 2 +- > libavfilter/vf_procamp_vaapi.c | 2 +- > libavfilter/vf_scale_vaapi.c | 2 +-

Re: [FFmpeg-devel] [PATCH V2 5/5] lavf/utils: support duration estimate method dump

On Mon, Sep 30, 2019 at 4:13 AM Michael Niedermayer wrote: > > On Sun, Sep 29, 2019 at 05:27:54PM +0800, Jun Zhao wrote: > > From: Jun Zhao > > > > add new function duration_estimate_name to dump duration estimate > > method, it's will help to debug some duration issue. > > > > Signed-off-by: Jun

Re: [FFmpeg-devel] [PATCH 1/2] mpeg4_unpack_bframes: Avoid allocations and copies of packet structures

Andreas Rheinhardt: > Andreas Rheinhardt: >> 1. Since bd90a2ec, mpeg4_unpack_bframes caches whole packets instead of >> just the pointer to the buffer and the buffer's size in order to be able >> to make use of refcounting to avoid copying of data; this unfortunately >> introduced copies of packet

Re: [FFmpeg-devel] [PATCH V2 5/5] lavf/utils: support duration estimate method dump

On Sun, Sep 29, 2019 at 05:27:54PM +0800, Jun Zhao wrote: > From: Jun Zhao > > add new function duration_estimate_name to dump duration estimate > method, it's will help to debug some duration issue. > > Signed-off-by: Jun Zhao > --- > libavformat/utils.c | 15 ++- > 1 files chan

Re: [FFmpeg-devel] [PATCH V2 2/5] lavf/nutdec: add logging context to log

On Sun, Sep 29, 2019 at 05:27:51PM +0800, Jun Zhao wrote: > From: Jun Zhao > > Add logging context to log, it's will help debuging. > > Signed-off-by: Jun Zhao > --- > libavformat/nutdec.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) LGTM [...] -- Michael GnuPG fing

Re: [FFmpeg-devel] [PATCH 1/8] lavc/cbs_h265: Disallow nonsensically large HVCC NAL arrays

On 9/29/2019 5:01 PM, Mark Thompson wrote: > On 29/09/2019 20:54, James Almer wrote: >> On 9/29/2019 1:45 PM, Mark Thompson wrote: >>> Fixes CID 1419833. >>> --- >>> libavcodec/cbs_h2645.c | 5 + >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h

Re: [FFmpeg-devel] [PATCH 1/8] lavc/cbs_h265: Disallow nonsensically large HVCC NAL arrays

On 29/09/2019 20:54, James Almer wrote: > On 9/29/2019 1:45 PM, Mark Thompson wrote: >> Fixes CID 1419833. >> --- >> libavcodec/cbs_h2645.c | 5 + >> 1 file changed, 5 insertions(+) >> >> diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c >> index 2dc261f7a5..185c458f61 100644 >> ---

Re: [FFmpeg-devel] [PATCH 6/8] lavfi/vf_deshake_opencl: Fix use of uninitialised variable in error case

On 9/29/2019 1:46 PM, Mark Thompson wrote: > Fixes CID 1452756 and 1452757. > --- > libavfilter/vf_deshake_opencl.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_deshake_opencl.c b/libavfilter/vf_deshake_opencl.c > index c959f19475..c914a77d83 100644

Re: [FFmpeg-devel] [PATCH 1/8] lavc/cbs_h265: Disallow nonsensically large HVCC NAL arrays

On 9/29/2019 1:45 PM, Mark Thompson wrote: > Fixes CID 1419833. > --- > libavcodec/cbs_h2645.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c > index 2dc261f7a5..185c458f61 100644 > --- a/libavcodec/cbs_h2645.c > +++ b/libavcodec/cbs_

[FFmpeg-devel] ARM/NEON build error on MSVC after moving to ffmpeg 4.2

Hi, after updating ffmpeg form 4.1.x to n4.2 or n4.2.1, I can no longer build ARM or ARM64 versions of ffmpeg with Visual Studio. I always get build errors on neon assembly code, like this: C:\Source\FFmpegInterop-lukasf\ffmpeg\Output\Windows10\ARM64\libavcodec\aarch64\fft_neon.o.asm(811) : e

Re: [FFmpeg-devel] [PATCH 03/10] avcodec/cbs_av1: Fix potential undefined shift

On 18/09/2019 04:26, Andreas Rheinhardt wrote: > 1 << w is undefined as soon as w is >= 31, as 1 has type int. In the > case of cbs_av1_read_ns, w could potentially even be 32, so one has to > use a 64bit type. > > (None of the current callers ever use arguments that are so large that > the above

[FFmpeg-devel] [PATCH 8/8] lavfi/vf_*_vaapi: Fix error case

Fixes CID 1452400, 1452416, 1452550, 1452590, 1452760. --- libavfilter/vf_deinterlace_vaapi.c | 2 +- libavfilter/vf_misc_vaapi.c| 2 +- libavfilter/vf_procamp_vaapi.c | 2 +- libavfilter/vf_scale_vaapi.c | 2 +- libavfilter/vf_transpose_vaapi.c | 2 +- 5 files changed, 5 inser

[FFmpeg-devel] [PATCH 6/8] lavfi/vf_deshake_opencl: Fix use of uninitialised variable in error case

Fixes CID 1452756 and 1452757. --- libavfilter/vf_deshake_opencl.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_deshake_opencl.c b/libavfilter/vf_deshake_opencl.c index c959f19475..c914a77d83 100644 --- a/libavfilter/vf_deshake_opencl.c +++ b/libavfilter/

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

On 11/09/2019 06:39, Zachary Zhou wrote: > It supports ICL platform. > H2H (HDR to HDR): P010 -> A2R10G10B10 > H2S (HDR to SDR): P010 -> ARGB The input format doesn't have any alpha so the output shouldn't either. Not sure what the first case wants, but the second should be AV_PIX_FMT_0RGB (or

[FFmpeg-devel] [PATCH 7/8] lavfi/vf_deshake_opencl: Avoid propagating uninitialised data

Fixes CID 1452753. --- libavfilter/vf_deshake_opencl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_deshake_opencl.c b/libavfilter/vf_deshake_opencl.c index c914a77d83..0ef015808f 100644 --- a/libavfilter/vf_deshake_opencl.c +++ b/libavfilter/vf_deshake_opencl.c @@ -757,6 +

[FFmpeg-devel] [PATCH 4/8] lavc/vaapi_encode: Fix leak in error case

Fixes CID 1442564. --- libavcodec/vaapi_encode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index 3be9159d37..0d111a574d 100644 --- a/libavcodec/vaapi_encode.c +++ b/libavcodec/vaapi_encode.c @@ -1093,6 +1093,7 @@ int ff_vaapi_encode_s

[FFmpeg-devel] [PATCH 5/8] lavc/vp9_raw_reorder_bsf: Fix operator ordering

Fixes CID 1413024. --- libavcodec/vp9_raw_reorder_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9_raw_reorder_bsf.c b/libavcodec/vp9_raw_reorder_bsf.c index f19b4c7198..e55a358457 100644 --- a/libavcodec/vp9_raw_reorder_bsf.c +++ b/libavcodec/vp9_raw_reorde

[FFmpeg-devel] [PATCH 3/8] lavc/h265_metadata_bsf: Fix parameter ordering

Fixes CID 1452433. --- libavcodec/h265_metadata_bsf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index b3a1fda144..730f7ac28f 100644 --- a/libavcodec/h265_metadata_bsf.c +++ b/libavcodec/h265_metadata_bsf.c @@

[FFmpeg-devel] [PATCH 2/8] lavc/cbs_h2645: Add missing newlines in log messages

--- libavcodec/cbs_h2645.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 185c458f61..47a376aaf2 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -610,7 +610,7 @@ static int cbs_h2645_split_fragment(C

[FFmpeg-devel] [PATCH 1/8] lavc/cbs_h265: Disallow nonsensically large HVCC NAL arrays

Fixes CID 1419833. --- libavcodec/cbs_h2645.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/cbs_h2645.c b/libavcodec/cbs_h2645.c index 2dc261f7a5..185c458f61 100644 --- a/libavcodec/cbs_h2645.c +++ b/libavcodec/cbs_h2645.c @@ -695,7 +695,12 @@ static int cbs_h2645_split_fragm

Re: [FFmpeg-devel] [PATCH] avcodec/fitsdec: fix use of uninitialised values

On 9/29/2019 12:38 PM, Michael Niedermayer wrote: > On Sat, Sep 28, 2019 at 11:12:08PM -0300, James Almer wrote: >> header.data_max and header.data_min are not necessarely set on all decoding >> scenarios. >> >> Fixes a Valgrind reported regression since >> cfa193779103c97bbfc28273a0ab12c114b6786

Re: [FFmpeg-devel] [PATCH 3/5] tools/target_dec_fuzzer: Adjust VP7 threshold

On Sun, Sep 29, 2019 at 03:34:33PM +1000, Peter Ross wrote: > On Sun, Sep 29, 2019 at 01:53:43AM +0200, Michael Niedermayer wrote: > > Fixes: Timeout (110sec -> 10sec) > > Fixes: > > 17705/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VP7_fuzzer-5765834135306240 > > > > Found-by: continuous f

Re: [FFmpeg-devel] [PATCH] avcodec/fitsdec: fix use of uninitialised values

On Sat, Sep 28, 2019 at 11:12:08PM -0300, James Almer wrote: > header.data_max and header.data_min are not necessarely set on all decoding > scenarios. > > Fixes a Valgrind reported regression since > cfa193779103c97bbfc28273a0ab12c114b6786d. > > Signed-off-by: James Almer > --- > libavcodec/

[FFmpeg-devel] [PATCH v2 1/3] avfilter/vf_scenechangedetect: add filter to detect scene change

From: Limin Wang Signed-off-by: Limin Wang --- Please provide a comment to add a new filter for scene change detection to avoid multiple calculations of mafd in the filter chain. The filter can avoid duplication code also for I am writing a new filter to synchronize frames that require scene ch

Re: [FFmpeg-devel] [PATCH v1 1/2] avformat/libsrt: change tlpktdrop, nakreport, messageapi options to boolean type

ping. On Fri, Sep 20, 2019 at 07:17:27PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/libsrt.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c > index b5568

[FFmpeg-devel] [PATCH v2 3/3] avfilter/vf_minterpolate: if metadata lavfi.scd.mafd exists, we'll use it first

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_minterpolate.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_minterpolate.c index b0bb238ade..db3d7d4ca3 100644 --- a/libavfilter/vf_minterpolate.

[FFmpeg-devel] [PATCH v2 2/3] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_framerate.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c index 06e463e4d7..d7ae1ae850 100644 --- a/libavfilter/vf_framerate.c +++ b/libav

[FFmpeg-devel] [PATCH v2 4/4] fate: add scenechangedetect metadata test

From: Limin Wang Signed-off-by: Limin Wang --- tests/fate/filter-video.mak | 6 ++ tests/ref/fate/filter-metadata-scenechangedetect | 11 +++ 2 files changed, 17 insertions(+) create mode 100644 tests/ref/fate/filter-metadata-scenechangedetect diff --git a/te

[FFmpeg-devel] [PATCH] avfilter: add scroll video filter

Signed-off-by: Paul B Mahol --- doc/filters.texi | 20 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_scroll.c | 200 +++ 4 files changed, 222 insertions(+) create mode 100644 libavfilter/vf_scroll.c diff --g

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: enable vp9 encoder

1. must enable low_power mode since just VDENC can be supported by iHD driver right now 2. Coding option1 and extra_data are not supported by MSDK 3. IVF header will be inserted in MSDK by default, but it is not needed for FFmpeg, so disable it. Signed-off-by: Zhong Li --- configure

[FFmpeg-devel] [PATCH 2/2] lavc/qsv: force internal allocator for MFX_FOURCC_VP9_SEGMAP surface

Return MFX_ERR_UNSUPPORTED for MFX_FOURCC_VP9_SEGMAP to force internal allocator. See https://github.com/Intel-Media-SDK/MediaSDK/issues/762 for more detail Signed-off-by: Zhong Li Signed-off-by: Haihao Xiang --- libavcodec/qsv.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/

[FFmpeg-devel] [PATCH V2 4/5] lavf/utils: Cosmetics: fix indentation for estimate_timings

From: Jun Zhao fix indentation for estimate_timings when dump start_time/duartion. Signed-off-by: Jun Zhao --- libavformat/utils.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 9d69e3a..112d19b 100644 --- a/libavfo

[FFmpeg-devel] [PATCH V2 1/5] lavf/utils: change the log level to warning if can't get duration

From: Jun Zhao change the log level to warning if can't get duration, it's will help to debug some duration issue Signed-off-by: vacingfang Signed-off-by: Jun Zhao --- libavformat/utils.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavfo

[FFmpeg-devel] [PATCH V2 3/5] lavf/utils: correct the duration estimation method for nut demuxer

From: Jun Zhao in fact, nut demuxer use the PTS for duration estimation. Signed-off-by: Jun Zhao --- libavformat/utils.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 07f02a7..9d69e3a 100644 --- a/libavformat/utils

Re: [FFmpeg-devel] [PATCH, v3] lavc/qsvdec: Add GPU-accelerated memory copy support

> +static int ff_qsv_get_continuous_buffer(AVCodecContext *avctx, AVFrame > +*frame, AVBufferPool *pool) { > +int ret = 0; > + > +ff_decode_frame_props(avctx, frame); > + > +frame->width = avctx->width; > +frame->height = avctx->height; > +frame->linesize[0] = FFALIGN

[FFmpeg-devel] [PATCH V2 0/5] add some information for duration issue debug

V2: - split the duration estimate as function, only update the patch 5/5 the other patches 1-4 same as the V1. Jun Zhao (5): lavf/utils: change the log level to warning if can't get duration lavf/nutdec: add logging context to log lavf/utils: correct the duration estimation method for

[FFmpeg-devel] [PATCH V2 2/5] lavf/nutdec: add logging context to log

From: Jun Zhao Add logging context to log, it's will help debuging. Signed-off-by: Jun Zhao --- libavformat/nutdec.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 979cb9a..2b5adcb 100644 --- a/libavformat/nutdec.

[FFmpeg-devel] [PATCH V2 5/5] lavf/utils: support duration estimate method dump

From: Jun Zhao add new function duration_estimate_name to dump duration estimate method, it's will help to debug some duration issue. Signed-off-by: Jun Zhao --- libavformat/utils.c | 15 ++- 1 files changed, 14 insertions(+), 1 deletions(-) diff --git a/libavformat/utils.c b/li

[FFmpeg-devel] [PATCH, v3] lavc/qsvdec: Add GPU-accelerated memory copy support

GPU copy enables or disables GPU accelerated copying between video and system memory. This may lead to a notable performance improvement. Memory must be sequent and aligned with 128x64. CMD: ffmpeg -init_hw_device qsv=hw -filter_hw_device hw -c:v h264_qsv -gpu_copy on -i input.

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: remove consistency check of depth for each component

Please ignore this patch, will send a new one. > -Original Message- > From: ffmpeg-devel On Behalf Of > Linjie Fu > Sent: Tuesday, September 24, 2019 17:29 > To: ffmpeg-devel@ffmpeg.org > Cc: Fu, Linjie > Subject: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: remove consistency > check of de

[FFmpeg-devel] [PATCH] lavfi/normalize: remove the unused pointer

Signed-off-by: Zhong Li --- libavfilter/vf_normalize.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavfilter/vf_normalize.c b/libavfilter/vf_normalize.c index 48eea59..d5cb536 100644 --- a/libavfilter/vf_normalize.c +++ b/libavfilter/vf_normalize.c @@ -143,14 +143,12 @@ static void nor

[FFmpeg-devel] [PATCH] lavc/qsv: fix a memory leak in ff_qsv_set_display_handle()

Reported-by: Linjie Fu Signed-off-by: Zhong Li --- libavcodec/qsv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c index 994c9eb..a43f0d5 100644 --- a/libavcodec/qsv.c +++ b/libavcodec/qsv.c @@ -838,6 +838,8 @@ int ff_qsv_close_internal_session(QSVSessi

Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvdec: Add GPU-accelerated memory copy support

> > > +static int ff_qsv_get_continuous_buffer(AVCodecContext *avctx, > > AVFrame > > > +*frame, AVBufferPool *pool) { > > > +int ret = 0; > > > + > > > +ff_decode_frame_props(avctx, frame); > > > + > > > +frame->width = avctx->width; > > > +frame->height = avctx->height;

Re: [FFmpeg-devel] [PATCH, v2] lavc/qsvdec: Add GPU-accelerated memory copy support

> -Original Message- > From: Li, Zhong > Sent: Sunday, September 29, 2019 11:57 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: ChaoX A Liu ; Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH, v2] lavc/qsvdec: Add GPU-accelerated > memory copy support > > > From: