Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-26 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Friday, September 27, 2019 11:27 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq > > On 9/27/2019 12:25 AM, Fu, Ting wrote: > > > > > >> -Ori

[FFmpeg-devel] [PATCH, v2] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-26 Thread Linjie Fu
VA_RT_FORMAT describes the desired sampling format for surface. Add vaapi_format_map support for new pixel formats. Signed-off-by: Linjie Fu --- This patch is part of the HEVC Rext support for qsv and vaapi, refined and resent separately. libavutil/hwcontext_vaapi.c | 7 +++ 1 file changed

[FFmpeg-devel] [PATCH, v2] lavc/qsvdec: Add GPU-accelerated memory copy support

2019-09-26 Thread Linjie Fu
GPU copy enables or disables GPU accelerated copying between video and system memory. This may lead to a notable performance improvement. Memory must be sequent and aligned with 128x64. (first introduced in FFmpeg 3.3.1) CMD: ffmpeg -init_hw_device qsv=hw -filter_hw_device hw -c:v h264_qsv

Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-26 Thread James Almer
On 9/27/2019 12:25 AM, Fu, Ting wrote: > > >> -Original Message- >> From: ffmpeg-devel On Behalf Of James >> Almer >> Sent: Thursday, September 26, 2019 11:20 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq >> >> On 9/26/

Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-26 Thread Fu, Ting
> -Original Message- > From: ffmpeg-devel On Behalf Of James > Almer > Sent: Thursday, September 26, 2019 11:20 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq > > On 9/26/2019 11:43 AM, Andreas Rheinhardt wrote: > > Ting

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-09-26 Thread Jun Li
On Fri, Sep 20, 2019 at 9:46 PM Jun Li wrote: > > On Sat, Sep 14, 2019 at 2:06 PM Jun Li wrote: > >> >> >> On Tue, Sep 10, 2019 at 12:16 PM Jun Li wrote: >> >>> >>> >>> On Tue, Sep 10, 2019 at 12:12 PM Jun Li wrote: >>> Fix #7637 One empty/end sample is created and inserted between t

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-09-26 Thread Aman Gupta
On Sat, Sep 7, 2019 at 11:39 AM Marton Balint wrote: > > > On Wed, 4 Sep 2019, Anthony Delannoy wrote: > > > Hi > > > > I'm still interested to have those three commits merged (update in > attachments). > > Ok, below are some more comments. > > > > > But I'd like to see data decoder in the future

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-26 Thread William Martin
I don't think so. The existing 'strict' option is more general and touches lots of things in encoding/decoding. The new option is very narrow in scope. The existing 'strict' and the new 'rtmp_strict_paths` don't have anything to do with each other - in fact it would be quite possible that a user mi

Re: [FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 10:04:44AM +0200, Paul B Mahol wrote: > Why this does not set dirty for all decoding cases? dirty is set for c->current_frame, so cases which write only into that do not need an explicit case. But maybe i forgot something ? Thanks [...] -- Michael GnuPG fingerprint

[FFmpeg-devel] [PATCH 4/5] avcodec/smacker: cleanup on errors in smka_decode_frame()

2019-09-26 Thread Michael Niedermayer
Fixes: multiple memleaks Fixes: 17660/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-5689769928949760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/smacker.c | 30

[FFmpeg-devel] [PATCH 5/5] avcodec/flicvideo: Use bytestream2_get_buffer() in flic_decode_frame_15_16BPP() for FLI_COPY

2019-09-26 Thread Michael Niedermayer
Fixes: Timeout(103sec -> 3sec) Fixes: 17678/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5715436989054976 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flicvideo.c | 4

[FFmpeg-devel] [PATCH 3/5] tools/target_dec_fuzzer: Adjust threshold for EATGV

2019-09-26 Thread Michael Niedermayer
Fixes: Timeout (26sec -> 9sec) Fixes: 17645/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGV_fuzzer-5717065922510848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

[FFmpeg-devel] [PATCH 1/5] avcodec/scpr: Check minimum size of type 17

2019-09-26 Thread Michael Niedermayer
Improves: Timeout (85sec -> 46sec) Improves: 17644/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5715704283660288 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/scpr.c | 3 +++

[FFmpeg-devel] [PATCH 2/5] tools/target_dec_fuzzer: Adjust threshold for SCPR

2019-09-26 Thread Michael Niedermayer
Fixes: Timeout (46sec -> 7sec) Fixes: 17644/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SCPR_fuzzer-5715704283660288 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 +

Re: [FFmpeg-devel] [PATCH 12/15] avcodec/exr: Fix undefined left shifts of negative numbers

2019-09-26 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:03:07AM +0200, Andreas Rheinhardt wrote: > Affected the FATE-tests exr-rgb-scanline-pxr24-half-uint32-13x9 and > exr-rgb-scanline-pxr24-uint32. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/exr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will

Re: [FFmpeg-devel] [PATCH 04/12] avcodec/hcom: Check that there are dictionary entries

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:55:12AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is what and why we do it that matters, not just one of them. signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 12/12] avcodec/4xm: Check index in decode_i_block() also in the path where its not used.

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 10:07:29AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. signature.asc Desc

Re: [FFmpeg-devel] [PATCH 11/12] avcodec/loco: Check for end of input in the first line

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 10:05:38AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you think the mosad wants you dead since a long time then you are either wrong or dead since a long time. signature.asc Desc

Re: [FFmpeg-devel] [PATCH 08/12] avcodec/atrac3: Check block_align

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:56:51AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control.

Re: [FFmpeg-devel] [PATCH 07/12] tools/target_dec_fuzzer: Print samples decoded like pixels

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:53:19AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable code and code with gotos often but not always is le

Re: [FFmpeg-devel] [PATCH 06/12] tools/target_dec_fuzzer: Check number of all samples decoded too, like max pixels

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:56:26AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be right in matters on which the established authorities are wrong. -- Voltaire signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 05/12] avcodec/alsdec: Avoid dereferencing context pointer in inner interleave loop

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:55:59AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB You can kill me, but you cannot change the truth. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 03/12] avcodec/fitsdec: Prevent division by 0 with huge data_max

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:52:48AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made as simple as possible, but not simpler. -- Albert Einstein signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH 02/12] avcodec/dstdec: Fix integer overflow in samples_per_frame computation

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 09:45:52AM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship: All citizens are under surveillance, all their steps and actions recorded, for the politicians to enforce control.

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/g729_parser: Check block_size

2019-09-26 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:39:10PM +0200, Paul B Mahol wrote: > lgtm will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I am the wisest man alive, for I know one thing, and that is that I know nothing. -- Socrates signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sbcdec: Initilaize nubmer of channels

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 03:08:59PM +0200, Moritz Barsnick wrote: > > please fix typo in commit message, nubmer will do > > and "Initilaize" -> "Initialize". will do too thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He w

[FFmpeg-devel] [PATCH] doc/ffmpeg: -timelimit is in user time

2019-09-26 Thread Lou Logan
Signed-off-by: Lou Logan --- Some users were expecting real/wall-clock time. doc/ffmpeg.texi | 2 +- fftools/ffmpeg_opt.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index 1da18d9d0b..92337d 100644 --- a/doc/ffmpeg.texi +++ b/

Re: [FFmpeg-devel] [PATCH] aformat/movenc: add missing padding to output track extradata

2019-09-26 Thread James Almer
On 9/26/2019 3:04 PM, Thierry Foucu wrote: > On Wed, Sep 25, 2019 at 10:30 AM James Almer wrote: > >> Fixes ticket #8183. >> >> Signed-off-by: James Almer >> --- >> libavformat/movenc.c | 15 ++- >> 1 file changed, 10 insertions(+), 5 deletions(-) >> >> diff --git a/libavformat/move

[FFmpeg-devel] [PATCH v5 0/3] hevc_mp4toannexb: Insert correct parameter sets

2019-09-26 Thread Andriy Gelman
Changes to v5: - Remove -y from new fate tests so that they are in the same format as other md5 tests. And removed proposed change to existing fate test. -- Andriy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mail

[FFmpeg-devel] [PATCH v5 2/3] fate: Add tests for hevc_mp4annexb bsf

2019-09-26 Thread Andriy Gelman
From: Andriy Gelman Test hevc-mp4annexb-pps: Test contains 64 PPS that are signalled in extradata. Different PPS are referenced by the VCL nal units during the mp4 to annexb conversion. Test hevc-mp4annexb-sps: Access units contain PPS that reference different cached SPS nal units. --- tests/fa

[FFmpeg-devel] [PATCH v5 1/3] hevc_mp4toannexb: Insert correct parameter sets before IRAP

2019-09-26 Thread Andriy Gelman
From: Andriy Gelman Fixes #7799 Currently, the mp4toannexb filter always inserts the same extradata at the start of the first IRAP unit. As in ticket #7799, this can lead to decoding errors if modified parameter sets are signalled in-band. This commit keeps track of the VPS/SPS/PPS parameter se

Re: [FFmpeg-devel] [PATCH 2/2] [monvenc] Add extra padding when allocating trk->vos_data

2019-09-26 Thread Thierry Foucu
On Thu, Sep 26, 2019 at 11:00 AM James Almer wrote: > On 9/26/2019 2:58 PM, Thierry Foucu wrote: > > trk->vos_data is mostly used to store the extradata from the codec. > > Most encoder when storing their extradata, are allocating with padding. > > But the current code was ignoring the padding, w

[FFmpeg-devel] [PATCH v5 3/3] hevc_mp4toannexb: Parse extradata directly from HVCC format

2019-09-26 Thread Andriy Gelman
From: Andriy Gelman Since the original extradata is in HVCC format, there is no need to segment the output extradata into nal units. --- libavcodec/hevc_mp4toannexb_bsf.c | 66 --- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/libavcodec/hevc_mp4toan

Re: [FFmpeg-devel] [PATCH] aformat/movenc: add missing padding to output track extradata

2019-09-26 Thread Thierry Foucu
On Wed, Sep 25, 2019 at 10:30 AM James Almer wrote: > Fixes ticket #8183. > > Signed-off-by: James Almer > --- > libavformat/movenc.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index c824ff5ba1..e328387

Re: [FFmpeg-devel] [PATCH 2/2] [monvenc] Add extra padding when allocating trk->vos_data

2019-09-26 Thread James Almer
On 9/26/2019 2:58 PM, Thierry Foucu wrote: > trk->vos_data is mostly used to store the extradata from the codec. > Most encoder when storing their extradata, are allocating with padding. > But the current code was ignoring the padding, which could causes > heap-buffer-overflow > --- > libavformat/

[FFmpeg-devel] [PATCH 2/2] [monvenc] Add extra padding when allocating trk->vos_data

2019-09-26 Thread Thierry Foucu
trk->vos_data is mostly used to store the extradata from the codec. Most encoder when storing their extradata, are allocating with padding. But the current code was ignoring the padding, which could causes heap-buffer-overflow --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [FFmpeg-devel] [PATCH v4 7/9] avformat/utils: Avoid copying packets unnecessarily

2019-09-26 Thread James Almer
On 9/20/2019 5:39 PM, Andreas Rheinhardt wrote: > Up until now, read_frame_internal in avformat/utils.c uses a spare > packet on the stack that serves no real purpose: At no point in this > function is there a need for another packet besides the packet destined > for output: > 1. If the packet does

Re: [FFmpeg-devel] [PATCH v6] doc/filters: add 4x4 layout example for xstack filter

2019-09-26 Thread Gyan
On 26-09-2019 08:27 PM, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 55 --- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filt

Re: [FFmpeg-devel] [PATCH 09/15] avcodec/ffv1enc: Fix out-of-bounds-array access

2019-09-26 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:03:04AM +0200, Andreas Rheinhardt wrote: > libavcodec/ffv1enc.c accessed an array of uint8_t [32] via array[0][j] > in order to loop over all the uint8_t in this array of arrays. Of course > this implied an out-of-bounds access for array[0] and UBSan complained > about th

[FFmpeg-devel] [PATCH 2/3] swscale/output: Correct Alpha in yuv2ya16_X_c_template()

2019-09-26 Thread Michael Niedermayer
Untested, no testcase Signed-off-by: Michael Niedermayer --- libswscale/output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index 60a9bdfe82..ed8a69287c 100644 --- a/libswscale/output.c +++ b/libswscale/output.c @@ -905,7 +9

[FFmpeg-devel] [PATCH 3/3] swscale/output: Avoid 64bit in Alpha in yuv2ya16_X_c_template()

2019-09-26 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libswscale/output.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libswscale/output.c b/libswscale/output.c index ed8a69287c..d192ea854b 100644 --- a/libswscale/output.c +++ b/libswscale/output.c @@ -905,7 +905,7 @@ yuv2ya16_X_c_te

[FFmpeg-devel] [PATCH 1/3] swscale/output: Implement Luma computation from yuv2ya16_X_c_template() without 64bit

2019-09-26 Thread Michael Niedermayer
This also reverts 21838cad2fc44023ad85e35d5c677e2f8d29a0ef The revert is in this commit to avoid 2 fate updates Signed-off-by: Michael Niedermayer --- libswscale/output.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libswscale/output.c b/libswscale/output.c index 0e20a0a

[FFmpeg-devel] [PATCH v4] swscale/swscale: cosmetics

2019-09-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libswscale/swscale.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index b4f958a..4ecfa88 100644 --- a/libswscale/swscale.c +++ b/libswscale/swscale.c @@ -271,7 +271,6 @@ static int swscale(Sw

[FFmpeg-devel] [PATCH v1] avfilter/vf_scale: cosmetics

2019-09-26 Thread lance . lmwang
From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/vf_scale.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index cb42794..41ddec7 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@

Re: [FFmpeg-devel] [FFmpeg-cvslog] swscale/output: fix signed integer overflow for ya16

2019-09-26 Thread Michael Niedermayer
On Thu, Sep 26, 2019 at 01:57:52PM +, Paul B Mahol wrote: > ffmpeg | branch: master | Paul B Mahol | Thu Sep 26 > 15:55:03 2019 +0200| [21838cad2fc44023ad85e35d5c677e2f8d29a0ef] | committer: > Paul B Mahol > > swscale/output: fix signed integer overflow for ya16 > > Fixes #7666. > > > htt

Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-26 Thread James Almer
On 9/26/2019 11:43 AM, Andreas Rheinhardt wrote: > Ting Fu: >> Signed-off-by: Ting Fu >> --- >> libavfilter/vf_eq.c | 13 --- >> libavfilter/vf_eq.h | 1 + >> tests/checkasm/Makefile | 1 + >> tests/checkasm/checkasm.c | 3 ++ >> tests/checkasm/checkasm.h | 1 + >> tests/che

[FFmpeg-devel] [PATCH v6] doc/filters: add 4x4 layout example for xstack filter

2019-09-26 Thread lance . lmwang
From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 55 --- 1 file changed, 52 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index e6f8bf0..581a96b 100644 --- a/doc/filters.tex

Re: [FFmpeg-devel] [PATCH V2 1/3] checkasm/vf_eq: add test for vf_eq

2019-09-26 Thread Andreas Rheinhardt
Ting Fu: > Signed-off-by: Ting Fu > --- > libavfilter/vf_eq.c | 13 --- > libavfilter/vf_eq.h | 1 + > tests/checkasm/Makefile | 1 + > tests/checkasm/checkasm.c | 3 ++ > tests/checkasm/checkasm.h | 1 + > tests/checkasm/vf_eq.c| 79 +

Re: [FFmpeg-devel] [PATCH v4] doc/filters: add 4x4 layout example for xstack filter

2019-09-26 Thread Limin Wang
On Thu, Sep 26, 2019 at 04:07:14PM +0530, Gyan wrote: > > > On 26-09-2019 12:22 PM, Limin Wang wrote: > >On Wed, Sep 25, 2019 at 09:26:58PM +0530, Gyan wrote: > >>Ok, the formatting is fine except for one. See below. > >> > >>On 25-09-2019 03:56 AM, lance.lmw...@gmail.com wrote: > >>>From: Limin

[FFmpeg-devel] [PATCH] avcodec/exr: Allow duplicate use of channel indexes

2019-09-26 Thread Michael Niedermayer
Fixes: Ticket #8203 Reported-by: durandal_1707 Signed-off-by: Michael Niedermayer --- libavcodec/exr.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavcodec/exr.c b/libavcodec/exr.c index c12469cc28..29dab36409 100644 --- a/libavcodec/exr.c +++ b/libavcodec/exr.

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: Remove dead code in vps_id check

2019-09-26 Thread James Almer
On 9/26/2019 8:48 AM, Andriy Gelman wrote: > On Sun, 22. Sep 00:17, Andriy Gelman wrote: >> From: Andriy Gelman >> >> Since reading 4 bits always returns a value in the range [0, 15], the >> check for vps_id >= HEVC_MAX_VPS_COUNT, where HEVC_MAX_VPS_COUNT = 16, is >> redundant. >> >> Signed-off-b

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sbcdec: Initilaize nubmer of channels

2019-09-26 Thread Moritz Barsnick
> please fix typo in commit message, nubmer and "Initilaize" -> "Initialize". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.o

Re: [FFmpeg-devel] [PATCH v7] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-09-26 Thread Paul B Mahol
On 8/19/19, Romane Lafon wrote: > This patch extends aphasemeter to detect out of phase or mono sequences in > stereo streams, with its associated documentation. > Sorry, can not apply this. It crashed on uninit() here. Inlink is not longer valid during uninit(), also get_index() function is bad

Re: [FFmpeg-devel] [PATCH 08/11] avformat/movenc: Fix undefined shift

2019-09-26 Thread Paul B Mahol
applied On 9/20/19, Andreas Rheinhardt wrote: > Fixes the movenc FATE-test. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/movenc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index edddfeeb00..ce9fc8c5aa 1

Re: [FFmpeg-devel] [PATCH 06/11] avcodec/pcm: Fix undefined shifts

2019-09-26 Thread Paul B Mahol
applied On 9/20/19, Andreas Rheinhardt wrote: > Fixes the acodec-pcm-u16[lb]e FATE-tests. > > Signed-off-by: Andreas Rheinhardt > --- > Changing the macro for planar decoding is actually unnecessary, as none > of the currently used users of this macro need it. I have nevertheless > done so to mi

Re: [FFmpeg-devel] [PATCH 02/11] avcodec/mpeg12dec: Sanitize start codes earlier

2019-09-26 Thread Paul B Mahol
applied On 9/20/19, Andreas Rheinhardt wrote: > The MPEG-1/2 decoder uses avpriv_find_start_code to search for start > codes and worked with the resulting start code before checking that it > is really a start code of a slice. In particular, if the picture is so > big that a slice_vertical_positi

Re: [FFmpeg-devel] [PATCH 07/11] avcodec/pcm: Cosmetics

2019-09-26 Thread Paul B Mahol
applied On 9/20/19, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/pcm.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c > index d9176732d9..83850cc793 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_ps: Remove dead code in vps_id check

2019-09-26 Thread Andriy Gelman
On Sun, 22. Sep 00:17, Andriy Gelman wrote: > From: Andriy Gelman > > Since reading 4 bits always returns a value in the range [0, 15], the > check for vps_id >= HEVC_MAX_VPS_COUNT, where HEVC_MAX_VPS_COUNT = 16, is > redundant. > > Signed-off-by: Andriy Gelman > --- > libavcodec/hevc_ps.c |

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sbcdec: Initilaize nubmer of channels

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 17609/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5758729319874560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michae

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sbcdec: Initilaize nubmer of channels

2019-09-26 Thread Paul B Mahol
please fix typo in commit message, nubmer On 9/26/19, Paul B Mahol wrote: > lgtm > > On 9/25/19, Michael Niedermayer wrote: >> Fixes: out of array access >> Fixes: >> 17609/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SBC_fuzzer-5758729319874560 >> >> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH v4] doc/filters: add 4x4 layout example for xstack filter

2019-09-26 Thread Gyan
On 26-09-2019 12:22 PM, Limin Wang wrote: On Wed, Sep 25, 2019 at 09:26:58PM +0530, Gyan wrote: Ok, the formatting is fine except for one. See below. On 25-09-2019 03:56 AM, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi

Re: [FFmpeg-devel] Ableton live aiff file

2019-09-26 Thread Adam Johnson
Carl pointed me at an 'abledecoder' repository he found on GitHub. I forked it and added a very basic compile script that works on my machine (I'm not a C(++) developer by day): https://github.com/adamchainz/abledecoder . The decryption there works. It seems there's a key in one of the AIFF chunks

Re: [FFmpeg-devel] Ableton live aiff file

2019-09-26 Thread Paul B Mahol
On 9/20/19, Adam Johnson wrote: > I have some aiff files in my music production library that I'd like to > convert to flac. However they aren't recognized by ffmpeg: > > $ ffmpeg -i Raylon-190-Full.aif > ... > [aiff @ 0x7fc3ce80] unknown or unsupported codec tag: able is not > implemented. Upd

Re: [FFmpeg-devel] [PATCH 11/12] avcodec/loco: Check for end of input in the first line

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: Timeout (85sec -> 0.1sec) > Fixes: > 17634/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5666410809786368 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 12/12] avcodec/4xm: Check index in decode_i_block() also in the path where its not used.

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: signed integer overflow: 2147483644 + 16 cannot be represented in > type 'int' > Fixes: > 16169/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5662570416963584 > Fixes: > 16782/clusterfuzz-testcase-minimi

Re: [FFmpeg-devel] [PATCH 09/12] avcodec/pafvideo: Only clear frame when it was written to

2019-09-26 Thread Paul B Mahol
Why this does not set dirty for all decoding cases? On 9/25/19, Michael Niedermayer wrote: > This avoids unneeded operations and makes the code faster. > > Fixes: Timeout > Fixes: > 15724/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PAF_VIDEO_fuzzer-5750842205929472 > (12sec -> 9sec) > Fixes

Re: [FFmpeg-devel] [PATCH 01/12] avcodec/wmaprodec: get frame during frame decode

2019-09-26 Thread Paul B Mahol
bettter add init cleanup? On 9/25/19, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 17615/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XMA2_fuzzer-5681306024804352 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-

Re: [FFmpeg-devel] [PATCH 08/12] avcodec/atrac3: Check block_align

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 17620/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC3_fuzzer-5086123012915200 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael N

Re: [FFmpeg-devel] [PATCH 05/12] avcodec/alsdec: Avoid dereferencing context pointer in inner interleave loop

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > This makes the decoder faster > > Improves/Fixes: Timeout (22sec -> 20sec) > Testcase: > 17619/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5078510820917248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/

Re: [FFmpeg-devel] [PATCH 06/12] tools/target_dec_fuzzer: Check number of all samples decoded too, like max pixels

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c > index 0dc1854738..6c670d8eb9 100644 > --- a/tools/target_dec

Re: [FFmpeg-devel] [PATCH 04/12] avcodec/hcom: Check that there are dictionary entries

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 17617/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HCOM_fuzzer-5674970478280704 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 07/12] tools/target_dec_fuzzer: Print samples decoded like pixels

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c > index 6c670d8eb9..4af7b26e54 100644 > --- a/tools/t

Re: [FFmpeg-devel] [PATCH 03/12] avcodec/fitsdec: Prevent division by 0 with huge data_max

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 15657/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5738154838982656 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nie

Re: [FFmpeg-devel] [PATCH 02/12] avcodec/dstdec: Fix integer overflow in samples_per_frame computation

2019-09-26 Thread Paul B Mahol
lgtm On 9/25/19, Michael Niedermayer wrote: > Fixes: Timeout (? -> 2ms) > Fixes: > 17616/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DST_fuzzer-5198057947267072 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 01/15] avutil/common: Add macro for left-shifting

2019-09-26 Thread Michael Niedermayer
On Wed, Sep 25, 2019 at 12:02:56AM +0200, Andreas Rheinhardt wrote: > Left shifting a negative integer is undefined, yet often needed. > Therefore add a macro that internally uses multiplication by powers of > two to make it clear that a shift is intended. > > Signed-off-by: Andreas Rheinhardt >

[FFmpeg-devel] [PATCH v5] doc/filters: add 4x4 layout example for xstack filter

2019-09-26 Thread lance . lmwang
From: Limin Wang Reviewed-by: Gyan Signed-off-by: Limin Wang --- doc/filters.texi | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index d0fdf957af..a53f572e10 100644 --- a/doc/filters.texi +++

[FFmpeg-devel] [PATCH] avcodec/tiff: Try to fix subsampling default

2019-09-26 Thread Michael Niedermayer
This ensures the default ycbcr_subsampling is 2 while also ensuring the subsampling values are correct for all pixel formats. This solution while it takes a few lines more code should be more robust Found-by: Skakov Pavel Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 13 +--