Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Paul B Mahol
On 7/22/19, David Bryant wrote: > Hi, > > As I promised late last year, here is a patch to add a WavPack DSD decoder. > > Thanks! > > -David Bryant > > Please correct me if I'm wrong, but why this uses new codec id? Apparently is also copies some logic from other files. __

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-21 Thread Paul B Mahol
On 7/21/19, Michael Niedermayer wrote: > On Sun, Jul 21, 2019 at 10:48:26AM +0200, Paul B Mahol wrote: >> On 7/21/19, Michael Niedermayer wrote: >> > Fixes: Timeout (22 -> 7 sec) >> > Fixes: >> > 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 >> > >> > Found-b

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/vp3: Check that theora is theora

2019-07-21 Thread Reimar Döffinger
On 22.07.2019, at 01:25, Michael Niedermayer wrote: > Fixes: Timeout (2min -> 100ms) > Fixes: > 15366/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5737849938247680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > S

Re: [FFmpeg-devel] [PATCH v4 2/3] lavc/libdavs2.c: fix decoder info level setting

2019-07-21 Thread Reimar Döffinger
On 22.07.2019, at 06:23, hwrenx wrote: > Mapping log level from av_log_level to davs3_log_level_e: > > [AV_LOG_QUIET, AV_LOG_ERROR] => DAVS2_LOG_ERROR > [AV_LOG_WARNING] => DAVS2_LOG_WARNING > [AV_LOG_INFO] => DAVS2_LOG_INFO > [AV_LOG_VERBOSE, AV_LOG_TRACE] => DA

[FFmpeg-devel] [PATCH v4 3/3] lavc/libdavs2.c: reduce memcpy

2019-07-21 Thread hwrenx
Can effectivly improved decoding speed when memcpy becomes a limitation for proccessing high resolution source. Tested under i7-8700k with `ffmpeg -i 7680x4320.avs2 -vsync 0 -f null -` got performance 23fps => 42fps Signed-off-by: hwrenx --- libavcodec/libdavs2.c | 52 +++

[FFmpeg-devel] [PATCH v4 0/3] optimize frame dumping and fix missing start codes

2019-07-21 Thread hwrenx
Version 4: 1. Change info level setting. 2. Remove `Decoder not found` condition. The previous version 2 patches were deprecated for using pointer to itself can be unsafe when release frames. This patch set is mainly about avoiding using memcpy when fetching frame data, and fixed missing

[FFmpeg-devel] [PATCH v4 2/3] lavc/libdavs2.c: fix decoder info level setting

2019-07-21 Thread hwrenx
Mapping log level from av_log_level to davs3_log_level_e: [AV_LOG_QUIET, AV_LOG_ERROR] => DAVS2_LOG_ERROR [AV_LOG_WARNING] => DAVS2_LOG_WARNING [AV_LOG_INFO] => DAVS2_LOG_INFO [AV_LOG_VERBOSE, AV_LOG_TRACE] => DAVS2_LOG_DEBUG in values: [-8, 16] => 3 [17, 24] =>

[FFmpeg-devel] [PATCH v4 1/3] lavc/avs2_parser.c: fix missing start code

2019-07-21 Thread hwrenx
Signed-off-by: hwrenx --- libavcodec/avs2_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c index 1c9b342..dc2fa16 100644 --- a/libavcodec/avs2_parser.c +++ b/libavcodec/avs2_parser.c @@ -23,8 +23,10 @@ #define S

[FFmpeg-devel] [PATCH 2/4] h264_mp4toannexb_bsf: Improve extradata overread checks

2019-07-21 Thread Andreas Rheinhardt
1. Currently during parsing the extradata, h264_mp4toannexb checks for overreads by adding the size of the current unit to the current position pointer and comparing this to the end position of the extradata. But pointer comparisons and pointer arithmetic is only defined if it does not exceed the o

[FFmpeg-devel] [PATCH 3/4] h264_mp4toannexb: Improve overread checks II

2019-07-21 Thread Andreas Rheinhardt
1. Left shifts of negative values are undefined as soon as the sign bit is involved. Therefore make nal_size an uint32_t and drop the check for whether it is < 0. 2. The two checks for overreads (whether the length field is contained in the packet and whether the actual unit is contained in the pac

[FFmpeg-devel] [PATCH 4/4] h264_mp4toannexb_bsf: Try to avoid four byte startcodes

2019-07-21 Thread Andreas Rheinhardt
According to the H.264 specifications, the only NAL units that need to have four byte startcodes in H.264 Annex B format are SPS/PPS units and units that start a new access unit. Before af7e953a, the first of these conditions wasn't upheld as already existing in-band parameter sets would not automa

[FFmpeg-devel] [PATCH 1/4] h264_mp4toannexb: Remove unnecessary check

2019-07-21 Thread Andreas Rheinhardt
There can be at most 31 SPS and 255 PPS in the mp4/Matroska extradata. Given that each has a size of at most 2^16-1, the length of the output derived from these parameter sets can never overflow an ordinary 32 bit integer. So use a simple int instead of uint64_t and remove the unnecessary check. S

Re: [FFmpeg-devel] dash: add descriptor which is useful to the scheme defined by ISO/IEC 23009-1:2014/Amd.2:2015.

2019-07-21 Thread Jeyapal, Karthick
On 7/19/19 1:13 PM, leozhang wrote: > Signed-off-by: leozhang > --- > Removed remarks which are not part of commit message. Thanks reminder > > doc/muxers.texi | 4 > libavformat/dashenc.c | 27 +++ > 2 files changed, 27 insertions(+), 4 deletions(-) > > diff

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-21 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Jean-Baptiste Kempf > Sent: Thursday, July 18, 2019 5:07 PM > To: Nicolas George ; ffmpeg-devel > > Subject: Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG > > On Thu,

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Andreas Rheinhardt
Lynne: > Jul 22, 2019, 12:03 AM by da...@wavpack.com: >> +    for (p0 = 0; p0 < history_bins; ++p0) { >> +    int32_t sum_values; >> +    unsigned char *vp; >> + >> +    for (sum_values = i = 0; i < 256; ++i) >> +    s->summed_probabilities [p0] [i] = sum_values += >> s->probab

Re: [FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread Lynne
Jul 22, 2019, 12:03 AM by da...@wavpack.com: > Hi, > > As I promised late last year, here is a patch to add a WavPack DSD decoder. > > Thanks! > > -David Bryant > > +    unsigned char probabilities [MAX_HISTORY_BINS] [256]; > +    unsigned char *value_lookup [MAX_HISTORY_BINS]; Use uint8_t throu

Re: [FFmpeg-devel] [PATCH] libavfilter: Update derain filter doc.

2019-07-21 Thread Guo, Yejun
> -Original Message- > From: Steven Liu [mailto:l...@chinaffmpeg.org] > Sent: Sunday, July 21, 2019 8:10 PM > To: FFmpeg development discussions and patches > Cc: Steven Liu ; Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH] libavfilter: Update derain filter doc. > > > > > 在 2019年7月2

[FFmpeg-devel] [PATCH 2/2] avcodec/vp3: Check that theora is theora

2019-07-21 Thread Michael Niedermayer
Fixes: Timeout (2min -> 100ms) Fixes: 15366/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-5737849938247680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vp3.c | 2 ++ 1 fil

[FFmpeg-devel] [PATCH 1/2] avcodec/pngdec: consider chunk size in minimal size check

2019-07-21 Thread Michael Niedermayer
assuming each block contains an empty chunk there has to be at least 8 bytes extra. Fixes: 15327/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5676669303521280 Fixes: Timeout (11->5sec) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects

[FFmpeg-devel] avcodec: add a WavPack DSD decoder

2019-07-21 Thread David Bryant
Hi, As I promised late last year, here is a patch to add a WavPack DSD decoder. Thanks! -David Bryant From d80f4fb59e4afec1e2c539391a7b4484f5ae8436 Mon Sep 17 00:00:00 2001 From: David Bryant Date: Sun, 21 Jul 2019 15:43:25 -0700 Subject: [PATCH] avcodec: add a WavPack DSD decoder Signed-off-

Re: [FFmpeg-devel] FFmpeg 4.2

2019-07-21 Thread Michael Niedermayer
On Mon, May 20, 2019 at 08:39:45PM +0200, Michael Niedermayer wrote: > Hi > > Its quite some time since 4.1 so its probably getting time to branch > 4.2. > > If there are any bugs you want fixed in 4.2 its probably a good idea to > fix them soon. > > Are there any suggestions for a name ? > If n

[FFmpeg-devel] [PATCH V1 1/3] lavf/hls: remove redundancy reset_packet() after av_packet_unref()

2019-07-21 Thread Jun Zhao
From: Jun Zhao av_packet_unref have reseted the AVPacket, so don't need to call reset_packet after that. Signed-off-by: Jun Zhao --- libavformat/hls.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 8c12fce..238ebd0 100644

[FFmpeg-devel] [PATCH V1 3/3] lavf/hls: replace the same code logic with ensure_playlist()

2019-07-21 Thread Jun Zhao
From: vacingfang Replace the same code logic with ensure_playlist(), it's will help reusable blocks of code. Reviewed-by: Jun Zhao Signed-off-by: vacingfang --- libavformat/hls.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/libavformat/hls.c b/libavformat/

[FFmpeg-devel] [PATCH V1 2/3] doc/ffmpeg: Document dts_error_threshold option

2019-07-21 Thread Jun Zhao
From: Jun Zhao Document dts_error_threshold option. Signed-off-by: Jun Zhao --- doc/ffmpeg.texi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index cd35eb4..2152e62 100644 --- a/doc/ffmpeg.texi +++ b/doc/ffmpeg.texi @@ -1515,6 +1515

Re: [FFmpeg-devel] [PATCH] libavfilter: Update derain filter doc.

2019-07-21 Thread Steven Liu
> 在 2019年7月21日,19:27,Xuewei Meng 写道: > > Add the usage of tensorflow model in derain filter. Training scripts > as well as scripts for tf/native model generation are provided in the > repository at https://github.com/XueweiMeng/derain_filter.git. > > Signed-off-by: Xuewei Meng > --- > doc/fil

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/aacdec: factorize the adts frame resync code

2019-07-21 Thread Reimar Döffinger
On 21.07.2019, at 02:51, James Almer wrote: > ffmpeg | branch: master | James Almer | Sat Jul 20 > 10:13:08 2019 -0300| [a38eab8b7501440f872ff1af8a0c5482b7b3e532] | committer: > James Almer > > avformat/aacdec: factorize the adts frame resync code > > Signed-off-by: James Almer > >> http:/

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/utils: Check close before calling it

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 10:50:17AM +0200, Paul B Mahol wrote: > LGTM will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No snowflake in an avalanche ever feels responsible. -- Voltaire signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/flicvideo: More strictly check chunk size for FLI_COPY

2019-07-21 Thread Reimar Döffinger
On 19.07.2019, at 21:46, Michael Niedermayer wrote: > On Fri, Jul 19, 2019 at 03:54:19PM +0200, Paul B Mahol wrote: >> On 7/19/19, Michael Niedermayer wrote: >>> On Sat, Jun 22, 2019 at 01:29:36AM +0200, Michael Niedermayer wrote: Fixes: Timeout (40sec -> 13sec) Fixes: 15417/clust

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-21 Thread Reimar Döffinger
On 21.07.2019, at 00:36, Lynne wrote: > Jul 20, 2019, 11:08 PM by mich...@niedermayer.cc: > >> Fixes: Timeout (22 -> 7 sec) >> Fixes: >> 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 >> >> Found-by: continuous fuzzing process >> https://github.com/google/

[FFmpeg-devel] [PATCH] libavfilter: Update derain filter doc.

2019-07-21 Thread Xuewei Meng
Add the usage of tensorflow model in derain filter. Training scripts as well as scripts for tf/native model generation are provided in the repository at https://github.com/XueweiMeng/derain_filter.git. Signed-off-by: Xuewei Meng --- doc/filters.texi | 18 +++--- 1 file changed, 11 in

Re: [FFmpeg-devel] [PATCH] hevc_mp4toannexb: Do not duplicate parameter sets

2019-07-21 Thread Andreas Rheinhardt
Andriy Gelman: > From: Andriy Gelman > > Fixes #7799 > > Currently, the mp4toannexb filter always inserts extradata at the start > of each IRAP unit. This can lead to duplication of parameter sets if the > demuxed packet from mdat atom already contains a version of the > parameters. > > As in t

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 10:48:26AM +0200, Paul B Mahol wrote: > On 7/21/19, Michael Niedermayer wrote: > > Fixes: Timeout (22 -> 7 sec) > > Fixes: > > 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 > > > > Found-by: continuous fuzzing process > > https://github

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vorbisdec: Check vlc for floor0 dec vector offset

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 21, 2019 at 11:27:44AM +0200, Paul B Mahol wrote: > On 7/21/19, Michael Niedermayer wrote: > > On Mon, Jul 08, 2019 at 01:18:04AM +0200, Michael Niedermayer wrote: > >> Fixes: out of array access > >> Fixes: > >> 15649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-572

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries

2019-07-21 Thread Gyan
On 21-07-2019 02:21 PM, Paul B Mahol wrote: On 7/20/19, Gyan wrote: Affected files can now be demuxed. Verified with John Stebbins. FATE passes. Gyan You removed negative check, so not ok. entries is unsigned (in the code as well as in the standard). So the value read from file will be

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vorbisdec: Check vlc for floor0 dec vector offset

2019-07-21 Thread Paul B Mahol
On 7/21/19, Michael Niedermayer wrote: > On Mon, Jul 08, 2019 at 01:18:04AM +0200, Michael Niedermayer wrote: >> Fixes: out of array access >> Fixes: >> 15649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5729191309344768 >> >> Found-by: continuous fuzzing process >> https://gith

Re: [FFmpeg-devel] [PATCH 1/4] tools/target_dec_fuzzer: Free parser in case of avcodec_open2() failure

2019-07-21 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 01:18:02AM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: part of > 15529/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVPX_VP8_fuzzer-5140143700180992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vorbisdec: Check vlc for floor0 dec vector offset

2019-07-21 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 01:18:04AM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5729191309344768 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vorbisdec: amplitude bits can be more than 25 bits

2019-07-21 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 01:18:03AM +0200, Michael Niedermayer wrote: > Fixes: assertion failure, invalid shift > Fixes: > 15583/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5640157484548096 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 5/5] avutil/softfloat_ieee754: Fix odd bit position for exponent and sign in av_bits2sf_ieee754()

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 07, 2019 at 03:18:14PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavutil/softfloat_ieee754.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB T

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/alsdec: fix undefined shift in multiply()

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 07, 2019 at 03:18:11PM +0200, Michael Niedermayer wrote: > Fixes: left shift of negative value -6 > Fixes: > 15564/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5701655938465792 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/p

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/flicvideo: More strictly check chunk size for FLI_COPY

2019-07-21 Thread Paul B Mahol
On 7/19/19, Michael Niedermayer wrote: > On Fri, Jul 19, 2019 at 03:54:19PM +0200, Paul B Mahol wrote: >> On 7/19/19, Michael Niedermayer wrote: >> > On Sat, Jun 22, 2019 at 01:29:36AM +0200, Michael Niedermayer wrote: >> >> Fixes: Timeout (40sec -> 13sec) >> >> Fixes: >> >> 15417/clusterfuzz-tes

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/alsdec: Fix 2 integer overflows

2019-07-21 Thread Michael Niedermayer
On Sun, Jul 07, 2019 at 03:18:10PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 1270564968 + 904828220 cannot be represented > in type 'int' > Fixes: > 15402/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5755426823471104 > > Found-by: continuous fuzzing proc

[FFmpeg-devel] [PATCH 1/3] avcodec/apedec: Fix multiple integer overflows and undefined behaviorin filter_3800()

2019-07-21 Thread Michael Niedermayer
Fixes: left shift of negative value -4 Fixes: signed integer overflow: -15091694 * 167 cannot be represented in type 'int' Fixes: signed integer overflow: 1898547155 + 453967445 cannot be represented in type 'int' Fixes: 15258/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-57590955

[FFmpeg-devel] [PATCH 3/3] avcodec/apedec: Make coeffsA/B uint32_t, this avoids several cases of undefined behavior

2019-07-21 Thread Michael Niedermayer
Changing the type to an unsigned one to avoid many casts was suggested This may be inadequate for fixing the UB on ILP64 Fixes: signed integer overflow: -1418162611 * 383 cannot be represented in type 'int' Fixes: 15547/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-569138490166476

[FFmpeg-devel] [PATCH 2/3] avcodec/apedec: make left/right unsigned to avoid undefined behavior

2019-07-21 Thread Michael Niedermayer
Fixes: signed integer overflow: 755176387 + 1515360583 cannot be represented in type 'int' Fixes: 15506/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5706859232624640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by

Re: [FFmpeg-devel] [PATCH v1] filter select - avoid 2 times rounding

2019-07-21 Thread Paul B Mahol
On 7/20/19, Ulf Zibis wrote: > > Am 20.07.19 um 00:37 schrieb Hendrik Leppkes: >>> $1 The captain is always right. >>> >>> $2 If the captain fails, see $1. >>> >>> 0 against 327 fails in 2500 frames is a "slightly more favorable >>> result". See my last post from 22:23 CEST. >>> >> The entire poin

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-21 Thread Paul B Mahol
On 7/21/19, Michael Niedermayer wrote: > Fixes: Timeout (22 -> 7 sec) > Fixes: > 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Ni

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/apedec: Fix various integer overflows

2019-07-21 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 11:57:00AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -538976267 * 31 cannot be represented in type > 'int' > Fixes: left shift of 65312 by 16 places cannot be represented in type 'int' > Fixes: > 15255/clusterfuzz-testcase-minimized-ffmpeg_AV_CODE

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/apedec: Fix multiple integer overflows in predictor_update_filter()

2019-07-21 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 11:56:58AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -829262115 + -1410750414 cannot be > represented in type 'int' > Fixes: > 15251/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5651742252859392 > > Found-by: continuous fuzzing pr

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries

2019-07-21 Thread Paul B Mahol
On 7/20/19, Gyan wrote: > > Affected files can now be demuxed. Verified with John Stebbins. FATE > passes. > > Gyan > You removed negative check, so not ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/utils: Check close before calling it

2019-07-21 Thread Paul B Mahol
LGTM On 7/21/19, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: > 15733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IDF_fuzzer-5658616977162240 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: M

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/flicvideo: Make line_packets int

2019-07-21 Thread Michael Niedermayer
On Mon, Jul 08, 2019 at 09:04:34AM +0200, Paul B Mahol wrote: > On 7/8/19, Michael Niedermayer wrote: > > On Sat, Jun 22, 2019 at 04:58:37PM +0200, Paul B Mahol wrote: > >> On 6/22/19, Michael Niedermayer wrote: > >> > Fixes: signed integer overflow: -32768 * 196032 cannot be represented > >> > i