Re: [FFmpeg-devel] [PATCH 1/6] avcodec/iff: Add "else" to make code look prettier

2019-07-13 Thread Peter Ross
On Sat, Jul 13, 2019 at 10:25:01PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/iff.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/iff.c b/libavcodec/iff.c > index c6e2359b00..7f1c589d7c 100644 > --- a/libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: avoid divide by 0 when writing adx trailer

2019-07-13 Thread Andriy Gelman
On Sat, 13. Jul 23:10, Andriy Gelman wrote: > On Sun, 14. Jul 00:40, Carl Eugen Hoyos wrote: > > > > > Am 13.07.2019 um 22:50 schrieb Andriy Gelman : > > > > > > From: Andriy Gelman > > > > > > Fixes #7985 > > > > Did you check the patch mentioned there? > > Sorry, I missed that you sent a pa

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: avoid divide by 0 when writing adx trailer

2019-07-13 Thread Andriy Gelman
On Sun, 14. Jul 00:40, Carl Eugen Hoyos wrote: > > > Am 13.07.2019 um 22:50 schrieb Andriy Gelman : > > > > From: Andriy Gelman > > > > Fixes #7985 > > Did you check the patch mentioned there? Sorry, I missed that you sent a patch. I applied it, but get a divide by 0 exception in libavforma

Re: [FFmpeg-devel] [PATCH v3 2/3] lavc/libdavs2.c: change decoder info level

2019-07-13 Thread hwren
At 2019-07-13 21:34:30, "Li, Zhong" wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of hwrenx >> Sent: Friday, July 12, 2019 11:22 PM >> To: ffmpeg-devel@ffmpeg.org >> Subject: [FFmpeg-devel] [PATCH v3 2/3] lavc/libdavs2.c: change decoder info >> level >

Re: [FFmpeg-devel] [PATCH] fate: add hls fmp4 segment type test case

2019-07-13 Thread Steven Liu
Marton Balint 于2019年7月14日周日 上午2:02写道: > > > > On Sat, 13 Jul 2019, Steven Liu wrote: > > > Signed-off-by: Steven Liu > > --- > > tests/fate/hlsenc.mak | 12 +++ > > tests/ref/fate/hls-fmp4 | 198 > > > > 2 files changed, 210 insertions(+) > > cre

Re: [FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-13 Thread Limin Wang
On Sat, Jul 13, 2019 at 07:24:59PM +0200, Marton Balint wrote: > > > On Sat, 13 Jul 2019, lance.lmw...@gmail.com wrote: > > >From: Limin Wang > > > >I have samples failed to detect the freeze frame with the default -60dB > >noise(-40dB is OK to detect), > >after apply the patch, it's ok to dete

[FFmpeg-devel] [PATCH v2] fate: add hls fmp4 segment type test case

2019-07-13 Thread Steven Liu
Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 12 +++ tests/ref/fate/hls-fmp4 | 198 2 files changed, 210 insertions(+) create mode 100644 tests/ref/fate/hls-fmp4 diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index 2a125cd

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: avoid divide by 0 when writing adx trailer

2019-07-13 Thread Carl Eugen Hoyos
> Am 13.07.2019 um 22:50 schrieb Andriy Gelman : > > From: Andriy Gelman > > Fixes #7985 Did you check the patch mentioned there? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

[FFmpeg-devel] [PATCH] avformat/rawenc: avoid divide by 0 when writing adx trailer

2019-07-13 Thread Andriy Gelman
From: Andriy Gelman Fixes #7985 This patch checks that the number of audio channels is not zero when writing the total sample count in adx header. --- libavformat/rawenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rawenc.c b/libavformat/rawenc.c index 993d232b70..bf8537f

[FFmpeg-devel] [PATCH 6/6] avcodec/clearvideo: fix invalid shift in tile size check

2019-07-13 Thread Michael Niedermayer
Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 15631/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CLEARVIDEO_fuzzer-5690110605000704 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nie

[FFmpeg-devel] [PATCH 5/6] avformat/xmv: Make bitrate 64bit

2019-07-13 Thread Michael Niedermayer
Fixes: signed integer overflow: 32 * 538976288 cannot be represented in type 'int' Fixes: 15633/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5752273981931520 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Nieder

[FFmpeg-devel] [PATCH 3/6] avformat/vividas: Check buffer size before allocation

2019-07-13 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 3 +++ 1 file changed

[FFmpeg-devel] [PATCH 1/6] avcodec/iff: Add "else" to make code look prettier

2019-07-13 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/iff.c b/libavcodec/iff.c index c6e2359b00..7f1c589d7c 100644 --- a/libavcodec/iff.c +++ b/libavcodec/iff.c @@ -284,7 +284,7 @@ static int extract_header(AVCodecCo

[FFmpeg-devel] [PATCH 4/6] avformat/vividas: Check if extradata was read successfully

2019-07-13 Thread Michael Niedermayer
Fixes: OOM Fixes: 15575/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5654666781655040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/vividas.c | 7 ++- 1 file changed, 6 insertio

[FFmpeg-devel] [PATCH 2/6] avformat/vividas: Fixes overflow in shift in recover_key()

2019-07-13 Thread Michael Niedermayer
Fixes: left shift of 133 by 24 places cannot be represented in type 'int' Fixes: 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Suggested-by: Reimar Döffinger Signed-

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, mikroh...@gmail.com wrote: From: Jernej Fijacko Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-13 Thread Nicolas George
James Almer (12019-07-13): > > +uint8_t *tmp = av_fast_realloc(ctx->pass_data, &ctx->pass_size, > > + ctx->pass_pos + buf_size); > Just use av_reallocp(). Each call will make the buffer bigger, so you're > not really making use the no-op benefits from av

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-13 Thread James Almer
On 7/9/2019 3:34 PM, Derek Buitenhuis wrote: > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Lots of stuff happened since v3! > > * The C API / library is now in rav1e's main repo, and officially supported. > * rav1e will bump the soname and pkg-c

Re: [FFmpeg-devel] [PATCH] fate: add hls fmp4 segment type test case

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, Steven Liu wrote: Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 12 +++ tests/ref/fate/hls-fmp4 | 198 2 files changed, 210 insertions(+) create mode 100644 tests/ref/fate/hls-fmp4 diff --git a/tests/fate/hlsenc.m

Re: [FFmpeg-devel] [PATCH 4/4] avformat/vividas: Fixes overflow in shift in recover_key()

2019-07-13 Thread Michael Niedermayer
On Sat, Jun 29, 2019 at 05:44:21AM +0200, Reimar Döffinger wrote: > > > On 28.06.2019, at 22:53, Michael Niedermayer wrote: > > > Fixes: left shift of 133 by 24 places cannot be represented in type 'int' > > Fixes: > > 15365/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5716153105645568

Re: [FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang I have samples failed to detect the freeze frame with the default -60dB noise(-40dB is OK to detect), after apply the patch, it's ok to detect. I run the testing with fate-suite sample for your testing: old: no freeze fr

Re: [FFmpeg-devel] [PATCH] avformat: Don't suggest deprecated function

2019-07-13 Thread James Almer
On 7/13/2019 1:48 PM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avformat.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index 734ae54cac..6eb329f13f 100644 > --- a/libavforma

[FFmpeg-devel] [PATCH] avformat: Don't suggest deprecated function

2019-07-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavformat/avformat.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 734ae54cac..6eb329f13f 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@ -175,8 +175,8 @@

[FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-13 Thread lance . lmwang
From: Limin Wang I have samples failed to detect the freeze frame with the default -60dB noise(-40dB is OK to detect), after apply the patch, it's ok to detect. I run the testing with fate-suite sample for your testing: old: no freeze frame detect. with the patch: ./ffmpeg -i fate-suite/svq3/

[FFmpeg-devel] [PATCH v2] libavformat/avio: Fix for the unexpected file close which will cause fd 0 is closed

2019-07-13 Thread lance . lmwang
From: Limin Wang By the code, is_connected is used to check file open or not, so after open_dir is done, we should not set is_connected to 1, it'll cause the function ffurl_closep will invoke the url_close and cause unexpected file close. Signed-off-by: Limin Wang --- libavformat/avio.c | 1

[FFmpeg-devel] [PATCH] fate: add hls fmp4 segment type test case

2019-07-13 Thread Steven Liu
Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 12 +++ tests/ref/fate/hls-fmp4 | 198 2 files changed, 210 insertions(+) create mode 100644 tests/ref/fate/hls-fmp4 diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index 2a125cd

Re: [FFmpeg-devel] [PATCH v3 2/3] lavc/libdavs2.c: change decoder info level

2019-07-13 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of hwrenx > Sent: Friday, July 12, 2019 11:22 PM > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v3 2/3] lavc/libdavs2.c: change decoder info > level > > Signed-off-by: hwrenx > --- > libavcodec/libdavs2.c |

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle

2019-07-13 Thread Jernej
Thanks for the explanation. I sent a new patch with the original commit message (and additional line break). I hope that everything is fine now. Regards, Jernej On Sat, Jul 13, 2019 at 12:45 AM Moritz Barsnick wrote: > On Sat, Jul 13, 2019 at 00:24:29 +0200, mikroh...@gmail.com wrote: > > From:

[FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-13 Thread mikrohard
From: Jernej Fijacko Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD (720x576) resolution which causes them to either rend

Re: [FFmpeg-devel] [PATCH 1/3] tools/target_dec_fuzzer: fix memleak of extradata

2019-07-13 Thread Michael Niedermayer
On Thu, Jul 11, 2019 at 11:34:10AM -0300, James Almer wrote: > On 7/11/2019 9:29 AM, Michael Niedermayer wrote: > > Fixes: memleak > > Fixes: > > 15535/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKER_fuzzer-5692162424963072 > > > > Found-by: continuous fuzzing process > > https://githu

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mpc8: Fixes invalid shift in mpc8_decode_frame()

2019-07-13 Thread Michael Niedermayer
On Thu, Jul 11, 2019 at 07:37:15PM -0300, James Almer wrote: > On 7/11/2019 6:49 PM, Michael Niedermayer wrote: > > Fixes: left shift of negative value -456 > > Fixes: > > 15561/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPC8_fuzzer-5758130404720640 > > > > Found-by: continuous fuzzing pro

[FFmpeg-devel] [PATCH] avformat/hlsenc: use old way for fragment mp4 in HLS PUT method

2019-07-13 Thread Steven Liu
fix ticket: 8015 Reported-by: Jun Zhao Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 4abc728a89..2ade6723f9 100644 --- a/libavformat/hlsenc.c ++

Re: [FFmpeg-devel] [PATCH] libavfilter: add photosensitivity filter

2019-07-13 Thread Paul B Mahol
On 7/13/19, Michael Niedermayer wrote: > On Sat, Jul 13, 2019 at 09:32:38AM +0200, Paul B Mahol wrote: >> On 7/13/19, Michael Niedermayer wrote: >> > On Fri, Jul 12, 2019 at 11:26:34AM +0200, Paul B Mahol wrote: >> >> From: Vladimir Panteleev >> >> >> >> Signed-off-by: Paul B Mahol >> >> --- >>

Re: [FFmpeg-devel] [PATCH 3/4] tools/target_dec_fuzzer: Remove redundant av_free()

2019-07-13 Thread Michael Niedermayer
On Thu, Jul 11, 2019 at 11:49:39PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > tools/target_dec_fuzzer.c | 2 -- > 1 file changed, 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB What does censorship

Re: [FFmpeg-devel] [PATCH] libavfilter: add photosensitivity filter

2019-07-13 Thread Michael Niedermayer
On Sat, Jul 13, 2019 at 09:32:38AM +0200, Paul B Mahol wrote: > On 7/13/19, Michael Niedermayer wrote: > > On Fri, Jul 12, 2019 at 11:26:34AM +0200, Paul B Mahol wrote: > >> From: Vladimir Panteleev > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> doc/filters.texi | 20 ++ >

[FFmpeg-devel] [PATCH V1] lavf/hlsenc: fix hls muxer time drifts from the actual clock time

2019-07-13 Thread Jun Zhao
From: Jun Zhao fix hls muxer time drifts from the actual clock time, based on Pavel Pilar's fix. fix: Ticket7986 Signed-off-by: Pavel Pilar Signed-off-by: Jun Zhao --- libavformat/hlsenc.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/hlsenc.c b

Re: [FFmpeg-devel] [PATCH] libavfilter: add photosensitivity filter

2019-07-13 Thread Paul B Mahol
On 7/13/19, Michael Niedermayer wrote: > On Fri, Jul 12, 2019 at 11:26:34AM +0200, Paul B Mahol wrote: >> From: Vladimir Panteleev >> >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 20 ++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c