[FFmpeg-devel] [PATCH 29/31] vp9_metadata: Update AVCodecParameters during init

2019-07-08 Thread Andreas Rheinhardt
This commit changes vp9_metadata to update the AVCodecParameters to reflect the output bitstream. This brings vp9_metadata in line with what is expected of a bitstream filter. Signed-off-by: Andreas Rheinhardt --- libavcodec/vp9_metadata_bsf.c | 16 1 file changed, 16 insertions

[FFmpeg-devel] [PATCH 31/31] hevc_metadata: Update AVCodecParameters during init

2019-07-08 Thread Andreas Rheinhardt
This commit makes hevc_metadata update the AVCodecParameters during init to bring them in line with the changes to the bitstream. Notice that for field-based HEVC the derived height is the height of a frame, which deviates from current FFmpeg behaviour. Signed-off-by: Andreas Rheinhardt --- I am

[FFmpeg-devel] [PATCH] avfilter/vf_convolution: add x86 SIMD for filter_3x3()

2019-07-08 Thread Ruiling Song
Tested using a simple command (apply edge enhance): ./ffmpeg_g -i ~/Downloads/bbb_sunflower_1080p_30fps_normal.mp4 \ -vf convolution="0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:0 0 0 -1 1 0 0 0 0:5:1:1:1:0:128:128:128" \ -an -vframes 1000 -f null /dev/null The fps increase from 15

[FFmpeg-devel] [PATCH 28/31] vp9_metadata: Improve spec-compliance and warnings

2019-07-08 Thread Andreas Rheinhardt
The earlier version had three deficits: 1. It allowed to set the stream to RGB although this is not allowed when the profile is 0 or 2. 2. If it set the stream to RGB, then it did not automatically set the range to full range; the result was that one got a warning every time a frame with color_conf

[FFmpeg-devel] [PATCH 30/31] h264_metadata: Update AVCodecParameters during init

2019-07-08 Thread Andreas Rheinhardt
This commit makes h264_metadata update the AVCodecParameters during init to align them with the changes at the bitstream level. Signed-off-by: Andreas Rheinhardt --- libavcodec/h264_metadata_bsf.c | 37 +- 1 file changed, 32 insertions(+), 5 deletions(-) diff --g

[FFmpeg-devel] [PATCH 27/31] mpeg2_metadata: Update AVCodecParameters during init

2019-07-08 Thread Andreas Rheinhardt
Otherwise the muxer could add header data that is based on the old AVCodecParameters that contradicts and potentially nullifies the modifications made to the bitstream. This brings mpeg2_metadata in line with what is expected of a bitstream filter. Signed-off-by: Andreas Rheinhardt --- libavcod

[FFmpeg-devel] [PATCH 26/31] av1_metadata: Update codec parameters

2019-07-08 Thread Andreas Rheinhardt
Up until now, this BSF only changed the bitstream and the extradata, not the rest of the AVCodecParameters. The result is that e.g. some muxers use outdated information to write header information that conflicts with (and potentially precedes) the new information at the bitstream level, so that usi

Re: [FFmpeg-devel] [PATCH] configure, cbs_h2645: Remove unneeded golomb dependency

2019-07-08 Thread Mark Thompson
On 08/07/2019 17:38, Andreas Rheinhardt wrote: > This has been forgotten in 44cde38c. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > libavcodec/cbs_h2645.c | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH 12/12] cbs_h264, h264_metadata: Deleting SEI messages never fails

2019-07-08 Thread Mark Thompson
On 08/07/2019 00:14, Andreas Rheinhardt wrote: > ff_cbs_delete_unit never fails if the index of the unit to delete is > valid, as it is with all current callers of the function. So just assert > in ff_cbs_delete_unit that the index is valid and change the return > value to void in order to remove t

[FFmpeg-devel] [PATCH v3] libavcodec/vp9: fix ref-frame size judging method

2019-07-08 Thread Yan Cen
From: yancen There is no need all reference frame demension is valid in libvpx. So this change contains three part: 1. Change each judgement's loglevel from "ERROR" to "WARNING" 2. Make sure at least one of frames that this frame references has valid dimension. 3. All judgements fail would repo

Re: [FFmpeg-devel] [PATCH 0/4] lavd/avfoundation: Support muxed device types

2019-07-08 Thread Thilo Borgmann
Am 04.07.19 um 16:28 schrieb Thilo Borgmann: > Am 30.06.19 um 14:11 schrieb Thilo Borgmann: >> Hi, >> >> some cleanup and $SUBJECT. >> >> Documentation and reindent follows afterwards. > > Will add docs and push with remarks from Moritz soonish - if there are no > more comments coming in. Pushed

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-07-08 Thread Amir Z
Thanks On Sun, Jul 7, 2019 at 3:38 PM Michael Niedermayer wrote: > On Fri, Jun 21, 2019 at 07:15:17AM -0700, Amir Pauker wrote: > > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred > is set > > after the call to ff_h264_execute_decode_slices. This allows the user to > detec

[FFmpeg-devel] [PATCH] configure, cbs_h2645: Remove unneeded golomb dependency

2019-07-08 Thread Andreas Rheinhardt
This has been forgotten in 44cde38c. Signed-off-by: Andreas Rheinhardt --- configure | 4 ++-- libavcodec/cbs_h2645.c | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 7cea9d4d73..4005987409 100755 --- a/configure +++ b/configure @@ -2

[FFmpeg-devel] [PATCH] avcodec/audiotoolboxdec: Fix decoding 24 Bit ALAC

2019-07-08 Thread Davis
"avctx->bits_per_raw_sample" always returns 0. Tested with 24 Bit ALAC. The result is bit-perfect. Fix #7287. --- libavcodec/audiotoolboxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index 5c0a9de8f6..95bf9acc4

[FFmpeg-devel] [PATCH] libavfilter/vf_scale: Ensure scaled video is divisible by n

2019-07-08 Thread Lars Kiesow
This patch adds a new option to the scale filter which ensures that the output resolution is divisible by the given integer when used together with `force_original_aspect_ratio`. This works similar to using `-n` in the `w` and `h` options. This option respects the value set for `force_original_asp

Re: [FFmpeg-devel] [PATCH] Ensure scaled video is divisible by n

2019-07-08 Thread Lars Kiesow
Hi Michael, > commit message should begin with a prefix like > avfilter/vf_scale: ... Thanks for the hint. Will use that. > what does this feature have to do with force_original_aspect_ratio ? > i think it should not be under this if() This really only makes sense when using force_original_asp

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Limin Wang
On Mon, Jul 08, 2019 at 01:52:16PM +0200, Moritz Barsnick wrote: > On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmw...@gmail.com wrote: > > +@item keep_dar > > +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default > > is 0. > ^ > Probably "i

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Paul B Mahol
>> >> Keep DAR of which input i.e. what if the inputs have different DARs? > > I'm using it for comparing two same video quality, it's not general > for all condition anyway. > >> >> The user can already emulate this by cropping inputs befoehand. > Yes, we can use the crop filter to get the same fu

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Limin Wang
On Mon, Jul 08, 2019 at 05:44:06PM +0530, Gyan wrote: > > > On 08-07-2019 04:18 PM, lance.lmw...@gmail.com wrote: > >From: Limin Wang > > > >It's useful to compare two 4K videos quality side by side on 4K TV. > > > >Signed-off-by: Limin Wang > >--- > > doc/filters.texi | 6 ++ > > l

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Paul B Mahol
Not acceptable patch. Please do not merge. On 7/8/19, lance.lmw...@gmail.com wrote: > From: Limin Wang > > It's useful to compare two 4K videos quality side by side on 4K TV. > > Signed-off-by: Limin Wang > --- > doc/filters.texi | 6 ++ > libavfilter/vf_stack.c | 31 ++

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Gyan
On 08-07-2019 04:18 PM, lance.lmw...@gmail.com wrote: From: Limin Wang It's useful to compare two 4K videos quality side by side on 4K TV. Signed-off-by: Limin Wang --- doc/filters.texi | 6 ++ libavfilter/vf_stack.c | 31 ++- 2 files changed, 32 i

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-07-08 Thread Gyan
On 25-04-2019 01:48 PM, Gyan wrote: On 25-04-2019 01:23 PM, Ali KIZIL wrote: There are also Dolby Codecs (ac3 & eac3). Will it also throw error for these codecs ? AC3   is  supported before and after this patch. EAC3 is unsupported before and after this patch. But it's sent to the sa

[FFmpeg-devel] [PATCH v5] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-07-08 Thread Romane Lafon
This patch extends aphasemeter to detect out of phase or mono sequences in stereo streams, with its associated documentation. From 7e2846ac3b4b79a2e9beca845d0f2be7ae6abcdb Mon Sep 17 00:00:00 2001 From: Romane Lafon Date: Mon, 8 Jul 2019 13:51:05 +0200 Subject: [PATCH] avfilter/avf_aphasemeter: Ad

Re: [FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread Moritz Barsnick
On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmw...@gmail.com wrote: > +@item keep_dar > +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default > is 0. ^ Probably "input's". Is screen the correct term here at all? (In three places in the patc

Re: [FFmpeg-devel] [PATCH v4] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-07-08 Thread Romane Lafon
Ok, thanks Le ven. 5 juil. 2019 à 16:54, Devin Heitmueller a écrit : > On Wed, Jul 3, 2019 at 9:34 AM Romane Lafon wrote: > > > > I've added documentation for the extension of aphasemeter filter. > > Also, I'm not sure that "phasing" is the right word to describe the > > detection. > > In some

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

2019-07-08 Thread Limin Wang
Richard Kern, please help to review the patch. On Wed, Jun 26, 2019 at 06:57:59PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Below is the testing ffmpeg command for the setting: > ./ffmpeg -i input.ts -c:v hevc_videotoolbox -color_primaries bt2020 > -colorspace bt2020_ncl -col

[FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

2019-07-08 Thread lance . lmwang
From: Limin Wang It's useful to compare two 4K videos quality side by side on 4K TV. Signed-off-by: Limin Wang --- doc/filters.texi | 6 ++ libavfilter/vf_stack.c | 31 ++- 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/doc/filters.texi b

[FFmpeg-devel] [PATCH] fftools/ffmpeg: fix video frame lost sync for the dual input ts files with audio

2019-07-08 Thread lance . lmwang
From: Limin Wang How to reproduce the problem(use two ts files with audio stream): ffmpeg -i left_w_a.ts -i right_w_a.ts -filter_complex "hstack=inputs=2" -f null - With above command, the audio stream of the second input will be discarded default, however the start_time is initalized from th

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/flicvideo: Make line_packets int

2019-07-08 Thread Paul B Mahol
On 7/8/19, Michael Niedermayer wrote: > On Sat, Jun 22, 2019 at 04:58:37PM +0200, Paul B Mahol wrote: >> On 6/22/19, Michael Niedermayer wrote: >> > Fixes: signed integer overflow: -32768 * 196032 cannot be represented >> > in >> > type 'int' >> > Fixes: >> > 15300/clusterfuzz-testcase-minimized-

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/qdm2: error out of qdm2_fft_decode_tones() before entering endless loop

2019-07-08 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 01:01:03AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483646 + 2 cannot be represented in type > 'int' > Fixes: infinite loop > Fixes: > 15396/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5116605501014016 > > Found-by: continu

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-08 Thread Fu, Linjie
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Yan Wang > Sent: Monday, July 8, 2019 15:54 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate > hw_frames_ctx without destroy va_context > >

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ilbcdec: Simplify use of unsigned and fix more undefined overflows

2019-07-08 Thread Michael Niedermayer
On Mon, Jul 01, 2019 at 12:16:51AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147475672 + 8192 cannot be represented in > type 'int' > Fixes: > 15415/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5712074128228352 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/h264_refs: Also check reference in ff_h264_build_ref_list()

2019-07-08 Thread Michael Niedermayer
On Mon, Jul 01, 2019 at 12:16:50AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 15409/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5758846959616000 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/golomb: Correct the doxy about get_ue_golomb() and errors

2019-07-08 Thread Michael Niedermayer
On Sun, Jun 30, 2019 at 05:55:20PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/golomb.h | 2 ++ > 1 file changed, 2 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Frequently ignored answer

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hq_hqa: Use ff_set_dimensions()

2019-07-08 Thread Michael Niedermayer
On Sun, Jun 30, 2019 at 12:30:15AM +0200, Michael Niedermayer wrote: > Fixes: > 15530/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQ_HQA_fuzzer-5637370344374272 > Fixes: signed integer overflow: 65312 * 65312 cannot be represented in type > 'int' > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/rv10: Fix integer overflow in aspect ratio compare

2019-07-08 Thread Michael Niedermayer
On Fri, Jun 28, 2019 at 10:53:42PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2040 * 1187872 cannot be represented in type > 'int' > Fixes: > 15368/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV20_fuzzer-5681657136283648 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/tta: Limit decoder to 16 channels

2019-07-08 Thread Michael Niedermayer
On Fri, Jun 28, 2019 at 10:53:43PM +0200, Michael Niedermayer wrote: > libtta 2.3 has a limit of 6 channels, so 16 is substantially above the > "official" already > > Fixes: OOM > Fixes: > 15249/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5643988125614080 > > Found-by: continuo

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vaapi_decode: recreate hw_frames_ctx without destroy va_context

2019-07-08 Thread Yan Wang
On 7/8/2019 2:45 PM, Yan Wang wrote: On 7/7/2019 9:49 PM, Fu, Linjie wrote: -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark Thompson Sent: Sunday, July 7, 2019 19:51 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 2/2] lav

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sanm: Optimize fill_frame() with av_memcpy_backptr()

2019-07-08 Thread Michael Niedermayer
On Fri, Jun 28, 2019 at 10:53:44PM +0200, Michael Niedermayer wrote: > Fixes: Timeout (76 sec -> 24 sec) > Fixes: > 15043/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SANM_fuzzer-5699856238116864 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/proje

Re: [FFmpeg-devel] [PATCH 1/4] avformat/vividas: Check for input length in get_v()

2019-07-08 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 02:35:30AM +0200, Michael Niedermayer wrote: > Fixes: out of array read > Fixes: > 15286/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5658245101780992 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signe

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/4xm: Fix signed integer overflows in idct()

2019-07-08 Thread Michael Niedermayer
On Thu, Jun 27, 2019 at 02:35:31AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 20242 * 121095 cannot be represented in type > 'int' > Fixes: > 15310/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5737051745419264 > > Found-by: continuous fuzzing process

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/qdm2: Check checksum_size for 0

2019-07-08 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 01:01:04AM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 15337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5757428949319680 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-07-08 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 02:09:57PM +0200, Moritz Barsnick wrote: > On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote: > > +if (sb + (j + k) / 64 > 29) { > [...] > > if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] > > > coding_method[c

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/svq3: Use ff_set_dimension()

2019-07-08 Thread Michael Niedermayer
On Wed, Jun 26, 2019 at 01:32:32AM +0200, Michael Niedermayer wrote: > Fixes: OOM > Fixes: > 15410/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-5659464805384192 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check ham vs bpp

2019-07-08 Thread Michael Niedermayer
On Sun, Jun 23, 2019 at 10:45:56AM +0200, Michael Niedermayer wrote: > On Sun, Jun 23, 2019 at 06:33:02PM +1000, Peter Ross wrote: > > On Sun, Jun 23, 2019 at 12:30:54AM +0200, Michael Niedermayer wrote: > > > This checks the ham value much stricter and avoids hitting cases which > > > cannot be r