Re: [FFmpeg-devel] [PATCH v2] Add multiple padding method in dnn native

> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Steven Liu > Sent: Wednesday, May 15, 2019 10:38 AM > To: FFmpeg development discussions and patches > Cc: Xuewei Meng > Subject: Re: [FFmpeg-devel] [PATCH v2] Add multiple padding method i

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg: Add support for per frame rotation and flip

On Mon, May 13, 2019 at 2:58 AM Michael Niedermayer wrote: > On Sat, May 11, 2019 at 10:57:01PM -0700, Jun Li wrote: > > On Sat, May 11, 2019 at 10:47 PM Jun Li wrote: > > > > > Fix #6945 > > > Current implementaion for autorotate works fine for stream > > > level rotataion but no support for fr

[FFmpeg-devel] [PATCH v2 1/2] lavu/display: add av_display_rotation_hflip_get and bump version

Add av_display_rotation_hflip_get to get information whether the matrix indicates horizontal flip. --- doc/APIchanges| 3 +++ libavutil/display.c | 14 ++ libavutil/display.h | 14 ++ libavutil/tests/display.c | 8 libavutil/version.h

[FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: add support for per frame rotation and flip

Fix #6945 Current implementaion for autorotate works fine for stream level rotataion but no support for frame level operation and frame flip. This patch is for adding flip support and per frame operations. --- fftools/cmdutils.c | 9 ++--- fftools/cmdutils.h | 2 +- fftools/ffmpeg.c

Re: [FFmpeg-devel] [PATCH v2] Add multiple padding method in dnn native

Xuewei Meng 于2019年5月11日周六 上午11:11写道： > > --- > libavfilter/dnn_backend_native.c | 52 > libavfilter/dnn_backend_native.h | 3 ++ > 2 files changed, 43 insertions(+), 12 deletions(-) > > diff --git a/libavfilter/dnn_backend_native.c > b/libavfilter/dnn_backend_na

[FFmpeg-devel] [PATCH] lavc/vaapi_hevc: extend parameter buffer to ParameterBufferHEVCExtension

Extend ParameterBufferHEVC to ParameterBufferHEVCExtension for both VAPicture and VASlice. Pass Range Extension flags to support the decode for HEVC REXT. Separate the behaviour of ff_vaapi_decode_make_slice_buffer for base and rext to avoid potential regression. Signed-off-by: Fu Linjie --- l

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_scale_cuda: Simplify output plane addressing

Yes, this looks better and should have been this way. Thanks, Yogender -Original Message- From: Philip Langdale Sent: Tuesday, May 14, 2019 8:42 AM To: ffmpeg-devel@ffmpeg.org Cc: Yogender Gupta ; Philip Langdale Subject: [PATCH 3/3] avfilter/vf_scale_cuda: Simplify output plane addres

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

On Wed, May 15, 2019 at 7:01 AM Hendrik Leppkes wrote: > > On Tue, May 14, 2019 at 11:25 PM Adam Richter wrote: > > > > Consider, for example, if you agree that columnization makes this range > > check > > more recognizable in a glance and makes it easier to spot what the bounds > > are > > (th

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Tue, May 14, 2019 at 10:37:03PM +1000, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > > On 12.05.2019, at 08:12, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > > > +int v = 1; > > > +int size; > > > + > > > +d

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

On Tue, May 14, 2019 at 11:25 PM Adam Richter wrote: > > Consider, for example, if you agree that columnization makes this range check > more recognizable in a glance and makes it easier to spot what the bounds are > (the sixteen space indentation is taken from the code in which it appeared): > >

Re: [FFmpeg-devel] [PATCH v2 2/2] tests/fate: Add fate test for timestamp interpolation

Hello, On Tue, 14. May 17:54, Andriy Gelman wrote: > From: Andriy Gelman > > This test verifies that missing timestamps from mpegts are interpolated > for a HEVC stream. > --- > tests/fate/mpegts.mak | 7 ++ > tests/ref/fate/mpegts-probe-interptime | 154 +

[FFmpeg-devel] [PATCH v2 1/2] libavformat/utils: Interpolate missing timestamps in H264 and HEVC when no b-frames observed

From: Andriy Gelman Fixes Ticket #7895. Currently, timestamp interpolation is disabled by default in H264 and HEVC. This creates playback issues when the demuxer does not output a valid timestamp. This patch allows interpolation when no b-frames have been observed during decoding, which fixes p

[FFmpeg-devel] [PATCH v2 2/2] tests/fate: Add fate test for timestamp interpolation

From: Andriy Gelman This test verifies that missing timestamps from mpegts are interpolated for a HEVC stream. --- tests/fate/mpegts.mak | 7 ++ tests/ref/fate/mpegts-probe-interptime | 154 + 2 files changed, 161 insertions(+) create mode 100644 tests

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

Hi Baptiste, Am Di., 14. Mai 2019 um 18:59 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 186 + > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavfo

Re: [FFmpeg-devel] [PATCH] "assert(a && b)" --> "assert(a); assert(b)" for more precise diagnostics, except for libformat

On Sun, May 12, 2019 at 11:16 AM Michael Niedermayer wrote: > > On Sun, May 12, 2019 at 05:58:50PM +0100, Mark Thompson wrote: > > On 12/05/2019 16:24, Adam Richter wrote: > > > This patch separates statements of the form "assert(a && b);" into > > > "assert(a);" and "assert(b);", typically involv

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

On Tue, May 14, 2019 at 10:34 PM Marton Balint wrote: > > > > On Sun, 5 May 2019, Carl Eugen Hoyos wrote: > > > Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : > >> > >> This reverts commit dd06f022b07438d650c82255dff16908ba04244a. > >> > >> Fixes ticket #7871 and reopens ticket #7816. >

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

On Sun, 5 May 2019, Carl Eugen Hoyos wrote: Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : This reverts commit dd06f022b07438d650c82255dff16908ba04244a. Fixes ticket #7871 and reopens ticket #7816. I'll send an alternative patch in a moment. Ping for this, I still think the re

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

On Wed, 8 May 2019, Michael Niedermayer wrote: On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: On Tue, 7 May 2019, Michael Niedermayer wrote: On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I don

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Check input space

On Tue, 14 May 2019 at 20:42, Michael Niedermayer wrote: > Fixes: Timeout (33sec -> 78ms) > Fixes: > 14668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5767073352908800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Sig

[FFmpeg-devel] [PATCH] avcodec/pngdec: Check input space

Fixes: Timeout (33sec -> 78ms) Fixes: 14668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5767073352908800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/pngdec.c | 3 +++ 1 f

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

May 14, 2019, 7:12 PM by one...@gmail.com: > On 5/14/19, Carl Eugen Hoyos <> ceffm...@gmail.com > > > wrote: > >> >> >> >>> Am 14.05.2019 um 19:17 schrieb Lynne <>>> d...@lynne.ee >>> : >>> >>> I've attached the latest version. >>> >> >> This

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On 5/14/19, Carl Eugen Hoyos wrote: > > > >> Am 14.05.2019 um 19:17 schrieb Lynne : > >> I've attached the latest version. > > This patch is still not ok, please do not commit. > I will and you can not stop me. > Carl Eugen > ___ > ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

> Am 14.05.2019 um 19:17 schrieb Lynne : > I've attached the latest version. This patch is still not ok, please do not commit. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsu

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

May 14, 2019, 5:55 PM by one...@gmail.com: > On 5/10/19, Lynne <> d...@lynne.ee > > wrote: > >> Patch updated again. >> Made some more cleanups to the transforms, the tables and the main context. >> API changed again, now the init function populates the function pointer for >

[FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

--- libavformat/Makefile | 2 +- libavformat/avc.c| 186 + libavformat/avc.h| 15 +++ libavformat/hevc.c | 36 +--- libavformat/mxf.h| 1 + libavformat/mxfenc.c | 213 ++- 6 files changed, 372 inser

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

On 5/10/19, Lynne wrote: > Patch updated again. > Made some more cleanups to the transforms, the tables and the main context. > API changed again, now the init function populates the function pointer for > transform. > I decided that having a separate function would encourage bad usage (e.g. > cal

[FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

Fixes bug #7839 https://trac.ffmpeg.org/ticket/7839 Supersedes: #12935 - https://patchwork.ffmpeg.org/patch/12935/ #12872 - https://patchwork.ffmpeg.org/patch/12872/ Regards. A.H. ---From 49aa7d21026051dc353a8658509d2ba81520bf78 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 14 May 201

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: Forward error codes in avio_seek

Michael Niedermayer: > On Tue, May 14, 2019 at 10:49:49AM +0200, Andreas Rheinhardt wrote: >> Signed-off-by: Andreas Rheinhardt >> --- >> libavformat/aviobuf.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) > > do you have some testcase for this ? > > thanks > Honestly, no. I jus

Re: [FFmpeg-devel] How to correctly use init and uninit

Am 19.04.19 um 14:35 schrieb Paul B Mahol: >>> You do not need to use loop filter on single png. >> I need real pictures to prove the correctness of my hacking. The >> smptebars is not appopriate to see errors in the output e.g. from mirroring. >> >>> Use something like this: >>> >>> ffmpeg -f lav

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: Don't modify const strings

On 14-05-2019 06:11 PM, Paul B Mahol wrote: On 5/14/19, Gyan wrote: On 14-05-2019 09:45 AM, Andreas Rheinhardt wrote: b3b7ba62 introduced undefined behaviour: A (non-modifiable) string literal has been assigned to a modifiable string; said string was indeed modified later via av_strtok. Thi

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: Fix compilation for IOS < 11.0 and OSX, < 10.13

$Subject Tested compilation only, sanity test actually using it appreciated. Thanks, Thilo From 104b26ca0eab116dcd49b5f2090067b76b5bfc70 Mon Sep 17 00:00:00 2001 From: Thilo Borgmann Date: Tue, 14 May 2019 15:11:38 +0200 Subject: [PATCH] lavc/videotoolboxenc: Fix compilation for IOS < 11.0 and O

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3enc: Avoid SEEK_END as it is unsupported

James Almer: > On 5/14/2019 8:04 AM, Michael Niedermayer wrote: >> Signed-off-by: Michael Niedermayer >> --- >> libavformat/mp3enc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c >> index dd662f5473..f4814be80e 100644 >>

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: Don't modify const strings

On 5/14/19, Andreas Rheinhardt wrote: > b3b7ba62 introduced undefined behaviour: A (non-modifiable) string > literal has been assigned to a modifiable string; said string was indeed > modified later via av_strtok. > This of course caused compiler warnings because of the discarded > qualifier; thes

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3enc: Avoid SEEK_END as it is unsupported

On 5/14/2019 8:04 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3enc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c > index dd662f5473..f4814be80e 100644 > --- a/libavformat/mp3e

[FFmpeg-devel] [PATCH] avcodec/mss4: Check input size against skip bits

Fixes: Timeout (17sec -> 20ms) Fixes: 14615/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MTS2_fuzzer-5093007763701760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/mss4.c | 8 +---

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

Hello, Andreas Håkon: > Hi, > > A fix for the missing in-band Sequence Headers from the QSV MPEG-2 HW Encoder. > > Regards. > A.H. I know nothing about QSV, but I know a bit about MPEG-2 and have therefore taken a quick look at this: 1. > +if ((p_buf[7] & 0x1) == 1) { >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_stack: Don't modify const strings

On 5/14/19, Gyan wrote: > > > On 14-05-2019 09:45 AM, Andreas Rheinhardt wrote: >> b3b7ba62 introduced undefined behaviour: A (non-modifiable) string >> literal has been assigned to a modifiable string; said string was indeed >> modified later via av_strtok. >> This of course caused compiler warni

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On 5/14/2019 9:37 AM, Peter Ross wrote: > On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: >> On 12.05.2019, at 08:12, Peter Ross wrote: >>> +static int read_mb_value(GetBitContext *gb) >>> +{ >>> +int v = 1; >>> +int size; >>> + >>> +do { >>> +size = 0; >>> +

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

On Sun, May 12, 2019 at 01:24:56PM +0200, Reimar Döffinger wrote: > On 12.05.2019, at 08:12, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > + > > +do { > > +size = 0; > > +if (!get_bits1(gb)) > > +

[FFmpeg-devel] [PATCH 2/2] avformat/mp3enc: Avoid SEEK_END as it is unsupported

Signed-off-by: Michael Niedermayer --- libavformat/mp3enc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index dd662f5473..f4814be80e 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -391,6 +391,7 @@ static void m

[FFmpeg-devel] [PATCH 1/2] avformat/dashenc: use 64bit for handling the return of avio_tell()

The return code is 64bit, so this is more correct, especially in case it actually would be a file of such large size Signed-off-by: Michael Niedermayer --- libavformat/dashenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

po 13. 5. 2019 o 13:42 Daniel Kucera napísal(a): > > From: Daniel Kucera > > Signed-off-by: Daniel Kucera > --- > doc/ffplay.texi | 2 ++ > fftools/ffplay.c | 8 > 2 files changed, 10 insertions(+) > > diff --git a/doc/ffplay.texi b/doc/ffplay.texi > index c305465078..a487c0de8d 10064

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

On 14-05-2019 02:03 PM, Timo Rothenpieler wrote: On 10/05/2019 15:55, Gyan wrote: At present, if the command args passed to drawtext contain any invalid values, ffmpeg may crash or, at best, stop drawing any text. Attached patch gets the filter to continue with existing parameters, if not all

[FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

Hi, A fix for the missing in-band Sequence Headers from the QSV MPEG-2 HW Encoder. Regards. A.H. ---From a0b8525e0ebfd1a3b91bad7a21cc9de5c5a01e0e Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 14 May 2019 11:07:10 +0100 Subject: [PATCH] libavformat/qsvenc: fix mpeg2 missing headers Th

Re: [FFmpeg-devel] [PATCH] avutil: Add missing reference files for pixdesc fate test

On Tue, May 14, 2019 at 07:53:13AM +0200, Andreas Rheinhardt wrote: > Commit cd48318035 added support for NV24 and NV42, including several > fate tests for these formats, but did not include the reference files > for the tests filter-pixdesc-nv24 and filter-pixdesc-nv42. As a result, > these two te

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cinepak: Check available input against encoded buffer size

On Mon, May 13, 2019 at 02:32:11PM +0200, Tomas Härdin wrote: > sön 2019-05-12 klockan 23:21 +0200 skrev Michael Niedermayer: > > Fixes: Timeout (12sec -> 2sec) > > Fixes: > > 14606/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CINEPAK_fuzzer-5738687561728000 > > > > Found-by: continuous fuzz

Re: [FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: Forward error codes in avio_seek

On Tue, May 14, 2019 at 10:49:49AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavformat/aviobuf.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) do you have some testcase for this ? thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF67

[FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: Remove dead check

avio_seek only accepts SEEK_CUR and SEEK_SET (possibly OR'ed with AVSEEK_FORCE) as whence parameter. Therefore the check "whence != SEEK_END || force" is always true and can be removed. Signed-off-by: Andreas Rheinhardt --- libavformat/aviobuf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

[FFmpeg-devel] [PATCH 2/2] avformat/aviobuf: Forward error codes in avio_seek

Signed-off-by: Andreas Rheinhardt --- libavformat/aviobuf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 5c01423a2e..2462b95b16 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -293,8 +293,11 @@ int64_

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: support XAVC long gop

Hi Baptiste, Am Di., 14. Mai 2019 um 00:33 Uhr schrieb Baptiste Coudurier < baptiste.coudur...@gmail.com>: > --- > libavformat/Makefile | 2 +- > libavformat/avc.c| 186 + > libavformat/avc.h| 15 +++ > libavformat/hevc.c | 36 +--- > libavfo

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext: make command processing error-resilient

On 10/05/2019 15:55, Gyan wrote: At present, if the command args passed to drawtext contain any invalid values, ffmpeg may crash or, at best, stop drawing any text. Attached patch gets the filter to continue with existing parameters, if not all of the changes can be parsed or applied. This allow

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

Hello everyone! (no meaning attached to which mail I respond to) While it reads less bad today than it did yesterday night, please try to keep the things written in the code of conduct in mind, assume best intentions etc., this thread didn't quite live up to it IMO. It's possible to state even st