Re: [FFmpeg-devel] [PATCH V4 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-23 Thread avih
> print_in_columns() { > -    cols=$(expr $ncols / 24) > -    cat | tr ' ' '\n' | sort | pr -r "-$cols" -w $ncols -t > +    set -- $(cat | tr ' ' '\n' | sort) > +    col_width=24 > +    cols=$(($ncols / $col_width)) > +    rows=$(($(($# + $cols - 1)) / $cols)) > +    cols_seq=$(seq $cols) > +    ro

[FFmpeg-devel] [PATCH V4 2/2] configure: replace 'pr' with printf since busybox does not support pr

2019-04-23 Thread Guo, Yejun
It is part of change from https://trac.ffmpeg.org/ticket/5680 provided by Kylie McClain at Wed, 29 Jun 2016 16:37:20 -0400. That change contains two parts, in function log_file and in function print_in_columns. The second part is not good, so I have send out a new patch for print_in_columns.

[FFmpeg-devel] [PATCH V4 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-23 Thread Guo, Yejun
take decoder names an example, with the default page length, shell command 'pr' needs two pages for all the decoder names. The names are firstly printed in the first page, then in the second page. So, as a whole, the names are sorted neither in column order nor in row order. It's a little confused.

Re: [FFmpeg-devel] [PATCH V3 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-23 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > avih > Sent: Tuesday, April 23, 2019 8:14 PM > To: FFmpeg development discussions and patches > Cc: Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH V3 1/2] configure: sort > decoder/encoder

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-23 Thread Gyan
On 24-04-2019 03:30 AM, Carl Eugen Hoyos wrote: 2019-04-22 13:00 GMT+02:00, Gyan : On 22-04-2019 01:15 PM, Gyan wrote: On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote: Am 20.04.2019 um 11:31 schrieb Gyan : Old patch that was never applied. Rebased. Please return patch_welcome for mlp and

Re: [FFmpeg-devel] [PATCH v3 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread James Almer
On 4/23/2019 7:55 PM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas Rheinh

Re: [FFmpeg-devel] [PATCH]lavfi/frei0r: Fix union and remove unneeded cast

2019-04-23 Thread myp...@gmail.com
On Wed, Apr 24, 2019 at 5:12 AM Carl Eugen Hoyos wrote: > > Hi! > > I failed to test attached patch but it seems like a more useful fix for > the following (past) warning: > libavfilter/vf_frei0r.c:130:17: warning: assignment to ‘char **’ from > incompatible pointer type ‘char *’ > > Please commen

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi/frei0r: Fixes the compilation warnings

2019-04-23 Thread myp...@gmail.com
On Wed, Apr 24, 2019 at 5:04 AM Carl Eugen Hoyos wrote: > > 2019-04-21 15:21 GMT+02:00, Jun Zhao : > > ffmpeg | branch: master | Jun Zhao | Sun Apr 21 > > 12:37:29 2019 +0800| [b272d5b9b6e189cb855ad393edf8524066bd0d07] | committer: > > Jun Zhao > > > > lavfi/frei0r: Fixes the compilation warnings

Re: [FFmpeg-devel] [PATCH]tests/run-sh: Add execsuf to some calls of local tools

2019-04-23 Thread Carl Eugen Hoyos
2019-04-19 18:05 GMT+02:00, Carl Eugen Hoyos : > 2019-04-19 16:12 GMT+02:00, Carl Eugen Hoyos : >> 2019-04-19 13:11 GMT+02:00, Carl Eugen Hoyos : >> >>> Attached patch is needed here for fate on wsl with msvc, not >>> sure why I didn't need this with mingw-gcc. >> >> Better tested and correct varia

Re: [FFmpeg-devel] [MSVC toolchain] Patch to allow building FFmpeg with Linux bash on Windows (WSL)

2019-04-23 Thread Carl Eugen Hoyos
2017-12-29 13:16 GMT+01:00, Cyber Sinh : > Sorry for the diff instead of regular git patch. Here is the patch. Only saw this today after wondering why nobody tried using wsl before... How can I test this part of the patch? In which situation is it supposed to make a difference? diff --git a/comp

Re: [FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-23 Thread Michael Niedermayer
On Mon, Apr 22, 2019 at 11:14:00PM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sun, Apr 21, 2019 at 11:04:00PM +, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> On Sat, Apr 20, 2019 at 01:41:09AM +0200, Andreas Rheinhardt wrote: > Up until now, a block's relat

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Michael Niedermayer
On Tue, Apr 23, 2019 at 11:55:59PM +0200, Michael Niedermayer wrote: > On Tue, Apr 23, 2019 at 07:16:07AM +, Andreas Håkon wrote: > > > > ‐‐‐ Original Message ‐‐‐ > > On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer > > wrote: > > > > > On Mon, Apr 22, 2019 at 11:42:57AM +0

[FFmpeg-devel] [PATCH v3 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread Andreas Rheinhardt
horizontal/vertical_size_value (containing the twelve least significant bits of the frame size) mustn't be zero according to the specifications; and the value 0 is forbidden for the colour_description elements. Signed-off-by: Andreas Rheinhardt --- The actual function calls after macro expansion

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add support for maxframesize

2019-04-23 Thread Michael Niedermayer
On Tue, Apr 23, 2019 at 11:29:17AM +0800, Linjie Fu wrote: > Add support for max frame size: > - max_frame_size (bytes) to indicate the allowed max frame size. > - pass_num to indicate number of passes. > - delta_qp to indicate adjust qp value. > > Currently only AVC encoder can suppor

Re: [FFmpeg-devel] [PATCH] avdevice/alsa: fix indefinite stop on closing PCM capture

2019-04-23 Thread Lou Logan
On Mon, Apr 22, 2019, at 10:47 AM, Nicolas George wrote: > > Sorry, missed it. LGTM. Pushed. f9a061a31c3d2d81b3ec1e1b9b37187a358cdd9e ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-04-23 Thread Carl Eugen Hoyos
2019-04-22 13:00 GMT+02:00, Gyan : > > On 22-04-2019 01:15 PM, Gyan wrote: >> >> >> On 22-04-2019 12:30 PM, Carl Eugen Hoyos wrote: >>> Am 20.04.2019 um 11:31 schrieb Gyan : Old patch that was never applied. Rebased. >>> Please return patch_welcome for mlp and truehd. >> Will do

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Michael Niedermayer
On Tue, Apr 23, 2019 at 07:16:07AM +, Andreas Håkon wrote: > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer > wrote: > > > On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > > > > > > Please, revise the code! I hope you underst

[FFmpeg-devel] [PATCH]lavfi/frei0r: Fix union and remove unneeded cast

2019-04-23 Thread Carl Eugen Hoyos
Hi! I failed to test attached patch but it seems like a more useful fix for the following (past) warning: libavfilter/vf_frei0r.c:130:17: warning: assignment to ‘char **’ from incompatible pointer type ‘char *’ Please comment, Carl Eugen From c0d6001012f3da95ee493905c7411dc20839f4c8 Mon Sep 17 00

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavfi/frei0r: Fixes the compilation warnings

2019-04-23 Thread Carl Eugen Hoyos
2019-04-21 15:21 GMT+02:00, Jun Zhao : > ffmpeg | branch: master | Jun Zhao | Sun Apr 21 > 12:37:29 2019 +0800| [b272d5b9b6e189cb855ad393edf8524066bd0d07] | committer: > Jun Zhao > > lavfi/frei0r: Fixes the compilation warnings > > Fixes the compilation warnings > > Reviewed-by: Paul B Mahol > Si

Re: [FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread James Almer
On 4/23/2019 5:32 PM, Andreas Rheinhardt wrote: > horizontal/vertical_size_value (containing the twelve least significant > bits of the frame size) mustn't be zero according to the specifications; > and the value 0 is forbidden for the colour_description elements. > > Signed-off-by: Andreas Rheinh

[FFmpeg-devel] [PATCH 3/4] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-04-23 Thread Andreas Rheinhardt
If a sequence display extension is read with colour_description equal to zero, but a user wants to add one or more of the colour_description elements, then the colour_description elements the user did not explicitly request to be set are set to zero and not to the value equal to unknown/unspecified

[FFmpeg-devel] [PATCH 4/4] cbs_mpeg2: Correct error codes

2019-04-23 Thread Andreas Rheinhardt
Up until now, things that are merely unsupported by cbs_mpeg2 have been declared to be invalid input. This has been changed. Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 4 +--- libavcodec/cbs_mpeg2_syntax_template.c | 4 ++-- 2 files changed, 3 insertions(+), 5

Re: [FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-23 Thread James Almer
On 4/23/2019 5:32 PM, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_mpeg2.c | 30 +++--- > libavcodec/cbs_mpeg2.h | 2 +- > libavcodec/cbs_mpeg2_syntax_template.c | 10 - > 3 files changed, 23 inse

[FFmpeg-devel] [PATCH 2/4] cbs_mpeg2: Improve checks for invalid values

2019-04-23 Thread Andreas Rheinhardt
horizontal/vertical_size_value (containing the twelve least significant bits of the frame size) mustn't be zero according to the specifications; and the value 0 is forbidden for the colour_description elements. Signed-off-by: Andreas Rheinhardt --- Given that xui is directly used in the syntax te

[FFmpeg-devel] [PATCH 1/4] cbs_mpeg2: Correct and use enum values

2019-04-23 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/cbs_mpeg2.c | 30 +++--- libavcodec/cbs_mpeg2.h | 2 +- libavcodec/cbs_mpeg2_syntax_template.c | 10 - 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/libavcodec/cbs_mpeg

[FFmpeg-devel] [PATCH 14/15] avformat/matroskaenc: Improve log messages for blocks

2019-04-23 Thread Andreas Rheinhardt
Up until now, a block's relative offset has been reported as the offset in the log messages output when writing blocks; given that it is impossible to know the real offset from the beginning of the file at this point due to the fact that it is not yet known how many bytes will be used for the conta

Re: [FFmpeg-devel] [PATCH] ffmpeg: Add option to force a specific decode format

2019-04-23 Thread Carl Eugen Hoyos
2018-11-11 15:54 GMT+01:00, Mark Thompson : > Fixes #7519. > +{ "decode_format", OPT_VIDEO | OPT_STRING | HAS_ARG | OPT_EXPERT | > +OPT_SPEC | OPT_INPUT, > { .off = OFFSET(decode_formats) }, > +"set output format used by decoder, fail if this format is not

Re: [FFmpeg-devel] [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX

2019-04-23 Thread Michael Niedermayer
On Mon, Apr 22, 2019 at 11:05:00AM -0700, Dan Sanders wrote: > It's this or add overflow detection in mov_read_header(). > --- > libavformat/mov.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC

Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to force a specific decode format

2019-04-23 Thread Eoff, Ullysses A
*bump* > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark > Thompson > Sent: Wednesday, February 20, 2019 1:52 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH v2] ffmpeg: Add option to force a spec

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 14:20, Moritz Barsnick wrote: > On Tue, Apr 23, 2019 at 12:03:11 +, Andreas Håkon wrote: > > > In addition, one correction regarding the initialization. > > Sorry, but first version has an error. This is clean! > > I had seen t

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Moritz Barsnick
On Tue, Apr 23, 2019 at 12:03:11 +, Andreas Håkon wrote: > In addition, one correction regarding the initialization. > Sorry, but first version has an error. This is clean! I had seen that the option got initialized to 0x, but checked that that is never a legally assigned pid (there's a "<

Re: [FFmpeg-devel] [PATCH V3 1/2] configure: sort decoder/encoder/filter/... names in alphabet order

2019-04-23 Thread avih
>  print_in_columns() { > -    cols=$(expr $ncols / 24) > -    cat | tr ' ' '\n' | sort | pr -r "-$cols" -w $ncols -t > +    col_width=24 > +    cols=$(expr $ncols / $col_width) > +    rows=$(expr $(expr $# + $cols - 1) / $cols) > +    for row in $(seq $rows); do > +    index=$row > +    li

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 13:43, Moritz Barsnick wrote: > On Tue, Apr 23, 2019 at 11:15:40 +, Andreas Håkon wrote: > > Nits: > > > Subject: libavformat: forced PCR pid in mpegts muxer > > "libavformat/mpegtsenc: allow to force the PID carrying the PCR"

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Moritz Barsnick
On Tue, Apr 23, 2019 at 11:15:40 +, Andreas Håkon wrote: Nits: > Subject: libavformat: forced PCR pid in mpegts muxer "libavformat/mpegtsenc: allow to force the PID carrying the PCR" (or something along those lines) > By default FFmpeg selects the first video stream, or the first one in > t

[FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
New optional parameter “-force_prc_pid” for the mpegtsenc muxer. Regards. A.H. ---From ecda0e2f9b0e01a62f06cfb00684d11de6eb6dc2 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 23 Apr 2019 12:05:40 +0100 Subject: [PATCH] libavformat: forced PCR pid in mpegts muxer This patch provides a n

Re: [FFmpeg-devel] [PATCH] cuviddec: improved way of finding out if a frame is interlaced or progressive

2019-04-23 Thread Timo Rothenpieler
applied, thanks. smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org w

Re: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add nlmeans_opencl filter

2019-04-23 Thread Song, Ruiling
> -Original Message- > From: Song, Ruiling > Sent: Sunday, April 21, 2019 8:18 PM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: RE: [FFmpeg-devel] [PATCH V2 2/2] lavfi/opencl: add > nlmeans_opencl filter > > > > > -Original Message- > > From: ff

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 9:29, Andreas Håkon wrote: > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 8:39, Li, Zhong zhong...@intel.com wrote: > > > I belive they are different. If you extend the MARCIO, they are actually: > > IMHO, yo

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add support for maxframesize

2019-04-23 Thread Fu, Linjie
> -Original Message- > From: myp...@gmail.com [mailto:myp...@gmail.com] > Sent: Tuesday, April 23, 2019 13:42 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode_h264: add support > for maxframesize >

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 8:39, Li, Zhong wrote: > > I belive they are different. If you extend the MARCIO, they are actually: > > > IMHO, your patch is only needed when disable "QSV_HAVE_CO3", but tiket#7839 > is not root caused now. > I will consider to a

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer wrote: > On Mon, Apr 22, 2019 at 11:42:57AM +, Andreas Håkon wrote: > > > > Please, revise the code! I hope you understand it when you look at my > > descriptions. > > I would prefer to have some test

Re: [FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 0:36, Michael Niedermayer wrote: > > > From c59569ca9426fef455edabfa648cb2ff678c1640 Mon Sep 17 00:00:00 2001 > > From: Andreas Hakon andreas.ha...@protonmail.com > > Date: Fri, 19 Apr 2019 09:32:33 +0100 > > Subject: [PATCH] libav