aks for review, thanks.
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Guo, Yejun
> Sent: Thursday, December 13, 2018 12:26 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 1/2] add support for ROI-based encoding
>
> This
The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is
still 32
in function ff_hevc_sao_edge_filter_8_msa. So, use AV_INPUT_BUFFER_PADDING_SIZE
directly.
Fate tests passed.
---
libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
> 2018-12-18 2:15 GMT+01:00, gxw :
> > The AV_INPUT_BUFFER_PADDING_SIZE has been increased to 64, but the value is
> > still 32
> > in function ff_hevc_sao_edge_filter_8_msa. So, Modify the corresponding
> > value to 64.
> > Fate tests passed.
> > ---
> > libavcodec/mips/hevc_lpf_sao_msa.c | 2 +-
On 12/19/2018 9:51 PM, Peter Ross wrote:
> this option is described by --help, but the definition was missing in
> CMDLINE_SET.
> ---
>
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 417fc470eb..6cbd642943 100755
> --- a/configure
> +++ b/conf
2018-12-20 1:49 GMT+01:00, Peter Ross :
> ---
> (--host-libs is not defined in code, and does not work)
>
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 7136f22395..2f35741aca 100755
> --- a/configure
> +++ b/configure
> @@ -380,7
this option is described by --help, but the definition was missing in
CMDLINE_SET.
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 417fc470eb..6cbd642943 100755
--- a/configure
+++ b/configure
@@ -2437,6 +2437,7 @@ CMDLINE_SET="
tempprefix
---
(--host-libs is not defined in code, and does not work)
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 7136f22395..2f35741aca 100755
--- a/configure
+++ b/configure
@@ -380,7 +380,7 @@ Toolchain options:
--host-cppflags=HCPPFLAGS u
2018-12-20 1:42 GMT+01:00, Peter Ross :
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index be49c19b88..7136f22395 100755
> --- a/configure
> +++ b/configure
> @@ -473,7 +473,7 @@ Developer options (useful when working on FFmpeg
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index be49c19b88..7136f22395 100755
--- a/configure
+++ b/configure
@@ -473,7 +473,7 @@ Developer options (useful when working on FFmpeg itself):
--random-seed=VALUE seed value for --ena
On Wed, Dec 19, 2018 at 09:35:28PM +0100, Paul B Mahol wrote:
> On 12/19/18, Michael Niedermayer wrote:
> > On Tue, Dec 18, 2018 at 10:55:16PM +0100, Paul B Mahol wrote:
> >> On 12/18/18, Michael Niedermayer wrote:
> >> > On Tue, Dec 18, 2018 at 02:56:54PM +0100, Paul B Mahol wrote:
> >> >> Signe
Hi!
Attached patch depends on Paul's PhotoCD decoder.
Please comment, Carl Eugen
From b7247956162c8104ba8bef90ea85e2fc3578b643 Mon Sep 17 00:00:00 2001
From: Carl Eugen Hoyos
Date: Thu, 20 Dec 2018 00:58:47 +0100
Subject: [PATCH] lavf/img2dec: Auto-detect Kodak Photo CD image files.
---
libavf
When reading frames, we need to use the fragment for the correct
stream. Sometimes the "current" fragment is not the same as the one
the frame is for.
Found by Chromium's ClusterFuzz:
https://crbug.com/906392 and https://crbug.com/915524
Signed-off-by: Jacob Trimble
---
libavformat/mov.c | 6 +
2018-12-19 21:32 GMT+01:00, Paul B Mahol :
> +static av_cold int photocd_decode_init(AVCodecContext *avctx)
> +{
> +avctx->pix_fmt= AV_PIX_FMT_YUV420P;
I very much welcome this patch but it appears that the colourspace
conversion is missing that was part of the original patchset=-(
Carl
On Wed, Dec 19, 2018 at 09:32:03PM +0100, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavcodec/Makefile | 1 +
> libavcodec/allcodecs.c | 1 +
> libavcodec/avcodec.h| 1 +
> libavcodec/codec_desc.c | 7 +
> libavcodec/photocd.c| 445 +++
On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote:
>
> On 12/19/2018 6:52 PM, Rene Claus wrote:
> > This commit adds configuration options to libvpxenc.c that can be used to
> > tune the sharpness parameter for VP8 and VP9.
> >
> > Signed-off-by: Rene Claus
> > ---
> > doc/encoders.texi | 4
Yes, setting it to zero is the same as not setting it at all.
I'll look into updating vp8cx.h
On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote:
> On 12/19/2018 6:52 PM, Rene Claus wrote:
> > This commit adds configuration options to libvpxenc.c that can be used to
> > tune the sharpness paramet
From: Matthew Fearnley
score_tab[] was only declared/initialised for elements 0..255, but with
block sizes set to 16*16, it was possible to reach 256.
This limit could also be overflowed in the histogram, because it was
declared with a uint8_t type.
This can be fixed, and also allow different Z
On 12/19/2018 6:52 PM, Rene Claus wrote:
> This commit adds configuration options to libvpxenc.c that can be used to
> tune the sharpness parameter for VP8 and VP9.
>
> Signed-off-by: Rene Claus
> ---
> doc/encoders.texi | 4
> libavcodec/libvpxenc.c | 6 ++
> 2 files changed, 10 i
From: Matthew Fearnley
All the values in score_tab are positive or 0, and so should be the sum
returned by block_cmp().
The logic in zmbv_me() assumes that all 'bv' values will be non-negative,
in order to guarantee an early return if ever bv==0.
---
libavcodec/zmbvenc.c | 7 ---
1 file cha
From: Matthew Fearnley
Store the value of *xored computed within block_cmp() in a local variable,
and only update the *xored parameter at the same time as *mx,*my are set.
This ensures that the value of *xored is accurate for the value of *mx,*my
whenever the function ends.
Note that the local v
From: Matthew Fearnley
If *xored is 0, then histogram[0]==bw*bh and histogram[1..255]==0.
Because histogram[0] is skipped over for the entropy calculation, the
return value is always 0 when *xored==0, so we don't need to waste time
calculating it.
This addition both clarifies the behaviour of t
This commit adds configuration options to libvpxenc.c that can be used to
tune the sharpness parameter for VP8 and VP9.
Signed-off-by: Rene Claus
---
doc/encoders.texi | 4
libavcodec/libvpxenc.c | 6 ++
2 files changed, 10 insertions(+)
diff --git a/doc/encoders.texi b/doc/encode
On Wed, Dec 19, 2018 at 10:24:29 -0800, Rene Claus wrote:
> +if (ctx->sharpness >= 0)
Can this ever be untrue?
Because:
> +{ "sharpness", "Sharpness", OFFSET(sharpness), AV_OPT_TYPE_INT,
> {.i64 = 0}, 0, 7, VE},
On 12/19/2018 5:57 PM, Paul B Mahol wrote:
> On 12/19/18, James Almer wrote:
>> On 12/18/2018 10:56 AM, Paul B Mahol wrote:
>>> Signed-off-by: Paul B Mahol
>>> ---
>>> libavformat/nut.h| 3 +
>>> libavformat/nutenc.c | 130 +--
>>> 2 files changed, 1
On 12/19/18, James Almer wrote:
> On 12/18/2018 10:56 AM, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol
>> ---
>> libavformat/nut.h| 3 +
>> libavformat/nutenc.c | 130 +--
>> 2 files changed, 129 insertions(+), 4 deletions(-)
>>
>> diff --git a
On 12/18/2018 10:56 AM, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavformat/nut.h| 3 +
> libavformat/nutenc.c | 130 +--
> 2 files changed, 129 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/nut.h b/libavformat/nut.h
>
Signed-off-by: Paul B Mahol
---
libavformat/img2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/img2.c b/libavformat/img2.c
index 8432cc0955..2db4290126 100644
--- a/libavformat/img2.c
+++ b/libavformat/img2.c
@@ -53,6 +53,7 @@ const IdStrMap ff_img_tags[] = {
{ AV_CODEC_I
On 12/19/18, Michael Niedermayer wrote:
> On Tue, Dec 18, 2018 at 10:55:16PM +0100, Paul B Mahol wrote:
>> On 12/18/18, Michael Niedermayer wrote:
>> > On Tue, Dec 18, 2018 at 02:56:54PM +0100, Paul B Mahol wrote:
>> >> Signed-off-by: Paul B Mahol
>> >> ---
>> >> libavformat/nut.h| 3 +
>>
Signed-off-by: Paul B Mahol
---
libavcodec/Makefile | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/avcodec.h| 1 +
libavcodec/codec_desc.c | 7 +
libavcodec/photocd.c| 445
5 files changed, 455 insertions(+)
create mode 100644 libavc
Hi,
Just to say, after further reviewing the logic in zmbv_me() and block_cmp(), I
think it all tenuously holds together, with no possibilities of incorrect xored
values or undefined behaviour. But it is quite fragile.
I’m planning some patches to strengthen/clarify the logic, and to make it mor
On Wed, Dec 19, 2018 at 8:56 PM Michael Niedermayer
wrote:
>
> On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote:
> > Fixes issues when a subtitle packet is received before PCR for the
> > program has been received, leading to wildly jumping timestamps
> > on the lavf client side as well
On Wed, Dec 19, 2018 at 7:08 PM Mohammad Izadi wrote:
> From: Mohammad Izadi
>
> The dynamic metadata contains data for color volume transform -
> application 4 of SMPTE 2094-40:2016 standard. The data comes from HEVC in
> the SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35.
>
> I'll add support to HEVC
On Wed, Dec 19, 2018 at 10:24 AM Rene Claus
wrote:
>
> This commit adds configuration options to libvpxenc.c that can be used to
> tune the sharpness parameter of the loop filter for VP8 and VP9.
>
> Signed-off-by: Rene Claus
> ---
> doc/encoders.texi | 4
> libavcodec/libvpxenc.c | 5
On Sat, Dec 15, 2018 at 08:50:41PM +0200, Jan Ekström wrote:
> Fixes issues when a subtitle packet is received before PCR for the
> program has been received, leading to wildly jumping timestamps
> on the lavf client side as well as in the re-ordering logic.
>
> This usually happens in case of mul
On Tue, Dec 18, 2018 at 01:26:35PM -0800, tianhu yang wrote:
> ---
> libavformat/rtsp.c | 1 +
> 1 file changed, 1 insertion(+)
how can the bug be reproduced ?
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
The greatest way to live with honor in this worl
On Wed, Dec 19, 2018 at 02:33:49PM +0200, Artyom Lebedev wrote:
> It was reallocated even if the exisiting buffer is larger than needed one,
> thus unnecessary shrinking it.
> aviobuf.c |3 +++
> 1 file changed, 3 insertions(+)
> 17a6a27b38d8fc7336d7177338b915b507a69033
> 0001-Fix-unnecessa
On 12/19/2018 2:13 PM, Helmut K. C. Tessarek wrote:
> commit
> https://aomedia.googlesource.com/aom/+/4667aa1a373566e9c124afcd58c71731ab0d7377
> changed parts of the code that broke compilation of libavcodec/libaomenc.c
> ---
> libavcodec/libaomenc.c | 9 +++--
> 1 file changed, 7 insertions(
This commit adds configuration options to libvpxenc.c that can be used to
tune the sharpness parameter of the loop filter for VP8 and VP9.
Signed-off-by: Rene Claus
---
doc/encoders.texi | 4
libavcodec/libvpxenc.c | 5 +
2 files changed, 9 insertions(+)
diff --git a/doc/encoders.
From: Mohammad Izadi
The dynamic metadata contains data for color volume transform - application 4
of SMPTE 2094-40:2016 standard. The data comes from HEVC in the
SEI_TYPE_USER_DATA_REGISTERED_ITU_T_T35.
I'll add support to HEVC in a follow-up.
---
libavutil/Makefile | 2 +
li
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
On 2018-12-19 17:28, James Almer wrote:
> This will break compilation with libaom 1.0.0 because it wasn't
> typedefed before this change. You will need to use an #ifdef
> UENUM1BYTE check or similar to choose one line or the other.
Yep, an ifdef
commit
https://aomedia.googlesource.com/aom/+/4667aa1a373566e9c124afcd58c71731ab0d7377
changed parts of the code that broke compilation of libavcodec/libaomenc.c
---
libavcodec/libaomenc.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libaomenc.c b/libavc
On 12/19/2018 1:03 PM, Helmut K. C. Tessarek wrote:
> commit
> https://aomedia.googlesource.com/aom/+/4667aa1a373566e9c124afcd58c71731ab0d7377
> changed parts of the code that broke compilation of libavcodec/libaomenc.c
> ---
> libavcodec/libaomenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2
All my tests ok.
Thank you, Adrian.
> On 19 Dec 2018, at 12:41, Adrian wrote:
>
> Okay, so given you two have some valid points, I've combined both and ended
> up with final version of the patch:
> - it uses temp file for playlist when either a flag is specified or playlist
> type is anything
commit
https://aomedia.googlesource.com/aom/+/4667aa1a373566e9c124afcd58c71731ab0d7377
changed parts of the code that broke compilation of libavcodec/libaomenc.c
---
libavcodec/libaomenc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/libaomenc.c b/libavcodec/
> On Dec 19, 2018, at 4:41 AM, Adrian wrote:
>
> Okay, so given you two have some valid points, I've combined both and ended
> up with final version of the patch:
> - it uses temp file for playlist when either a flag is specified or playlist
> type is anything other than VOD
> - it does not u
On Tue, Dec 18, 2018 at 10:55:16PM +0100, Paul B Mahol wrote:
> On 12/18/18, Michael Niedermayer wrote:
> > On Tue, Dec 18, 2018 at 02:56:54PM +0100, Paul B Mahol wrote:
> >> Signed-off-by: Paul B Mahol
> >> ---
> >> libavformat/nut.h| 3 +
> >> libavformat/nutenc.c | 130 +
2018-12-17 20:43 GMT+01:00, Carl Eugen Hoyos :
> 2018-12-17 16:45 GMT+01:00, Nicolas George :
>> Carl Eugen Hoyos (2018-12-17):
>>> #ifndef emms_c
>>> -# define emms_c() while(0)
>>> +# define emms_c() while(0){}
>>> #endif
>>
>> That feels really wrong, or at least completely unusual. But no
2018-12-17 2:47 GMT+01:00, Carl Eugen Hoyos :
> The Opus struct RawBitsContext is used in both the decoder and the encoder.
> The fact that *position is const avoids warnings in the decoder where
> it points into the bitstream. The encoder writes into the same
> pointer, attached cast silences the
2018-12-19 13:40 GMT+01:00, Artyom Lebedev :
> I have this assert fired after probing done
How can we reproduce the assertion failure?
In general, fixing the crash and (potentially) removing
the assert() should be two different things.
Carl Eugen
___
f
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> Of Zachary Zhou
> Sent: Tuesday, December 18, 2018 5:55 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Zhou, Zachary
> Subject: [FFmpeg-devel] [PATCH V6] libavfilter: add transpose_vaapi filter
>
> Swap width and height when do clo
Paul B Mahol (2018-12-17):
> Yes, it is poc - patch of crap.
Please refrain from using that language.
--
Nicolas George
signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/lis
I have this assert fired after probing done and frames are normally
read: "av_assert0(len >= s->orig_buffer_size);". Buffer size after
probing ended up with ~5MB, orig_buffer_size was 64K. This place looks
like total mess, it definitely has a bug with incorrect len modification
even if buffer w
It was reallocated even if the exisiting buffer is larger than needed
one, thus unnecessary shrinking it.
>From 2b8cea72a69abe6564367fb2149be936d2ffb916 Mon Sep 17 00:00:00 2001
From: Artyom Lebedev
Date: Wed, 19 Dec 2018 11:49:22 +0200
Subject: [PATCH] Fix unnecessary buffer reallocotion in
ffi
tis 2018-12-18 klockan 22:58 +0100 skrev Paul B Mahol:
> > On 12/18/18, Tomas Härdin wrote:
> > sön 2018-12-16 klockan 22:28 +0100 skrev Paul B Mahol:
> > > >
> > >
> > > +static void track_header(VividasDemuxContext *viv, AVFormatContext
> > > *s, uint8_t *buf, int size)
> > > +{
> > > +[...]
On Sun, Dec 16, 2018 at 09:43:05PM +0100, Michael Niedermayer wrote:
> This will allow performing some fast checks before the slow allocation
>
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/rpza.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
will apply
[...]
On Sun, Dec 16, 2018 at 09:43:06PM +0100, Michael Niedermayer wrote:
> Fixes: Timeout
> Fixes:
> 11547/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RPZA_fuzzer-5678435842654208
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed
On Tue, Dec 18, 2018 at 13:41:06 -0800, Mohammad Izadi wrote:
Nit:
> #define LIBAVUTIL_VERSION_MAJOR 56
> -#define LIBAVUTIL_VERSION_MINOR 24
> +#define LIBAVUTIL_VERSION_MINOR 25
> #define LIBAVUTIL_VERSION_MICRO 101
When bumping minor, you need to reset micro to 100.
Moritz
_
On Fri, Dec 07, 2018 at 11:57:48PM +0100, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/mpegts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
will apply patchset
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
N
On Fri, Dec 07, 2018 at 01:01:09AM +0100, Michael Niedermayer wrote:
> On Thu, Dec 06, 2018 at 10:42:24PM +0100, Carl Eugen Hoyos wrote:
> > 2018-12-06 22:41 GMT+01:00, Carl Eugen Hoyos :
> > > 2018-12-06 22:19 GMT+01:00, Michael Niedermayer :
> > >> Fixes: test failure on powerpc
> > >>
> > >> Sig
Okay, so given you two have some valid points, I've combined both and
ended up with final version of the patch:
- it uses temp file for playlist when either a flag is specified or
playlist type is anything other than VOD
- it does not use temp file for HLS_SINGLE_FILE in place mentioned by
Aleks
On 19/12/2018 02:40, Michael Niedermayer wrote:
Signed-off-by: Michael Niedermayer
---
libavcodec/ffv1enc.c | 10 +++---
libavcodec/rangecoder.c | 4 +++-
libavcodec/rangecoder.h | 2 +-
libavcodec/snowenc.c | 2 +-
libavcodec/sonic.c| 2 +-
On Tue, Dec 18, 2018 at 03:11:12PM +0100, Paul B Mahol wrote:
> On 12/18/18, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/encoders.texi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Patch set LGTM.
will apply
thx
[...]
--
Michael
On 12/18/18, James Almer wrote:
> On 12/18/2018 5:05 PM, Paul B Mahol wrote:
>> Signed-off-by: Paul B Mahol
>> ---
>> libavcodec/Makefile| 1 +
>> libavcodec/g723_1_parser.c | 60 ++
>> libavcodec/parsers.c | 1 +
>> libavcodec/utils.c
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of
> Song, Ruiling
> Sent: Tuesday, December 4, 2018 3:33 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH] lavfi/tonemap_opencl: reuse matrix
> calculatio
64 matches
Mail list logo
