Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-07-28 Thread James Almer
On 7/28/2018 6:59 PM, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> I'm not 100% sure this is correct. I also don't know if the CBS contexts need >> to be fully reinitialized or not in this scenario. Because if so,

Re: [FFmpeg-devel] [PATCH 6/8] avcodec/h264_redundant_pps_bsf: implement a AVBSFContext.flush() callback

2018-07-28 Thread Michael Niedermayer
On Fri, Jul 27, 2018 at 11:57:47AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > I'm not 100% sure this is correct. I also don't know if the CBS contexts need > to be fully reinitialized or not in this scenario. Because if so, then every > bsf using cbs will require a flush() call

Re: [FFmpeg-devel] [PATCH 5/8] avcodec/mpeg4_unpack_bframes_bsf: implement a AVBSFContext.flush() callback

2018-07-28 Thread Michael Niedermayer
On Fri, Jul 27, 2018 at 11:57:46AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/mpeg4_unpack_bframes_bsf.c | 7 +++ > 1 file changed, 7 insertions(+) should be ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Elect your

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

2018-07-28 Thread Michael Niedermayer
On Sat, Jul 28, 2018 at 01:25:36PM -0300, James Almer wrote: > On 7/28/2018 4:09 AM, Michael Niedermayer wrote: > > On Fri, Jul 27, 2018 at 11:11:47PM -0300, James Almer wrote: > >> On 7/27/2018 10:58 PM, Michael Niedermayer wrote: > >>> On Fri, Jul 27, 2018 at 11:57:49AM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/libopusenc: allow encoding channel mapping 2

2018-07-28 Thread Rostislav Pehlivanov
On 27 July 2018 at 20:44, Felicia Lim wrote: > --- > libavcodec/libopusenc.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/libavcodec/libopusenc.c b/libavcodec/libopusenc.c > index 4ae81b0bb2..6b450ec317 100644 > --- a/libavcodec/libopusenc.c > +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-28 Thread Pedro Arthur
2018-07-27 14:24 GMT-03:00 Rostislav Pehlivanov : > On 27 July 2018 at 18:12, Rostislav Pehlivanov wrote: > >> >> And the coding style is just the tip, there are dozens of things I >> disagree with, such as the custom float to 8 bit conversions, when filters >> already exist which take in floats (

Re: [FFmpeg-devel] [PATCH 2/2] cmdutils: print a more descriptive error message in show_help_bsf() when no bsf is specified

2018-07-28 Thread James Almer
On 7/28/2018 10:11 AM, Michael Niedermayer wrote: > On Sat, Jul 28, 2018 at 12:58:48AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> fftools/cmdutils.c | 5 - >> 1 file changed, 4 insertions(+), 1 deletion(-) > > LGTM > > thx Pushed, thanks.

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

2018-07-28 Thread James Almer
On 7/28/2018 4:09 AM, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 11:11:47PM -0300, James Almer wrote: >> On 7/27/2018 10:58 PM, Michael Niedermayer wrote: >>> On Fri, Jul 27, 2018 at 11:57:49AM -0300, James Almer wrote: Certain AVCodecParameters, like the contents of the extradata, m

Re: [FFmpeg-devel] [PATCH] avformat/movenc: implicitly enable negative CTS offsets for ismv

2018-07-28 Thread Jan Ekström
On Fri, Jul 27, 2018 at 1:30 AM, Michael Niedermayer wrote: > breaks fate > fate-lavf-ismv seems to be all about the version identifier (0 is for uintXX CTS offsets, and 1 is for intXX CTS offsets). F.ex. with the first file: diff --git a/old_1st.log b/new_1st.log index f188075577..5100ff6710 10

Re: [FFmpeg-devel] [PATCH 3/5] Renamed reinterlace to tinterlace

2018-07-28 Thread Thomas Mundt
Hi, 2018-07-24 12:17 GMT+02:00 Vasile Toncu : > Fixed tabs. > Thank you for the feedback. > > {} > +case MODE_INTERLEAVE_BOTTOM: > +case MODE_INTERLEAVE_TOP: > +y = y * 2; > + > +if (tinterlace->flags & FLAG_VLPF || tinterlace->flags & > FLAG_CVLPF) { > + > +

Re: [FFmpeg-devel] [PATCH] lavfi/nlmeans: fixup aarch64 assembly with clang

2018-07-28 Thread Jan Ekström
On Fri, Jul 27, 2018 at 11:14 AM, Clément Bœsch wrote: > On Fri, Jul 27, 2018 at 12:03:46AM +0300, Jan Ekström wrote: >> Clang is more strict about some things. >> --- >> libavfilter/aarch64/vf_nlmeans_neon.S | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavfil

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/diracdec: Prevent integer overflow in intermediate in global_mv()

2018-07-28 Thread Michael Niedermayer
On Sun, Jul 22, 2018 at 10:23:18PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -393471 * 5460 cannot be represented in type > 'int' > Fixes: > 8890/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DIRAC_fuzzer-6299775379963904 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] avformat/flvenc: Check audio packet size

2018-07-28 Thread Michael Niedermayer
Fixes: Assertion failure Fixes: assert_flvenc.c:941_1.swf Found-by: #CHEN HONGXU# Signed-off-by: Michael Niedermayer --- libavformat/flvenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/flvenc.c b/libavformat/flvenc.c index 1c552a3e6b..e4863f1fc7 100644 --- a/libavforma

Re: [FFmpeg-devel] [PATCH 2/2] cmdutils: print a more descriptive error message in show_help_bsf() when no bsf is specified

2018-07-28 Thread Michael Niedermayer
On Sat, Jul 28, 2018 at 12:58:48AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/cmdutils.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Complexity theory is the

Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?

2018-07-28 Thread Naveed Basha
Yes, please find the test stream here. I was using ffmpeg v3.4.2. https://drive.google.com/open?id=1rHCfG4csA3rB4LSgErEBn1F3WfI5nUVr On Sat, Jul 28, 2018 at 6:36 AM Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 05:27:44PM +0530, Naveed Basha wrote: > > Hi All, > > > > I used av_read_fram

[FFmpeg-devel] [PATCH 2/4] avcodec/aacdec_template: Check for duplicate elements

2018-07-28 Thread Michael Niedermayer
Fixes: Timeout Fixes: 9552/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-6027842339995648 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_template.c | 9 +

[FFmpeg-devel] [PATCH 3/4] avcodec/simple_idct_template: Fix several integer overflows

2018-07-28 Thread Michael Niedermayer
Fixes: simple_idct_template.c:184:30: runtime error: signed integer overflow: -1065517056 - 1392182838 cannot be represented in type 'int' Fixes: simple_idct_template.c:269:21: runtime error: signed integer overflow: 16384 * 259254 cannot be represented in type 'int' Fixes: simple_idct_template.c

[FFmpeg-devel] [PATCH 1/4] avcodec/aacpsdsp_template: Fix integer overflow in ps_stereo_interpolate_c()

2018-07-28 Thread Michael Niedermayer
Fixes: signed integer overflow: -1813244069 + -1407981383 cannot be represented in type 'int' Fixes: 8823/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5643295618236416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signe

[FFmpeg-devel] [PATCH 4/4] avcodec/pnm_parser: Avoid reparsing failed data.

2018-07-28 Thread Michael Niedermayer
Alternatively the parser could be re implemented / redesigned so as to better and more efficiently find frame boundaries Fixes: Timeout Fixes: 9210/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PBM_fuzzer-4770771833454592 Fixes: 9214/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PPM_fuzz

Re: [FFmpeg-devel] Why not integrate libyuv as a scale filter

2018-07-28 Thread Jeff
Hi Carl, Sorry for late reply. I make a simple test on my MacBook Pro (13-inch, 2016, 2 GHz Intel Core i5, 8 GB 1867 MHz LPDDR3). I read a 1088x1920 BGR24 frame from local disk, and then scale it to 480x854-YUV420P 500 times respectively by libswscale & libyuv. The result shows that libswsc

Re: [FFmpeg-devel] Why does ffmpeg h264 decoder stop decoding when certain type of packets are coming in the input stream?

2018-07-28 Thread Naveed Basha
Yes I have it. On Sat, 28 Jul 2018 at 6:36 AM, Michael Niedermayer wrote: > On Fri, Jul 27, 2018 at 05:27:44PM +0530, Naveed Basha wrote: > > Hi All, > > > > I used av_read_frame to get the AVPacket from encoded h264 file. But when > > this packet (00 00 01 05 94 5a 33 e7 4d 6b d7 ad 13 86 ff 47

Re: [FFmpeg-devel] [GSOC] [PATCH] On the fly generation of default DNN models and code style fixes

2018-07-28 Thread Sergey Lavrushkin
2018-07-28 4:31 GMT+03:00 Michael Niedermayer : > On Fri, Jul 27, 2018 at 08:06:15PM +0300, Sergey Lavrushkin wrote: > > Hello, > > > > The first patch provides on the fly generation of default DNN models, > > that eliminates data duplication for model weights. Also, files with > > internal weight

Re: [FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-28 Thread Jan Ekström
On Thu, Jul 26, 2018 at 1:20 PM, Timo Rothenpieler wrote: > --- > libavformat/librtmp.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c > index f3cfa9a8e2..43013e46e0 100644 > --- a/libavformat/librtmp.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH] qt-faststart: Add mode for probing faststart-ness

2018-07-28 Thread Tomas Härdin
lör 2018-07-28 klockan 10:31 +0530 skrev Gyan Doshi: > > On 28-07-2018 03:33 AM, Tomas Härdin wrote: > > > > woot! I didn't know the mov demuxer dumped such things. It is quite > > slow however, since it will scan through every leaf atom in the > > file. > > For example, running time ffmpeg -i in

Re: [FFmpeg-devel] [PATCH 8/8] avcodec/decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext

2018-07-28 Thread Michael Niedermayer
On Fri, Jul 27, 2018 at 11:11:47PM -0300, James Almer wrote: > On 7/27/2018 10:58 PM, Michael Niedermayer wrote: > > On Fri, Jul 27, 2018 at 11:57:49AM -0300, James Almer wrote: > >> Certain AVCodecParameters, like the contents of the extradata, may be > >> changed > >> by the init() function of a