Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Pedro Arthur
2018-07-26 23:19 GMT-03:00 Ronald S. Bultje : > Hi, > > On Thu, Jul 26, 2018 at 10:04 PM, Pedro Arthur wrote: > >> If you compare NN weights with quantization tables they are pretty >> similar > > > https://chromium.googlesource.com/webm/libvpx/+/3b9c19aaa7b8830a896c5f578a3ce6c6a7953947%5E%21/#F0

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/motion_estimation: use pixelutils API for sad.

2018-07-26 Thread myp...@gmail.com
On Mon, Jul 23, 2018 at 2:33 AM Marton Balint wrote: > > > > On Tue, 17 Jul 2018, myp...@gmail.com wrote: > > > On Sun, Jul 15, 2018 at 1:03 AM Michael Niedermayer > > wrote: > >> > >> On Sat, Jul > >> 14, 2018 at 12:04:46PM +0200, Marton Balint wrote: > >> > > >> > > >> > On Sat, 14 Jul 2018, Mi

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Ronald S. Bultje
Hi, On Thu, Jul 26, 2018 at 10:04 PM, Pedro Arthur wrote: > If you compare NN weights with quantization tables they are pretty > similar https://chromium.googlesource.com/webm/libvpx/+/3b9c19aaa7b8830a896c5f578a3ce6c6a7953947%5E%21/#F0 So, that one tiny single function is how VP9/AV1 quant ta

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Pedro Arthur
Hi, I'm surprised with this patch, there wasn't any concern raised in the patch review process. 2018-07-26 16:26 GMT-03:00 Rostislav Pehlivanov : > As discussed recently, the vf_sr filter and the DNN framework have an > issue: unreproducable weights and questionable license, as well as > overall

Re: [FFmpeg-devel] [PATCH] avformat/movenc: implicitly enable negative CTS offsets for ismv

2018-07-26 Thread Michael Niedermayer
On Thu, Jul 26, 2018 at 02:51:38AM +0300, Jan Ekström wrote: > ISMV lacks any sort of edit list support, as well as tfxd is > effectively the PTS of the fragment for most intents and purposes. > > Thus, if b-frames are requested without negative CTS offsets you > end up with N frames' worth of del

[FFmpeg-devel] [PATCH] lavfi/nlmeans: fixup aarch64 assembly with clang

2018-07-26 Thread Jan Ekström
Clang is more strict about some things. --- libavfilter/aarch64/vf_nlmeans_neon.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/aarch64/vf_nlmeans_neon.S b/libavfilter/aarch64/vf_nlmeans_neon.S index 6308a428db..ac16157bbd 100644 --- a/libavfilter/aarch64/vf_

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Carl Eugen Hoyos
2018-07-26 21:26 GMT+02:00, Rostislav Pehlivanov : > There's an overall consensus that NN filters should accept > external weights only Do you mean an overall consensus on irc? I ask because the patch in question was sent several times for review, and I don't remember a comment concerning interna

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Paul B Mahol
On 7/26/18, Thilo Borgmann wrote: > Hi, > > Am 26.07.18 um 21:26 schrieb Rostislav Pehlivanov: >> As discussed recently, the vf_sr filter and the DNN framework have an >> issue: unreproducable weights and questionable license, as well as >> overall unfitting coding style to the rest of the project

Re: [FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Thilo Borgmann
Hi, Am 26.07.18 um 21:26 schrieb Rostislav Pehlivanov: > As discussed recently, the vf_sr filter and the DNN framework have an > issue: unreproducable weights and questionable license, as well as > overall unfitting coding style to the rest of the project. > > The vf_sr filter in particular has w

[FFmpeg-devel] [PATCH] libavfilter: temporarily remove DNN framework and vf_sr filter

2018-07-26 Thread Rostislav Pehlivanov
As discussed recently, the vf_sr filter and the DNN framework have an issue: unreproducable weights and questionable license, as well as overall unfitting coding style to the rest of the project. The vf_sr filter in particular has weights embedded which weight the libavfilter binary by a bit and c

Re: [FFmpeg-devel] [PATCH 1/2] lavc/amfenc: moving amf common code (library and context) to lavu/hwcontext_amf from amfenc to be reused in other amf components

2018-07-26 Thread Alexander Kravchenko
Hello. It is reminder. Could you please review the patch? if it is ok, could you apply it? It was published 2 weeks ago and it is required for further updates Thanks, Alexander  ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH 1/3] diracdec: add 10-bit Haar SIMD functions

2018-07-26 Thread Rostislav Pehlivanov
On 26 July 2018 at 12:28, James Darnley wrote: > + > +%macro HAAR_HORIZONTAL 0 > + > +cglobal horizontal_compose_haar_10bit, 3, 6+ARCH_X86_64, 4, b, temp_, w, > x, b2 > +DECLARE_REG_TMP 2,5 > +%if ARCH_X86_64 > +%define tail r6d > +%else > +%define tail dword wm > +

Re: [FFmpeg-devel] [PATCH 1/3] diracdec: add 10-bit Haar SIMD functions

2018-07-26 Thread Rostislav Pehlivanov
On 26 July 2018 at 12:28, James Darnley wrote: > Speed of ffmpeg when decoding a 720p yuv422p10 file encoded with the > relevant transform. > C:119fps > SSE2: 204fps > AVX: 206fps > AVX2: 221fps > > timer measurements, haar horizontal compose: > sse2: 3.68x faster (45143 vs. 12279 decicy

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-07-26 Thread Vittorio Giovara
On Thu, Jul 26, 2018 at 4:15 PM, Rostislav Pehlivanov wrote: > Hey, > > As of now, the ambisonics API is enabled by default in libopus. We still > don't have a way to signal ambisonics yet. > We still have plenty of bits left in libavutil/channel_layout.h to signal > many orders of ambisonics but

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-07-26 Thread Rostislav Pehlivanov
Hey, As of now, the ambisonics API is enabled by default in libopus. We still don't have a way to signal ambisonics yet. We still have plenty of bits left in libavutil/channel_layout.h to signal many orders of ambisonics but some people have had opinions against extending that API. We could instea

[FFmpeg-devel] [PATCH 0/1] libavformat/dashenc: Fix relative URI of HLS master playlist

2018-07-26 Thread Antonio Morell
When using the DASH muxer to produce a segmented media stream, enabling the setting "hls_playlist" yields also HLS-compatible master and playlist manifest files. However, the relative URI of the master playlist is not formed as expected, since an extra slash preceeds the file name, i.e., ::///PATH

[FFmpeg-devel] [PATCH 1/1] libavformat/dashenc: Fix relative URI of HLS master playlist

2018-07-26 Thread Antonio Morell
--- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a9b8b1d4f6..ae57fd5493 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -868,7 +868,7 @@ static int write_manifest(AVFormatContext *s,

Re: [FFmpeg-devel] About the maintainer of mips

2018-07-26 Thread yinshiyou...@loongson.cn
>> I hered from the previous mantainer for mips that he was no longer part of >> mips company,and as a result, my patch was still pending review. >> Will ffmpeg community asign new mantainer for mips? > >No, you have to send a patch that changes the maintainership to you, >see MAINTAINERS in the m

[FFmpeg-devel] [PATCH 1/3] diracdec: add 10-bit Haar SIMD functions

2018-07-26 Thread James Darnley
Speed of ffmpeg when decoding a 720p yuv422p10 file encoded with the relevant transform. C:119fps SSE2: 204fps AVX: 206fps AVX2: 221fps timer measurements, haar horizontal compose: sse2: 3.68x faster (45143 vs. 12279 decicycles) compared with C avx: 3.68x faster (45143 vs. 12275 deci

[FFmpeg-devel] [PATCH 0/3 v2] x86 SIMD for dirac 10-bit wavelet transforms

2018-07-26 Thread James Darnley
I will ask the same question as last time. Is the AVX worth it in Haar? Also I am surprised that the AVX2 doesn't have a bigger difference on some of the vertical transforms. James Darnley (3): diracdec: add 10-bit Haar SIMD functions diracdec: add 10-bit Legall 5,3 (5_3) SIMD functions di

[FFmpeg-devel] [PATCH 3/3] diracdec: add 10-bit Deslauriers-Dubuc 9, 7 (9_7) vertical high-pass function

2018-07-26 Thread James Darnley
Speed of ffmpeg when decoding a 720p yuv422p10 file encoded with the relevant transform. C: 84fps SSE2: 111fps AVX2: 115fps dd97 vertical hi sse2: 2.77x faster (31773 vs. 11457 decicycles) compared with C avx2: 3.83x faster (31773 vs. 8297 decicycles) compared with C --- libavcodec/x

[FFmpeg-devel] [PATCH 2/3] diracdec: add 10-bit Legall 5, 3 (5_3) SIMD functions

2018-07-26 Thread James Darnley
Speed of ffmpeg when decoding a 720p yuv422p10 file encoded with the relevant transform. C: 94fps SSE2: 118fps AVX2: 121fps legall vertical hi sse2: 3.86x faster (20201 vs. 5231 decicycles) compared with C avx2: 6.70x faster (20201 vs. 3014 decicycles) compared with C legall vertical l

[FFmpeg-devel] [PATCH] avformat/librtmp: fix returning EOF from Read/Write

2018-07-26 Thread Timo Rothenpieler
--- libavformat/librtmp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c index f3cfa9a8e2..43013e46e0 100644 --- a/libavformat/librtmp.c +++ b/libavformat/librtmp.c @@ -261,7 +261,10 @@ static int rtmp_write(URLContext *

[FFmpeg-devel] [PATCH 2/2] lavc/encode: fix frame_number double-counted

2018-07-26 Thread Zhong Li
Encoder frame_number may be double-counted if some frames are cached and then flushed. Take qsv encoder (some frames are cached firsty for asynchronism) as example, ./ffmpeg -loglevel verbose -hwaccel qsv -c:v h264_qsv -i in.mp4 -vframes 100 -c:v h264_qsv out.mp4 frame_number passed to encoder is

[FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: expose qp of encoded frames

2018-07-26 Thread Zhong Li
Requirement from ticket #7254. Currently only H264 supported by MSDK. Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 43 +++ libavcodec/qsvenc.h | 2 ++ libavcodec/qsvenc_h264.c | 5 + 3 files changed, 50 insertions(+) diff --git a/liba

[FFmpeg-devel] [PATCH 1/2] tests/audiogen: raise channel count limit to 12

2018-07-26 Thread Tobias Rapp
Signed-off-by: Tobias Rapp --- tests/audiogen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/audiogen.c b/tests/audiogen.c index 8d596b5..c43bb70 100644 --- a/tests/audiogen.c +++ b/tests/audiogen.c @@ -26,7 +26,7 @@ #include #include -#define MAX_CHANNELS 8 +#d

[FFmpeg-devel] [PATCH 2/2] fate: add tests for audio channel up-/downmixing with pan filter

2018-07-26 Thread Tobias Rapp
Add tests for upmixing and downmixing with audio channel counts that have a corresponding default layout and also tests where there is no default layout. Update the existing "stereo4" test so it actually outputs stereo like the other stereo tests. Rename the previous "stereo4" test into "upmix1".