Re: [FFmpeg-devel] [PATCH v6 3/3] aadec: improve seeking in mp3 content

2018-07-13 Thread Michael Niedermayer
On Fri, Jul 13, 2018 at 12:35:07PM +0200, Karsten Otto wrote: > MP3 frames may not be aligned to aa chunk boundaries. When seeking, > calculate the expected frame offset in the target chunk. Adjust the > timestamp and truncate the next packet accordingly. > > This solution works for the majority o

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/motion_estimation: use pixelutils API for sad.

2018-07-13 Thread Michael Niedermayer
On Fri, Jul 13, 2018 at 10:51:00AM +0200, Marton Balint wrote: > > > On Thu, 12 Jul 2018, myp...@gmail.com wrote: > > >On Thu, Jul 12, 2018 at 12:43 AM Marton Balint wrote: > >> > >> > >> > >>On Wed, 11 Jul 2018, Jun Zhao wrote: > >> > >>> use pixelutils API for sad in motion estimation. > >> >

Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-13 Thread Michael Niedermayer
On Fri, Jul 13, 2018 at 01:34:47PM +0530, Umair Khan wrote: > On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer > wrote: > > > > On Tue, Jul 10, 2018 at 08:10:00PM +0530, Umair Khan wrote: > > > Hi, > > > > > > Patch attached. > > > > > > -Umair > > > > > lrcdec.c |3 +++ > > > 1 file chan

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/dirac_dwt_template: Fix signedness regression in interleave()

2018-07-13 Thread Michael Niedermayer
On Fri, Jul 13, 2018 at 07:59:43PM +0200, James Darnley wrote: > On 2018-07-13 19:26, Michael Niedermayer wrote: > > Found-by: > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/dirac_dwt_template.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git

[FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: Use bytestream2 for peaks

2018-07-13 Thread Michael Niedermayer
This fixes out of array accesses No testcase known Signed-off-by: Michael Niedermayer --- libavcodec/cfhd.c | 10 +- libavcodec/cfhd.h | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c index ef5ebe42c5..76838f0869 100644 --- a/

[FFmpeg-devel] [PATCH 1/2] libavcodec/cfhd: Fix signed overflow in shift

2018-07-13 Thread Michael Niedermayer
Fixes: 8695/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CFHD_fuzzer-4906172426485760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/cfhd.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[FFmpeg-devel] [PATCH] avformat/mxfdec: drop invalid index table segments when sorting them

2018-07-13 Thread Marton Balint
This way we can guess a proper index instead of using an invalid one. Fixes seeking in the sample of ticket #5671. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavformat/mxfdec.c b/libavfor

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: only return stream indexes which have a corresponding track

2018-07-13 Thread Marton Balint
On Wed, 4 Jul 2018, Marton Balint wrote: Without this check some crafted files might crash because a packet might be demuxed which have no corresponding mxf track. Applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] ffplay: add support for various YUV conversion modes

2018-07-13 Thread Marton Balint
On Fri, 13 Jul 2018, Carl Eugen Hoyos wrote: 2018-07-02 23:53 GMT+02:00, Marton Balint : SDL from version 2.0.8 has support for full range YUV and specifying BT601/BT709 color space for YUV->RGB conversion. Signed-off-by: Marton Balint --- fftools/ffplay.c | 18 ++ 1 file c

Re: [FFmpeg-devel] [PATCH] ffplay: add support for various YUV conversion modes

2018-07-13 Thread Carl Eugen Hoyos
2018-07-02 23:53 GMT+02:00, Marton Balint : > SDL from version 2.0.8 has support for full range YUV and specifying > BT601/BT709 color space for YUV->RGB conversion. > > Signed-off-by: Marton Balint > --- > fftools/ffplay.c | 18 ++ > 1 file changed, 18 insertions(+) > > diff --gi

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/internal: increase FF_SANE_NB_CHANNELS to 256

2018-07-13 Thread Marton Balint
On Tue, 3 Jul 2018, Marton Balint wrote: This was reduced from 128 in libav commit 192f1984b1a93aa08af053b8f9ab4950f307bd5d, but since we support unknown channel layouts, we can increase this limit. Fixes ticket #6332. Applied. Might make sense to increase SWR_CH_MAX in libswresample/swres

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: report insane channel count errors

2018-07-13 Thread Marton Balint
On Wed, 4 Jul 2018, Michael Niedermayer wrote: On Tue, Jul 03, 2018 at 12:51:11PM +0200, Marton Balint wrote: More than 64 is not *that* insane, so let's report the error at least. Signed-off-by: Marton Balint --- libavcodec/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libav

Re: [FFmpeg-devel] [PATCH] ffplay: add support for various YUV conversion modes

2018-07-13 Thread Marton Balint
On Mon, 2 Jul 2018, Marton Balint wrote: SDL from version 2.0.8 has support for full range YUV and specifying BT601/BT709 color space for YUV->RGB conversion. Applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Thilo Borgmann
[...] > 0001-avfilter-added-colorconstancy.patch > > > From 75ff45f28690cf208058315e4a3ec48e7981b837 Mon Sep 17 00:00:00 2001 > From: Mina > Date: Thu, 12 Jul 2018 20:19:55 +0200 > Subject: [PATCH] avfilter: added colorconstancy > > Signed-off-by: Mina > --- > Changelog

Re: [FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Thilo Borgmann
Hi, >>>This patch introduces Grey-Edge algorithm as part of the Color >>> Constancy Filter project in GSOC. >>> >> >> Docs missing. >> >> > The filter isn't completely finished yet and documentation is planed before > the GSOC duration is finished. for this patch the question is if what is in

Re: [FFmpeg-devel] [PATCH]lavc/aarch64/h264_init_aarch64: Fix weight function prototypes

2018-07-13 Thread Carl Eugen Hoyos
2018-01-21 0:19 GMT+01:00, Carl Eugen Hoyos : > Attached patch fixes a warning when compiling for aarch64, fate passes. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH]configure: Force pie for Android

2018-07-13 Thread Carl Eugen Hoyos
Hi! A user pointed out that Android requires pie since Lollipop. Please comment, Carl Eugen From eb04227c4c2cee59b257b2ef91316d0c674575bf Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 13 Jul 2018 20:46:18 +0200 Subject: [PATCH] configure: Force pie for Android. Position-independet

Re: [FFmpeg-devel] [PATCH] lavfi/colorspace: Suppress compile warning on incompatible pointer type.

2018-07-13 Thread Carl Eugen Hoyos
2018-07-13 16:37 GMT+02:00, Ruiling Song : > Signed-off-by: Ruiling Song > --- > Sorry I have not verified this patch, I don't know how to > reproduce the gcc warning. To the best of my knowledge, this is because the issue is not reproducible with newer compilers. This patch is therefore unneces

[FFmpeg-devel] [PATCH] fate: add more vc2 encoder tests

2018-07-13 Thread James Darnley
From: James Darnley --- tests/fate/vcodec.mak | 24 tests/ref/vsynth/vsynth1-vc2-5_3 | 4 tests/ref/vsynth/vsynth1-vc2-haar | 4 tests/ref/vsynth/vsynth2-vc2-5_3 | 4 tests/ref/vsynth/vsynth2-vc2-haar | 4 tests/r

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/dirac_dwt_template: Fix signedness regression in interleave()

2018-07-13 Thread James Darnley
On 2018-07-13 19:26, Michael Niedermayer wrote: > Found-by: > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dirac_dwt_template.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/dirac_dwt_template.c b/libavcodec/dirac_dwt_template.c > index 528f

[FFmpeg-devel] [PATCH] lavfi/colorspace: Suppress compile warning on incompatible pointer type.

2018-07-13 Thread Ruiling Song
Signed-off-by: Ruiling Song --- Sorry I have not verified this patch, I don't know how to reproduce the gcc warning. Thanks! Ruiling libavfilter/vf_colorspace.c | 16 libavfilter/vf_tonemap_opencl.c | 4 ++-- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/4] avcodec/dvdsub_parser: Allocate input padding

2018-07-13 Thread Michael Niedermayer
Fixes: out of array read Fixes: 9350/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_DVDSUB_fuzzer-574650765568 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dvdsub_parser.c | 6 +-

[FFmpeg-devel] [PATCH 1/4] avcodec/dirac_dwt_template: Fix signedness regression in interleave()

2018-07-13 Thread Michael Niedermayer
Found-by: Signed-off-by: Michael Niedermayer --- libavcodec/dirac_dwt_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dirac_dwt_template.c b/libavcodec/dirac_dwt_template.c index 528fc7e9e7..2369c8d15b 100644 --- a/libavcodec/dirac_dwt_template.c ++

[FFmpeg-devel] [PATCH 2/4] avcodec/vp8_parser: Remove redundant output initialization

2018-07-13 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vp8_parser.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/vp8_parser.c b/libavcodec/vp8_parser.c index e2d91b271f..7ce35e7535 100644 --- a/libavcodec/vp8_parser.c +++ b/libavcodec/vp8_parser.c @@ -70,8 +70,6 @@ static int parse(

[FFmpeg-devel] [PATCH 3/4] avcodec/dvdsub_parser: Init output buf/size

2018-07-13 Thread Michael Niedermayer
No testcase Signed-off-by: Michael Niedermayer --- libavcodec/dvdsub_parser.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/dvdsub_parser.c b/libavcodec/dvdsub_parser.c index 32a945ed65..8e1c48bef6 100644 --- a/libavcodec/dvdsub_parser.c +++ b/libavcodec/dvdsub_parser.c @@ -4

Re: [FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Mina Samy
On Fri, Jul 13, 2018 at 12:10 PM, Gyan Doshi wrote: > > > On 13-07-2018 02:44 PM, Mina wrote: > >> >>This patch introduces Grey-Edge algorithm as part of the Color >> Constancy Filter project in GSOC. >> > > Docs missing. > > The filter isn't completely finished yet and documentation is plane

Re: [FFmpeg-devel] [PATCH] avcodec/mips: fix conflicting types error of ff_vc1_h_s_overlap_mmi.

2018-07-13 Thread Jerome Borsboom
> In commit 975a1a8,function ff_vc1_h_s_overlap_mmi was refactored, > but the declaration in libavcodec/mips/vc1dsp_mips.h was unchanged. > > Change-Id: I90beae683511622a0cc1130ab1660ac8669ec3ef > Signed-off-by: Shiyou Yin > --- > libavcodec/mips/vc1dsp_mips.h | 2 +- > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [FFmpeg-user] fMP4 generation speed

2018-07-13 Thread Ronak Patel
I was wondering if anyone on the development list was familiar with this code and could provide pointers on how to fix up the code due to the below problem. > On Jul 12, 2018, at 7:27 PM, Ronak Patel > wrote: > > > >> On Jul 12, 2018, at 6:21 PM, Ronak Patel >> wrote: >> >> Hey Carl, >>

[FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-13 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. In ticket #6790 the problem has been pa

Re: [FFmpeg-devel] [PATCH] Use channel count if channel layout is undefined

2018-07-13 Thread Marcin Gorzel
On Fri, Jul 13, 2018 at 12:15 AM Michael Niedermayer wrote: > On Tue, Jul 10, 2018 at 10:34:51AM +0100, Marcin Gorzel wrote: > > Hi Michael, > > > > I think I know where the misunderstanding could be. > > > > The main changes in my patch are: > > > > rematrix.c:389 and rematrix_int.c:36: > > > >

[FFmpeg-devel] Is rate control/frame rate tied to AVCodecContext.time_base?

2018-07-13 Thread Robert Krüger
Hi, I recently changed code that uses libavcodec for encoding to use timebases with a higher granularity because there were cases where certain conversions resulted in timestamp clashes which I could fix that way. Now I realized that this totally screwed up rate control, e.g. for mpeg2video. Bitr

[FFmpeg-devel] [PATCH v7] Add lensfun filter

2018-07-13 Thread Stephen Seo
Lensfun is a library that applies lens correction to an image using a database of cameras/lenses (you provide the camera and lens models, and it uses the corresponding database entry's parameters to apply lens correction). It is licensed under LGPL3. The lensfun filter utilizes the lensfun library

[FFmpeg-devel] [PATCH v6 3/3] aadec: improve seeking in mp3 content

2018-07-13 Thread Karsten Otto
MP3 frames may not be aligned to aa chunk boundaries. When seeking, calculate the expected frame offset in the target chunk. Adjust the timestamp and truncate the next packet accordingly. This solution works for the majority of tested audio material. For some rare encodings with mp3 padding or emb

Re: [FFmpeg-devel] [PATCH V2 1/2] lavc/hevc_ps: Refine sps_range_extension parse.

2018-07-13 Thread Michael Niedermayer
On Thu, Jul 12, 2018 at 10:28:43PM +0800, Jun Zhao wrote: > Signed-off-by: Jun Zhao > --- > libavcodec/hevc_ps.c |6 ++ > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index bca3abb..bc5406b 100644 > --- a/libavcodec/hevc_

Re: [FFmpeg-devel] [PATCH V2 2/2] lavc/hevc_ps: use skip_bits instead of get_bits when skip bits.

2018-07-13 Thread Michael Niedermayer
On Thu, Jul 12, 2018 at 10:28:44PM +0800, Jun Zhao wrote: > use skip_bits when want to skip some bits. > > Signed-off-by: Jun Zhao > --- > libavcodec/hevc_ps.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index bc54

Re: [FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Gyan Doshi
On 13-07-2018 02:44 PM, Mina wrote:   This patch introduces Grey-Edge algorithm as part of the Color Constancy Filter project in GSOC. Docs missing. Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [PATCH] https://trac.ffmpeg.org/ticket/7030 fix

2018-07-13 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Mark Thompson > Sent: Thursday, July 12, 2018 7:46 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH] https://trac.ffmpeg.org/ticket/7030 fix > > On 04/07/18 05:07, Li, Zhong wrote: > >> -Original

[FFmpeg-devel] [PATCH][GSOC] avfilter: added colorconstancy

2018-07-13 Thread Mina
Hi,   This patch introduces Grey-Edge algorithm as part of the Color Constancy Filter project in GSOC. Best regards, Mina Sami >From 75ff45f28690cf208058315e4a3ec48e7981b837 Mon Sep 17 00:00:00 2001 From: Mina Date: Thu, 12 Jul 2018 20:19:55 +0200 Subject: [PATCH] avfilter: added colorconsta

Re: [FFmpeg-devel] [PATCH v6] Add lensfun filter

2018-07-13 Thread Moritz Barsnick
Hi Stephen, On Fri, Jul 13, 2018 at 15:00:24 +0900, Stephen Seo wrote: One more, I missed this previously: > +a = sqrt((float)index / LANCZOS_RESOLUTION); You're nicely sticking strictly to float (vs. double) in your code. So this one should be sqrtf(), not sqrt(). Cheers,

Re: [FFmpeg-devel] [PATCH v5] Add lensfun filter

2018-07-13 Thread Moritz Barsnick
On Fri, Jul 13, 2018 at 12:07:05 +0900, Stephen Seo wrote: > > If you're logging the model on success, you might as well also log it > > on failure. > Actually, it is impossible to log the model because on failure, the pointer > to camera/lens is NULL, which is where such info is originally derived

Re: [FFmpeg-devel] [PATCH 3/3] lavfi/motion_estimation: use pixelutils API for sad.

2018-07-13 Thread Marton Balint
On Thu, 12 Jul 2018, myp...@gmail.com wrote: On Thu, Jul 12, 2018 at 12:43 AM Marton Balint wrote: On Wed, 11 Jul 2018, Jun Zhao wrote: > use pixelutils API for sad in motion estimation. Does it make sense to improve this code? I thought a superior and faster approach was a result of 20

Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-13 Thread Umair Khan
On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer wrote: > > On Tue, Jul 10, 2018 at 08:10:00PM +0530, Umair Khan wrote: > > Hi, > > > > Patch attached. > > > > -Umair > > > lrcdec.c |3 +++ > > 1 file changed, 3 insertions(+) > > 6782b07bfa45139361c15527ee5fb78e5893b9ba > > 0001-avforma

[FFmpeg-devel] [PATCH 9/9] avcodec/mips: [loongson] optimize vp8 decoding in vp8dsp.

2018-07-13 Thread Shiyou Yin
From: gxw Optimize vp8 loop filter with mmi, four functions optimized: 1. ff_vp8_h_loop_filter8uv_mmi. 2. ff_vp8_v_loop_filter8uv_mmi. 3. ff_vp8_h_loop_filter16_mmi. 4. ff_vp8_v_loop_filter16_mmi. Vp8 decoding speed improved about 50%(from 73fps to 110fps, Tested on loongson 3A3000). Change-Id