Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread Gyan Doshi
On 17-06-2018 01:23 AM, John Stebbins wrote: On 06/16/2018 03:49 AM, Gyan Doshi wrote: Activates functionality added a few years ago. Regards, Gyan FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it

[FFmpeg-devel] [PATCH 4/4] mpegvideo_enc: add intra_penalty option for p frames

2018-06-16 Thread Ramiro Polla
This option allows more control over the use of intra macroblocks in predictive frames. By using '-intra_penalty max', intra macroblocks are never used in predictive frames. It is useful for glitch artists to generate input material. This option allows them to split and merge two video files whil

[FFmpeg-devel] [PATCH 2/4] mpegutils: split debug function that prints mb_type so it may be used by ffprobe

2018-06-16 Thread Ramiro Polla
--- libavcodec/mpegutils.c | 115 + libavcodec/mpegutils.h | 7 +++ 2 files changed, 76 insertions(+), 46 deletions(-) diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c index 0fbe5f8c9d..12c2468797 100644 --- a/libavcodec/mpegutils.c ++

[FFmpeg-devel] [PATCH 3/4] ffprobe: print mb_types frame side data

2018-06-16 Thread Ramiro Polla
--- fftools/ffprobe.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 544786ec72..5bd14ebfdb 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -30,6 +30,7 @@ #include "libavformat/avformat.h" #include "libavcodec/avco

Re: [FFmpeg-devel] [PATCH] mpegvideo_enc: add option to disable intra mbs in p frames

2018-06-16 Thread Ramiro Polla
On Sun, Jun 10, 2018 at 2:32 AM, Michael Niedermayer wrote: > On Sat, Jun 09, 2018 at 05:09:13PM +0200, Ramiro Polla wrote: >> On Thu, May 10, 2018 at 11:01 PM, Michael Niedermayer >> wrote: >> > On Wed, May 09, 2018 at 08:44:25PM +0200, Ramiro Polla wrote: >> >> This option prevents the mpv enco

[FFmpeg-devel] [PATCH 1/4] lavu/frame: add mb_types side data

2018-06-16 Thread Ramiro Polla
--- libavcodec/avcodec.h | 4 libavcodec/mpegutils.c | 20 libavcodec/options_table.h | 1 + libavutil/frame.c | 1 + libavutil/frame.h | 9 + 5 files changed, 35 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec

Re: [FFmpeg-devel] Fw: [PATCH] Refactor two near-identical clauses.

2018-06-16 Thread Michael Niedermayer
On Tue, Jun 12, 2018 at 12:53:20PM +0300, Shlomi Fish wrote: > This message did not arrive to the list after three submissions. > > Begin forwarded message: > > Date: Tue, 12 Jun 2018 12:42:52 +0300 > From: Shlomi Fish > To: ffmpeg-devel@ffmpeg.org > Cc: Shlomi Fish > Subject: [PATCH] Refactor

[FFmpeg-devel] [PATCH] lavc/libopusenc: add support for specifying signal type

2018-06-16 Thread Takayuki 'January June' Suwa
--- doc/encoders.texi | 14 ++ libavcodec/libopusenc.c | 11 +++ 2 files changed, 25 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 7b095754d1..6d0fc8e63e 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -986,6 +986,20 @@ If set to 0, dis

Re: [FFmpeg-devel] [PATCH]lavc/dpx: Support 10-bit packing method b (msbpad)

2018-06-16 Thread Carl Eugen Hoyos
2018-06-16 21:32 GMT+02:00, Jerome Martinez : > On 16/06/2018 17:49, Carl Eugen Hoyos wrote: >> +*lbuf = (*lbuf << 10) | (*lbuf >> shift); > > Padding bits are 0 in all DPX files I have seen up to now > but in theory padding bits are not defined Of course not, new patch attached. Thank you!

Re: [FFmpeg-devel] [PATCH]lavc/dpx: Support 12-bit packing method b (msbpad)

2018-06-16 Thread Carl Eugen Hoyos
2018-06-16 17:18 GMT+02:00, Carl Eugen Hoyos : > Attached patch allows to decode files that can be created with > GraphicsMagick: > $ gm convert input -depth 12 -define dpx:packing-method=b out.dpx Updated patch attached, hoping I understood Jerome's comment correctly. Please comment, Carl Eugen

Re: [FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread John Stebbins
On 06/16/2018 03:49 AM, Gyan Doshi wrote: > Activates functionality added a few years ago. > > Regards, > Gyan > FYI, HandBrake has been using the "handler" metadata key since 2014 when I added this code.  And it was completely self-consistent (since it was the only occurrence of usage of this k

Re: [FFmpeg-devel] [PATCH]lavc/dpx: Support 10-bit packing method b (msbpad)

2018-06-16 Thread Jerome Martinez
On 16/06/2018 17:49, Carl Eugen Hoyos wrote: Hi! Attached patch allows to decode 10-bit dpx files with packing method b, needs the 12-bit patch. Great to see the support of Method B. Please comment, Carl Eugen [...] +    *lbuf = (*lbuf << 10) | (*lbuf >> shift); Padding bits are 0 in al

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vaapi: slice_vertical_position starts from zero for the second field

2018-06-16 Thread Carl Eugen Hoyos
2018-06-08 11:09 GMT+02:00, Jerome Borsboom : > If there are no more issues or remarks with these two patches, could > someone please commit them? I cannot test, sorry! Perhaps you could send your public git key to Michael and push yourself? Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vc1: fix overlap filtering for Simple and Main profile

2018-06-16 Thread Carl Eugen Hoyos
2018-06-06 21:20 GMT+02:00, Carl Eugen Hoyos : > 2018-06-06 20:47 GMT+02:00, Jerome Borsboom : >> Overlap filtering I and BI frames for Simple and Main profile is only >> dependent on PQUANT. Restrict testing for CONDOVER and OVERFLAGS to >> advanced profile. >> >> Signed-off-by: Jerome Borsboom >

Re: [FFmpeg-devel] [PATCH v2] avcodec/vc1: fix overlap smoothing filter for P frames

2018-06-16 Thread Carl Eugen Hoyos
2018-05-30 13:53 GMT+02:00, Jerome Borsboom : > The v_overlap_filter needs to run on the colocated block of the previous > macroblock. For the luma plane, the colocated block is located two blocks > on the left instead of one. In addition, the overlap filter needs to run > on the non-edge blocks of

Re: [FFmpeg-devel] Fw: [PATCH] Refactor two near-identical clauses.

2018-06-16 Thread Shlomi Fish
On Tue, 12 Jun 2018 12:53:20 +0300 Shlomi Fish wrote: > This message did not arrive to the list after three submissions. > hi all! Ping! Can this patch please be reviewed? > Begin forwarded message: > > Date: Tue, 12 Jun 2018 12:42:52 +0300 > From: Shlomi Fish > To: ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]lavc/dpx: Support 10-bit packing method b (msbpad)

2018-06-16 Thread Carl Eugen Hoyos
Hi! Attached patch allows to decode 10-bit dpx files with packing method b, needs the 12-bit patch. Please comment, Carl Eugen From 401bdebba6dc8fa2253c720107a971b3fbf2c312 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 16 Jun 2018 17:47:46 +0200 Subject: [PATCH] lavc/dpx: Support 10

[FFmpeg-devel] [PATCH]lavc/dpx: Support 12-bit packing method b (msbpad)

2018-06-16 Thread Carl Eugen Hoyos
Hi! Attached patch allows to decode files that can be created with GraphicsMagick: $ gm convert input -depth 12 -define dpx:packing-method=b out.dpx Please comment, Carl Eugen From 93c9de7a1ca638dfe7bb2a4108974e55ab13c9b8 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 16 Jun 2018 17:

Re: [FFmpeg-devel] [PATCH]lavfi/avfiltergraph: Do not return ENOMEM if filter is missing

2018-06-16 Thread Carl Eugen Hoyos
2018-02-05 3:05 GMT+01:00, James Almer : > On 2/4/2018 10:33 PM, Carl Eugen Hoyos wrote: >> Hi! >> >> OOM is unlikely as a failure for avfilter_graph_alloc_filter(), the >> patch avoids a surprising error if a filter was not found. >> >> Please comment, Carl Eugen >> >> >> 0001-lavfi-avfiltergraph-

[FFmpeg-devel] [PATCH]lavf/mov: Do not fail hard for truncated stsz atom

2018-06-16 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6433 for me, this is also what vlc does. Please comment, Carl Eugen From adfa5858eacbb6210e5e9da20284b3a27523e5b1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 16 Jun 2018 14:22:52 +0200 Subject: [PATCH] lavf/mov: Do not fail hard for truncated stsz

[FFmpeg-devel] [PATCH] avformat/movenc: read track title from correct key

2018-06-16 Thread Gyan Doshi
Activates functionality added a few years ago. Regards, Gyan From bead9f22630f2b8efc4a3859568cb0fc46102dd3 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 16 Jun 2018 15:31:51 +0530 Subject: [PATCH] avformat/movenc: read track title from correct key da9cc22d5bd allowed the MOV muxer to rel