Re: [FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-02 Thread Richard Shaffer
On Mon, Apr 2, 2018 at 10:15 PM, Steven Liu wrote: > > >> On 3 Apr 2018, at 12:33, Richard Shaffer wrote: >> >> On Mon, Apr 2, 2018 at 8:31 PM, Steven Liu wrote: >>> >>> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote: From: Richard Shaffer The rw_timeout option is c

[FFmpeg-devel] [PATCH] avformat/movenc: use correct iTunes copyright atom

2018-04-02 Thread Timo Teräs
Support for writing copyright metadata was added in commit bed4fc54c9 for 3GP, MOV and iTunes metadata. 3GP and MOV cases are formally specified. However, iTunes format does not have specification, and it seems to have been assumed that it would use the same atom as MOV (both being Apple formats).

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-02 Thread Mattias Amnefelt
Yes, my feeling was also that it's better to handle this when possible. You are of course correct that the two tags needs to be inbetween frames. Sorry about that, I stripped the sample down too much. I updated with a sample which has two frames. This new sample fails the test without the patc

Re: [FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-02 Thread Steven Liu
> On 3 Apr 2018, at 12:33, Richard Shaffer wrote: > > On Mon, Apr 2, 2018 at 8:31 PM, Steven Liu wrote: >> >> >>> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote: >>> >>> From: Richard Shaffer >>> >>> The rw_timeout option is currently not applied when opening media playlist, >>> segme

Re: [FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-02 Thread Richard Shaffer
On Mon, Apr 2, 2018 at 8:31 PM, Steven Liu wrote: > > >> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote: >> >> From: Richard Shaffer >> >> The rw_timeout option is currently not applied when opening media playlist, >> segment, or encryption key URLs. This can cause the HLS demuxer to block >>

Re: [FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-02 Thread Steven Liu
> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote: > > From: Richard Shaffer > > The rw_timeout option is currently not applied when opening media playlist, > segment, or encryption key URLs. This can cause the HLS demuxer to block > indefinitely, even when the rw_timeout option has been sp

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the general developers list

2018-04-02 Thread Steven Liu
> On 3 Apr 2018, at 07:24, Jun Zhao wrote: > > Want to close work with this community, so I request as > a general developer. > <0001-MAINTAINERS-add-myself-to-the-general-developers-lis.patch>___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] lavu: add a Vulkan hwcontext

2018-04-02 Thread Rostislav Pehlivanov
On 2 April 2018 at 21:24, Mark Thompson wrote: > On 30/03/18 04:14, Rostislav Pehlivanov wrote: > > This commit adds a Vulkan hwcontext, currently capable of mapping DRM and > > VAAPI frames but additional functionality can be added later to support > > importing of D3D11 surfaces as well as expo

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-04-02 Thread wm4
On Tue, 3 Apr 2018 00:45:17 +0200 Michael Niedermayer wrote: > So in this sense my question is what advantage the opaque side data based > system > has over a system simply using a C struct the way AVChapter works ? The _only_ reason the side data is opqaue is because side data can't contain po

[FFmpeg-devel] [PATCH v2 2/2] lavf/qsv: clone the frame which may be managed by framework

2018-04-02 Thread Ruiling Song
For filters based on framesync, the input frame was managed by framesync, so we should not directly keep and destroy it, instead we make a clone of it here, or else double-free will occur. But for other filters not based on framesync, we still need to free the input frame inside filter_frame. That'

[FFmpeg-devel] [PATCH v2 1/2] lavf: make overlay_qsv work based on framesync

2018-04-02 Thread Ruiling Song
The existing version which was cherry-picked from Libav does not work with FFmpeg framework, because ff_request_frame() was totally different between Libav (recursive) and FFmpeg (non-recursive). The existing overlay_qsv implementation depends on the recursive version of ff_request_frame to trigger

[FFmpeg-devel] [PATCH] avformat/hls: copy rw_timeout from parent to child AVIOContexts.

2018-04-02 Thread rshaffer
From: Richard Shaffer The rw_timeout option is currently not applied when opening media playlist, segment, or encryption key URLs. This can cause the HLS demuxer to block indefinitely, even when the rw_timeout option has been specified. This change simply enables carrying over the rw_timeout opti

Re: [FFmpeg-devel] [PATCH 2/3] lavfi: add common Vulkan filtering code

2018-04-02 Thread Rostislav Pehlivanov
On 2 April 2018 at 21:50, Mark Thompson wrote: > On 30/03/18 04:14, Rostislav Pehlivanov wrote: > > This commit adds a common code for use in Vulkan filters. It attempts > > to ease the burden of writing Vulkan image filtering to a minimum, > > which is pretty much a requirement considering how v

Re: [FFmpeg-devel] [PATCH 1/3] lavu: add a Vulkan hwcontext

2018-04-02 Thread Rostislav Pehlivanov
On 2 April 2018 at 21:24, Mark Thompson wrote: > On 30/03/18 04:14, Rostislav Pehlivanov wrote: > > This commit adds a Vulkan hwcontext, currently capable of mapping DRM and > > VAAPI frames but additional functionality can be added later to support > > importing of D3D11 surfaces as well as expo

Re: [FFmpeg-devel] [PATCH] avcodec/clearvideo: add inter-frame decoding

2018-04-02 Thread Michael Niedermayer
On Mon, Apr 02, 2018 at 08:18:02PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/clearvideo.c | 2394 > ++- > 1 file changed, 2378 insertions(+), 16 deletions(-) > [...] > @@ -271,6 +2022,332 @@ static int decode_mb(CLVC

Re: [FFmpeg-devel] swscale/swscale_unscaled : add X86_64 (SSE2, AVX) for uyvyto422

2018-04-02 Thread James Almer
On 4/2/2018 8:33 PM, Carl Eugen Hoyos wrote: > 2018-04-02 23:26 GMT+02:00, Martin Vignali : > >> Around 20% faster (on a "benchmark cmd", who test pix_fmt conversion) >> (4.2s with the patch, 5.2s without) >> >> Pass fate test for me. >> >> Checkasm result : >> uyvytoyuv422_c: 14146.6 >> uyvytoyu

Re: [FFmpeg-devel] swscale/swscale_unscaled : add X86_64 (SSE2, AVX) for uyvyto422

2018-04-02 Thread Carl Eugen Hoyos
2018-04-02 23:26 GMT+02:00, Martin Vignali : > Around 20% faster (on a "benchmark cmd", who test pix_fmt conversion) > (4.2s with the patch, 5.2s without) > > Pass fate test for me. > > Checkasm result : > uyvytoyuv422_c: 14146.6 > uyvytoyuv422_mmx: 13696.4 > uyvytoyuv422_mmxext: 19395.9 Somethi

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-04-02 Thread Michael Niedermayer
On Mon, Apr 02, 2018 at 11:52:42AM +0200, Vittorio Giovara wrote: > On 3/20/18, Michael Niedermayer > wrote: > >* Signed-off-by: Michael Niedermayer >> > *>* --- > *>* libavfilter/vf_scale.c | 7 +++

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the general developers list

2018-04-02 Thread Jun Zhao
Want to close work with this community, so I request as a general developer. From 4a21d75db2070031986d92cde45d3c1ea64f0cfa Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 3 Apr 2018 07:14:46 +0800 Subject: [PATCH] MAINTAINERS: add myself to the general developers list Signed-off-by: Jun Zhao

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

2018-04-02 Thread Michael Niedermayer
On Mon, Apr 02, 2018 at 12:02:38PM +0300, Timo Teras wrote: > On Fri, 30 Mar 2018 04:06:03 +0300 > Timo Teras wrote: > > > On Fri, 30 Mar 2018 02:39:13 +0200 > > Michael Niedermayer wrote: > > > > > git log points to > > > bed4fc54c947b9e36d2103b400d438bfb4dd80dd > > > > > > This commit added

Re: [FFmpeg-devel] [PATCH 2/2] lavc: Add VP9 metadata bitstream filter

2018-04-02 Thread James Almer
On 4/2/2018 7:47 PM, Mark Thompson wrote: > Can adjust the colour information. > --- > And nothing else, so meh. Still, offers a clean filter for testing VP9 CBS. > > I think it should have some FATE tests along the same lines as H.26[45] and > MPEG-2, running across a set of streams and making

[FFmpeg-devel] [PATCH 1/2] lavc: Add coded bitstream read/write support for VP9

2018-04-02 Thread Mark Thompson
--- Written a while ago but never sent, because it wasn't particularly useful beyond the learning exercise of writing it. However, it does now have parts in common with AV1 where this will be more useful, so here we go. configure| 2 + libavcodec/Makefile

[FFmpeg-devel] [PATCH 2/2] lavc: Add VP9 metadata bitstream filter

2018-04-02 Thread Mark Thompson
Can adjust the colour information. --- And nothing else, so meh. Still, offers a clean filter for testing VP9 CBS. I think it should have some FATE tests along the same lines as H.26[45] and MPEG-2, running across a set of streams and making sure it reads and writes them back correctly. Not cl

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-04-02 Thread Michael Niedermayer
Hi On Mon, Apr 02, 2018 at 04:46:18PM +0100, Derek Buitenhuis wrote: > On 4/1/2018 10:38 PM, Michael Niedermayer wrote: > >> I agree that the APIs are annoyingly different, but that they should remain > >> separate APIs. The suggestion of aligned (same names, args, etc.) seems the > >> most reason

Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: fix encoding of sRGB streams

2018-04-02 Thread James Almer
On 4/1/2018 11:03 PM, James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libaomenc.c | 25 ++--- > 1 file changed, 22 insertions(+), 3 deletions(-) Patch dropped. The whole gbrp output stuff is kinda weird, so I'll leave it to someone else. ___

[FFmpeg-devel] [PATCH] lavc/amfenc: Reference to input AVFrame (hwaccel) is retained during the encoding process

2018-04-02 Thread Alexander Kravchenko
Hello, Mark, Did you have a chance to review the latest version patch? Thanks, Alexander ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] swscale/swscale_unscaled : add X86_64 (SSE2, AVX) for uyvyto422

2018-04-02 Thread Martin Vignali
Hello, In attach patch to add SSE and AVX SIMD (x86_64) for uyvyto422 Write using external ASM (keep a similar logic, than the MMX Inline version) also add checkasm test uyvy is use by some devices (like decklink, to provide raw data) Around 20% faster (on a "benchmark cmd", who test pix_fmt c

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-02 Thread Richard Shaffer
It seems like some software can insert an additional ID3v2 tag instead of appending a frame to an existing one. One could argue that that is somewhat broken, but I agree it's better to handle it instead of returning an error. The changes in aacdec.c look ok to me. The fate sample you provided has

Re: [FFmpeg-devel] [PATCH] avcodec/cscd: Error out when LZ* decompression fails

2018-04-02 Thread Michael Niedermayer
On Mon, Mar 12, 2018 at 12:32:53AM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 6304/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CSCD_fuzzer-5754772461191168 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec_fixed: Fix integer overflow in apply_independent_coupling_fixed()

2018-04-02 Thread Michael Niedermayer
On Sat, Mar 31, 2018 at 09:44:23PM +0200, Michael Niedermayer wrote: > I was not able to reproduce this, this fix is based on just the fuzzer log. > Fixes: 4959/clusterfuzz-testcase-minimized-6035350934781952 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/maste

[FFmpeg-devel] [PATCH] libavcodec/rv34: error out earlier on missing references

2018-04-02 Thread Michael Niedermayer
Fixes visual corruption on seeking Fixes: downloadTest_clip_24M.rmvb Signed-off-by: Michael Niedermayer --- libavcodec/rv34.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c index f1495fb5a8..d171e6e1bd 100644 --- a/libavcodec/rv34

Re: [FFmpeg-devel] [PATCH 3/3] lavfi: add a Vulkan avgblur filter

2018-04-02 Thread Mark Thompson
On 30/03/18 04:14, Rostislav Pehlivanov wrote: > This commit adds an average blur Vulkan filter which functions > exactly the same as avgblur but on Vulkan surfaces. > > Currently contains a workaround that will be removed for the actual, > non-RFC version. > > It implements a clever way of minim

Re: [FFmpeg-devel] [PATCH 2/3] lavfi: add common Vulkan filtering code

2018-04-02 Thread Mark Thompson
On 30/03/18 04:14, Rostislav Pehlivanov wrote: > This commit adds a common code for use in Vulkan filters. It attempts > to ease the burden of writing Vulkan image filtering to a minimum, > which is pretty much a requirement considering how verbose the API is. > > It supports both compute and grap

Re: [FFmpeg-devel] [PATCH 1/3] lavu: add a Vulkan hwcontext

2018-04-02 Thread Mark Thompson
On 30/03/18 04:14, Rostislav Pehlivanov wrote: > This commit adds a Vulkan hwcontext, currently capable of mapping DRM and > VAAPI frames but additional functionality can be added later to support > importing of D3D11 surfaces as well as exporting to various other APIs. Assuming you haven't done t

Re: [FFmpeg-devel] [PATCH] Support for Ambisonics and OpusProjection* API.

2018-04-02 Thread Drew Allen
Friendly ping to allow this to push to the member list, please. On Wed, Mar 28, 2018 at 2:58 PM Drew Allen wrote: > Hello all, > > My name is Andrew Allen and I'm a contributor to Opus, supporting new > channel mappings 2 and 3 for ambisonics compression. I've attached a patch > to support the n

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: only set output stream index before returning packet

2018-04-02 Thread Marton Balint
On Sun, 1 Apr 2018, Nicolas George wrote: Marton Balint (2018-03-25): Fixes ticket #6434. Signed-off-by: Marton Balint --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) LGTM, thanks. Applied, thanks. Regards, Marton _

Re: [FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

2018-04-02 Thread Carl Eugen Hoyos
2018-04-02 19:49 GMT+02:00, Kieran Kunhya : > On Mon, 2 Apr 2018 at 18:04 Carl Eugen Hoyos wrote: > >> Hi! >> >> One of our few sstp samples triggers a repeated request for samples. >> ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf > I left the message there because I actually want more D

[FFmpeg-devel] [PATCH 0/1] re: Add Sega FILM muxer

2018-04-02 Thread misty
From: Misty De Meo > I assume you copied the demuxer but shouldn't you be here as well? Good point, added! > I honestly think your comment style (i.e. C vs C++) should be consistent > throughout the file, but that's just me. OK, updated all the single-line comments to use the same format as th

Re: [FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

2018-04-02 Thread Kieran Kunhya
On Mon, 2 Apr 2018 at 18:04 Carl Eugen Hoyos wrote: > Hi! > > One of our few sstp samples triggers a repeated request for samples. > ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf > Hi, I left the message there because I actually want more DPCM samples. That one only has a small number

[FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-02 Thread misty
From: Misty De Meo --- Changelog | 1 + doc/general.texi | 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/segafilmenc.c | 398 ++ libavformat/version.h | 2 +- 6 files changed,

[FFmpeg-devel] [PATCH] lavf/mov.c: Fix timestamps to be strictly monotonic for video also.

2018-04-02 Thread Sasi Inguva
From: Sasi Inguva Using same timestamp for multiple packets confuses clients like Ffms2 while seeking to a packet with specific timestamp. Signed-off-by: Sasi Inguva --- libavformat/mov.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavform

[FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

2018-04-02 Thread Carl Eugen Hoyos
Hi! One of our few sstp samples triggers a repeated request for samples. ffmpeg-bugs/trac/ticket4447/A003C003_SR_422_23.98p.mxf Please comment, Carl Eugen From ab69d77146af4f9eaa12debf185d588b8db80c44 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 2 Apr 2018 18:56:37 +0200 Subject: [

Re: [FFmpeg-devel] [PATCH][RFC] avcodec/avutil: Add timeline side data

2018-04-02 Thread Derek Buitenhuis
On 4/1/2018 10:38 PM, Michael Niedermayer wrote: >> I agree that the APIs are annoyingly different, but that they should remain >> separate APIs. The suggestion of aligned (same names, args, etc.) seems the >> most reasonable to me - consistency. >> >> I don't really think they can share some commo

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: deprecate AV_PIX_FMT_FLAG_PSEUDOPAL

2018-04-02 Thread wm4
On Thu, 29 Mar 2018 15:30:43 +0200 wm4 wrote: > PSEUDOPAL pixel formats are not paletted, but carried a palette with the If nobody has any comments, I will push tonight or tomorrow or so. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
> On 2 Apr 2018, at 14:16, James Almer wrote: > >> On 4/2/2018 10:13 AM, Josh de Kock wrote: >> --- >> Changelog | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Changelog b/Changelog >> index 200866d873..f0b51ad1ee 100644 >> --- a/Changelog >> +++ b/Changelog >> @@ -52,6 +52,8 @@ v

Re: [FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread James Almer
On 4/2/2018 10:13 AM, Josh de Kock wrote: > --- > Changelog | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Changelog b/Changelog > index 200866d873..f0b51ad1ee 100644 > --- a/Changelog > +++ b/Changelog > @@ -52,6 +52,8 @@ version : > - E-AC-3 dependent frames support > - bitstream

[FFmpeg-devel] [PATCH] Changelog: add entry for new iteration API

2018-04-02 Thread Josh de Kock
--- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 200866d873..f0b51ad1ee 100644 --- a/Changelog +++ b/Changelog @@ -52,6 +52,8 @@ version : - E-AC-3 dependent frames support - bitstream filter for extracting E-AC-3 core - Haivision SRT protocol via

Re: [FFmpeg-devel] [PATCH 1/1] Add Sega FILM muxer

2018-04-02 Thread Josh de Kock
On 2018/04/02 3:56, mi...@brew.sh wrote: From: Misty De Meo [...] --- /dev/null +++ b/libavformat/segafilmenc.c @@ -0,0 +1,397 @@ +/* + * Sega FILM Format (CPK) Muxer + * Copyright (C) 2003 The FFmpeg project I assume you copied the demuxer but shouldn't you be here as well? + * + * This fil

[FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-02 Thread Mattias Amnefelt
This is a follow-up to https://patchwork.ffmpeg.org/patch/7477/ and changes so all ID3 tags between ADTS frames gets parsed, not just the first one. Sample media for the included fate test is available at http://mattias.amnefe.lt/tmp/id3v2_two_tags.aac From 2f681aa27c216a1aa8d8f2b643289dbf0

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: Do not set YUV color range for RGB formats

2018-04-02 Thread Vittorio Giovara
On 3/20/18, Michael Niedermayer http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>> wrote: >* Signed-off-by: Michael Niedermayer > *>* --- *>* libavfilter/vf_scale.c | 7 ++- *>* 1 file changed, 6 insertions(+), 1 deletion(-) *>>* diff --git a/lib

Re: [FFmpeg-devel] [PATCH 1/1] avformat/movenc: use modern iTunes copyright atom

2018-04-02 Thread Timo Teras
On Fri, 30 Mar 2018 04:06:03 +0300 Timo Teras wrote: > On Fri, 30 Mar 2018 02:39:13 +0200 > Michael Niedermayer wrote: > > > git log points to > > bed4fc54c947b9e36d2103b400d438bfb4dd80dd > > > > This commit added both cpy and cprt, that makes your hypothesis not > > fit very well > > That

[FFmpeg-devel] Decrease in activity for a month

2018-04-02 Thread Gagandeep Singh
As I had written in a previous mail that I will be trying to participate in gsoc for FFmpeg, that part I have committed to myself for the last month, but since my collage exams are after 3 weeks so for the this month I will usually be difficult to reach from irc. If anyone needs to contact me plea

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: debugged padding issue for last 8 pixels distortion

2018-04-02 Thread Gagandeep Singh
On Tue, 27 Mar 2018, 12:54 Gagandeep Singh, wrote: > fate reference has also been updated and can be tested that the patched > output is better for the sample cfhd_odd.mov in fate reference. fixes > ticket #6675. > --- > libavcodec/cfhd.c | 5 +++-- > tests/ref/fate/cfhd-3 | 20 ++--

[FFmpeg-devel] [PATCH v2 0/3] avformat/movenc: support writing iTunes cover image

2018-04-02 Thread Timo Teräs
Hi, This patch set adds support for writing iTunes cover images in mov muxer. Copying of the picture to attached_pic was not yet made common code. It is better to do this when additional users are introduced. Passes fate. valgrind says runs to add/copy cover images were without errors. Changes

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: support writing iTunes cover image

2018-04-02 Thread Timo Teräs
Fixes https://trac.ffmpeg.org/ticket/2798 This makes movenc handle AV_DISPOSITION_ATTACHED_PIC and write the associated pictures in iTunes cover atom. This corresponds to how 'mov' demuxer parses and exposes the cover images when reading. Most of the existing track handling loops properly ignore

[FFmpeg-devel] [PATCH 2/3] avformat/movenc: add rtp_hinting_needed() helper function

2018-04-02 Thread Timo Teräs
This is shared test and this simplifies code a bit. Follow up commit will have additional tests for this function. Signed-off-by: Timo Teräs --- libavformat/movenc.c | 30 -- 1 file changed, 12 insertions(+), 18 deletions(-) diff --git a/libavformat/movenc.c b/libavf

[FFmpeg-devel] [PATCH 1/3] ffmpeg: allow setting attached_pic disposition

2018-04-02 Thread Timo Teräs
This is used to signal that image should be stored in metadata as cover image. Signed-off-by: Timo Teräs --- fftools/ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 2f8a5ace56..4dbe72186d 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c