[FFmpeg-devel] [PATCH] avcodec/vp3: Error out on invalid num_coeffs in unpack_vlcs()

2018-02-10 Thread Michael Niedermayer
This fixes a hypothetical integer overflow Signed-off-by: Michael Niedermayer --- libavcodec/vp3.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 33be345c14..1d83753314 100644 --- a/libavcodec/vp3.c +++ b/libavcodec/vp3.c @@ -951,

[FFmpeg-devel] How to pass metadata between filters

2018-02-10 Thread Mujib Haider
Dear ffmpeg-devel, I have a general question about the capabilities of avfilter. Is it possible to send meta-data between avfilters? Specifically, I want to create a filter to take a single input image, and produce a single output image along with metadata which encodes information about the im

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-10 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 01:56:39PM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552 > Fixes: special case for theora (untested due to lack of sample) > > Found-by: continuous fuzzing process > https://github.com/google/os

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/utvideodec: Add several out of array read related checks

2018-02-10 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 10:24:59PM +0100, Michael Niedermayer wrote: > Fixes: OV_decode_plane.avi > > Found-by: GwanYeong Kim > Signed-off-by: Michael Niedermayer > --- > libavcodec/utvideodec.c | 17 - > 1 file changed, 12 insertions(+), 5 deletions(-) applied [...] -- Micha

Re: [FFmpeg-devel] [PATCH] avcodec/pafvideo: Check allocated frame size

2018-02-10 Thread Michael Niedermayer
On Sun, Feb 04, 2018 at 03:56:19AM +0100, Michael Niedermayer wrote: > Fixes: OOM > Fixes: 5549/clusterfuzz-testcase-minimized-5390553567985664 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] avcodec/scpr: Fix reading a pixel before the first

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 03, 2018 at 07:07:19PM +0100, Michael Niedermayer wrote: > Fixes: 5540/clusterfuzz-testcase-minimized-6122458273808384 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/sc

Re: [FFmpeg-devel] [PATCH] mpeg2dec: Fix motion vector rounding for chroma components

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 06:36:33PM +0900, Nekopanda wrote: > In 16x8 motion compensation, for lower 16x8 region, the input to > mpeg_motion() for motion_y was "motion_y + 16", which causes wrong rounding. > For 4:2:0, chroma scaling for y is dividing by two and rounding toward zero. > When motio

Re: [FFmpeg-devel] [PATCH] mpeg2dec: Fix field selection for skipped macroblocks

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 06:36:32PM +0900, Nekopanda wrote: > For B field pictures, the spec says, > > > The prediction shall be made from the field of the same parity as the field > > being predicted. > > I did it. > --- > libavcodec/mpeg12dec.c | 2 + > tests/ref/fate/mpeg2-ticket186

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-10 Thread Muhammad Faiz
On Sun, Feb 11, 2018 at 6:37 AM, Michael Niedermayer wrote: > On Sat, Feb 10, 2018 at 05:13:10PM +0700, Muhammad Faiz wrote: >> On Sat, Feb 10, 2018 at 7:51 AM, Michael Niedermayer >> wrote: >> > On Fri, Feb 09, 2018 at 10:21:04PM +0700, Muhammad Faiz wrote: >> >> On Fri, Feb 9, 2018 at 6:53 PM,

Re: [FFmpeg-devel] [PATCH] fate/libavcodec: add codec_desc test

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 04:37:00PM +0700, Muhammad Faiz wrote: > Remove runtime check at codec_desc.c > > Signed-off-by: Muhammad Faiz > --- > libavcodec/Makefile | 1 + > libavcodec/codec_desc.c | 24 --- > libavcodec/tests/codec_desc.c | 45 > +

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 05:13:10PM +0700, Muhammad Faiz wrote: > On Sat, Feb 10, 2018 at 7:51 AM, Michael Niedermayer > wrote: > > On Fri, Feb 09, 2018 at 10:21:04PM +0700, Muhammad Faiz wrote: > >> On Fri, Feb 9, 2018 at 6:53 PM, James Almer wrote: > >> > On 2/9/2018 7:56 AM, Muhammad Faiz wrote

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec: Constify several pointers

2018-02-10 Thread Muhammad Faiz
On Sat, Feb 10, 2018 at 8:57 AM, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes two warnings. > libavformat/rtpdec.c: In function ‘ff_rtp_handler_find_by_name’: > libavformat/rtpdec.c:155:20: warning: return discards ‘const’ > qualifier from pointer target type [-Wdiscarded-qualifiers] >

Re: [FFmpeg-devel] [PATCH] avformat/mpeg12enc: add support for specifying video_format in the sequence_display_extension

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 07:45:36PM +0100, Marton Balint wrote: > In a recent commit the default was changed from 0 (component) to 5 > (unspecified), however some standards require using 0. With this option, the > user will be able to do so. > > Signed-off-by: Marton Balint > --- > doc/encoders.t

Re: [FFmpeg-devel] [PATCH] avformat/mpeg12enc: add support for specifying video_format in the sequence_display_extension

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 07:45:36PM +0100, Marton Balint wrote: > In a recent commit the default was changed from 0 (component) to 5 > (unspecified), however some standards require using 0. With this option, the > user will be able to do so. > > Signed-off-by: Marton Balint > --- > doc/encoders.t

Re: [FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-02-10 Thread Carl Eugen Hoyos
2018-02-10 16:36 GMT+01:00 Kieran Kunhya : > $subj. Still depends on simple_idct template patch > +FF_ALLOCZ_OR_GOTO(s->avctx, s->block32, 64 * 12 * sizeof(int32_t), fail) I believe this should be sizeof(variable). > +} > +else { Since this is still unusual i

Re: [FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-02-10 Thread Michael Niedermayer
On Sat, Feb 10, 2018 at 03:36:21PM +, Kieran Kunhya wrote: > $subj. Still depends on simple_idct template patch > > Fixes crashes in ER [...] > diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h > index 0ba502d50b..3c9ec4ac42 100644 > --- a/libavcodec/mpeg4video.h > +++ b/libavcode

[FFmpeg-devel] [PATCH] avformat/mpeg12enc: add support for specifying video_format in the sequence_display_extension

2018-02-10 Thread Marton Balint
In a recent commit the default was changed from 0 (component) to 5 (unspecified), however some standards require using 0. With this option, the user will be able to do so. Signed-off-by: Marton Balint --- doc/encoders.texi | 5 + libavcodec/mpeg12enc.c | 12 ++-- libavcodec/mpe

[FFmpeg-devel] [PATCH] rawenc: use av_get_padded_bits_per_pixel() instead of non-padded bps

2018-02-10 Thread Rostislav Pehlivanov
Bitrate was calculated incorrectly. Signed-off-by: Rostislav Pehlivanov --- libavcodec/rawenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rawenc.c b/libavcodec/rawenc.c index d181b74570..cd476d4bb1 100644 --- a/libavcodec/rawenc.c +++ b/libavcodec/rawenc.c @@

[FFmpeg-devel] [PATCH 2/2] avformat/concatdec: add support for very long line sizes

2018-02-10 Thread Marton Balint
Fixes ticket #6761. Signed-off-by: Marton Balint --- libavformat/concatdec.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index 178fac86cb..3e41a62a36 100644 --- a/libavformat/concatdec.c +++ b/libavfor

[FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: add ff_read_line_to_bprint and ff_read_line_to_bprint_overwrite functions

2018-02-10 Thread Marton Balint
To be able to read lines longer than a static buffer size. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 46 ++ libavformat/internal.h | 26 ++ 2 files changed, 72 insertions(+) diff --git a/libavformat/aviobuf.c b/

Re: [FFmpeg-devel] [PATCH] lavf/aptxdec: fix the limit on the APTX demuxer definition

2018-02-10 Thread Jan Ekström
On Sat, Feb 10, 2018 at 6:27 PM, James Almer wrote: > > I know it's a simple fix so in this case it's fine, but keep in mind > Aurelien Jacobs is the maintainer of aptx for future patches. Yes, if this was less straightforward I would have waited for the maintainer. Jan _

Re: [FFmpeg-devel] [PATCH] lavf/aptxdec: fix the limit on the APTX demuxer definition

2018-02-10 Thread James Almer
On 2/10/2018 1:21 PM, Jan Ekström wrote: > On Sat, Feb 10, 2018 at 6:18 PM, Paul B Mahol wrote: >> >> lgtm >> ___ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > Cheers, pushed. > > Jan I

Re: [FFmpeg-devel] [PATCH] lavf/aptxdec: fix the limit on the APTX demuxer definition

2018-02-10 Thread Jan Ekström
On Sat, Feb 10, 2018 at 6:18 PM, Paul B Mahol wrote: > > lgtm > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel Cheers, pushed. Jan ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/aptxdec: fix the limit on the APTX demuxer definition

2018-02-10 Thread Paul B Mahol
On 2/10/18, Jan Ekstroem wrote: > Fixes breakage with --disable-muxers as it was originally limited > to the muxer, and not the demuxer. > --- > libavformat/aptxdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/aptxdec.c b/libavformat/aptxdec.c > index 467

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-10 Thread Aurelien Jacobs
On Fri, Feb 09, 2018 at 10:27:39PM +0100, Aurelien Jacobs wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ba7a7284eb..b691bd56ec 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -139,6 +139,7 @@ Codecs: >aacenc*, aaccode

[FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-02-10 Thread Kieran Kunhya
$subj. Still depends on simple_idct template patch Fixes crashes in ER 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

[FFmpeg-devel] [PATCH] lavf/aptxdec: fix the limit on the APTX demuxer definition

2018-02-10 Thread Jan Ekström
Fixes breakage with --disable-muxers as it was originally limited to the muxer, and not the demuxer. --- libavformat/aptxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/aptxdec.c b/libavformat/aptxdec.c index 467bc3fd5a..a262cd9ebe 100644 --- a/libavformat/apt

[FFmpeg-devel] [PATCH] h264_idct: enable unmacro on newer NASM versions

2018-02-10 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavcodec/x86/h264_idct.asm | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index 8804638091..c54f9f1a68 100644 --- a/libavcodec/x86/h264_idct.asm +++ b/libavcodec/x86/h26

Re: [FFmpeg-devel] [PATCH] fate/libavcodec: add codec_desc test

2018-02-10 Thread wm4
On Sat, 10 Feb 2018 16:37:00 +0700 Muhammad Faiz wrote: > Remove runtime check at codec_desc.c > > Signed-off-by: Muhammad Faiz > --- > libavcodec/Makefile | 1 + > libavcodec/codec_desc.c | 24 --- > libavcodec/tests/codec_desc.c | 45 > ++

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-10 Thread Muhammad Faiz
On Sat, Feb 10, 2018 at 7:51 AM, Michael Niedermayer wrote: > On Fri, Feb 09, 2018 at 10:21:04PM +0700, Muhammad Faiz wrote: >> On Fri, Feb 9, 2018 at 6:53 PM, James Almer wrote: >> > On 2/9/2018 7:56 AM, Muhammad Faiz wrote: >> >> On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer >> >> wrote:

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-10 Thread Nekopanda
> On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: >> - Fix field selection for skipped macroblocks >> >> For B field pictures, the spec says, >> >> > The prediction shall be made from the field of the same parity as the > field being predicted. >> >> I did it. >> >> - Fix moti

[FFmpeg-devel] [PATCH] fate/libavcodec: add codec_desc test

2018-02-10 Thread Muhammad Faiz
Remove runtime check at codec_desc.c Signed-off-by: Muhammad Faiz --- libavcodec/Makefile | 1 + libavcodec/codec_desc.c | 24 --- libavcodec/tests/codec_desc.c | 45 +++ tests/fate/libavcodec.mak | 5 + 4 file

[FFmpeg-devel] [PATCH] mpeg2dec: Fix field selection for skipped macroblocks

2018-02-10 Thread Nekopanda
For B field pictures, the spec says, > The prediction shall be made from the field of the same parity as the field > being predicted. I did it. --- libavcodec/mpeg12dec.c | 2 + tests/ref/fate/mpeg2-ticket186 | 328 - 2 files changed, 166 insert

[FFmpeg-devel] [PATCH] mpeg2dec: Fix motion vector rounding for chroma components

2018-02-10 Thread Nekopanda
In 16x8 motion compensation, for lower 16x8 region, the input to mpeg_motion() for motion_y was "motion_y + 16", which causes wrong rounding. For 4:2:0, chroma scaling for y is dividing by two and rounding toward zero. When motion_y < 0 and motion_y + 16 > 0, the rounding direction of "motion_y"