Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:51:25PM -0800, Sasi Inguva wrote: > The new patch looks good to me. will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Freedom in capitalist society always remains about the same as it was in ancient Greek republics: Fr

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 10:27:39PM +0100, Aurelien Jacobs wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ba7a7284eb..b691bd56ec 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -139,6 +139,7 @@ Codecs: >aacenc*, aaccode

[FFmpeg-devel] [PATCH]lavf/rtpdec: Constify several pointers

2018-02-09 Thread Carl Eugen Hoyos
Hi! Attached patch fixes two warnings. libavformat/rtpdec.c: In function ‘ff_rtp_handler_find_by_name’: libavformat/rtpdec.c:155:20: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] return handler; ^~~ libavformat/rtp

Re: [FFmpeg-devel] [PATCH] fate: add aac id3v2 demux test

2018-02-09 Thread wm4
On Sat, 3 Feb 2018 23:25:56 -0800 Richard Shaffer wrote: > Attaching sample file for the test. > > -Richard > > On Sat, Feb 3, 2018 at 11:24 PM, wrote: > > From: Richard Shaffer > > > > A basic test for demuxing raw AAC (ADTS) with ID3v2 tags. > > --- > > This is related to the patch 'libavf

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 10:21:04PM +0700, Muhammad Faiz wrote: > On Fri, Feb 9, 2018 at 6:53 PM, James Almer wrote: > > On 2/9/2018 7:56 AM, Muhammad Faiz wrote: > >> On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer > >> wrote: > >>> On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wro

Re: [FFmpeg-devel] [PATCH] avformat/format: temporarily use old next api

2018-02-09 Thread Muhammad Faiz
On Sat, Feb 10, 2018 at 1:08 AM, Muhammad Faiz wrote: > On Fri, Feb 9, 2018 at 7:04 PM, James Almer wrote: >> On 2/9/2018 7:16 AM, Muhammad Faiz wrote: >>> Should fix >>> https://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225066.html >>> >>> Signed-off-by: Muhammad Faiz >>> --- >>> The act

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:03:24AM +0900, Nekopanda wrote: > - Fix field selection for skipped macroblocks > > For B field pictures, the spec says, > > > The prediction shall be made from the field of the same parity as the field > > being predicted. > > I did it. > > - Fix motion vector round

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread Sasi Inguva
The new patch looks good to me. On Fri, Feb 9, 2018 at 1:34 PM, Xiaohan Wang (王消寒) wrote: > I uploaded a new patch. Is this what you meant? > > I am confused with the code though. In the case *ctts_index == ctts_count, > this while loop will do nothing. Is this what we want? Also, the "wrong" >

Re: [FFmpeg-devel] [PATCH] examples: Don't call deprecated functions which don't do anything

2018-02-09 Thread Mark Thompson
On 09/02/18 01:54, James Almer wrote: > On 2/8/2018 10:41 PM, Jun Zhao wrote: >> On 2018/2/8 3:44, Mark Thompson wrote: >>> --- >>> doc/examples/avio_dir_cmd.c | 2 -- >>> doc/examples/avio_reading.c | 3 --- >>> doc/examples/decode_audio.c | 3 --- >>> doc/examples/decode_video.c

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread Sasi Inguva
On Fri, Feb 9, 2018 at 1:34 PM, Xiaohan Wang (王消寒) wrote: > I uploaded a new patch. Is this what you meant? > > I am confused with the code though. In the case *ctts_index == ctts_count, > The problem is when *ctts_index == (ctts_count -1) . if ( (ctts_count- 1) < ctts_count) { while ( ctts_

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-09 Thread Rostislav Pehlivanov
On 9 February 2018 at 21:27, Aurelien Jacobs wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ba7a7284eb..b691bd56ec 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -139,6 +139,7 @@ Codecs: >aacenc*, aaccoder.c

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread 王消寒
I uploaded a new patch. Is this what you meant? I am confused with the code though. In the case *ctts_index == ctts_count, this while loop will do nothing. Is this what we want? Also, the "wrong" |ctts_index| will be available outside of this function. How do we make sure it won't cause trouble la

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse ID3 tags between ADTS frames.

2018-02-09 Thread Richard Shaffer
On Fri, Feb 9, 2018 at 1:21 PM, wm4 wrote: > On Fri, 9 Feb 2018 12:54:29 -0800 > Richard Shaffer wrote: > >> I just wanted to send a final ping about this patch. While most >> streams will not encounter the case that it addresses, those that do >> will have a pretty bad experience. The demuxer's

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself for aptx.c

2018-02-09 Thread Aurelien Jacobs
--- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ba7a7284eb..b691bd56ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -139,6 +139,7 @@ Codecs: aacenc*, aaccoder.c Rostislav Pehlivanov alacenc.c J

[FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Ignore multiple VOL headers

2018-02-09 Thread Michael Niedermayer
Fixes: Ticket7005 Signed-off-by: Michael Niedermayer --- libavcodec/mpeg4videodec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c index 756753e2fc..19210d97fe 100644 --- a/libavcodec/mpeg4videodec.c +++ b/libavcode

[FFmpeg-devel] [PATCH 2/2] avcodec/utvideodec: Add several out of array read related checks

2018-02-09 Thread Michael Niedermayer
Fixes: OV_decode_plane.avi Found-by: GwanYeong Kim Signed-off-by: Michael Niedermayer --- libavcodec/utvideodec.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/libavcodec/utvideodec.c b/libavcodec/utvideodec.c index 1bcd14e74c..f0be2b231b 100644 --- a/li

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse ID3 tags between ADTS frames.

2018-02-09 Thread wm4
On Fri, 9 Feb 2018 12:54:29 -0800 Richard Shaffer wrote: > I just wanted to send a final ping about this patch. While most > streams will not encounter the case that it addresses, those that do > will have a pretty bad experience. The demuxer's read_packet function > currently only reads 7 bytes

Re: [FFmpeg-devel] [PATCH 4/5] aptx: implement the aptX HD bluetooth codec

2018-02-09 Thread Aurelien Jacobs
On Mon, Feb 05, 2018 at 12:27:20AM +0100, Michael Niedermayer wrote: > On Sun, Feb 04, 2018 at 04:07:26PM +0100, Aurelien Jacobs wrote: > > On Sat, Jan 20, 2018 at 11:20:22PM +, Rostislav Pehlivanov wrote: > > > On 20 January 2018 at 17:26, Aurelien Jacobs wrote: > > > > > > > On Sun, Jan 14,

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse ID3 tags between ADTS frames.

2018-02-09 Thread Richard Shaffer
I just wanted to send a final ping about this patch. While most streams will not encounter the case that it addresses, those that do will have a pretty bad experience. The demuxer's read_packet function currently only reads 7 bytes (ADTS_HEADER_SIZE) of input. If the first 12 bits aren't the sync w

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread Sasi Inguva
> > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 5adba52e08..f0bd3e3623 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -3148,7 +3148,7 @@ static int find_prev_closest_index(AVStream *st, > *ctts_index = 0; > *ctts_sample = 0; > for (index_ct

Re: [FFmpeg-devel] [PATCH]configure: Improve the wording of the license failure

2018-02-09 Thread Lou Logan
On Fri, Feb 9, 2018, at 1:06 AM, Carl Eugen Hoyos wrote: > Hi! > > It was reported on the user mailing list that "libvmaf is version3 and > --enable-version3 is not specified." is unclear, attached patch tries > to slightly improve the sentence. > > Please comment, Carl Eugen [...] A few alterna

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread Muhammad Faiz
On Fri, Feb 9, 2018 at 6:12 PM, Nicolas George wrote: > Muhammad Faiz (2018-02-08): >> I actually prefer _next() without introducing new API. Yeah, it is >> slower because it must initialize next pointer > > I am not sure what you mean here. The problem with initing the next > pointer was never sp

Re: [FFmpeg-devel] [PATCH] avformat/format: temporarily use old next api

2018-02-09 Thread Muhammad Faiz
On Fri, Feb 9, 2018 at 7:04 PM, James Almer wrote: > On 2/9/2018 7:16 AM, Muhammad Faiz wrote: >> Should fix >> https://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225066.html >> >> Signed-off-by: Muhammad Faiz >> --- >> The actual problem is that av*next() and av*iterate() have different >>

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread James Almer
On 2/9/2018 12:21 PM, Muhammad Faiz wrote: > On Fri, Feb 9, 2018 at 6:53 PM, James Almer wrote: >> On 2/9/2018 7:56 AM, Muhammad Faiz wrote: >>> On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer >>> wrote: On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wrote: > Josh de Kock (

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread Muhammad Faiz
On Fri, Feb 9, 2018 at 6:53 PM, James Almer wrote: > On 2/9/2018 7:56 AM, Muhammad Faiz wrote: >> On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer >> wrote: >>> On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wrote: Josh de Kock (2018-02-06): > ffmpeg | branch: master | Josh

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 02:28:41PM +0100, wm4 wrote: > On Fri, 9 Feb 2018 03:08:26 +0100 > Michael Niedermayer wrote: > > > On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > > > protocol requires libsrt (https://github.com/Haivision/srt) to be > > > installed > > > > > > Signed

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Tomas Härdin
On 2018-02-09 11:29, Carl Eugen Hoyos wrote: 2018-01-15 22:36 GMT+01:00 Tomas Härdin : +if (p->buf[4] > EXPECTED_CODEC2_MINOR_VERSION) score -= AVPROBE_SCORE_MAX/5; +if (p->buf[5] > AVPRIV_CODEC2_MODE_MAX)score -= AVPROBE_SCORE_MAX/5; +if (p->buf[6] != 0)

Re: [FFmpeg-devel] [PATCH] avformat/opensrt: add Haivision Open SRT protocol

2018-02-09 Thread wm4
On Fri, 9 Feb 2018 03:08:26 +0100 Michael Niedermayer wrote: > On Tue, Jan 30, 2018 at 04:11:03PM -0500, Nablet Developer wrote: > > protocol requires libsrt (https://github.com/Haivision/srt) to be > > installed > > > > Signed-off-by: Nablet Developer > > --- > > MAINTAINERS | 1

[FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-09 Thread Michael Niedermayer
Fixes: out of array access Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552 Fixes: special case for theora (untested due to lack of sample) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libav

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-09 Thread Michael Niedermayer
On Fri, Feb 09, 2018 at 04:41:44AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nieder

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Nekopanda
> From: Carl Eugen Hoyos > > 2018-02-09 3:51 GMT+01:00 Nekopanda > : >>> From: Carl Eugen Hoyos >   Yes, I have files that show artifacts without this change. > Recently,   Japanese satellite television started to use field pictures > widely,   and many of that show artifact

Re: [FFmpeg-devel] [PATCH] avformat/format: temporarily use old next api

2018-02-09 Thread James Almer
On 2/9/2018 7:16 AM, Muhammad Faiz wrote: > Should fix https://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225066.html > > Signed-off-by: Muhammad Faiz > --- > The actual problem is that av*next() and av*iterate() have different > semantics: > - av*next() iterate all formats+devices > - a

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread James Almer
On 2/9/2018 7:56 AM, Muhammad Faiz wrote: > On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer > wrote: >> On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wrote: >>> Josh de Kock (2018-02-06): ffmpeg | branch: master | Josh de Kock | Fri Dec 22 22:17:00 2017 +| [7e8eba2d8

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Jerome Martinez
On 09/02/2018 12:20, Kieran O Leary wrote: Hi both, I'm just wondering if the past duration errors in my earlier email mean anything,or should they be ignored? They are independent from the patch, e.g.: https://stackoverflow.com/questions/30782771/what-does-past-duration-x-xxx-too-large-mean _

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Kieran O Leary
Hi both, I'm just wondering if the past duration errors in my earlier email mean anything,or should they be ignored? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread Nicolas George
Muhammad Faiz (2018-02-08): > I actually prefer _next() without introducing new API. Yeah, it is > slower because it must initialize next pointer I am not sure what you mean here. The problem with initing the next pointer was never speed. The problem with the next pointer is that it requires a ru

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Jerome Martinez
On 09/02/2018 11:32, Carl Eugen Hoyos wrote: [...] please mention ticket #5639 in the commit message. I should definitely have indicated this source instead of my copy, my mistake. Commit message extended with it. FYI I am running tests on several DPX flavors (to FFV1 and back to DPX, checki

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc: add new API for iterating codecs and codec parsers

2018-02-09 Thread Muhammad Faiz
On Thu, Feb 8, 2018 at 7:04 AM, Michael Niedermayer wrote: > On Wed, Feb 07, 2018 at 01:52:33PM +0100, Nicolas George wrote: >> Josh de Kock (2018-02-06): >> > ffmpeg | branch: master | Josh de Kock | Fri Dec 22 >> > 22:17:00 2017 +| [7e8eba2d8755962d9dca5eade57bf8f591a73c0c] | >> > committ

Re: [FFmpeg-devel] [PATCH] avcodec/codec_desc: sort codec_descriptors

2018-02-09 Thread Muhammad Faiz
On Fri, Feb 9, 2018 at 9:11 AM, Michael Niedermayer wrote: > On Sat, Feb 03, 2018 at 01:35:34AM +0700, Muhammad Faiz wrote: >> Use bsearch on avcodec_descriptor_get(). >> >> Signed-off-by: Muhammad Faiz >> --- >> libavcodec/codec_desc.c | 1103 >> ---

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Carl Eugen Hoyos
2018-02-09 11:34 GMT+01:00 Jerome Martinez : > On 09/02/2018 11:15, Carl Eugen Hoyos wrote: >> >> >>> Sorry, I see a line was missing in my first post, the one with the link >>> to >>> the RGBA test file. >>> Test file for RGBA 12-bit packed: >>> >>> https://github.com/MediaArea/RAWcooked-Regressio

Re: [FFmpeg-devel] [PATCH] mpeg2dec: fix decoding field pictures

2018-02-09 Thread Carl Eugen Hoyos
2018-02-09 3:51 GMT+01:00 Nekopanda : >> From: Carl Eugen Hoyos >>> Yes, I have files that show artifacts without this change. Recently, >>> Japanese satellite television started to use field pictures widely, >>> and many of that show artifacts. We need this change to remove >>> the artifacts

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Jerome Martinez
On 09/02/2018 11:15, Carl Eugen Hoyos wrote: Sorry, I see a line was missing in my first post, the one with the link to the RGBA test file. Test file for RGBA 12-bit packed: https://github.com/MediaArea/RAWcooked-RegressionTestingFiles/tree/master/Formats/DPX/Flavors/RGBA_12_Packed_BE Is this

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Carl Eugen Hoyos
2018-02-09 11:15 GMT+01:00 Carl Eugen Hoyos : > 2018-02-09 7:38 GMT+01:00 Jerome Martinez : >> Sorry, I see a line was missing in my first post, the one with the link to >> the RGBA test file. >> Test file for RGBA 12-bit packed: >> https://github.com/MediaArea/RAWcooked-RegressionTestingFiles/tre

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Carl Eugen Hoyos
2018-01-15 22:36 GMT+01:00 Tomas Härdin : >> +if (p->buf[4] > EXPECTED_CODEC2_MINOR_VERSION) score -= >> AVPROBE_SCORE_MAX/5; >> +if (p->buf[5] > AVPRIV_CODEC2_MODE_MAX)score -= >> AVPROBE_SCORE_MAX/5; >> +if (p->buf[6] != 0) score -= >> AVPROBE_SC

[FFmpeg-devel] [PATCH] avformat/format: temporarily use old next api

2018-02-09 Thread Muhammad Faiz
Should fix https://ffmpeg.org/pipermail/ffmpeg-devel/2018-February/225066.html Signed-off-by: Muhammad Faiz --- The actual problem is that av*next() and av*iterate() have different semantics: - av*next() iterate all formats+devices - av*iterate() iterate formats only. Is this the intended beh

Re: [FFmpeg-devel] [PATCH] avcodec/dpx: Support for RGB and RGBA 12-bit packed decoding

2018-02-09 Thread Carl Eugen Hoyos
2018-02-09 7:38 GMT+01:00 Jerome Martinez : > On 09/02/2018 02:19, Carl Eugen Hoyos wrote: >> >> 2018-02-08 11:28 GMT+01:00 Jerome Martinez : >>> >>> Currently RGB and RGBA 12-bit are supported by DPX decoder only if >>> component >>> values are padded (packing "Filled to 32-bit words, method A").

[FFmpeg-devel] [PATCH]configure: Improve the wording of the license failure

2018-02-09 Thread Carl Eugen Hoyos
Hi! It was reported on the user mailing list that "libvmaf is version3 and --enable-version3 is not specified." is unclear, attached patch tries to slightly improve the sentence. Please comment, Carl Eugen From c0170122c42f9837dc188296e6d66ad37258febe Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoy

Re: [FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

2018-02-09 Thread Tomas Härdin
Ping? I'd maintain this of course. Plus I'd like to add some tests, but I need to know if this looks OK to everyone first /Tomas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Check eob_run

2018-02-09 Thread Paul B Mahol
On 2/9/18, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 5919/clusterfuzz-testcase-minimized-5859311382167552 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c

[FFmpeg-devel] fate/exr : add test for ticket 6994 (long name flag)

2018-02-09 Thread Martin Vignali
Hello, Patch in attach add test for ticket 6994 (flag long name) Sample can be found here : https://we.tl/WBnt10VSA1 and need to be put inside ./fate-suite/exr Can be test with : make fate-exr SAMPLES=fate-suite/ Need to be apply after one of the patch in discussion : "lavc/exr: Ignore long n