Re: [FFmpeg-devel] [PATCH] libavfilter: constify filter list

2018-01-29 Thread wm4
On Tue, 30 Jan 2018 14:24:12 +0700 Muhammad Faiz wrote: > Move REGISTER_FILTER to FILTER_TABLE in configure. > Auto generate filter extern and filter table. > Sort filter table, use bsearch on avfilter_get_by_name. > Define next pointer at filter extern, no need to initialize > next pointer at ru

Re: [FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread wm4
On Tue, 30 Jan 2018 02:24:29 +0100 Michael Niedermayer wrote: > On Mon, Jan 29, 2018 at 03:13:54PM -0800, Dale Curtis wrote: > > Otherwise the decoder will throw "Missing header" errors when the > > packets are sent for decoding. > > > mpegaudio_parser.c |7 +++ > > 1 file changed, 7

Re: [FFmpeg-devel] [PATCH 1/4] avformat/mpegenc - fix typo in VBV warning

2018-01-29 Thread Michael Niedermayer
On Mon, Jan 29, 2018 at 12:39:08PM +0530, Gyan Doshi wrote: > Changes to MPEG-PS muxer factored as requested in > http://www.ffmpeg.org/pipermail/ffmpeg-devel/2018-January/224642.html. > mpegenc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 8e1d73e5fbfa2dcbbf79c0295907aad719180d5

Re: [FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread Michael Niedermayer
On Mon, Jan 29, 2018 at 10:29:04PM -0300, James Almer wrote: > On 1/29/2018 10:24 PM, Michael Niedermayer wrote: > > On Mon, Jan 29, 2018 at 03:13:54PM -0800, Dale Curtis wrote: > >> Otherwise the decoder will throw "Missing header" errors when the > >> packets are sent for decoding. > > > >> mpe

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mpegenc - reject unsupported audio streams

2018-01-29 Thread Michael Niedermayer
On Mon, Jan 29, 2018 at 12:43:16PM +0530, Gyan Doshi wrote: > mpegenc.c |4 > 1 file changed, 4 insertions(+) > b173bdf76e80d3c378118ef452dd49b3aefdd5a3 > 0004-avformat-mpegenc-reject-unsupported-audio-streams.patch > From 800aa096357c5dfa822157f349a0f0d23fea8c84 Mon Sep 17 00:00:00 200

Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to AVCodecParameters

2018-01-29 Thread Li, Zhong
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > Of Michael Niedermayer > Sent: Friday, January 26, 2018 11:56 PM > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc: Add coded_w/h to > AVCodecParameters > > On Fri, Jan 19, 20

Re: [FFmpeg-devel] librsvg-2.0 not found using pkg-config

2018-01-29 Thread James Almer
On 1/29/2018 10:44 PM, Charles Lawrence wrote: > Created a debian-based dockerfile a few days ago that successfully > built ffmpeg 3.4.1 from source with librsvg enabled. > > However today, without any intervening changes in the build script, > librsvg fails due to "librsvg-2.0 not found using pkg

[FFmpeg-devel] librsvg-2.0 not found using pkg-config

2018-01-29 Thread Charles Lawrence
Created a debian-based dockerfile a few days ago that successfully built ffmpeg 3.4.1 from source with librsvg enabled. However today, without any intervening changes in the build script, librsvg fails due to "librsvg-2.0 not found using pkg-config". The 3.4.1 archive hasn't been changed as far a

Re: [FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread James Almer
On 1/29/2018 10:24 PM, Michael Niedermayer wrote: > On Mon, Jan 29, 2018 at 03:13:54PM -0800, Dale Curtis wrote: >> Otherwise the decoder will throw "Missing header" errors when the >> packets are sent for decoding. > >> mpegaudio_parser.c |7 +++ >> 1 file changed, 7 insertions(+) >> 262

Re: [FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread Michael Niedermayer
On Mon, Jan 29, 2018 at 03:13:54PM -0800, Dale Curtis wrote: > Otherwise the decoder will throw "Missing header" errors when the > packets are sent for decoding. > mpegaudio_parser.c |7 +++ > 1 file changed, 7 insertions(+) > 2628fa8480b15237a528e94b1689da7321ce9440 skip-ape-tags.patch

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegenc - log error messages for unsupported LPCM streams

2018-01-29 Thread Michael Niedermayer
On Mon, Jan 29, 2018 at 12:40:30PM +0530, Gyan Doshi wrote: > Changes to MPEG-PS muxer factored as requested in > http://www.ffmpeg.org/pipermail/ffmpeg-devel/2018-January/224642.html was this mail intended to contain a patch ? it seems it does not ... [...] -- Michael GnuPG fingerprint: 9FF

[FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread Dale Curtis
Otherwise the decoder will throw "Missing header" errors when the packets are sent for decoding. From 05f5e837862a958fb8791668ab3cdf8fc7766fe5 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Mon, 29 Jan 2018 15:10:26 -0800 Subject: [PATCH] [mp3] Skip APE tags when parsing mp3 packets. Otherwise

Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for AMD GPUs based on AMF SDK

2018-01-29 Thread Mironov, Mikhail
> -Original Message- > From: James Almer [mailto:jamr...@gmail.com] > Sent: January 28, 2018 6:32 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Mironov, Mikhail > Subject: Re: [FFmpeg-devel] [PATCH] Add HW H.264 and HEVC encoding for > AMD GPUs based on AMF SDK > > On 11/29/2017 12:13 PM, Mirono

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mpegenc - reject unsupported audio streams

2018-01-29 Thread Gyan Doshi
On 1/29/2018 3:48 PM, Carl Eugen Hoyos wrote: The error message you print does not reflect patch 3/4 afaict. Does it need to? There's no PCM_DVD encoder. PCM headers are written within the muxer, so a user reading that message gets no actionable insight from seeing pcm_dvd in the list but

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegenc - log error messages for unsupported LPCM streams

2018-01-29 Thread Gyan Doshi
On 1/29/2018 3:46 PM, Carl Eugen Hoyos wrote: Looks like you should be using "goto fail" instead of returning an error directly. I preserved the existing behaviour, but I'll change it to fail: Regards, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-01-29 Thread Gyan Doshi
On 1/29/2018 3:47 PM, Carl Eugen Hoyos wrote: How did you test this patch? By remuxing with patched ffmpeg and then checking with ffprobe, but not ffplay! On playback, I see the output is garbled, because the PCM_DVD header carries over from the source packet and also breaks LPCM block a

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mpegenc - reject unsupported audio streams

2018-01-29 Thread Carl Eugen Hoyos
2018-01-29 8:13 GMT+01:00 Gyan Doshi : The error message you print does not reflect patch 3/4 afaict. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/4] avformat/mpegenc - accept PCM_DVD streams

2018-01-29 Thread Carl Eugen Hoyos
2018-01-29 8:12 GMT+01:00 Gyan Doshi : How did you test this patch? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegenc - log error messages for unsupported LPCM streams

2018-01-29 Thread Carl Eugen Hoyos
2018-01-29 8:12 GMT+01:00 Gyan Doshi : > Forgot to attach patch. > > Changes to MPEG-PS muxer factored as requested in > http://www.ffmpeg.org/pipermail/ffmpeg-devel/2018-January/224642.html. Looks like you should be using "goto fail" instead of returning an error directly. Carl Eugen ___