Re: [FFmpeg-devel] [PATCH] doc/filters: Add note on Flite thread safety and update URL

2017-10-16 Thread Gyan Doshi
On 10/9/2017 11:19 AM, Gyan Doshi wrote: Version 2 of Flite, a speech synthesis library, was released towards the end of 2014. Among the notes at the project site: "Thread safe (really this time)". Docs and project URL updated accordingly. Ping. __

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread wm4
Correction: will push as part of cuvid/videotoolbox patches whenever they're ready. On Tue, 17 Oct 2017 00:58:58 +0200 Michael Niedermayer wrote: > > It doesn't - not the user's. We use only the field for internal > > purposes (as AVFrame users), and we never do anything with the user's > > valu

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread wm4
I have realized that your veto is actually not valid: - it's a Libav merge - it has been for months in the Libav repo and you didn't specifically care, nor did you make an attempt to merge the commit in a "fixed" way - this patch would have been merged normally, and you wouldn't have cared at a

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-16 Thread James Almer
On 10/16/2017 9:13 PM, Michael Niedermayer wrote: > On Mon, Oct 16, 2017 at 11:14:49AM +0200, Daniel Kucera wrote: >> transfer_func variable passed to retry_transfer_wrapper >> are h->prot->url_read and h->prot->url_write functions. >> These need to return EOF or other error properly. >> In case of

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/16/2017 10:04 PM, Carl Eugen Hoyos wrote: > 2017-10-16 23:02 GMT+02:00 James Almer : >> and by hardcoding a -lstdc++ ldflag in configure checks we're >> apparently breaking detection on systems where the compiler >> uses libc++, like it seems to be the case with Clang on MacOS. > > Did you t

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-16 Thread Carl Eugen Hoyos
2017-10-10 21:48 GMT+02:00 Bjorn Roche : > On Fri, Oct 6, 2017 at 5:23 PM, Carl Eugen Hoyos wrote: >> Do you think an option to set the value of the transparent >> colour to something else than 0xFF00 would make sense? >> And/or another default? >> You can use ffplay on an output png file to test

Re: [FFmpeg-devel] [PATCH] Fix for paletteuse to support transparency

2017-10-16 Thread Carl Eugen Hoyos
2017-10-10 23:41 GMT+02:00 Bjorn Roche : > +{ "trans_threshold", "set the threshold for alpha values avoce which > they are considered completely opaque", OFFSET(trans_thresh), > AV_OPT_TYPE_INT, {.i64=128}, 0, 255, }, I wonder if "threshold" is enough. No more comments from me, thank you!

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Carl Eugen Hoyos
2017-10-16 23:02 GMT+02:00 James Almer : > and by hardcoding a -lstdc++ ldflag in configure checks we're > apparently breaking detection on systems where the compiler > uses libc++, like it seems to be the case with Clang on MacOS. Did you test this? I ask because I was never able to reproduce (it

Re: [FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-16 Thread Michael Niedermayer
On Mon, Oct 16, 2017 at 11:14:49AM +0200, Daniel Kucera wrote: > transfer_func variable passed to retry_transfer_wrapper > are h->prot->url_read and h->prot->url_write functions. > These need to return EOF or other error properly. > In case of returning >= 0, url_read/url_write is retried > until e

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread Michael Niedermayer
On Mon, Oct 16, 2017 at 09:40:26AM +0200, wm4 wrote: > On Sat, 14 Oct 2017 23:01:41 +0200 > Michael Niedermayer wrote: > > > On Fri, Oct 13, 2017 at 09:19:04PM +0200, wm4 wrote: > > > On Fri, 13 Oct 2017 19:41:28 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Fri, Oct 06, 2017 at 01:

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Jan Ekstrom
On Tue, Oct 17, 2017 at 12:38 AM, Hendrik Leppkes wrote: > Perhaps such libraries shouldn't hardcode -lstdc++ in there, but > dynamically put whichever C++ library they built against in there > instead? > Its not like you can actually use a static library build with another > C++ library, that *ma

Re: [FFmpeg-devel] [V3 1/4] ffmpeg: remove hwaccel_lax_profile_check opt.

2017-10-16 Thread Mark Thompson
On 09/10/17 08:49, Jun Zhao wrote: > V3: Remove hwaccel_lax_profile_check opt, and add new pre-stream > hwaccel_flags option > > From 2b1585fd6e6e68c81761ace0a8503385067086e0 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Mon, 9 Oct 2017 02:13:14 -0400 > Subject: [V3 1/4] ffmpeg: remove hwacce

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Hendrik Leppkes
On Mon, Oct 16, 2017 at 11:02 PM, James Almer wrote: > On 10/16/2017 2:36 PM, Jan Ekstrom wrote: >> On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: >>> On 10/14/2017 12:59 PM, James Almer wrote: It's used by every library, and by making it global we simplify a lot of checks. >>

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-16 Thread Dale Curtis
More details on the issue which uncovered this can be seen here https://bugs.chromium.org/p/chromium/issues/detail?id=775042#c13 - dale On Mon, Oct 16, 2017 at 2:22 PM, Dale Curtis wrote: > Previously the start padding was used to blindly overwrite any skip > samples which may have come from an

[FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-16 Thread Dale Curtis
Previously the start padding was used to blindly overwrite any skip samples which may have come from an edit list. Instead take the maximum of the two. A new fate test is added, fate-mov-440hz-10ms, to ensure this is handled correctly. The sample can be downloaded and added to the fate-suite from

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/16/2017 2:36 PM, Jan Ekstrom wrote: > On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: >> On 10/14/2017 12:59 PM, James Almer wrote: >>> It's used by every library, and by making it global we simplify a lot >>> of checks. >>> > > LGTM. > > I dislike the fact that we have to fix issues c

Re: [FFmpeg-devel] [PATCH] configure: add pkg-config check for alsa

2017-10-16 Thread James Almer
On 10/16/2017 5:01 PM, Jan Ekström wrote: > --- > configure | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index b9a3a9bc1f..5aa642a9bb 100755 > --- a/configure > +++ b/configure > @@ -6254,7 +6254,8 @@ EOF > fi > check_header soundcard.h >

[FFmpeg-devel] [PATCH] fateserver/index: clean chars in sort parameter

2017-10-16 Thread Michael Niedermayer
Prevents cross site scripting attack Found-by: Pankaj Jadhav Signed-off-by: Michael Niedermayer --- index.cgi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/index.cgi b/index.cgi index 030fb52..a164d3b 100755 --- a/index.cgi +++ b/index.cgi @@ -32,6 +32,8 @@ use URI::Escape; my @queries

[FFmpeg-devel] [PATCH] configure: add pkg-config check for alsa

2017-10-16 Thread Jan Ekström
--- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index b9a3a9bc1f..5aa642a9bb 100755 --- a/configure +++ b/configure @@ -6254,7 +6254,8 @@ EOF fi check_header soundcard.h -enabled alsa && check_lib alsa alsa/asoundlib.h snd_pcm_htimestam

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-16 Thread Paul B Mahol
On 10/16/17, Dave Rice wrote: > Hi, > > I tested this with my Ultrastudio Express and confirmed that I'm getting > higher bit depth recordings with the abitscope filter. This patch adds an > option to get 32 bit audio as an input with the decklink device (beforehand > only 16 bit audio was support

[FFmpeg-devel] [PATCH] libavdevice/decklink: 32 bit audio support

2017-10-16 Thread Dave Rice
Hi, I tested this with my Ultrastudio Express and confirmed that I'm getting higher bit depth recordings with the abitscope filter. This patch adds an option to get 32 bit audio as an input with the decklink device (beforehand only 16 bit audio was supported). This resolves http://trac.ffmpeg.o

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread Jan Ekstrom
On Mon, Oct 16, 2017 at 7:31 PM, James Almer wrote: > On 10/14/2017 12:59 PM, James Almer wrote: >> It's used by every library, and by making it global we simplify a lot >> of checks. >> LGTM. I dislike the fact that we have to fix issues caused by 3rd party libraries' pkg-config files but at th

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

2017-10-16 Thread James Almer
On 10/14/2017 12:59 PM, James Almer wrote: > It's used by every library, and by making it global we simplify a lot > of checks. > > Signed-off-by: James Almer > --- > configure | 18 +++--- > 1 file changed, 7 insertions(+), 11 deletions(-) > > diff --git a/configure b/configure > i

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread James Almer
On 10/16/2017 12:24 PM, Rostislav Pehlivanov wrote: > On 16 October 2017 at 16:14, wm4 wrote: > >> On Mon, 16 Oct 2017 16:02:19 +0100 >> Rostislav Pehlivanov wrote: >> >>> Signed-off-by: Rostislav Pehlivanov >>> --- >>> libavutil/frame.c | 16 ++-- >>> libavutil/frame.h | 13 ++

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread wm4
On Mon, 16 Oct 2017 16:24:56 +0100 Rostislav Pehlivanov wrote: > On 16 October 2017 at 16:14, wm4 wrote: > > > On Mon, 16 Oct 2017 16:02:19 +0100 > > Rostislav Pehlivanov wrote: > > > > > Signed-off-by: Rostislav Pehlivanov > > > --- > > > libavutil/frame.c | 16 ++-- > > > lib

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread Rostislav Pehlivanov
On 16 October 2017 at 16:14, wm4 wrote: > On Mon, 16 Oct 2017 16:02:19 +0100 > Rostislav Pehlivanov wrote: > > > Signed-off-by: Rostislav Pehlivanov > > --- > > libavutil/frame.c | 16 ++-- > > libavutil/frame.h | 13 + > > 2 files changed, 19 insertions(+), 10 deletion

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread wm4
On Mon, 16 Oct 2017 12:27:17 -0300 James Almer wrote: > On 10/16/2017 12:02 PM, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > libavutil/frame.c | 16 ++-- > > libavutil/frame.h | 13 + > > 2 files changed, 19 insertions(+), 10 deletions(

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread James Almer
On 10/16/2017 12:02 PM, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavutil/frame.c | 16 ++-- > libavutil/frame.h | 13 + > 2 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/frame.c > index d

Re: [FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread wm4
On Mon, 16 Oct 2017 16:02:19 +0100 Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > libavutil/frame.c | 16 ++-- > libavutil/frame.h | 13 + > 2 files changed, 19 insertions(+), 10 deletions(-) > > diff --git a/libavutil/frame.c b/libavutil/fram

[FFmpeg-devel] [PATCH] frame: add an av_frame_new_side_data_from_buf function

2017-10-16 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- libavutil/frame.c | 16 ++-- libavutil/frame.h | 13 + 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/libavutil/frame.c b/libavutil/frame.c index d5fd2932e3..0668c888ea 100644 --- a/libavutil/frame.c +++ b/libavutil

Re: [FFmpeg-devel] libavcodec/hap : add HapAlphaOnly decoding/encoding

2017-10-16 Thread Tom Butterworth
>> Patches 0001, 0002, 0006 and 0007 LGTM and are uncontentious. As they are >> required for Hap Q Alpha support I will commit these shortly, assuming >> nobody objects. >> >> > Ok for that, so we can discuss in parallel about HAPQAlpha support (with > RGBA pix_fmt output this time ! :-) > I’v

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread wm4
On Mon, 16 Oct 2017 20:32:03 +0800 Xiaolei Yu wrote: > On 10/16/2017 07:36 PM, wm4 wrote: > > On Mon, 16 Oct 2017 19:28:27 +0800 > > Xiaolei Yu wrote: > > > >> On 10/03/2017 09:15 PM, wm4 wrote: > >>> From: Anton Khirnov > >>> > >>> Use the AVFrame.opaque_ref field. The original user's opa

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread Xiaolei Yu
On 10/16/2017 07:36 PM, wm4 wrote: > On Mon, 16 Oct 2017 19:28:27 +0800 > Xiaolei Yu wrote: > >> On 10/03/2017 09:15 PM, wm4 wrote: >>> From: Anton Khirnov >>> >>> Use the AVFrame.opaque_ref field. The original user's opaque_ref is >>> wrapped in the lavc struct and then unwrapped before the fra

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread wm4
On Mon, 16 Oct 2017 19:28:27 +0800 Xiaolei Yu wrote: > On 10/03/2017 09:15 PM, wm4 wrote: > > From: Anton Khirnov > > > > Use the AVFrame.opaque_ref field. The original user's opaque_ref is > > wrapped in the lavc struct and then unwrapped before the frame is > > returned to the caller. > > >

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread Xiaolei Yu
On 10/03/2017 09:15 PM, wm4 wrote: > From: Anton Khirnov > > Use the AVFrame.opaque_ref field. The original user's opaque_ref is > wrapped in the lavc struct and then unwrapped before the frame is > returned to the caller. > > This new struct will be useful in the following commits. > How abou

[FFmpeg-devel] [PATCH] libavformat: not treat 0 as EOF

2017-10-16 Thread Daniel Kucera
transfer_func variable passed to retry_transfer_wrapper are h->prot->url_read and h->prot->url_write functions. These need to return EOF or other error properly. In case of returning >= 0, url_read/url_write is retried until error is returned. Signed-off-by: Daniel Kucera --- libavformat/avio.c

Re: [FFmpeg-devel] [PATCH] libavformat/cache: don't treat 0 as EOF libavformat/aviobuf: don't treat 0 as EOF libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-10-16 Thread Daniel Kučera
> > This changes: > ./ffmpeg -y -i 'concat:matrixbench_mpeg2.mpg|matrixbench_mpeg2.mpg' -vsync 0 > -an file.avi > fixed, sending new patch. -- S pozdravom / Best regards Daniel Kucera. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffm

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

2017-10-16 Thread wm4
On Sat, 14 Oct 2017 23:01:41 +0200 Michael Niedermayer wrote: > On Fri, Oct 13, 2017 at 09:19:04PM +0200, wm4 wrote: > > On Fri, 13 Oct 2017 19:41:28 +0200 > > Michael Niedermayer wrote: > > > > > On Fri, Oct 06, 2017 at 01:48:14AM +0200, wm4 wrote: > > > > On Fri, 6 Oct 2017 00:01:30 +0200