Re: [FFmpeg-devel] [PATCH] RFC: drop VDA

On 9/5/2017 10:57 AM, Clément Bœsch wrote: > From: Clément Bœsch > > I'm reworking the Apple Framework dependencies in the build system, and > unfortunately I can't test VDA (because OSX doesn't have it anymore). > I'll either break it badly without being able to fix it, or won't be > able to do

[FFmpeg-devel] [PATCH] avfilter/vf_tonemap: don't use NAN constant as an initializer

Netbsd: src/libavfilter/vf_tonemap.c:314: error: initializer element is not constant src/libavfilter/vf_tonemap.c:314: error: (near initialization for 'tonemap_options[8].default_val.dbl') DJGPP src/libavfilter/vf_tonemap.c:314:87: error: initializer element is not constant { "param",

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/fitsdec: write output to frame directly

On 9/2/2017 4:07 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > This fixes the failed fate tests on mingw32: > http://fate.ffmpeg.org/report.cgi?time=20170902182311&slot=x86_32-mingw-w64-dll-windows-native > > libavcodec/fitsdec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 de

Re: [FFmpeg-devel] [PATCH] flvdec: Check the avio_seek return value after reading a metadata packet

2017-09-06 0:38 GMT+08:00 Steven Liu : > COPY FROM libav Martin Storsjö > > If the metadata packet is corrupted, flv_read_metabody can accidentally > read past the start of the next packet. If the start of the next packet > had been flushed out of the IO buffer, we would be unable to seek to > the

Re: [FFmpeg-devel] [PATCH] avformat/mux: stop delaying writing the header

On 5/26/2017 5:08 PM, James Almer wrote: > There's no need to wait for the first packet of every stream now that > every bitstream filter behaves as intended. > > Signed-off-by: James Almer > --- > What should we do with the AVFMT_FLAG_AUTO_BSF flag? Do we deprecate > it and force the automatic i

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

On Wed, Sep 06, 2017 at 11:55:41AM +0200, wm4 wrote: > On Tue, 5 Sep 2017 22:14:39 -0300 > James Almer wrote: > > > On 9/5/2017 5:38 AM, wm4 wrote: > > > On Tue, 5 Sep 2017 10:03:11 +0200 > > > Clément Bœsch wrote: > > > > > >> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: [...] > > >

Re: [FFmpeg-devel] [PATCH 2/2] lavfi/atempo: Avoid false triggering an assertion failure

On Tue, 5 Sep 2017, Marton Balint wrote: On Sun, 3 Sep 2017, pkoshe...@gmail.com wrote: From: Pavel Koshevoy Steps to reproduce: 1. revert 4240e5b047379b29c33dd3f4438bc4e610527b83 2. ./ffmpeg -f lavfi -i sine=d=1 -af aselect=e=0,atempo=0.5 -y atempo.wav --- libavfilter/af_atempo.c | 5

Re: [FFmpeg-devel] [PATCH] vf_fps: uses the last frame duration to duplicate it if needed

Le decadi 20 fructidor, an CCXXV, Paul B Mahol a écrit : > Why? Several reasons that I have explained in the past. To make it short, the information there is not reliable, not filled by the applications, not updated by many filters and likely to be inconsistent. Is that enough? > And why was it b

Re: [FFmpeg-devel] [PATCH] vf_fps: uses the last frame duration to duplicate it if needed

On 9/6/17, Nicolas George wrote: > Le decadi 20 fructidor, an CCXXV, Thierry Foucu a ecrit : >> --- >> libavfilter/vf_fps.c| 40 >> +++- >> tests/ref/fate/filter-fps | 6 ++ >> tests/ref/fate/filter-fps-r | 4 >> 3 files changed, 45 inserti

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: migrate to new encode API

On Wed, 6 Sep 2017 18:14:17 +0200 Timo Rothenpieler wrote: > >> +int ff_nvenc_receive_packet(AVCodecContext *avctx, AVPacket *pkt) > >> +{ > >> +CUresult cu_res; > >> +CUcontext dummy; > >> +NvencSurface *tmpoutsurf; > > > > You can remove tmpoutsurf in ff_nvenc_send_frame > > B

Re: [FFmpeg-devel] [PATCH] vf_fps: uses the last frame duration to duplicate it if needed

Le decadi 20 fructidor, an CCXXV, Thierry Foucu a écrit : > --- > libavfilter/vf_fps.c| 40 +++- > tests/ref/fate/filter-fps | 6 ++ > tests/ref/fate/filter-fps-r | 4 > 3 files changed, 45 insertions(+), 5 deletions(-) Already explained: n

[FFmpeg-devel] [PATCH] vf_fps: uses the last frame duration to duplicate it if needed

--- libavfilter/vf_fps.c| 40 +++- tests/ref/fate/filter-fps | 6 ++ tests/ref/fate/filter-fps-r | 4 3 files changed, 45 insertions(+), 5 deletions(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 20ccd797d1..a231da415c 10

Re: [FFmpeg-devel] [PATCH] avfilter/interlace: prevent over-sharpening with the complex low-pass filter

2017-09-01 1:55 GMT+02:00 Thomas Mundt : > 2017-09-01 1:22 GMT+02:00 Michael Niedermayer : > >> On Fri, Sep 01, 2017 at 01:18:11AM +0200, Michael Niedermayer wrote: >> > On Thu, Aug 31, 2017 at 10:40:12PM +0200, Thomas Mundt wrote: >> > > 2017-08-31 21:42 GMT+02:00 Michael Niedermayer > >: >> > >

[FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

From: Ashish Singh Hi, this patch changes previous one to framesync2. SIMD is a work in progress for this filter. Signed-off-by: Ashish Singh --- Changelog | 1 + doc/filters.texi| 16 ++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 +

Re: [FFmpeg-devel] [PATCH 1/7] build: fix objcc header check

Hi, Am 06.09.17 um 11:58 schrieb Clément Bœsch: > From: Clément Bœsch > > $headers is a variable set in the context of other functions (we don't > use the "local" keyword in our scripts, so those variables are global). > > Currently, when checking for AVFoundation/AVFoundation.h, the actual > e

Re: [FFmpeg-devel] [PATCH] configure: Fix DEF file post-processing with LTO enabled.

2017-08-22 21:26 GMT+02:00 Kacper Michajłow : > With LTO enabled exported symbol entry looks like: > av_audio_convert @3 DATA > > In order to maintain valid format we need to strip everything after @. > > This patch fixes linking libraries compiled with MinGW toolchain with LTO > enabled. > > Sign

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: don't immediately abort if an ADTS frame is not found

On Wed, Sep 6, 2017 at 3:51 PM, James Almer wrote: > On 9/6/2017 6:09 AM, Hendrik Leppkes wrote: >> On Wed, Sep 6, 2017 at 2:27 AM, James Almer wrote: >>> On 9/5/2017 8:47 PM, Hendrik Leppkes wrote: On Wed, Sep 6, 2017 at 12:32 AM, James Almer wrote: > On 9/5/2017 7:12 PM, Hendrik Leppk

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

Hi, On Wed, Sep 6, 2017 at 10:33 AM, James Almer wrote: > But i also agree with him that, currently, the > tree is littered with error messages that go "$spec_field is out of > range" or whatever, and that they have not been seen as an issue before. > He basically argues that wanting to make new

[FFmpeg-devel] [PATCH] avfilter: add Haas stereo enhancer

Signed-off-by: Paul B Mahol --- doc/filters.texi | 64 ++ libavfilter/Makefile | 1 + libavfilter/af_haas.c| 226 +++ libavfilter/allfilters.c | 1 + 4 files changed, 292 insertions(+) create mode 100644 libavfilter/af_

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: new options 'list_pixelformats' and 'pixelformat_code' to allow pixelformat selection by code

On Wed, 6 Sep 2017, Gildas Fargeas wrote: Alright, this should do the trick: - use named const for raw_format option - deprecate bm_v210 - bumped avdevice micro version --- libavdevice/decklink_common.cpp | 2 +- libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 43

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: migrate to new encode API

+int ff_nvenc_receive_packet(AVCodecContext *avctx, AVPacket *pkt) +{ +CUresult cu_res; +CUcontext dummy; +NvencSurface *tmpoutsurf; You can remove tmpoutsurf in ff_nvenc_send_frame But it's used in it? At the very end, to move the frames between queues. smime.p7s Description: S

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: migrate to new encode API

On Sat, 2 Sep 2017 21:27:03 +0200 Timo Rothenpieler wrote: > Signed-off-by: Timo Rothenpieler > --- > libavcodec/nvenc.c | 65 > - > libavcodec/nvenc.h | 6 + libavcodec/nvenc_h264.c | 6 + > libavcodec/nvenc_hevc.c | 4 +++ >

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

On Wed, 6 Sep 2017 11:33:05 -0300 James Almer wrote: > Also, had you also removed the automated merging parts of the code > without waiting for a major bump, if a pre-removal lavf were to send a > packet to a post-removal lavc, the latter would shit the bed with all > the packets full of unexpect

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

On 9/6/2017 6:55 AM, wm4 wrote: > On Tue, 5 Sep 2017 22:14:39 -0300 > James Almer wrote: > >> On 9/5/2017 5:38 AM, wm4 wrote: >>> On Tue, 5 Sep 2017 10:03:11 +0200 >>> Clément Bœsch wrote: >>> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: [...] Can't we just remove

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: don't immediately abort if an ADTS frame is not found

On 9/6/2017 6:09 AM, Hendrik Leppkes wrote: > On Wed, Sep 6, 2017 at 2:27 AM, James Almer wrote: >> On 9/5/2017 8:47 PM, Hendrik Leppkes wrote: >>> On Wed, Sep 6, 2017 at 12:32 AM, James Almer wrote: On 9/5/2017 7:12 PM, Hendrik Leppkes wrote: > On Tue, Sep 5, 2017 at 11:20 PM, James Alm

[FFmpeg-devel] [PATCH] avdevice/decklink: new options 'list_pixelformats' and 'pixelformat_code' to allow pixelformat selection by code

Alright, this should do the trick: - use named const for raw_format option - deprecate bm_v210 - bumped avdevice micro version --- libavdevice/decklink_common.cpp | 2 +- libavdevice/decklink_common_c.h | 1 + libavdevice/decklink_dec.cpp| 43 ++--- libav

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 18:31 GMT+08:00 Jeyapal, Karthick : > > >>On 9/6/17, 3:43 PM, "Steven Liu" >>mailto:lingjiujia...@gmail.com>> wrote: >> >>>2017-09-06 16:46 GMT+08:00 Jeyapal, Karthick >>>mailto:kjeya...@akamai.com>>: On 9/6/17, 12:37 PM, "Steven Liu" >>>gmail.com

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

>On 9/6/17, 3:43 PM, "Steven Liu" >mailto:lingjiujia...@gmail.com>> wrote: > >>2017-09-06 16:46 GMT+08:00 Jeyapal, Karthick >>mailto:kjeya...@akamai.com>>: >>>On 9/6/17, 12:37 PM, "Steven Liu" >>gmail.com>> at gmail.com

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 16:46 GMT+08:00 Jeyapal, Karthick : >>On 9/6/17, 12:37 PM, "Steven Liu" >>mailto:lingjiujia...@gmail.com>> wrote: >>segment1.ts duration = 4.88 >>ROUND is 5, not 4, is it? >>if its duration = 4.04 >>ROUND is 4, the real segment1.ts duration is 4.04, >> >>the safe one is

[FFmpeg-devel] [PATCH 5/7] build: add --disable-coreimage autodetect switch

From: Clément Bœsch --- configure | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/configure b/configure index a4c2d81dee..1e36cde447 100755 --- a/configure +++ b/configure @@ -205,6 +205,7 @@ External library support: --disable-avfoundation disable Apple AVFo

[FFmpeg-devel] [PATCH 7/7] build: cleanup videotoolbox

From: Clément Bœsch - there is no need for kCVImageBufferColorPrimaries_ITU_R_2020 checks, it's done at runtime - VideoToolbox presence is now checked with check_apple_framework() - link to CoreServices is only done when videotoolbox is enabled --- configure | 15 +-- 1 file change

[FFmpeg-devel] [PATCH 1/7] build: fix objcc header check

From: Clément Bœsch $headers is a variable set in the context of other functions (we don't use the "local" keyword in our scripts, so those variables are global). Currently, when checking for AVFoundation/AVFoundation.h, the actual enabled header is math.h. Similarly, when testing for QuartzCor

[FFmpeg-devel] [PATCH 4/7] build: add --disable-avfoundation autodetect switch

From: Clément Bœsch --- configure | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 158f9ba24b..a4c2d81dee 100755 --- a/configure +++ b/configure @@ -202,6 +202,7 @@ External library support: themselves, not all their features wi

[FFmpeg-devel] [PATCH 2/7] lavfi/coreimage: reduce dependency scope from QuartzCore to CoreImage

From: Clément Bœsch What is required by the filter is CoreImage, there is no QuartzCore usage. QuartzCore/CoreImage.h is simply an include to CoreImage/CoreImage.h. --- configure | 8 libavfilter/vf_coreimage.m | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) d

[FFmpeg-devel] [PATCH 3/7] build: add check_apple_framework()

From: Clément Bœsch This will be used in the following commits. --- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/configure index 442ef606e0..158f9ba24b 100755 --- a/configure +++ b/configure @@ -1120,6 +1120,15 @@ check_header_objcc(){ } | check_objcc &

[FFmpeg-devel] [PATCH 6/7] build: cleanup audiotoolbox handling

From: Clément Bœsch *_at codecs only need the AudioToolbox framework, which is now checked like the other Apple frameworks. --- configure | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/configure b/configure index 1e36cde447..a91bc9f58a 100755 --- a/configure +++ b/confi

Re: [FFmpeg-devel] [PATCH] avcodec/snowdec: Check intra block dc differences.

On Tue, 5 Sep 2017 22:14:39 -0300 James Almer wrote: > On 9/5/2017 5:38 AM, wm4 wrote: > > On Tue, 5 Sep 2017 10:03:11 +0200 > > Clément Bœsch wrote: > > > >> On Mon, Sep 04, 2017 at 08:35:17PM +0200, wm4 wrote: > >> [...] > >> Can't we just remove this codec? It has no use other than c

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec: add execute3() api to utilize the main function of avpriv_slicethread_create().

On Wed, 6 Sep 2017 06:57:25 +0700 Ilia Valiakhmetov wrote: > Signed-off-by: Ilia Valiakhmetov > --- > libavcodec/avcodec.h | 7 ++- > libavcodec/options.c | 1 + > libavcodec/pthread_slice.c | 26 -- > libavcodec/utils.c | 14 ++ >

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: don't immediately abort if an ADTS frame is not found

On Wed, Sep 6, 2017 at 2:27 AM, James Almer wrote: > On 9/5/2017 8:47 PM, Hendrik Leppkes wrote: >> On Wed, Sep 6, 2017 at 12:32 AM, James Almer wrote: >>> On 9/5/2017 7:12 PM, Hendrik Leppkes wrote: On Tue, Sep 5, 2017 at 11:20 PM, James Almer wrote: > On 9/5/2017 5:30 PM, Hendrik Lepp

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

>On 9/6/17, 12:37 PM, "Steven Liu" >mailto:lingjiujia...@gmail.com>> wrote: >segment1.ts duration = 4.88 >ROUND is 5, not 4, is it? >if its duration = 4.04 >ROUND is 4, the real segment1.ts duration is 4.04, > >the safe one is TARGETDURATION = 5, the get_int_from_ double API can >

Re: [FFmpeg-devel] [PATCH] lavd: implement threaded NewTek NDI output

On Tue, 5 Sep 2017, Marton Balint wrote: On Tue, 5 Sep 2017, Maksym Veremeyenko wrote: 04.09.2017 17:10, Maksym Veremeyenko пише: Hi, attached patch implemented threaded NDI output - separate output thread for each stream. it makes audio preview in my case more smooth. updated patch a

Re: [FFmpeg-devel] [PATCH] libswscale/swscale_unscaled: fix DITHER_COPY macro

W dniu 2017-09-06 o 02:07, Michael Niedermayer pisze: > On Wed, Sep 06, 2017 at 01:25:45AM +0200, Mateusz wrote: >> W dniu 2017-09-05 o 23:37, Michael Niedermayer pisze: >>> On Tue, Sep 05, 2017 at 04:42:06PM +0200, Mateusz wrote: W dniu 2017-09-05 o 15:40, Michael Niedermayer pisze: > On

Re: [FFmpeg-devel] [PATCH 1/1] avformat/hlsenc: Fix target duration computation when 'round_durations' is enabled

2017-09-06 14:06 GMT+08:00 Jeyapal, Karthick : > Hi Steven, > > I am restarting this discussion, just to conclude this thread one way or the > other. Maybe I am not thinking correctly. Here is detailed thinking, on why I > think this patch will not violate HLS spec. > >>if (target_duratio