Re: [FFmpeg-devel] [PATCH 1/2] vaapi_hevc: Add an option to set quality level

2017-08-20 Thread Li, Zhong
> -Original Message- > From: Jun Zhao [mailto:mypopy...@gmail.com] > Sent: Monday, August 21, 2017 11:27 AM > To: FFmpeg development discussions and patches > ; Li, Zhong > Cc: s...@jkqxz.net; Zhao, Jun ; nfx...@googlemail.com > Subject: Re: [FFmpeg-devel] [PATCH 1/2] vaapi_hevc: Add an op

Re: [FFmpeg-devel] [PATCH 1/2] vaapi_hevc: Add an option to setquality level

2017-08-20 Thread liyoubdu
so, how to use avctx->compression_level option? -- Original -- From: "Jun Zhao";; Send time: Monday, Aug 21, 2017 11:26 AM To: "FFmpeg development discussions and patches"; "Zhong Li"; Cc: "sw"; "jun.zhao"; "nfxjfg"; Subject: Re: [FFmpeg-devel] [PATCH 1/2]

Re: [FFmpeg-devel] [PATCH 1/2] vaapi_hevc: Add an option to set quality level

2017-08-20 Thread Jun Zhao
On 2017/8/21 11:04, Zhong Li wrote: > Just like vaapi_h264 encoder, quality_level is set for tradeoff quality > and performance. > > Signed-off-by: Zhong Li > --- > libavcodec/vaapi_encode_h265.c | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/libavcodec/

[FFmpeg-devel] [PATCH 2/2] vaapi_h264: fix quality level setting range

2017-08-20 Thread Zhong Li
The max value of quality should be 7 instead of 8. It has been fixed in intel-vaapi-driver(https://github.com/01org/intel-vaapi-driver/commit/53fa3daa12f6dbdd391d24ab479dc601ae37a89d) Signed-off-by: Zhong Li --- libavcodec/vaapi_encode_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[FFmpeg-devel] [PATCH 1/2] vaapi_hevc: Add an option to set quality level

2017-08-20 Thread Zhong Li
Just like vaapi_h264 encoder, quality_level is set for tradeoff quality and performance. Signed-off-by: Zhong Li --- libavcodec/vaapi_encode_h265.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c ind

Re: [FFmpeg-devel] [PATCH 03/18] hevc: Add names for reserved NAL unit types

2017-08-20 Thread Michael Niedermayer
On Sun, Aug 20, 2017 at 11:41:31PM +0100, Mark Thompson wrote: > While not yet used, these NAL units do already have some defined > semantics and are referred to elsewhere. > > (cherry picked from commit 3daaa4417317ca732fb00476fdb3308d784f87e4) > --- > libavcodec/hevc.h | 16 >

Re: [FFmpeg-devel] [PATCH 02/18] h264: Add stream constraint values to the common header

2017-08-20 Thread Michael Niedermayer
On Sun, Aug 20, 2017 at 11:41:30PM +0100, Mark Thompson wrote: > With comments describing the derivation of each value. > > (cherry picked from commit aaf441465080b9bc57f5ca8dea656f9b2c5dc821) > --- > libavcodec/h264.h | 45 + > 1 file changed, 45 inser

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Check delta_pocs in ff_hevc_decode_short_term_rps()

2017-08-20 Thread Michael Niedermayer
Fixes: integer overflow Fixes: 2893/clusterfuzz-testcase-minimized-5809330567774208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc_ps.c | 12 1 file changed, 12 insertions(+)

[FFmpeg-devel] [PATCH 1/2] avcodec/aacdec_template: Fix running cleanup in decode_ics_info()

2017-08-20 Thread Michael Niedermayer
Fixes: out of array read Fixes: 2873/clusterfuzz-testcase-minimized-5924145713905664 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aacdec_template.c | 4 ++-- 1 file changed, 2 insertions(+),

[FFmpeg-devel] [PATCH 17/18] vaapi_h265: Convert to use coded bitstream infrastructure

2017-08-20 Thread Mark Thompson
Also improves the metadata and generally makes the configuration a bit cleaner. (cherry picked from commit ac12486714b48f9bd5d9167f90b77c936751d6ef) --- configure |2 +- libavcodec/Makefile|2 +- libavcodec/vaapi_encode_h265.c | 1536 +++---

[FFmpeg-devel] [PATCH 18/18] vaapi_h265: Add support for AUD NAL units

2017-08-20 Thread Mark Thompson
Matching the H.264 encoder. (cherry picked from commit e3e8eab359238486dc233f7aa89b7bb3cb19ec38) --- libavcodec/vaapi_encode_h265.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 84

[FFmpeg-devel] [PATCH 16/18] vaapi_h264: Add support for SEI recovery points

2017-08-20 Thread Mark Thompson
Included by default with non-IDR intra frames. (cherry picked from commit a49ee60d5fdbdae1706a44cfbb814abb9793815f) --- libavcodec/vaapi_encode_h264.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_

[FFmpeg-devel] [PATCH 14/18] vaapi_h264: Convert to use coded bitstream infrastructure

2017-08-20 Thread Mark Thompson
(cherry picked from commit 7a4fac5e91789b73e07bd4ad20493cfde028df76) --- configure |2 +- libavcodec/Makefile|2 +- libavcodec/vaapi_encode_h264.c | 1425 3 files changed, 551 insertions(+), 878 deletions(-) diff --

[FFmpeg-devel] [PATCH 13/18] lavc: Add mpeg2_metadata bitstream filter

2017-08-20 Thread Mark Thompson
(cherry picked from commit b78c30d7ec26af67c00ce2002709a189f6a87a7e) --- configure | 1 + doc/bitstream_filters.texi | 36 libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/mpeg2_metadata_bsf.c | 360

[FFmpeg-devel] [PATCH 09/18] lavc: Add trace_headers bitstream filter

2017-08-20 Thread Mark Thompson
Supports all streams that the coded bitstream infrastructure does (currently H.264, H.265 and MPEG-2). (cherry picked from commit f11d8a5e8b185340cc50fcbc8a1437b0fbe7e931) --- configure | 1 + doc/bitstream_filters.texi | 8 +++ libavcodec/Makefile| 1 +

[FFmpeg-devel] [PATCH 15/18] vaapi_h264: Add support for AUD NAL units

2017-08-20 Thread Mark Thompson
Adds a new private option to enable them (off by default). (cherry picked from commit 820a4483af13cf6fd51f13638e57bcd1c3f629d4) --- libavcodec/vaapi_encode_h264.c | 33 + 1 file changed, 33 insertions(+) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaa

[FFmpeg-devel] [PATCH 08/18] lavc: Add coded bitstream read/write support for MPEG-2

2017-08-20 Thread Mark Thompson
(cherry picked from commit 2bc9ba8d3c41f3a8e56484bd67b05040c7909a01) --- configure | 2 + libavcodec/Makefile| 1 + libavcodec/cbs.c | 3 + libavcodec/cbs_internal.h | 1 + libavcodec/cbs_mpeg2.c

[FFmpeg-devel] [PATCH 12/18] lavc: Add hevc_metadata bitstream filter

2017-08-20 Thread Mark Thompson
This is able to modify some header metadata found in the VPS/SPS/VUI, and can also add/remove AUDs. (cherry picked from commit b31a9eae0233325c4b382c657f4b687d5d8b0812) --- configure | 1 + doc/bitstream_filters.texi | 54 + libavcodec/Makefile| 1 +

[FFmpeg-devel] [PATCH 11/18] lavc: Add h264_redundant_pps bitstream filter

2017-08-20 Thread Mark Thompson
This applies a specific fixup to some Bluray streams which contain redundant PPSs modifying irrelevant parameters of the stream which confuse other transformations which require correct extradata. A new single global PPS is created, and all of the redundant PPSs within the stream are removed. (ch

[FFmpeg-devel] [PATCH 07/18] lavc: Add coded bitstream read/write support for H.265

2017-08-20 Thread Mark Thompson
(cherry picked from commit 867381b8b51fa21fa2b8f071f508f3d39cc9c1f0) --- configure |2 + libavcodec/Makefile |1 + libavcodec/cbs.c |3 + libavcodec/cbs_h2645.c| 410 - libavcodec/cbs_h265.h

[FFmpeg-devel] [PATCH 06/18] lavc: Add coded bitstream read/write support for H.264

2017-08-20 Thread Mark Thompson
(cherry picked from commit acf06f45441be24c5cbae0920579cd69427326a1) (cherry picked from commit 768eb9182e94a94bc2ef46f565a0dac7afef3b57) --- configure |2 + libavcodec/Makefile |1 + libavcodec/cbs.c |3 + libavcodec/c

[FFmpeg-devel] [PATCH 04/18] hevc: Improve stream constraint values in common header

2017-08-20 Thread Mark Thompson
Add comments to describe the sources of the constraint values expressed here, and add some more related values which will be used in following patches. Fix the incorrect values for SPS and PPS count (they are not the same as those used for H.264), and remove HEVC_MAX_CU_SIZE because it is not used

[FFmpeg-devel] [PATCH 02/18] h264: Add stream constraint values to the common header

2017-08-20 Thread Mark Thompson
With comments describing the derivation of each value. (cherry picked from commit aaf441465080b9bc57f5ca8dea656f9b2c5dc821) --- libavcodec/h264.h | 45 + 1 file changed, 45 insertions(+) diff --git a/libavcodec/h264.h b/libavcodec/h264.h index 86df5eb9

[FFmpeg-devel] [PATCH 00/18] Coded bitstream editing

2017-08-20 Thread Mark Thompson
This series adds a coded bitstream editing infrastructure, mostly as a merge from the other tine. The main change on merging is replacing the use of the bitstream API with the get_bits API; pretty much all other differences are just resolving minor differences between the two tines. Patches 1-

[FFmpeg-devel] [PATCH 03/18] hevc: Add names for reserved NAL unit types

2017-08-20 Thread Mark Thompson
While not yet used, these NAL units do already have some defined semantics and are referred to elsewhere. (cherry picked from commit 3daaa4417317ca732fb00476fdb3308d784f87e4) --- libavcodec/hevc.h | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/hevc.h b/libavcodec

[FFmpeg-devel] [PATCH 10/18] lavc: Add h264_metadata bitstream filter

2017-08-20 Thread Mark Thompson
This is able to modify some header metadata found in the SPS/VUI, and can also add/remove AUDs and insert user data in SEI NAL units. (cherry picked from commit 9e93001b6135a23fe4e200196c08fb4fbffed6fc) --- configure | 1 + doc/bitstream_filters.texi | 63 + libavc

[FFmpeg-devel] [PATCH 05/18] lavc: Add coded bitstream read/write API

2017-08-20 Thread Mark Thompson
(cherry picked from commit 18f1706f331bf5dd565774eae680508c8d3a97ad) --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/cbs.c | 460 ++ libavcodec/cbs.h | 274 +++ libavcodec/cbs

[FFmpeg-devel] [PATCH 01/18] h264_sei: Add namespace prefix to all SEI values

2017-08-20 Thread Mark Thompson
This avoids confusion with equivalent H.265 SEI values when both are being used at the same time. (cherry picked from commit 6ea220cbeec8863e2006a03b73bed52db2b13ee7) --- libavcodec/h264_parser.c | 26 - libavcodec/h264_sei.c | 20 ++-- libav

Re: [FFmpeg-devel] V4L2 M2M version 5

2017-08-20 Thread Jorge Ramirez
On 08/09/2017 01:19 PM, Jorge Ramirez-Ortiz wrote: This commit fixes the broken build on platforms not support v4l2_m2m but supporting v4l - this has been tested on ubuntu 10.04, 2.6.xx kernel. It also fixes a regression introduced in libavcodec/Makefile with v4. Fate suite and encoders/decoder

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavc

[FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka --- libavcodec/utils.c| 2 +- libavformat/aviobuf.c | 2 ++ libavformat/mov.c | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavc

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Fixes: undefined shift in av_mod_uintp2()

2017-08-20 Thread Michael Niedermayer
On Sun, Aug 20, 2017 at 04:06:46PM +0200, Paul B Mahol wrote: > On 8/19/17, Michael Niedermayer wrote: > > On Sat, Aug 19, 2017 at 04:00:18PM +0200, Paul B Mahol wrote: > >> On 8/19/17, Michael Niedermayer wrote: > >> > On Fri, Aug 18, 2017 at 06:21:56PM +0200, Paul B Mahol wrote: > >> >> On 8/18

Re: [FFmpeg-devel] [PATCH V3 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-08-20 Thread Mark Thompson
On 18/08/17 03:14, Jun Zhao wrote: > From 64c53df3134c0b478d212f141e6dbe4c3743b3c6 Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 1 Aug 2017 23:05:44 -0400 > Subject: [PATCH V3 3/4] lavc/vaapi_encode_h264: respect "slices" option in > h264 vaapi encoder > > Enable multi-slice support in

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread James Almer
On 8/20/2017 4:10 AM, Vitaly Buka wrote: > Looks like libavcodec/ has more LL or ll than INT64_C. > Should I update the patch? IMO yes. LL is known to work whereas ll might not in some fringe setups (we have a few of those running FATE). > > On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes > w

Re: [FFmpeg-devel] [PATCH V3 1/4] lavc/vaapi_encode: Change the slice/parameter buffers to dynamic alloc.

2017-08-20 Thread Mark Thompson
On 18/08/17 03:13, Jun Zhao wrote: > V3: - Making pic->slices be VAAPIEncodeSlice* instead of VAAPIEncodeSlice**. > - Fix resource (vaBuffer) lead when realloc pic->param_buffers fail. > - Adjust max_slices location in VAAPIEncodeContext. > - Re-work distributing the macro-blocks for mu

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Fixes: undefined shift in av_mod_uintp2()

2017-08-20 Thread Paul B Mahol
On 8/19/17, Michael Niedermayer wrote: > On Sat, Aug 19, 2017 at 04:00:18PM +0200, Paul B Mahol wrote: >> On 8/19/17, Michael Niedermayer wrote: >> > On Fri, Aug 18, 2017 at 06:21:56PM +0200, Paul B Mahol wrote: >> >> On 8/18/17, Michael Niedermayer wrote: >> >> > Fixes: runtime error: shift exp

Re: [FFmpeg-devel] [PATCH V3 1/2] lavc/vaapi_encode_h264: add "coder" option support

2017-08-20 Thread Mark Thompson
On 16/08/17 03:47, Jun Zhao wrote: > V3: Clean the code and add docs for "coder" option base on Steven code review. > V2: Follow libx264 "coder" option style, base on Hendrik Leppkes code review. LGTM; applied. Thanks, - Mark ___ ffmpeg-devel mailing l

[FFmpeg-devel] [PATCH] avformat/hlsenc: move free fmp4_init_filename after hls_window operation

2017-08-20 Thread Steven Liu
fix ticket id: 6599 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 74a3249b73..4a90886331 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1745,7 +1745,6 @@ s

Re: [FFmpeg-devel] [PATCH 10/16] lavfi/vf_libvmaf: convert to framesync2.

2017-08-20 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Nicolas George a écrit : > After this commit, the code compiles, but on my setup it > segfaults before and after. It also prints the very worrying > warning: > > src/libavfilter/vf_libvmaf.c:161:66: warning: passing argument 4 of > ‘compute_vmaf’ from incompatible

Re: [FFmpeg-devel] [PATCH 01/16] doc/filters: document the unstability of the shorthand options notation.

2017-08-20 Thread Nicolas George
Le tridi 23 thermidor, an CCXXV, Marton Balint a écrit : > I suggest you push the patch series without this patch, Michael can fix the > overlay and blend/tblend parameter order. If later the needed additional > compatibility code becomes too much of a burden, we can discuss this > further. I will

Re: [FFmpeg-devel] [PATCH] lavf/bink: fix latest header and add all existing revisions

2017-08-20 Thread Banana M.
Yes, it's my github handle, thanks. 2017-08-20 3:00 GMT+02:00 Michael Niedermayer : > On Sun, Aug 20, 2017 at 01:51:07AM +0200, Michael Niedermayer wrote: > > On Fri, Aug 18, 2017 at 07:45:16PM +0200, bananaman...@gmail.com wrote: > > > From: bnnm > > > > > > KB2 'i' found in Life is Strange (Xb

Re: [FFmpeg-devel] [PATCH] Fix signed integer overflows

2017-08-20 Thread Vitaly Buka
Looks like libavcodec/ has more LL or ll than INT64_C. Should I update the patch? On Sat, Aug 19, 2017 at 11:35 PM, Hendrik Leppkes wrote: > On Sun, Aug 20, 2017 at 3:19 AM, Vitaly Buka > wrote: > > Signed integer overflow is undefined behavior. > > Detected with clang and -fsanitize=signed-int