Re: [FFmpeg-devel] [PATCH] avutil/frame: allow only one element per type in frame side data

2017-07-28 Thread James Almer
On 7/25/2017 9:10 PM, James Almer wrote: > Same rationale as with packet side data, it was never meant to do otherwise > as av_frame_get_side_data returns the first entry it finds of a given type. > > Based on code from libavformat's av_stream_add_side_data(). > > Signed-off-by: James Almer > --

Re: [FFmpeg-devel] [PATCH] avcodec/atrac3p: use float_dsp in ff_atrac3p_power_compensation

2017-07-28 Thread James Almer
On 7/20/2017 4:01 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Fate passes, so i guess the aligment requirements are met. > > libavcodec/atrac3plus.h| 5 +++-- > libavcodec/atrac3plusdec.c | 36 ++-- > libavcodec/atrac3plusdsp.c | 8 >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rtmppkt: Convert ff_amf_get_field_value() to bytestream2

2017-07-28 Thread James Almer
On 7/28/2017 10:57 PM, Michael Niedermayer wrote: > On Fri, Jul 28, 2017 at 03:47:05PM +0200, Michael Niedermayer wrote: >> Fixes: out of array accesses >> > >> The new function uses ff_ prefix even though its static to ease future >> changes toward bytestream2 > > applied without this and also t

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/takdec: Fix integer overflow in decode_subframe()

2017-07-28 Thread Michael Niedermayer
On Thu, Jul 27, 2017 at 11:49:26PM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -536870912 - 1972191120 cannot > be represented in type 'int' > Fixes: 2711/clusterfuzz-testcase-minimized-4975142398590976 > > Found-by: continuous fuzzing process > https://git

Re: [FFmpeg-devel] [PATCH 2/2] avformat/rtmppkt: Convert ff_amf_get_field_value() to bytestream2

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 03:47:05PM +0200, Michael Niedermayer wrote: > Fixes: out of array accesses > > The new function uses ff_ prefix even though its static to ease future > changes toward bytestream2 applied without this and also the ff_ prefix removed as requested for the other patch, so it

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtmppkt: Convert ff_amf_tag_size() to bytestream2

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 07:11:35PM -0300, James Almer wrote: > On 7/28/2017 10:47 AM, Michael Niedermayer wrote: > > Fixes: out of array accesses > > Fixes: crash-9238fa9e8d4fde3beda1f279626f53812cb001cb-SEGV > > > > Found-by: JunDong Xie of Ant-financial Light-Year Security Lab > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-28 Thread Ivan Kalvachev
On 7/29/17, Dominik 'Rathann' Mierzejewski wrote: > On Saturday, 29 July 2017 at 00:20, Hendrik Leppkes wrote: >> On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot >> wrote: > [...] >> > This Makefile snippet allows libffmpeg to be created without the help >> > of Chromium's build system. It uses

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: tile threading v1

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 10:31:26PM +0700, Ilia Valiakhmetov wrote: > Signed-off-by: Ilia Valiakhmetov > --- > libavcodec/vp9.c | 441 +++- > libavcodec/vp9_mc_template.c | 126 ++-- > libavcodec/vp9block.c| 470 > +++

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-28 Thread Dominik 'Rathann' Mierzejewski
On Saturday, 29 July 2017 at 00:20, Hendrik Leppkes wrote: > On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot wrote: [...] > > This Makefile snippet allows libffmpeg to be created without the help > > of Chromium's build system. It uses the CONFIG_SHARED variable to > > decide whether to link the

Re: [FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-28 Thread Hendrik Leppkes
On Fri, Jul 28, 2017 at 12:07 PM, James Le Cuirot wrote: > Google Chrome ships with support for proprietary codecs and Chromium > can be built with support for them, either using the bundled FFmpeg or > a system copy. > > This leaves other browsers such as Opera and Vivaldi, which ship with > a li

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rtmppkt: Convert ff_amf_tag_size() to bytestream2

2017-07-28 Thread James Almer
On 7/28/2017 10:47 AM, Michael Niedermayer wrote: > Fixes: out of array accesses > Fixes: crash-9238fa9e8d4fde3beda1f279626f53812cb001cb-SEGV > > Found-by: JunDong Xie of Ant-financial Light-Year Security Lab > Signed-off-by: Michael Niedermayer > --- > libavformat/rtmppkt.c | 60 >

[FFmpeg-devel] [PATCH] speedhq: fix behavior of single-field decoding

2017-07-28 Thread Steinar H. Gunderson
The height convention for decoding frames with only a single field made sense for compatibility with legacy decoders, but doesn't really match the convention used by NDI, which is the primary (only?) user. Thus, change it to simply assuming that if the two fields overlap, the frame is meant to be a

[FFmpeg-devel] [PATCH] build: Allow libffmpeg to be built for Chromium-based browsers

2017-07-28 Thread James Le Cuirot
Google Chrome ships with support for proprietary codecs and Chromium can be built with support for them, either using the bundled FFmpeg or a system copy. This leaves other browsers such as Opera and Vivaldi, which ship with a libffmpeg that does not support proprietary codecs, presumably for cost

Re: [FFmpeg-devel] [PATCH 7/8] build: simplify weak-enabling of autodetected libraries

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 01:51:44PM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > --- > configure | 18 +++--- > 1 file changed, 3 insertions(+), 15 deletions(-) breaks mingw64 build configure --cc='ccache x86_64-w64-mingw32-gcc' --enable-xmm-clobber-test --samples=/home

Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc dequant-idct luma dc msa function

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 11:17:26AM +, Manojkumar Bhosale wrote: > LGTM will be in my next git push thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away the freedom of one citizen and you will be jailed, take away the freedom of all citizens and you

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dirac_vlc: Fix invalid shift

2017-07-28 Thread Michael Niedermayer
On Fri, Jul 28, 2017 at 02:44:34AM +0100, Rostislav Pehlivanov wrote: > On 28 July 2017 at 02:22, Michael Niedermayer > wrote: > > > Fixes: runtime error: shift exponent 65 is too large for 64-bit type > > 'residual' (aka 'unsigned long') > > Fixes: 2737/clusterfuzz-testcase-minimized-49686391470

Re: [FFmpeg-devel] [PATCH V3 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-28 Thread James Almer
On 7/28/2017 11:59 AM, Tyler Jones wrote: >>> --- a/libavcodec/vorbisenc.c >>> +++ b/libavcodec/vorbisenc.c >>> @@ -33,6 +33,7 @@ >>> #include "mathops.h" >>> #include "vorbis.h" >>> #include "vorbis_enc_data.h" >>> +#include "vorbispsy.h" >>> >>> #include "audio_frame_queue.h" >>> #include

[FFmpeg-devel] [PATCH V4 2/2] avcodec/vorbisenc: Apply dynamic frame lengths

2017-07-28 Thread Tyler Jones
Additional codebooks are added for shorter 128-sample frames. Changes in codeword generation are made to handle valid values of 0 that prepend some codebooks, otherwise books are classified incorrectly and cause unreadable streams. A second residue, floor, and mapping is created for short window l

[FFmpeg-devel] [PATCH V4 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-28 Thread Tyler Jones
The encoder will attempt to determine the existence of transient signals by applying a 4th order highpass filter to remove dominant low frequency waveforms. Frames are then split up into blocks where the variance is calculated and compared with blocks from the previous frame. A preecho is only like

Re: [FFmpeg-devel] [PATCH V3 1/2] avcodec/vorbisenc: Add pre-echo detection

2017-07-28 Thread Tyler Jones
> > --- a/libavcodec/vorbisenc.c > > +++ b/libavcodec/vorbisenc.c > > @@ -33,6 +33,7 @@ > > #include "mathops.h" > > #include "vorbis.h" > > #include "vorbis_enc_data.h" > > +#include "vorbispsy.h" > > > > #include "audio_frame_queue.h" > > #include "libavfilter/bufferqueue.h" > > @@ -136,6

Re: [FFmpeg-devel] [PATCH 8/8 v2] build: add --disable-autodetect switch

2017-07-28 Thread Clément Bœsch
On Fri, Jul 28, 2017 at 01:51:45PM +0200, Clément Bœsch wrote: > From: Clément Bœsch > > --- > Changelog | 1 + > configure | 6 -- > 2 files changed, 5 insertions(+), 2 deletions(-) > new version attached, fixing link problems. I still have some stuff I'd like to drop though: ☭ ldd ./ff

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread Steven Liu
sharpbai 于2017年7月28日 周五下午5:34写道: > From: sharpbai > > feature: add scaleFactor attribute for avfoundation > added by: siyuan.w...@duobei.com > added by: yiren...@duobei.com > --- > doc/indevs.texi| 3 +++ > libavdevice/avfoundation.m | 6 ++ > 2 files changed, 9 insertions(+) > >

[FFmpeg-devel] [PATCH 1/2] avformat/rtmppkt: Convert ff_amf_tag_size() to bytestream2

2017-07-28 Thread Michael Niedermayer
Fixes: out of array accesses Fixes: crash-9238fa9e8d4fde3beda1f279626f53812cb001cb-SEGV Found-by: JunDong Xie of Ant-financial Light-Year Security Lab Signed-off-by: Michael Niedermayer --- libavformat/rtmppkt.c | 60 ++- 1 file changed, 40 inserti

[FFmpeg-devel] [PATCH 2/2] avformat/rtmppkt: Convert ff_amf_get_field_value() to bytestream2

2017-07-28 Thread Michael Niedermayer
Fixes: out of array accesses The new function uses ff_ prefix even though its static to ease future changes toward bytestream2 Found-by: JunDong Xie of Ant-financial Light-Year Security Lab Signed-off-by: Michael Niedermayer --- libavformat/rtmppkt.c | 57 +--

Re: [FFmpeg-devel] [PATCH 3/8] build: treat iconv like other autodetected libraries

2017-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXV, Clement Boesch a écrit : > Though, --disable-autodetect will disable its auto-detection, be it > a "system" or a randomly installed library. Yes, and I think it is a bad idea for iconv. > Well, being maintained by the base system or through a normal package > doe

Re: [FFmpeg-devel] [PATCH 3/8] build: treat iconv like other autodetected libraries

2017-07-28 Thread Clément Bœsch
On Fri, Jul 28, 2017 at 01:57:53PM +0200, Nicolas George wrote: > Le decadi 10 thermidor, an CCXXV, Clement Boesch a écrit : > > From: Clément Bœsch > > > > --- > > configure | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > I am not sure exactly what the code does, but I think i

Re: [FFmpeg-devel] [PATCH 2/8] build: treat crystalhd like other hwaccels

2017-07-28 Thread Philip Langdale
On 2017-07-28 11:51, Clément Bœsch wrote: From: Clément Bœsch --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a80f9cb2eb..a2ad72f7f4 100755 --- a/configure +++ b/configure @@ -1529,7 +1529,6 @@ EXTERNAL_LIBRARY_LIST=" $E

Re: [FFmpeg-devel] [PATCH 3/8] build: treat iconv like other autodetected libraries

2017-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXV, Clement Boesch a écrit : > From: Clément Bœsch > > --- > configure | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I am not sure exactly what the code does, but I think it must make a difference between iconv provided by the libc on good Unix systems

[FFmpeg-devel] [PATCH 8/8] build: add --disable-autodetect switch

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- Changelog | 1 + configure | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index 187ae7950a..50409118e6 100644 --- a/Changelog +++ b/Changelog @@ -29,6 +29,7 @@ version : - limiter video filter - libvmaf video filter - D

[FFmpeg-devel] [PATCH 5/8] build: treat securetransport and schannel like other autodetected libraries

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/configure b/configure index d5e05a0eca..296e83926d 100755 --- a/configure +++ b/configure @@ -3597,6 +3597,7 @@ enable_weak cuda cuvid nvenc vda_framework videotoolbox videotool

[FFmpeg-devel] [PATCH 7/8] build: simplify weak-enabling of autodetected libraries

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/configure b/configure index 6ddda239de..fa1b1d334a 100755 --- a/configure +++ b/configure @@ -3583,21 +3583,9 @@ done for lib in $AUTODETECT_LIBS; do enabled $lib && re

[FFmpeg-devel] [PATCH 6/8] build: remove vda_framework from enable_weak

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch vda_framework is already pulled by the weakly enabled vda and videotoolbox. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 296e83926d..6ddda239de 100755 --- a/configure +++ b/configure @@ -3591,7 +3591,7 @@ enable

[FFmpeg-devel] [PATCH 4/8] build: treat libxcb like other autodetected libraries

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/configure b/configure index 5ba171d459..d5e05a0eca 100755 --- a/configure +++ b/configure @@ -3589,7 +3589,7 @@ enable_weak audiotoolbox # Enable hwaccels by default

[FFmpeg-devel] [PATCH 2/8] build: treat crystalhd like other hwaccels

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/configure b/configure index a80f9cb2eb..a2ad72f7f4 100755 --- a/configure +++ b/configure @@ -1529,7 +1529,6 @@ EXTERNAL_LIBRARY_LIST=" $EXTERNAL_LIBRARY_VERSION3_LIST $EXTERNAL

[FFmpeg-devel] [PATCH 3/8] build: treat iconv like other autodetected libraries

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index a2ad72f7f4..5ba171d459 100755 --- a/configure +++ b/configure @@ -3596,6 +3596,8 @@ enable_weak cuda cuvid nvenc vda_framework videotoolbox videotoolbox_encoder

[FFmpeg-devel] [PATCH 1/8] build: group z libs with other autodetected libraries

2017-07-28 Thread Clément Bœsch
From: Clément Bœsch --- configure | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 5811ee149a..a80f9cb2eb 100755 --- a/configure +++ b/configure @@ -3593,6 +3593,9 @@ enable_weak xlib enable_weak cuda cuvid nvenc vda_framework videotoolb

[FFmpeg-devel] Switching of automatically detected libraries

2017-07-28 Thread Clément Bœsch
Creating predictible builds is currentl difficult due to automatically detected libraries. This patchset adds an option to turn this off. As a side effect, it regroups all the automatically detected libraries in the same place. Note: crystalhd, securetransport, schannel and vda changes mostly UNTE

[FFmpeg-devel] [PATCH] avfilter: add ADM filter

2017-07-28 Thread Ashish Pratap Singh
From: Ashish Singh Signed-off-by: Ashish Singh --- Changelog| 1 + doc/filters.texi | 19 ++ libavfilter/Makefile | 1 + libavfilter/adm.h| 88 + libavfilter/allfilters.c | 1 + libavfilter/vf_adm.c | 819 ++

Re: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc dequant-idct luma dc msa function

2017-07-28 Thread Manojkumar Bhosale
LGTM -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of kaustubh.ra...@imgtec.com Sent: Friday, July 28, 2017 2:12 PM To: ffmpeg-devel@ffmpeg.org Cc: Kaustubh Raste Subject: [FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc dequant-idct luma dc

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread Moritz Barsnick
On Fri, Jul 28, 2017 at 15:55:01 +0800, sharpbai wrote: > +float scaleFactor; No camelCase in ffmpeg for plain variables. > +{ "scaleFactor", "scale screen factor range", offsetof(AVFContext, > scaleFactor), AV_OPT_TYPE_FLOAT, {.i64=1}, 0, 2, AV_OPT_FLAG_DECODING_PARAM }, No c

Re: [FFmpeg-devel] [PATCH] Add FITS Decoder

2017-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit : > Signed-off-by: Paras Chadha > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c |

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-28 Thread Nicolas George
Le decadi 10 thermidor, an CCXXV, Paras Chadha a écrit : > Signed-off-by: Paras Chadha > --- > > Made all the changes suggested. Nice. There are a few nitpicks, but I like these versions much better. > > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavformat/fitsd

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-28 Thread Paras Chadha
On Fri, Jul 28, 2017 at 1:44 PM, Clément Bœsch wrote: > On Fri, Jul 28, 2017 at 12:32:59AM +0530, Paras Chadha wrote: > [...] > > +static int fits_probe(AVProbeData *p) > > +{ > > +const uint8_t *b = p->buf; > > + > > +if (AV_RB64(b) == 0x53494d504c452020 && > > +AV_RB64(b + 8) ==

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread sharpbai
From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 3 +++ libavdevice/avfoundation.m | 6 ++ 2 files changed, 9 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index

Re: [FFmpeg-devel] [PATCH 4/4] libavcodec/dev: v4l2: add support for v4l2 mem2mem codecs

2017-07-28 Thread Jorge Ramirez
On 07/28/2017 12:45 AM, Michael Niedermayer wrote: On Thu, Jul 27, 2017 at 08:44:37AM +0200, Jorge Ramirez wrote: On 07/26/2017 04:04 PM, Michael Niedermayer wrote: On Mon, Jul 24, 2017 at 09:08:49PM +0200, Jorge Ramirez-Ortiz wrote: From: Alexis Ballier This patchset enhances Alexis Ballier

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread Steven Liu
2017-07-28 16:34 GMT+08:00 Steven Liu : > 2017-07-28 15:55 GMT+08:00 sharpbai : >> From: sharpbai >> >> feature: add scaleFactor attribute for avfoundation >> added by: siyuan.w...@duobei.com >> added by: yiren...@duobei.com >> --- >> libavdevice/avfoundation.m | 5 + >> 1 file changed, 5 ins

[FFmpeg-devel] [PATCH] libavcodec/mips: Improve avc dequant-idct luma dc msa function

2017-07-28 Thread kaustubh.raste
From: Kaustubh Raste Signed-off-by: Kaustubh Raste --- libavcodec/mips/h264idct_msa.c | 66 +++- 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/libavcodec/mips/h264idct_msa.c b/libavcodec/mips/h264idct_msa.c index 81e09e9..861befe 100644 --

Re: [FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread Steven Liu
2017-07-28 15:55 GMT+08:00 sharpbai : > From: sharpbai > > feature: add scaleFactor attribute for avfoundation > added by: siyuan.w...@duobei.com > added by: yiren...@duobei.com > --- > libavdevice/avfoundation.m | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavdevice/avfoundati

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

2017-07-28 Thread sharpbai
From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- libavdevice/avfoundation.m | 5 + 1 file changed, 5 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index e2ddf47..22cff1f

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-07-28 Thread Clément Bœsch
On Fri, Jul 28, 2017 at 12:32:59AM +0530, Paras Chadha wrote: [...] > +static int fits_probe(AVProbeData *p) > +{ > +const uint8_t *b = p->buf; > + > +if (AV_RB64(b) == 0x53494d504c452020 && > +AV_RB64(b + 8) == 0x3D20202020202020 && > +AV_RB64(b + 16) == 0x2020202020202020