Re: [FFmpeg-devel] [PATCH]v5 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-22 Thread Rostislav Pehlivanov
On 22 July 2017 at 12:18, Ivan Kalvachev wrote: > This patch is ready for review and inclusion. > > > >+%macro emu_blendvps 3 ; dst/src_a, src_b, mask >+%macro lea_pic_base 2; reg, const_label Capitalize macro names. >+ %error sse41 blendvps uses xmm0 as default 3d operand, you used %3 Rem

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dcaadpcm: fix use of uninitialized variable

2017-07-22 Thread foo86
On Sat, Jul 22, 2017 at 07:36:04PM +0100, Rostislav Pehlivanov wrote: > On 22 July 2017 at 18:50, foo86 wrote: > > > Fixes CID 1409924. > > --- > > libavcodec/dcaadpcm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

2017-07-22 Thread foo86
On Sat, Jul 22, 2017 at 03:33:18PM -0300, James Almer wrote: > On 7/22/2017 2:50 PM, foo86 wrote: > > Fixes CID 1409915. > > --- > > libavcodec/dcaadpcm.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c > > index 8742c7ccf6..e00f81f0

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

2017-07-22 Thread foo86
On Sat, Jul 22, 2017 at 07:55:05PM +0200, Nicolas George wrote: > Le quartidi 4 thermidor, an CCXXV, foo86 a écrit : > > Fixes CID 1409915. > > --- > > libavcodec/dcaadpcm.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c > > index 8

Re: [FFmpeg-devel] [PATCH] pixdesc: Explicitly handle invalid arguments to av_find_best_pix_fmt_of_2()

2017-07-22 Thread Mark Thompson
On 21/07/17 14:29, Carl Eugen Hoyos wrote: > 2017-07-21 15:22 GMT+02:00 Michael Niedermayer : >> On Thu, Jul 20, 2017 at 09:54:05PM +0100, Mark Thompson wrote: > >> PS: heres the patch without whitespace changes (much more readable) > > Please use this variant and push a cosmetic change. > >> co

Re: [FFmpeg-devel] [PATCH 2/2] pngdec: decode and expose iCCP chunks as side data

2017-07-22 Thread Rostislav Pehlivanov
On 21 July 2017 at 14:11, Michael Niedermayer wrote: > On Thu, Jul 20, 2017 at 09:46:22PM +0100, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > libavcodec/pngdec.c | 45 + > > 1 file changed, 45 insertions(+) > > > > d

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

2017-07-22 Thread Rostislav Pehlivanov
On 21 July 2017 at 14:36, Nicolas George wrote: > Le tridi 3 thermidor, an CCXXV, Derek Buitenhuis a écrit : > > +1 on exposing it as side data; it's consistent with previous APIs and > doesn't > > I will not oppose further; I do not buy the "Yet Another Field" argument > but I will debunk it ano

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/dcaadpcm: fix use of uninitialized variable

2017-07-22 Thread Rostislav Pehlivanov
On 22 July 2017 at 18:50, foo86 wrote: > Fixes CID 1409924. > --- > libavcodec/dcaadpcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c > index e00f81f011..99cbb40172 100644 > --- a/libavcodec/dcaadpcm.c > +++ b/libavcodec/

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

2017-07-22 Thread James Almer
On 7/22/2017 2:50 PM, foo86 wrote: > Fixes CID 1409915. > --- > libavcodec/dcaadpcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c > index 8742c7ccf6..e00f81f011 100644 > --- a/libavcodec/dcaadpcm.c > +++ b/libavcodec/dcaadpcm.c > @@ -2

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

2017-07-22 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, foo86 a écrit : > Fixes CID 1409915. > --- > libavcodec/dcaadpcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c > index 8742c7ccf6..e00f81f011 100644 > --- a/libavcodec/dcaadpcm.c > +++ b/libavcodec/dc

[FFmpeg-devel] [PATCH 1/2] avcodec/dcaadpcm: check for av_malloc() failure

2017-07-22 Thread foo86
Fixes CID 1409915. --- libavcodec/dcaadpcm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c index 8742c7ccf6..e00f81f011 100644 --- a/libavcodec/dcaadpcm.c +++ b/libavcodec/dcaadpcm.c @@ -215,6 +215,9 @@ av_cold int ff_dcaadpcm_init(DCAADPCMEnc

[FFmpeg-devel] [PATCH 2/2] avcodec/dcaadpcm: fix use of uninitialized variable

2017-07-22 Thread foo86
Fixes CID 1409924. --- libavcodec/dcaadpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dcaadpcm.c b/libavcodec/dcaadpcm.c index e00f81f011..99cbb40172 100644 --- a/libavcodec/dcaadpcm.c +++ b/libavcodec/dcaadpcm.c @@ -80,7 +80,7 @@ static int64_t find_best_filt

Re: [FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, Kieran Kunhya a écrit : > In practice this is not an API change because it is required for some > decoders in practice (Opus and AVX2 comes to mind). Yes, but if that constraint is not documented then any crash should be considered a bug in FFmpeg, not a violatio

Re: [FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : > Of course, the linesize constraint has already been there. Should we > relax this constraint? Yes, if we can, we should. But I am not implying any kind of priority about it. Relaxing a constraint that is already present since long ago is

Re: [FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Kieran Kunhya
On Sat, 22 Jul 2017 at 15:14 Nicolas George wrote: > Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : > > The behaviour is based on assumptions: > > - copying audio data is cheap, so keeping data alignment is cheap, > > - copying video data is not cheap, so keeping data alignmen

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: Fix decoding regression due to height check

2017-07-22 Thread Kieran Kunhya
> > LGTM. Look at Libav repo, it is checked with a_height. > > Thank's. > Patch OK. As author of this code I would highly recommend not looking at libav repo because they broke a ton of stuff. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 22.07.2017, at 10:45, Reimar Döffinger wrote: > > Sorry for disturbing anyone's fun with too much philosophy ;) I also apologize that I sent my previous mail, which was the first on the topic, to the public mailing list. I SHOULD know better and contact the people involved in private as a f

Re: [FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Muhammad Faiz
On Sat, Jul 22, 2017 at 9:53 PM, Nicolas George wrote: > Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : >> It fixed the testcase's crash, but didn't fix the bug. > > So it is not FIXED. > >> It is easy for application: >>- always use av_frame_get_buffer >>- never modify audio d

Re: [FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : > It fixed the testcase's crash, but didn't fix the bug. So it is not FIXED. > It is easy for application: >- always use av_frame_get_buffer >- never modify audio data pointer. Even easier: never use libavcodec. Kind of defeating

[FFmpeg-devel] Fwd: [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Muhammad Faiz
On Sat, Jul 22, 2017 at 9:14 PM, Nicolas George wrote: > Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : >> The behaviour is based on assumptions: >> - copying audio data is cheap, so keeping data alignment is cheap, >> - copying video data is not cheap, so keeping data alignmen

Re: [FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Nicolas George
Le quartidi 4 thermidor, an CCXXV, Muhammad Faiz a écrit : > The behaviour is based on assumptions: > - copying audio data is cheap, so keeping data alignment is cheap, > - copying video data is not cheap, so keeping data alignment is not cheap, > e.g. crop filter. > > Should fix Tic

[FFmpeg-devel] [PATCH] avutil/frame: document data alignment restriction

2017-07-22 Thread Muhammad Faiz
The behaviour is based on assumptions: - copying audio data is cheap, so keeping data alignment is cheap, - copying video data is not cheap, so keeping data alignment is not cheap, e.g. crop filter. Should fix Ticket6349. Note that after fc3a03fcf9cd7eafe7342e2508e612efa0bb, the

Re: [FFmpeg-devel] [PATCH] avfilter/w3fdif: do not write to line before start line

2017-07-22 Thread Paul B Mahol
On 7/22/17, Muhammad Faiz wrote: > That line has been written by previous job. > Fix tsan warning. > > Signed-off-by: Muhammad Faiz > --- > libavfilter/vf_w3fdif.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/vf_w3fdif.c b/libavfilter/vf_w3fdif.c > ind

[FFmpeg-devel] Testing JPEG 2000 over MPEG TS

2017-07-22 Thread Aaron Boxer
Dear FFmpegers, GStreamer project now has a working muxer/demuxer for J2K over MPEG TS. ​https://bugzilla.gnome.org/show_bug.cgi?id=753323 This code is checked into gstreamer master - not yet released. Sample pipelines are listed in the gstreamer bugzilla ticket. This should allow FFmpeg to te

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: Fix decoding regression due to height check

2017-07-22 Thread Muhammad Faiz
On Fri, Jul 21, 2017 at 4:49 PM, Michael Niedermayer wrote: > From: Vodyannikov Aleksandr > > Fixes: Ticket6546 > > Regression since: 54aaadf648073149f1ac34f56cbde4e6c5aa22ef > > Signed-off-by: Michael Niedermayer > --- > libavcodec/cfhd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH] avfilter/w3fdif: do not write to line before start line

2017-07-22 Thread Muhammad Faiz
That line has been written by previous job. Fix tsan warning. Signed-off-by: Muhammad Faiz --- libavfilter/vf_w3fdif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_w3fdif.c b/libavfilter/vf_w3fdif.c index b7872db341..c6a6550778 100644 --- a/libavfilter/v

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself

2017-07-22 Thread foo86
On Fri, Jul 21, 2017 at 12:22:25PM -0300, James Almer wrote: > Applied. > > Send your public ssh key privately to Michael Niedermayer to get push > rights to the git repo. Key sent, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

[FFmpeg-devel] [PATCH]v5 Opus Pyramid Vector Quantization Search in x86 SIMD asm

2017-07-22 Thread Ivan Kalvachev
This patch is ready for review and inclusion. Explanation of what it does and how it works could be found in the previous WIP threads: [v1] http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212146.html [v2] http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212816.html [v3] http://ffmpeg.org/pipe

Re: [FFmpeg-devel] [PATCH] Add YUV444 32bit floating point pixel format

2017-07-22 Thread Reimar Döffinger
On 21.07.2017, at 20:48, Paul B Mahol wrote: > On 7/21/17, Reimar Doeffinger wrote: >> On 21.07.2017, at 08:48, Paul B Mahol wrote: >> >>> On 7/20/17, Carl Eugen Hoyos wrote: 2017-07-20 17:46 GMT+02:00 Vittorio Giovara : > +[AV_PIX_FMT_YUV444F32LE] = { 0, 0 }, > +[