Re: [FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

2017-07-12 12:32 GMT+08:00 Geek.Song : > In ffmpeg.c: > // > // @ static int process_input_packet(InputStream *ist, const AVPacket > *pkt, int no_eof) > // > if (ret < 0) { > if (decode_failed) { > av_log(NULL, AV_LOG_ERROR, "Error while decoding > stream #%d:%d: %s\n",

[FFmpeg-devel] Question on the “decode_failed” logic in ffmpeg.c:

In ffmpeg.c: // // @ static int process_input_packet(InputStream *ist, const AVPacket *pkt, int no_eof) // if (ret < 0) { if (decode_failed) { av_log(NULL, AV_LOG_ERROR, "Error while decoding stream #%d:%d: %s\n", ist->file_index, ist->st->index,

[FFmpeg-devel] [PATCH] opusenc: use float_dsp for transient mdcts

vector_fmul_reverse requires padding the window at the front Signed-off-by: Rostislav Pehlivanov --- libavcodec/opus_celt.h | 4 ++-- libavcodec/opusenc.c | 8 +++- libavcodec/opustab.c | 8 ++-- libavcodec/opustab.h | 3 +-- 4 files changed, 12 insertions(+), 11 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avcodec/aacps (fixed point): Fix multiple signed integer overflows

On Sun, Jul 09, 2017 at 06:27:58PM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: 1421978265 - -1810326882 > cannot be represented in type 'int' > Fixes: 2527/clusterfuzz-testcase-minimized-5260915396050944 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH] Add prefetch for mips

On Tue, Jul 11, 2017 at 12:18:59PM +0530, kaustubh.ra...@imgtec.com wrote: > From: Kaustubh Raste > > Signed-off-by: Kaustubh Raste > --- > libavcodec/mips/Makefile|1 + > libavcodec/mips/videodsp_mips.c | 42 > +++ > libavcodec/videodsp.c

Re: [FFmpeg-devel] [PATCH] pthread_frame: save the FF_DEBUG_THREADS option in PerThreadContext.

Hi, On Mon, Jul 10, 2017 at 5:51 PM, Ronald S. Bultje wrote: > On Mon, Jul 10, 2017 at 1:24 PM, Wan-Teh Chang < > wtc-at-google@ffmpeg.org> wrote: > >> Add the debug_threads boolean field to PerThreadContext. For >> PerThreadContext *p, p->debug_threads records whether the >> FF_DEBUG_THREAD

[FFmpeg-devel] [PATCH 1/3] avutil: merge slice threading implementation from avcodec and avfilter

Rework it to improve performance. Now mutex is not shared by workers, instead each worker has its own mutex and condition variable. This reduces lock contention between workers. Also use atomic variable for counter. The interface also allows execute to run special function on main thread, requeste

[FFmpeg-devel] [PATCH 3/3] avfilter/pthread: use slice threading from avutil

Benchmark (with 2 cpus): ./ffmpeg -f rawvideo -s 1280x720 -t 1000 -i /dev/zero \ -filter_threads $threads -vf transpose=clock -f null null threads=2: old: 31.129s 31.446s 31.574s new: 29.602s 29.636s 29.656s threads=3 (nb_threads = nb_cpus + 1 is bad choice at this situation): old: 40.132

[FFmpeg-devel] [PATCH 2/3] avcodec/pthread_slice: use slice threading from avutil

Also remove pthread_cond_broadcast(progress_cond) on uninit. Broadcasting it is not required because workers are always parked when they are not in thread_execute. So it is imposible that a worker is waiting on progress_cond when uninitialized. Benchmark: ./ffmpeg -threads $threads -thread_type sl

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

Hi Wan-Teh, On Tue, Jul 11, 2017 at 6:30 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the quick reply. > > On Tue, Jul 11, 2017 at 2:09 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Tue, Jul 11, 2017 at 4:53 PM, Wan-Teh Chang wrote: > >> > >> Hi Ronald, > >> > >> I have a

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

If I need to write a new atom under stsd for my stream in the mov muxer (mov_write_stsd_tag), is it appropriate to indicate that through the AVStream metadata rather than the codec_tag? On Mon, Jul 10, 2017 at 1:48 AM, wm4 wrote:

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On Tue, Jul 11, 2017 at 04:50:25PM +0100, Derek Buitenhuis wrote: > On 7/10/2017 11:04 PM, Kieran O Leary wrote: > > A user mentioned in ffmpeg-user ( > > http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036571.html) that they > > couldn't write the 'keywords' metadata tag. I tested this patch an

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

Hi Ronald, Thank you for the quick reply. On Tue, Jul 11, 2017 at 2:09 PM, Ronald S. Bultje wrote: > Hi Wan-Teh, > > On Tue, Jul 11, 2017 at 4:53 PM, Wan-Teh Chang wrote: >> >> Hi Ronald, >> >> I have a question about this patch. >> >> On Mon, Apr 3, 2017 at 7:24 AM, Ronald S. Bultje >> wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

On Sun, Jul 09, 2017 at 02:28:28PM +0200, Clément Bœsch wrote: > On Sat, Jul 08, 2017 at 11:07:48PM +0200, Michael Niedermayer wrote: > [...] > > 5 days passed with no comments and no suggestions on how to implement > > this better. > > does anyone object to the fix as in the patch to be applied ?

[FFmpeg-devel] [PATCH] fate: add sub-srt-badsyntax test

Based-on: srt sample by ubitux Signed-off-by: Michael Niedermayer --- tests/fate/subtitles.mak | 3 +++ tests/ref/fate/sub-srt-badsyntax | 22 ++ 2 files changed, 25 insertions(+) create mode 100644 tests/ref/fate/sub-srt-badsyntax diff --git a/tests/fate/subtitles

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

Hi Wan-Teh, On Tue, Jul 11, 2017 at 4:53 PM, Wan-Teh Chang wrote: > Hi Ronald, > > I have a question about this patch. > > On Mon, Apr 3, 2017 at 7:24 AM, Ronald S. Bultje > wrote: > > This tries to handle cases where separate invocations of decode_frame() > > (each running in separate threads)

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config for libgme, if available

On 6 July 2017 at 23:16, Ricardo Constantino wrote: > On 23 June 2017 at 17:08, wm4 wrote: >> On Fri, 23 Jun 2017 01:53:37 +0100 >> Ricardo Constantino wrote: >> >>> The pkg-config file is relatively new (2013), so some distros might >>> not have it yet. And the -lstdc++ being required for the s

Re: [FFmpeg-devel] [PATCH] pthread_frame: allow per-field ThreadFrame owners.

Hi Ronald, I have a question about this patch. On Mon, Apr 3, 2017 at 7:24 AM, Ronald S. Bultje wrote: > This tries to handle cases where separate invocations of decode_frame() > (each running in separate threads) write to respective fields in the > same AVFrame->data[]. Having per-field owners

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()

On Sun, Jul 02, 2017 at 01:33:16PM +0200, Michael Niedermayer wrote: > On Sun, Jul 02, 2017 at 01:14:31PM +0200, wm4 wrote: > > On Sun, 2 Jul 2017 04:28:54 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: runtime error: signed integer overflow: -2147483648 - 1202286525 > > > cannot be repr

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

On 7/11/17, Nicolas George wrote: > Le tridi 23 messidor, an CCXXV, Paul B Mahol a ecrit : >> Nothing can get rid of that issue, except tootal lavfi rewrite. > > Why do you say that? My plan gets rid of them quite easily, since now > all links have a dynamically-sized FIFO built-in. > >> I tried t

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

Le tridi 23 messidor, an CCXXV, Paul B Mahol a écrit : > Nothing can get rid of that issue, except tootal lavfi rewrite. Why do you say that? My plan gets rid of them quite easily, since now all links have a dynamically-sized FIFO built-in. > I tried this and it did not work at all. And I even co

[FFmpeg-devel] [PATCH 1/3] avcodec/get_bits: add cached bitstream reader

Signed-off-by: Paul B Mahol --- libavcodec/get_bits.h | 263 +- 1 file changed, 237 insertions(+), 26 deletions(-) diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h index c530015..dbacdda 100644 --- a/libavcodec/get_bits.h +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

On 7/11/17, Nicolas George wrote: > Le primidi 21 messidor, an CCXXV, Marton Balint a ecrit : >> I am not saying they aren't, I'm just showing a case where your revert is >> breaking another case which was working before. Nicolas also stated there >> can be cases where the old code (before the rev

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On 7/10/2017 11:04 PM, Kieran O Leary wrote: > A user mentioned in ffmpeg-user ( > http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036571.html) that they > couldn't write the 'keywords' metadata tag. I tested this patch and it > appears to add the metadata value when using MOV and MP4 as output.

Re: [FFmpeg-devel] [PATCH] lavfi/buffersrc: push the frame deeper if requested.

Le primidi 21 messidor, an CCXXV, Marton Balint a écrit : > I am not saying they aren't, I'm just showing a case where your revert is > breaking another case which was working before. Nicolas also stated there > can be cases where the old code (before the revert) worked better. I just > hope that I

Re: [FFmpeg-devel] [PATCH] web/template_head2: Add net neutrality script

On Tue, Jul 11, 2017 at 07:54:14AM -0400, Ronald S. Bultje wrote: > Hi, > > On Tue, Jul 11, 2017 at 6:45 AM, Michael Niedermayer > wrote: > > > On Mon, Jul 10, 2017 at 01:11:52AM +0200, Michael Niedermayer wrote: > > > See: https://www.battleforthenet.com/july12/ > > > > > > Signed-off-by: Micha

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

On Tue, Jul 11, 2017 at 3:41 PM, Nicolas George wrote: > Le decadi 20 messidor, an CCXXV, Reimar Döffinger a écrit : > > I don't think that's a correct description then. > > First, the format is made to change and be extended, so what is > > true now might not stay true. > > But also the images c

Re: [FFmpeg-devel] [PATCH v2] avfilter/pthread: rewrite implementation

On Tue, Jul 11, 2017 at 1:24 PM, Clément Bœsch wrote: > On Tue, Jul 11, 2017 at 11:18:42AM +0700, Muhammad Faiz wrote: > [...] >> My plan is to merge implementation of slice threading in avutil. >> > > As a public API? With the .c include "trick"? avpriv_? I don't know what's > the current consens

Re: [FFmpeg-devel] [PATCH] web/template_head2: Add net neutrality script

Hi, On Tue, Jul 11, 2017 at 6:45 AM, Michael Niedermayer wrote: > On Mon, Jul 10, 2017 at 01:11:52AM +0200, Michael Niedermayer wrote: > > See: https://www.battleforthenet.com/july12/ > > > > Signed-off-by: Michael Niedermayer > > --- > > src/template_head2 | 1 + > > 1 file changed, 1 inserti

Re: [FFmpeg-devel] [PATCH] web/template_head2: Add net neutrality script

On Mon, Jul 10, 2017 at 01:11:52AM +0200, Michael Niedermayer wrote: > See: https://www.battleforthenet.com/july12/ > > Signed-off-by: Michael Niedermayer > --- > src/template_head2 | 1 + > 1 file changed, 1 insertion(+) applied, this script should automatically activate on the 12th and deacti

Re: [FFmpeg-devel] [PATCH] Add FITS Demuxer

Le decadi 20 messidor, an CCXXV, Reimar Döffinger a écrit : > I don't think that's a correct description then. > First, the format is made to change and be extended, so what is > true now might not stay true. > But also the images can have arbitrary dimensions, in particular > they can be "3D" imag

Re: [FFmpeg-devel] [PATCH v2] avfilter/pthread: rewrite implementation

Le tridi 23 messidor, an CCXXV, Clement Boesch a écrit : > As a public API? With the .c include "trick"? avpriv_? I don't know what's > the current consensus, but people never seem to agree about the path to > take in that regard. You'll also get the discussion about merging all the > libs into one

Re: [FFmpeg-devel] [PATCH v2] avfilter/pthread: rewrite implementation

On Tue, 11 Jul 2017, wm4 wrote: On Mon, 10 Jul 2017 23:40:10 +0200 Michael Niedermayer wrote: On Mon, Jul 10, 2017 at 10:53:42AM +0200, wm4 wrote: > On Sat, 8 Jul 2017 01:45:06 +0200 > Michael Niedermayer wrote: > > > On Fri, Jul 07, 2017 at 09:04:37PM +0700, Muhammad Faiz wrote: > > > Av

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/aacpsdsp_template: Fixes integer overflow in ps_add_squares_c()

On Mon, 10 Jul 2017 23:10:35 +0200 Michael Niedermayer wrote: > On Mon, Jul 10, 2017 at 10:37:46AM +0200, wm4 wrote: > > On Sun, 9 Jul 2017 22:03:21 +0200 > > Reimar Döffinger wrote: > > > > > On 09.07.2017, at 16:08, "Ronald S. Bultje" wrote: > > > > Hi, > > > > > > > > On Sun, Jul 9, 20

Re: [FFmpeg-devel] [PATCH v2] avfilter/pthread: rewrite implementation

On Mon, 10 Jul 2017 23:40:10 +0200 Michael Niedermayer wrote: > On Mon, Jul 10, 2017 at 10:53:42AM +0200, wm4 wrote: > > On Sat, 8 Jul 2017 01:45:06 +0200 > > Michael Niedermayer wrote: > > > > > On Fri, Jul 07, 2017 at 09:04:37PM +0700, Muhammad Faiz wrote: > > > > Avoid pthread_cond_broad

Re: [FFmpeg-devel] [PATCH V2] examples/vaapi_dec: Add a VA-API hwaccel decoding example

On Tue, 11 Jul 2017 12:06:10 +0800 Jun Zhao wrote: > From 0e4d230ae4c98949a962c6bbdad31d216b54bb6a Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 21 Mar 2017 11:04:41 +0800 > Subject: [V2] examples/vaapi_dec: Add a VA-API hwaccel decoding example. > > Add a VA-API hwaccel decoding examp