[FFmpeg-devel] Requesting push access to FFmpeg repo

2017-06-19 Thread Kevin Mark
Ronald Bultje via IRC recommended I ask on the mailing list for push access to the FFmpeg repository so that I may push my own patches once approved. If someone with the access to do so could please consider this request it would be greatly appreciated. Thank you, Kevin ___

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-19 Thread Kieran Kunhya
On Tue, 20 Jun 2017, 00:38 Michael Niedermayer, wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c > index 63a30b93ce..e29558b3a2 100644 > --- a/libav

[FFmpeg-devel] [PATCH v2 3/5] Interplay MVE: Implement frame format 0x06

2017-06-19 Thread Hein-Pieter van Braam
This implements the 0x06 frame format for Interplay MVE movies. The format is relatively simple. The video data consists of two parts: 16 bits per 8x8 block movement data a number of 8x8 blocks of pixel data For each 8x8 block of pixel data the movement data is consulted. There are 3 possible mea

[FFmpeg-devel] [PATCH v2 4/5] Interplay MVE: Implement frame format 0x10

2017-06-19 Thread Hein-Pieter van Braam
This implements the 0x10 frame format for Interplay MVE movies. The format is a variation on the 0x06 format with some changes. In addition to the decoding map there's also a skip map. This skip map is used to determine what 8x8 blocks can change in a particular frame. This format expects to be ab

[FFmpeg-devel] [PATCH v2 5/5] Interplay MVE: Changelog entry for changes

2017-06-19 Thread Hein-Pieter van Braam
Signed-off-by: Hein-Pieter van Braam --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index a893efa..bb02a62 100644 --- a/Changelog +++ b/Changelog @@ -22,6 +22,7 @@ version : - headphone audio filter - superequalizer audio filter - roberts video filter +

[FFmpeg-devel] [PATCH v2 2/5] Interplay MVE: Refactor IP packet format

2017-06-19 Thread Hein-Pieter van Braam
Interplay MVE can contain up to three different frame formats. They require different streams of information to render a frame. This patch changes the IP packet format to prepare for the extra frame formats. Signed-off-by: Hein-Pieter van Braam --- libavcodec/interplayvideo.c | 33 ++

[FFmpeg-devel] [PATCH v2 1/5] Interplay MVE: Implement MVE SEND_BUFFER operation

2017-06-19 Thread Hein-Pieter van Braam
Interplay MVE movies have a SEND_BUFFER operation. Only after this command does the current decoding buffer get displayed. This is required for the other frame formats. They are fixed-size and can't always encode a full frame worth of pixeldata. This code prevents half-finished frames from being e

[FFmpeg-devel] [PATCH v2 0/5] Interplay MVE: Implement additional frame formats

2017-06-19 Thread Hein-Pieter van Braam
Changes since V1: * Implemented fixes suggested by Moritz Barsnick (if/else whitespace) * Strict checking on overread of the IP packet data * Fixed checking the size of the IP packet header size (6 vs 8) This patch series implement the previously unknown opcodes 0x06, 0x0E, and 0x010 for Interp

[FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: Use intra_scantable in dct_unquantize_h263_intra_c()

2017-06-19 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 63a30b93ce..e29558b3a2 100644 --- a/libavcodec/mpegvideo.c +++ b/libavcodec/mpegvideo.c @@ -225,7 +225,7 @@ stati

[FFmpeg-devel] [PATCH 2/2] avcodec/mpegvideo_enc: Use intra/inter scantable matching mb type in quantization

2017-06-19 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/mpegvideo_enc.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index fffb113096..97257ce98c 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/mpegenc: do not use unquantize shortcuts for wmv1

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 05:10:58PM +0200, James Darnley wrote: > From: "Ronald S. Bultje" > > Commit message by James Darnley > > The shortcut is based on end-of-block positions. This leads to some > coefficients not being unquantized. This is the symptom of the bug. > > A possible candidate

Re: [FFmpeg-devel] [PATCH 1/4] ffmpeg: Flush output BSFs when encode reaches EOF

2017-06-19 Thread Mark Thompson
On 19/06/17 16:32, Michael Niedermayer wrote: > On Sun, Jun 18, 2017 at 11:09:23PM +0100, Mark Thompson wrote: >> Before this, output bitstream filters would never see EOF and >> therefore would not be able to flush any delayed packets. >> >> (cherry picked from commit f64d1100a54d12c78ce436181bb64

Re: [FFmpeg-devel] [PATCH 3/4] avformat: make flush_packets a tri-state and set it to -1 (auto) by default

2017-06-19 Thread Marton Balint
On Mon, 19 Jun 2017, Michael Niedermayer wrote: On Mon, Jun 19, 2017 at 12:02:53AM +0200, Marton Balint wrote: If flushing is not disabled, then mux.c will signal the end of the packets with an AVIO_DATA_MARKER_FLUSH_POINT, and aviobuf will be able to decide to flush or not based on the prefe

[FFmpeg-devel] [PATCH] libavformat/mov.c: use calculated dts offset when seeking in streams

2017-06-19 Thread Jonas Licht
Subtract the calculated dts offset from the requested timestamp before seeking. This fixes an error "Error while filtering: Operation not permitted" observed with a short file which contains only one key frame and starts with negative timestamps. Then, av_index_search_timestamp() returns a valid n

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf: don't treat 0 as EOF

2017-06-19 Thread Hendrik Leppkes
On Mon, Jun 19, 2017 at 9:30 PM, Daniel Kučera wrote: > 2017-06-19 16:34 GMT+02:00 Michael Niedermayer : >> On Mon, Jun 19, 2017 at 11:15:27AM -0300, James Almer wrote: >>> On 6/19/2017 11:09 AM, Michael Niedermayer wrote: >>> > On Sun, Jun 18, 2017 at 09:14:21PM +0200, Daniel Kucera wrote: >>> >>

Re: [FFmpeg-devel] [PATCH 2/4] avformat/aviobuf: add support for specifying minimum packet size and marking flush points

2017-06-19 Thread Marton Balint
On Mon, 19 Jun 2017, Michael Niedermayer wrote: On Mon, Jun 19, 2017 at 12:02:52AM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/avio.h| 13 - libavformat/aviobuf.c | 7 +++ libavformat/url.h | 1 + libavformat/version.h | 2 +- 4 files

[FFmpeg-devel] [PATCH] libavformat/avio: retry_transfer_wrapper: don't treat 0 as EOF

2017-06-19 Thread Daniel Kucera
transfer_func variable passed to retry_transfer_wrapper are h->prot->url_read and h->prot->url_write functions. These need to return EOF or other error properly. In case of returning >= 0, url_read/url_write is retried until error is returned. requires patch: libavformat/cache: don't treat 0 as E

Re: [FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 05:11:03PM +0200, James Darnley wrote: > Includes add/put functions > > Rounding contributed by Ronald S. Bultje > --- > libavcodec/tests/x86/dct.c| 2 + > libavcodec/x86/idctdsp_init.c | 23 > libavcodec/x86/simple_idct.h

Re: [FFmpeg-devel] AV_LOG_DEBUG Fixes Problem?

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 04:58:44PM +, Rod Delay wrote: > I have inherited a C++ project that uses FFMpeg to capture audio and video > from JitsiMeet, what we have found is after about 10 minutes it stops writing > to the output file. It's random anywhere from 5 to 10 minutes. > > I was able

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 02:44:47PM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Jun 16, 2017 at 12:46 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > > > On Thu, Jun 15, 2017 at 03:50:31PM -0400, Ronald S. Bultje wrote: > > > From: Anton Mitrofanov > > > > > > Use the correct ct

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf: don't treat 0 as EOF

2017-06-19 Thread Daniel Kučera
2017-06-19 16:34 GMT+02:00 Michael Niedermayer : > On Mon, Jun 19, 2017 at 11:15:27AM -0300, James Almer wrote: >> On 6/19/2017 11:09 AM, Michael Niedermayer wrote: >> > On Sun, Jun 18, 2017 at 09:14:21PM +0200, Daniel Kucera wrote: >> >> Signed-off-by: Daniel Kucera >> >> --- >> >> libavformat/a

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/h264_cabac: Fix CABAC+8x8dct in 4:4:4

2017-06-19 Thread Ronald S. Bultje
Hi, On Fri, Jun 16, 2017 at 12:46 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Jun 15, 2017 at 03:50:31PM -0400, Ronald S. Bultje wrote: > > From: Anton Mitrofanov > > > > Use the correct ctxIdxInc calculation for coded_block_flag. > > Keep old behavior for old versions of

Re: [FFmpeg-devel] [PATCH 07/11] avcodec/x86: modify simple_idct10 macros to add an action paramter

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:11 AM, James Darnley wrote: > --- > libavcodec/x86/proresdsp.asm | 2 +- > libavcodec/x86/simple_idct10.asm | 8 +++ > libavcodec/x86/simple_idct10_template.asm | 37 > +-- > 3 files changed, 25 insertions(+)

Re: [FFmpeg-devel] [PATCH 06/11] avcodec/x86: cleanup simple_idct10

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > Use named arguments for the functions so we can remove a define. The > stride/linesize argument is now ptrdiff_t type so we no longer need to > sign extend the register. > --- > libavcodec/x86/proresdsp.asm | 2 +- > li

Re: [FFmpeg-devel] [PATCH] libavfilter/scale: Populate ow/oh when using 0 as w/h

2017-06-19 Thread Ronald S. Bultje
Hi, On Wed, Jun 14, 2017 at 1:03 AM, Kevin Mark wrote: > The input width and height is known at parse time so there's no > reason ow/oh should not be usable when using 0 as the width or > height expression. > > Previously in "scale=0:ow" ow would be set to "0" which works, > conveniently, as "sc

Re: [FFmpeg-devel] [PATCH] doc/filters: Correct scale doc regarding w/h <= 0

2017-06-19 Thread Ronald S. Bultje
Hi, On Tue, Jun 13, 2017 at 7:42 AM, Moritz Barsnick wrote: > On Mon, Jun 12, 2017 at 01:59:05 -0400, Kevin Mark wrote: > > Signed-off-by: Kevin Mark > > --- > > doc/filters.texi | 39 --- > > 1 file changed, 20 insertions(+), 19 deletions(-) > > Yes, this t

Re: [FFmpeg-devel] [PATCH 04/11] avcodec/mdec: allow/use permuted IDCTs

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 12:39 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Jun 19, 2017 at 05:10:57PM +0200, James Darnley wrote: > > From: "Ronald S. Bultje" > > > > --- > > libavcodec/mdec.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/mdec: override IDCT choice before initing DSP structs

2017-06-19 Thread Ronald S. Bultje
Hi, On Mon, Jun 19, 2017 at 11:10 AM, James Darnley wrote: > --- > libavcodec/mdec.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c > index 8e28aa04f0..97bfebbeb7 100644 > --- a/libavcodec/mdec.c > +++ b/libavcodec/mdec.c > @@

[FFmpeg-devel] AV_LOG_DEBUG Fixes Problem?

2017-06-19 Thread Rod Delay
I have inherited a C++ project that uses FFMpeg to capture audio and video from JitsiMeet, what we have found is after about 10 minutes it stops writing to the output file. It's random anywhere from 5 to 10 minutes. I was able to narrow down to a problem with the following line: avcodec_encode

Re: [FFmpeg-devel] [PATCH 04/11] avcodec/mdec: allow/use permuted IDCTs

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 05:10:57PM +0200, James Darnley wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/mdec.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c > index 97bfebbeb7..1e1c8f4c55 100644 > --- a/libavcodec/mde

Re: [FFmpeg-devel] [PATCH 02/11] avcodec/x86/mpegenc: support transpose permuation type

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 05:10:55PM +0200, James Darnley wrote: > --- > libavcodec/x86/mpegvideoenc_template.c | 47 > +- > 1 file changed, 46 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

[FFmpeg-devel] [PATCH] Add FITS Decoder

2017-06-19 Thread Paras Chadha
Added support for XTENSION keyword Signed-off-by: Paras Chadha --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 8 + libavcodec/fitsdec.c| 518 +

[FFmpeg-devel] [PATCH] Add FITS Demuxer

2017-06-19 Thread Paras Chadha
Signed-off-by: Paras Chadha --- Changelog| 2 +- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/fitsdec.c| 207 +++ libavformat/version.h| 2 +- 5 files changed, 211 insertions(+), 2 deletions

Re: [FFmpeg-devel] [PATCH 1/4] ffmpeg: Flush output BSFs when encode reaches EOF

2017-06-19 Thread Michael Niedermayer
On Sun, Jun 18, 2017 at 11:09:23PM +0100, Mark Thompson wrote: > Before this, output bitstream filters would never see EOF and > therefore would not be able to flush any delayed packets. > > (cherry picked from commit f64d1100a54d12c78ce436181bb64229c56da6b3) > --- > ffmpeg.c | 30 +++

[FFmpeg-devel] [PATCH 11/11] avcodec/x86: use new x86-64 functions for -idct simple

2017-06-19 Thread James Darnley
They now match according to FATE, barring any further bugs with untested parts --- libavcodec/x86/idctdsp_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/idctdsp_init.c b/libavcodec/x86/idctdsp_init.c index 9da60d1a1e..162560d411 100644 --- a/libavco

[FFmpeg-devel] [PATCH 04/11] avcodec/mdec: allow/use permuted IDCTs

2017-06-19 Thread James Darnley
From: "Ronald S. Bultje" --- libavcodec/mdec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c index 97bfebbeb7..1e1c8f4c55 100644 --- a/libavcodec/mdec.c +++ b/libavcodec/mdec.c @@ -94,7 +94,7 @@ static inline int mdec_decode_block

[FFmpeg-devel] [PATCH 05/11] avcodec/mpegenc: do not use unquantize shortcuts for wmv1

2017-06-19 Thread James Darnley
From: "Ronald S. Bultje" Commit message by James Darnley The shortcut is based on end-of-block positions. This leads to some coefficients not being unquantized. This is the symptom of the bug. A possible candidate for the real bug is the scan table used here in unquantize does not appear to m

[FFmpeg-devel] [PATCH 07/11] avcodec/x86: modify simple_idct10 macros to add an action paramter

2017-06-19 Thread James Darnley
--- libavcodec/x86/proresdsp.asm | 2 +- libavcodec/x86/simple_idct10.asm | 8 +++ libavcodec/x86/simple_idct10_template.asm | 37 +-- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/libavcodec/x86/proresdsp.asm b/libavcodec/

Re: [FFmpeg-devel] [PATCH 4/4] avformat/file: increase min/max packet size to 256k for written files

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 12:02:54AM +0200, Marton Balint wrote: > Buffering more than one packet can be a huge performance improvement for > encoding files with small packets (e.g. wav) over SMB/CIFS. > > Signed-off-by: Marton Balint > --- > libavformat/file.c | 5 + > 1 file changed, 5 inser

[FFmpeg-devel] [PATCH 10/11] avcodec/x86: add an 8-bit simple IDCT function based on the x86-64 high depth functions

2017-06-19 Thread James Darnley
Includes add/put functions Rounding contributed by Ronald S. Bultje --- libavcodec/tests/x86/dct.c| 2 + libavcodec/x86/idctdsp_init.c | 23 libavcodec/x86/simple_idct.h | 9 +++ libavcodec/x86/simple_idct10.asm | 92 +++

[FFmpeg-devel] [PATCH 06/11] avcodec/x86: cleanup simple_idct10

2017-06-19 Thread James Darnley
Use named arguments for the functions so we can remove a define. The stride/linesize argument is now ptrdiff_t type so we no longer need to sign extend the register. --- libavcodec/x86/proresdsp.asm | 2 +- libavcodec/x86/simple_idct10.asm | 8 ++-- libavcodec/x86/simple_i

[FFmpeg-devel] [PATCH 09/11] avcodec/x86: allow future 8-bit simple idct to have "DC only hack"

2017-06-19 Thread James Darnley
Created by Ronald S. Bultje --- libavcodec/x86/simple_idct10_template.asm | 38 +++ 1 file changed, 38 insertions(+) diff --git a/libavcodec/x86/simple_idct10_template.asm b/libavcodec/x86/simple_idct10_template.asm index d8ea0bcc6b..51baf84c82 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 08/11] avcodec/x86: allow future 8-bit simple idct to use slightly different coefficients

2017-06-19 Thread James Darnley
--- libavcodec/x86/proresdsp.asm | 18 ++ libavcodec/x86/simple_idct10.asm | 29 + libavcodec/x86/simple_idct10_template.asm | 19 +++ 3 files changed, 50 insertions(+), 16 deletions(-) diff --git a/libavcodec/x86/p

Re: [FFmpeg-devel] [PATCH 3/4] avformat: make flush_packets a tri-state and set it to -1 (auto) by default

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 12:02:53AM +0200, Marton Balint wrote: > If flushing is not disabled, then mux.c will signal the end of the packets > with > an AVIO_DATA_MARKER_FLUSH_POINT, and aviobuf will be able to decide to flush > or > not based on the preferred minimum packet size set by the used p

[FFmpeg-devel] [PATCH 03/11] avcodec/mdec: override IDCT choice before initing DSP structs

2017-06-19 Thread James Darnley
--- libavcodec/mdec.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/mdec.c b/libavcodec/mdec.c index 8e28aa04f0..97bfebbeb7 100644 --- a/libavcodec/mdec.c +++ b/libavcodec/mdec.c @@ -213,6 +213,9 @@ static av_cold int decode_init(AVCodecContext *avctx) {

[FFmpeg-devel] [PATCH 02/11] avcodec/x86/mpegenc: support transpose permuation type

2017-06-19 Thread James Darnley
--- libavcodec/x86/mpegvideoenc_template.c | 47 +- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/mpegvideoenc_template.c b/libavcodec/x86/mpegvideoenc_template.c index 3ce72e1367..1201be514b 100644 --- a/libavcodec/x86/mpegvideoenc_t

[FFmpeg-devel] [PATCH 01/11] avcodec/x86/mpegenc: check IDCT permutation type is a valid value

2017-06-19 Thread James Darnley
--- libavcodec/x86/mpegvideoenc_template.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/mpegvideoenc_template.c b/libavcodec/x86/mpegvideoenc_template.c index b2512744ca..3ce72e1367 100644 --- a/libavcodec/x86/mpegvideoenc_template.c +++ b/libavcodec/x

[FFmpeg-devel] [PATCH 00/11] [v3] sse2/avx functions for 8-bit simple idct

2017-06-19 Thread James Darnley
After a few days of hard work, mostly on Ronald's part, and with helpful contibutions from Michael I think we have arrived at the end of this long saga. There has been no significant change in my additions from the last time it was posted. I removed the couple of TODOs that were long since outdat

Re: [FFmpeg-devel] [PATCH 2/4] avformat/aviobuf: add support for specifying minimum packet size and marking flush points

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 12:02:52AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/avio.h| 13 - > libavformat/aviobuf.c | 7 +++ > libavformat/url.h | 1 + > libavformat/version.h | 2 +- > 4 files changed, 21 insertions(+), 2 deletions(-

Re: [FFmpeg-devel] [PATCH 1/4] avformat/aviobuf: fix flushing write buffers after seeking backward or forward

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 12:02:51AM +0200, Marton Balint wrote: > This patch makes aviobuf work more like traditinal file IO, which is how > people > think about it. > > For example, in the past, aviobuf only flushed buffers until the current > buffer > position, even if more data was written to

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf: don't treat 0 as EOF

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 11:15:27AM -0300, James Almer wrote: > On 6/19/2017 11:09 AM, Michael Niedermayer wrote: > > On Sun, Jun 18, 2017 at 09:14:21PM +0200, Daniel Kucera wrote: > >> Signed-off-by: Daniel Kucera > >> --- > >> libavformat/aviobuf.c | 20 > >> 1 file changed,

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf: don't treat 0 as EOF

2017-06-19 Thread James Almer
On 6/19/2017 11:09 AM, Michael Niedermayer wrote: > On Sun, Jun 18, 2017 at 09:14:21PM +0200, Daniel Kucera wrote: >> Signed-off-by: Daniel Kucera >> --- >> libavformat/aviobuf.c | 20 >> 1 file changed, 12 insertions(+), 8 deletions(-) > > This causes fate-swr-resample-s32p

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf: don't treat 0 as EOF

2017-06-19 Thread Michael Niedermayer
On Sun, Jun 18, 2017 at 09:14:21PM +0200, Daniel Kucera wrote: > Signed-off-by: Daniel Kucera > --- > libavformat/aviobuf.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) This causes fate-swr-resample-s32p-2626-44100 to infinite loop [...] -- Michael GnuPG fi

Re: [FFmpeg-devel] [PATCH] avcodec: Rename ff_mpv_decode_mb() to ff_mpv_reconstruct_mb

2017-06-19 Thread Michael Niedermayer
On Mon, Jun 19, 2017 at 08:48:09AM -0400, Ronald S. Bultje wrote: > Hi, > > On Sun, Jun 18, 2017 at 9:46 PM, Michael Niedermayer > wrote: > > > The new name more accuratly describes what the function does > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h| 2 +

Re: [FFmpeg-devel] [PATCH] avcodec: Rename ff_mpv_decode_mb() to ff_mpv_reconstruct_mb

2017-06-19 Thread Ronald S. Bultje
Hi, On Sun, Jun 18, 2017 at 9:46 PM, Michael Niedermayer wrote: > The new name more accuratly describes what the function does > > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h| 2 +- > libavcodec/h261dec.c| 4 ++-- > libavcodec/h263dec.c| 4 ++-- >

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-19 Thread Moritz Barsnick
On Mon, Jun 19, 2017 at 14:32:38 +0200, Hein-Pieter van Braam wrote: > > > +if (! opcode) { > > > > Style: You should drop the space. > > You mean the space between the ! and opcode? The space between if and > opening parenthesis should stay, right? Correct. The handling of paranthes

Re: [FFmpeg-devel] [PATCH] avfilter: add superequalizer filter

2017-06-19 Thread Moritz Barsnick
On Sat, Jun 17, 2017 at 18:00:01 +0200, Paul B Mahol wrote: > + * This file is part of FFmpeg. > + * No copyright at all? (Not that I know better or care.) > +static float alpha(float a) > +{ > +if (a <= 21) > +return 0; > +if (a <= 50) > +return .5842 * pow(a - 21,0.4) +

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-19 Thread Hein-Pieter van Braam
I've resubmitted the patch in a more reviewable format here: http://ffmpeg.org/pipermail/ffmpeg-devel/2017-June/212532.html having said that: On Mon, 2017-06-19 at 14:22 +0200, Moritz Barsnick wrote: > On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote: > > +s->pixel_

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-19 Thread Moritz Barsnick
On Sat, Jun 17, 2017 at 19:13:52 +0200, Hein-Pieter van Braam wrote: > +s->pixel_ptr = frame->data[0] + x + y*frame->linesize[0]; Style: You might want to add spaces around '*'. > +if (! opcode) { Style: You should drop the space. > +if (opcode < 0) { > +

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-19 Thread Tobias Rapp
On 19.06.2017 10:28, wm4 wrote: On Mon, 19 Jun 2017 09:38:19 +0200 Tobias Rapp wrote: On 19.06.2017 02:04, 21na...@gmail.com wrote: Le 18/06/2017 à 00:57, Sasi Inguva a écrit : Hi, I was the one who made that change. We needed a way to obtain individual stream durations from a Matroska fil

[FFmpeg-devel] [PATCH] checkasm/aarch64: fix tests returning a float

2017-06-19 Thread Matthieu Bouron
Avoids overriding v0 (which containins the result of the tested function) in checkasm_call_checked. Also properly calls checkasm_call_checked. --- tests/checkasm/aarch64/checkasm.S | 8 tests/checkasm/checkasm.h | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Set default output format for cuvid hwaccel

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 16:27:30 -0700 Philip Langdale wrote: > The cuvid hwaccel is weird because it's not a real hwaccel. This > means that requesting the hwaccel by itself does nothing as the > right decoder and encoder have to be request to take advantage of > it. > > On the other hand, requesti

Re: [FFmpeg-devel] hev1 vs. hvc1

2017-06-19 Thread Eran Kornblau
> > > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > liyoubdu > Sent: Monday, June 19, 2017 11:20 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] hev1 vs. hvc1 > > >> > i think mov is mp4

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-19 Thread wm4
On Mon, 19 Jun 2017 09:38:19 +0200 Tobias Rapp wrote: > On 19.06.2017 02:04, 21na...@gmail.com wrote: > > Le 18/06/2017 à 00:57, Sasi Inguva a écrit : > >> Hi, > >> > >> I was the one who made that change. We needed a way to obtain individual > >> stream durations from a Matroska file without

Re: [FFmpeg-devel] hev1 vs. hvc1

2017-06-19 Thread liyoubdu
-- Original -- From: "wm4";; Send time: Monday, Jun 19, 2017 4:11 PM To: "ffmpeg-devel"; Subject: Re: [FFmpeg-devel] hev1 vs. hvc1 On Sun, 18 Jun 2017 13:32:42 + Eran Kornblau wrote: > Hi all, > > We're trying to make ffmpeg output a format tag of 'hvc1

Re: [FFmpeg-devel] [PATCH 1/4] ffmpeg: Flush output BSFs when encode reaches EOF

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 23:09:23 +0100 Mark Thompson wrote: > Before this, output bitstream filters would never see EOF and > therefore would not be able to flush any delayed packets. > > (cherry picked from commit f64d1100a54d12c78ce436181bb64229c56da6b3) > --- > ffmpeg.c | 30 +++-

Re: [FFmpeg-devel] hev1 vs. hvc1

2017-06-19 Thread wm4
On Sun, 18 Jun 2017 13:32:42 + Eran Kornblau wrote: > Hi all, > > We're trying to make ffmpeg output a format tag of 'hvc1' for HEVC, since it > seems that only hvc1 works in iOS 11 beta. > We saw that '-tag:v hvc1' does the trick, but it only works in 'mov' format, > and not in 'mp4' form

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-19 Thread Tobias Rapp
On 19.06.2017 02:04, 21na...@gmail.com wrote: Le 18/06/2017 à 00:57, Sasi Inguva a écrit : Hi, I was the one who made that change. We needed a way to obtain individual stream durations from a Matroska file without reading the entire file. I don't think it adds to the file size greatly (< 50 by