[FFmpeg-devel] [PATCH 4/5] Interplay MVE: Implement frame format 0x10

2017-06-17 Thread Hein-Pieter van Braam
This implements the 0x10 frame format for Interplay MVE movies. The format is a variation on the 0x06 format with some changes. In addition to the decoding map there's also a skip map. This skip map is used to determine what 8x8 blocks can change in a particular frame. This format expects to be ab

[FFmpeg-devel] [PATCH 5/5] Interplay MVE: Changelog entry for changes

2017-06-17 Thread Hein-Pieter van Braam
Signed-off-by: Hein-Pieter van Braam --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index cd91f63..c05b6ef 100644 --- a/Changelog +++ b/Changelog @@ -20,6 +20,7 @@ version : - sofalizer filter switched to libmysofa - Gremlin Digital Video demuxer and dec

[FFmpeg-devel] [PATCH 3/5] Interplay MVE: Implement frame format 0x06

2017-06-17 Thread Hein-Pieter van Braam
This implements the 0x06 frame format for Interplay MVE movies. The format is relatively simple. The video data consists of two parts: 16 bits per 8x8 block movement data a number of 8x8 blocks of pixel data For each 8x8 block of pixel data the movement data is consulted. There are 3 possible mea

[FFmpeg-devel] [PATCH 2/5] Interplay MVE: Refactor IP packet format

2017-06-17 Thread Hein-Pieter van Braam
Interplay MVE can contain up to three different frame formats. They require different streams of information to render a frame. This patch changes the IP packet format to prepare for the extra frame formats. Signed-off-by: Hein-Pieter van Braam --- libavcodec/interplayvideo.c | 28 ++

[FFmpeg-devel] [PATCH 0/5] Interplay MVE: Implement additional frame formats

2017-06-17 Thread Hein-Pieter van Braam
This patch series implement the previously unknown opcodes 0x06, 0x0E, and 0x010 for Interplay MVE movies. With this series every MVE sample[0] plays correctly, but I have some doubts as to the implementation of the extra two AVFrames necessary for format 0x10. If someone has a better idea on how

[FFmpeg-devel] [PATCH 1/5] Interplay MVE: Implement MVE SEND_BUFFER operation

2017-06-17 Thread Hein-Pieter van Braam
Interplay MVE movies have a SEND_BUFFER operation. Only after this command does the current decoding buffer get displayed. This is required for the other frame formats. They are fixed-size and can't always encode a full frame worth of pixeldata. This code prevents half-finished frames from being e

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

2017-06-17 Thread Sasi Inguva
Hi, I was the one who made that change. We needed a way to obtain individual stream durations from a Matroska file without reading the entire file. I don't think it adds to the file size greatly (< 50 bytes) compared to the size of video and audio data, hence I didn't hide it under an option. How

Re: [FFmpeg-devel] videotoolboxenc.c crash on iOS8

2017-06-17 Thread Steven Liu
2017-06-17 11:17 GMT+08:00 姜 文杰 : > when use videotoolboxencoder in ffmpeg, some codes will lead to crash. > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > From ee465de23b27cbeaaa25fd

[FFmpeg-devel] videotoolboxenc.c crash on iOS8

2017-06-17 Thread 姜 文杰
when use videotoolboxencoder in ffmpeg, some codes will lead to crash. videotoolboxenc_crash_ios8.patch Description: videotoolboxenc_crash_ios8.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH 0/1] ffmpeg: Switch cuvid to generic hwaccel

2017-06-17 Thread Timo Rothenpieler
Am 17.06.2017 um 21:35 schrieb Hendrik Leppkes: On Sat, Jun 17, 2017 at 9:29 PM, Timo Rothenpieler wrote: Am 17.06.2017 um 00:11 schrieb Philip Langdale: On Fri, 16 Jun 2017 21:53:22 +0200 wm4 wrote: On Fri, 16 Jun 2017 20:31:14 +0200 Timo Rothenpieler wrote: Am 16.06.2017 um 16:41 schr

Re: [FFmpeg-devel] [PATCH 1/2] avformat/rmenc: do not access AVIO write buffer directly

2017-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2017 at 01:24:41AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/rmenc.c | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB No

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-17 Thread James Almer
On 6/17/2017 4:57 PM, Michael Niedermayer wrote: > On Fri, Jun 16, 2017 at 06:30:45PM -0300, James Almer wrote: >> On 6/11/2017 2:47 PM, James Almer wrote: >>> Fixes ticket #6413 >>> >>> Signed-off-by: James Almer >>> --- >>> The public key authentication also tries to use the password variable. I

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-17 Thread Michael Niedermayer
On Fri, Jun 16, 2017 at 06:30:45PM -0300, James Almer wrote: > On 6/11/2017 2:47 PM, James Almer wrote: > > Fixes ticket #6413 > > > > Signed-off-by: James Almer > > --- > > The public key authentication also tries to use the password variable. I > > don't know if NULL is valid in that case or no

Re: [FFmpeg-devel] [PATCH] libavformat/file: return AVERROR_EOF on EOF

2017-06-17 Thread Michael Niedermayer
On Thu, Jun 15, 2017 at 10:21:00AM +0200, Nicolas George wrote: > Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > > Signed-off-by: Daniel Kucera > > --- > > libavformat/file.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/file.c b/libavformat/file.c > >

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: return AVERROR_EOF on EOF

2017-06-17 Thread Michael Niedermayer
On Thu, Jun 15, 2017 at 10:19:53AM +0200, Nicolas George wrote: > Le septidi 17 prairial, an CCXXV, Daniel Kucera a écrit : > > Signed-off-by: Daniel Kucera > > --- > > libavformat/subfile.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/subfile.c b/li

Re: [FFmpeg-devel] [PATCH] Cleanly exit at the end of an Interplay MVE

2017-06-17 Thread Paul B Mahol
On 6/17/17, Hein-Pieter van Braam wrote: > Interplay movies signal the end of the stream, currently decoding > continues and eventually returns AVERROR_INVALIDDATA. > > This honors the MVE CHUNK_END and CHUNK_SHUTDOWN types. > > Signed-off-by: Hein-Pieter van Braam > --- > libavformat/ipmovie.c

[FFmpeg-devel] [PATCH] Cleanly exit at the end of an Interplay MVE

2017-06-17 Thread Hein-Pieter van Braam
Interplay movies signal the end of the stream, currently decoding continues and eventually returns AVERROR_INVALIDDATA. This honors the MVE CHUNK_END and CHUNK_SHUTDOWN types. Signed-off-by: Hein-Pieter van Braam ---  libavformat/ipmovie.c | 2 ++  1 file changed, 2 insertions(+) diff --git a/li

Re: [FFmpeg-devel] [PATCH] avformat/file: increase max packet size to 256k for written files

2017-06-17 Thread Michael Niedermayer
On Mon, Jun 05, 2017 at 07:16:57PM +0200, Marton Balint wrote: > Another huge performance improvement when using SMB/CIFS as output. > > Signed-off-by: Marton Balint > --- > libavformat/file.c | 5 + > 1 file changed, 5 insertions(+) is this intended to cause any change in output ? the fol

Re: [FFmpeg-devel] [PATCH 0/1] ffmpeg: Switch cuvid to generic hwaccel

2017-06-17 Thread Hendrik Leppkes
On Sat, Jun 17, 2017 at 9:29 PM, Timo Rothenpieler wrote: > Am 17.06.2017 um 00:11 schrieb Philip Langdale: >> >> On Fri, 16 Jun 2017 21:53:22 +0200 >> wm4 wrote: >> >>> On Fri, 16 Jun 2017 20:31:14 +0200 >>> Timo Rothenpieler wrote: >>> Am 16.06.2017 um 16:41 schrieb Philip Langdale: >

Re: [FFmpeg-devel] [PATCH 0/1] ffmpeg: Switch cuvid to generic hwaccel

2017-06-17 Thread Timo Rothenpieler
Am 17.06.2017 um 00:11 schrieb Philip Langdale: On Fri, 16 Jun 2017 21:53:22 +0200 wm4 wrote: On Fri, 16 Jun 2017 20:31:14 +0200 Timo Rothenpieler wrote: Am 16.06.2017 um 16:41 schrieb Philip Langdale: This is mechanically simple, but does the fact that additional command line arguments ha

[FFmpeg-devel] [PATCHv2 2/2] fate: use do_md5sum instead of the md5 protocol for most md5 fate tests

2017-06-17 Thread Marton Balint
The md5 protocol has no seek support, but some tests use seeks. This changes the fate tests to actually create the output files and calculate the md5 on the written files, which also makes the tests independent of the size of the output buffers and output buffering in general. A new md5pipe fate t

Re: [FFmpeg-devel] [PATCH] avfilter: add superequalizer filter

2017-06-17 Thread James Almer
On 6/17/2017 1:00 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/Makefile| 1 + > libavfilter/af_superequalizer.c | 381 > > libavfilter/allfilters.c| 1 + > 3 files changed, 383 insertions(+) > create m

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-17 Thread Hein-Pieter van Braam
On Sat, 2017-06-17 at 18:45 +0200, Paul B Mahol wrote: > Have you made sure that new code does not cause overreads? > > Use bytestream2* for that. > I have made that change, thanks, the code actually looks better now too! Attached is a new version of the patch. Thanks! - HPFrom e8a45ce4748e39

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-17 Thread Paul B Mahol
On 6/17/17, Hein-Pieter van Braam wrote: > Hi all, > > I seemed to have done something wrong when fixing the patchcheck > problems originally. Apparently I didn't build between making my > 'fixes' and creating the patch. The previous patch doesn't compile. > > I fixed this in this version, my apol

[FFmpeg-devel] [PATCH] avfilter: add superequalizer filter

2017-06-17 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile| 1 + libavfilter/af_superequalizer.c | 381 libavfilter/allfilters.c| 1 + 3 files changed, 383 insertions(+) create mode 100644 libavfilter/af_superequalizer.c diff --git a/li

Re: [FFmpeg-devel] [PATCH] avformat/aiffenc: add aiff_init()

2017-06-17 Thread James Almer
On 6/17/2017 6:43 AM, Paul B Mahol wrote: > On 5/28/17, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/aiffenc.c | 45 + >> 1 file changed, 29 insertions(+), 16 deletions(-) >> >> diff --git a/libavformat/aiffenc.c b/libavformat

Re: [FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-17 Thread Hein-Pieter van Braam
Hi all, I seemed to have done something wrong when fixing the patchcheck problems originally. Apparently I didn't build between making my 'fixes' and creating the patch. The previous patch doesn't compile. I fixed this in this version, my apologies for the noise. I've also fixed reading garbage

[FFmpeg-devel] [RFC] Implement support for interplay MVE 0x06, 0x0F and 0x10

2017-06-17 Thread Hein-Pieter van Braam
Hi all, This patch implements support for 3 previously unknown Interplay MVE opcodes. These opcodes together implement support for 2 additional video frame formats. This is my first time trying to contribute to ffmpeg so I expect this code to not be entirely up to snuff, I'm interested in getting

Re: [FFmpeg-devel] [PATCH 2/3] avformat/options: disable flush_packets as default

2017-06-17 Thread Michael Niedermayer
On Sat, Jun 17, 2017 at 12:18:27AM +0200, Marton Balint wrote: > > On Sun, 4 Jun 2017, Marton Balint wrote: > > >It is a huge performance improvement for encoding files with small packets > >(e.g. wav) over SMB/CIFS. > > > > Ping? Maybe enabling this unconditionally is also problematic for > pro

Re: [FFmpeg-devel] [PATCH] avformat/aiffenc: add aiff_init()

2017-06-17 Thread Paul B Mahol
On 5/28/17, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/aiffenc.c | 45 + > 1 file changed, 29 insertions(+), 16 deletions(-) > > diff --git a/libavformat/aiffenc.c b/libavformat/aiffenc.c > index fcadf149a0..1e0c5b11a0 100644 >