Re: [FFmpeg-devel] [PATCH] minterpolate: added codec_me_mode

2017-05-25 Thread Michael Niedermayer
On Mon, May 08, 2017 at 07:40:25PM +, Davinder Singh wrote: > hi, > > On Mon, Apr 24, 2017 at 9:43 PM Paul B Mahol wrote: > > > On 4/24/17, Davinder Singh wrote: > > > Patch attached. > > > > > > > So this encodes video frames to generate motion vectors? > > > > yes. it significantly impro

[FFmpeg-devel] [PATCH] lavc/golomb: Fix UE golomb overwrite issue.

2017-05-25 Thread Jun Zhao
From eabcbf3d41e83f24623e6195d4a0ff86e4d95a80 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 26 May 2017 09:02:29 +0800 Subject: [PATCH] lavc/golomb: Fix UE golomb overwrite issue. put_bits just support write up to 31 bits, when write 32 bit in put_bits, it's will overwrite the bit buffer, be

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-05-25 Thread Michael Niedermayer
On Thu, May 25, 2017 at 03:29:59PM +0100, Rostislav Pehlivanov wrote: > On 25 May 2017 at 15:10, Michael Niedermayer wrote: > > > Fixes: 1735/clusterfuzz-testcase-minimized-5350472347025408 > > > > Found-by: continuous fuzzing process https://github.com/google/oss- > > fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Carl Eugen Hoyos
2017-05-25 22:39 GMT+02:00 Paul B Mahol : > On 5/25/17, Carl Eugen Hoyos wrote: >> 2017-05-25 16:45 GMT+02:00 Paul B Mahol : >> >>> +@section surround >>> +Apply audio surround upmix filter. >>> + >>> +This filter allows to produce multichannel output from >>> stereo audio stream. >> >> Does this

[FFmpeg-devel] [PATCH] zscale: Add range options aliases to match scale ones

2017-05-25 Thread Vittorio Giovara
--- libavfilter/vf_zscale.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 594de179f4..d7b1612f3c 100644 --- a/libavfilter/vf_zscale.c +++ b/libavfilter/vf_zscale.c @@ -708,6 +708,7 @@ static const AVOption zscale_options[] = { {

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Paul B Mahol
On 5/25/17, Moritz Barsnick wrote: > The same questions as Carl Eugen posted came to mind, furthermore: > > On Thu, May 25, 2017 at 16:45:46 +0200, Paul B Mahol wrote: > >> +Set output channel layout. By default is @var{5.1}. > > The grammar of the second sentence here (and all the following > des

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Moritz Barsnick
The same questions as Carl Eugen posted came to mind, furthermore: On Thu, May 25, 2017 at 16:45:46 +0200, Paul B Mahol wrote: > +Set output channel layout. By default is @var{5.1}. The grammar of the second sentence here (and all the following descriptions) should either by: "By default, this i

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Paul B Mahol
On 5/25/17, Carl Eugen Hoyos wrote: > 2017-05-25 16:45 GMT+02:00 Paul B Mahol : > >> +@section surround >> +Apply audio surround upmix filter. >> + >> +This filter allows to produce multichannel output from >> stereo audio stream. > > Does this work on Pro Logic-encoded files (ticket #4085) > or d

Re: [FFmpeg-devel] [PATCH] zscale: Add pixdesc-API compatible color names to filter options

2017-05-25 Thread Vittorio Giovara
On Thu, May 25, 2017 at 2:53 PM, Vittorio Giovara wrote: > Reviewed-by: Paul B Mahol > Signed-off-by: Vittorio Giovara > --- > libavfilter/vf_zscale.c | 22 +- > 1 file changed, 21 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.

[FFmpeg-devel] [PATCH] zscale: Add pixdesc-API compatible color names to filter options

2017-05-25 Thread Vittorio Giovara
Reviewed-by: Paul B Mahol Signed-off-by: Vittorio Giovara --- libavfilter/vf_zscale.c | 22 +- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index 1675278935..8ef5cab320 100644 --- a/libavfilter/vf_zscale.c +++

Re: [FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Carl Eugen Hoyos
2017-05-25 16:45 GMT+02:00 Paul B Mahol : > +@section surround > +Apply audio surround upmix filter. > + > +This filter allows to produce multichannel output from > stereo audio stream. Does this work on Pro Logic-encoded files (ticket #4085) or does this filter use a different algorithm? Does a

[FFmpeg-devel] [PATCH] avcodec/htmlsubtitles: Be a bit more picky on syntax

2017-05-25 Thread Michael Niedermayer
This reduces the number of strstr() calls per byte Fixes timeout Fixes: 1817/clusterfuzz-testcase-minimized-5104230530547712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/htmlsubtitles.c | 4

[FFmpeg-devel] [PATCH 3/3] avcodec/audiotoolboxdec: switch to the new generic filtering mechanism

2017-05-25 Thread James Almer
Signed-off-by: James Almer --- Again, untested. libavcodec/audiotoolboxdec.c | 73 1 file changed, 20 insertions(+), 53 deletions(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index c30817778f..97514368bf 100644 --- a/li

Re: [FFmpeg-devel] [PATCH] lavc/aarch64: add a few SIMD function for AAC PS

2017-05-25 Thread James Almer
On 5/25/2017 12:50 PM, Clément Bœsch wrote: > --- > > This is still not benchmarked (written and verified with qemu). > > I typically wrote an alternative implementation for > stereo_interpolate[0] which needs to be compared with the current one: > > function ff_ps_stereo_interpolate_neon, expor

[FFmpeg-devel] [PATCH] lavc/aarch64: add a few SIMD function for AAC PS

2017-05-25 Thread Clément Bœsch
--- This is still not benchmarked (written and verified with qemu). I typically wrote an alternative implementation for stereo_interpolate[0] which needs to be compared with the current one: function ff_ps_stereo_interpolate_neon, export=1 ld1 {v0.4S}, [x2] ld1 {v

[FFmpeg-devel] [PATCH] avfilter: add audio surround upmixer

2017-05-25 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 27 ++ libavfilter/Makefile | 1 + libavfilter/af_surround.c | 853 ++ libavfilter/allfilters.c | 1 + 4 files changed, 882 insertions(+) create mode 100644 libavfilter/af_surround.

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-05-25 Thread Rostislav Pehlivanov
On 25 May 2017 at 15:10, Michael Niedermayer wrote: > Fixes: 1735/clusterfuzz-testcase-minimized-5350472347025408 > > Found-by: continuous fuzzing process https://github.com/google/oss- > fuzz/tree/master/projects/ffmpeg > Signed-off-by >

[FFmpeg-devel] [PATCH 2/2] avcodec/audiotoolboxdec: add FF_CODEC_CAP_INIT_CLEANUP to the decoder capabilities

2017-05-25 Thread James Almer
Extradata may be allocated and the AudioConverterRef may be created during init(), which in case of a failure would not be freed as close() isn't called afterwards. Signed-off-by: James Almer --- Untested. The documentation for AudioConverterDispose() didn't say if it could handle NULL as arg

[FFmpeg-devel] [PATCH 1/2] avcodec/audiotoolboxdec: always use a copy of the AVCodecContext extradata

2017-05-25 Thread James Almer
Fixes memleaks introduced by 954e2b3d34b7c2d82871254f07e2f8a39bc451cb Signed-off-by: James Almer --- Untested. libavcodec/audiotoolboxdec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/audiotoolboxdec.c b/libavcodec/audiotoolboxdec.c index a8655f0421

[FFmpeg-devel] [PATCH] avcodec/fft_template: Fix multiple runtime error: signed integer overflow: -1943918714 - 1935113003 cannot be represented in type 'int'

2017-05-25 Thread Michael Niedermayer
Fixes: 1735/clusterfuzz-testcase-minimized-5350472347025408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fft_template.c | 50 +++ 1 file changed,

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-25 Thread Michael Niedermayer
On Thu, May 25, 2017 at 08:20:46AM -0400, Ronald S. Bultje wrote: > Should fix tsan errors in utvideoenc_rgb_left and related tests. > --- > libavcodec/frame_thread_encoder.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/frame_thread_encoder.c

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/wavpack: Fix: runtime error: signed integer overflow: 3 * -2147483648 cannot be represented in type 'int'

2017-05-25 Thread Michael Niedermayer
On Wed, May 24, 2017 at 12:21:20AM +0200, Michael Niedermayer wrote: > Fixes: 1776/clusterfuzz-testcase-minimized-6191258231898112 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wa

Re: [FFmpeg-devel] [PATCH] avcodec/tscc2: Skip duplicate frames

2017-05-25 Thread Michael Niedermayer
On Sun, May 21, 2017 at 03:34:21PM +0200, Michael Niedermayer wrote: > This turns CFR duplicated frames into skiped frames > > Fixes: Timeout > Fixes: 1719/clusterfuzz-testcase-minimized-6375090079924224 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

[FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-25 Thread Ronald S. Bultje
Should fix tsan errors in utvideoenc_rgb_left and related tests. --- libavcodec/frame_thread_encoder.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavcodec/frame_thread_encoder.c b/libavcodec/frame_thread_encoder.c index 27ae356..6cf1a68 100644 --- a/libavc

Re: [FFmpeg-devel] [PATCH] frame_thread_encoder: extend critical code covered by finished_task_mutex.

2017-05-25 Thread Michael Niedermayer
On Wed, May 24, 2017 at 12:59:58PM -0400, Ronald S. Bultje wrote: > Hi, > > On May 24, 2017 12:51 PM, "Clément Bœsch" wrote: > > On Wed, May 24, 2017 at 12:15:05PM -0400, Ronald S. Bultje wrote: > > Should fix tsan errors in utvideoenc_rgb_left and related tests. > > --- > > libavcodec/frame_th

Re: [FFmpeg-devel] [PATCH] udp: ignore UDP packets without payload

2017-05-25 Thread Daniel Kučera
2017-05-24 9:02 GMT+02:00 Nicolas George : > Le quartidi 4 prairial, an CCXXV, Daniel Kucera a écrit : >> Time to time some devices send UDP packets without payload. >> ffmpeg previously exited on receiving such packet, this patch >> fixes this behaviour. >> >> Signed-off-by: Daniel Kucera >> ---