Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CID 1405135

2017-04-27 Thread Steven Liu
2017-04-26 16:43 GMT+08:00 Steven Liu : > Fixes Coverity CID: 1405135 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 3ec0f330fb..b7aafb73da 100644 > --

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-04-27 Thread Steven Liu
2017-04-26 7:30 GMT+08:00 Steven Liu : > fix ticket id: #6353 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 24 > 1 file changed, 24 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 27c8e3355d..3ec0f330fb 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH] avformat/concatdec: port to the new bitstream filter API

2017-04-27 Thread Michael Niedermayer
On Wed, Apr 26, 2017 at 04:40:55PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/concatdec.c | 86 > +++-- > 1 file changed, 26 insertions(+), 60 deletions(-) breaks ./ffmpeg -f concat -i ~/tickets/3108/concatfile.txt -cod

Re: [FFmpeg-devel] [PATCH] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-27 Thread Michael Niedermayer
On Fri, Apr 28, 2017 at 01:32:04AM +0700, Muhammad Faiz wrote: > So, all frames and errors are correctly reported in order. > Fix fate failure with THREADS>=4: > make fate-h264-attachment-631 THREADS=4 > > Suggested-by: wm4, Ronald S. Bultje, Marton Balint > Signed-off-by: Muhammad Faiz > --- >

[FFmpeg-devel] [PATCH] doc/developer: Add terse documentation of assumed C implementation defined behavior

2017-04-27 Thread Michael Niedermayer
Suggested-by: "Ronald S. Bultje" Signed-off-by: Michael Niedermayer --- doc/developer.texi | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index dbe1f5421f..a948113792 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -131,6 +131,11 @@ d

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
I realized that I missed the indentation. I've fixed it in the latest patch. On 27 April 2017 at 09:52, Lucas Cooper wrote: > find_fps attempts to infer framerate from AVCodec's timebase. When this > results in a frame rate that isn't explicitly marked as supported in > av_timecode_check_frame_r

[FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
find_fps attempts to infer framerate from AVCodec's timebase. When this results in a frame rate that isn't explicitly marked as supported in av_timecode_check_frame_rate, find_fps returns the AVStream's avg_frame_rate, which, per avformat.h, _may_ be set (or not). mov_get_mpeg2_xdcam_codec_tag, mo

[FFmpeg-devel] [PATCH] avcodec/pthread_frame, decode: allow errors to happen on draining

2017-04-27 Thread Muhammad Faiz
So, all frames and errors are correctly reported in order. Fix fate failure with THREADS>=4: make fate-h264-attachment-631 THREADS=4 Suggested-by: wm4, Ronald S. Bultje, Marton Balint Signed-off-by: Muhammad Faiz --- libavcodec/decode.c| 3 ++- libavcodec/pthread_frame.c | 15 +++-

Re: [FFmpeg-devel] [PATCH] pthread_frame: set err from the thread that return frame

2017-04-27 Thread Muhammad Faiz
On Fri, Apr 28, 2017 at 12:16 AM, Muhammad Faiz wrote: > On Thu, Apr 27, 2017 at 5:30 AM, Marton Balint wrote: >> >> >> On Wed, 26 Apr 2017, Ronald S. Bultje wrote: >> >>> Hi, >>> >>> On Wed, Apr 26, 2017 at 2:20 PM, Muhammad Faiz wrote: >>> On Wed, Apr 26, 2017 at 10:34 PM, Ronald S. Bultj

Re: [FFmpeg-devel] [PATCH] pthread_frame: set err from the thread that return frame

2017-04-27 Thread Muhammad Faiz
On Thu, Apr 27, 2017 at 5:30 AM, Marton Balint wrote: > > > On Wed, 26 Apr 2017, Ronald S. Bultje wrote: > >> Hi, >> >> On Wed, Apr 26, 2017 at 2:20 PM, Muhammad Faiz wrote: >> >>> On Wed, Apr 26, 2017 at 10:34 PM, Ronald S. Bultje >>> wrote: >>> > Hi, >>> > >>> > On Wed, Apr 26, 2017 at 1:21 AM

Re: [FFmpeg-devel] [PATCH] pthread_frame: set err from the thread that return frame

2017-04-27 Thread Muhammad Faiz
On Thu, Apr 27, 2017 at 2:59 AM, wm4 wrote: > On Thu, 27 Apr 2017 01:20:53 +0700 > Muhammad Faiz wrote: > >> On Wed, Apr 26, 2017 at 10:34 PM, Ronald S. Bultje >> wrote: >> > Hi, >> > >> > On Wed, Apr 26, 2017 at 1:21 AM, Muhammad Faiz wrote: >> > >> >> On Wed, Apr 26, 2017 at 4:09 AM, wm4 wr

[FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Lucas Cooper
find_fps attempts to infer framerate from AVCodec's timebase. When this results in a frame rate that isn't explicitly marked as supported in av_timecode_check_frame_rate, find_fps returns the AVStream's avg_frame_rate, which, per avformat.h, _may_ be set (or not). mov_get_mpeg2_xdcam_codec_tag, mo

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Ronald S. Bultje
Hi, On Thu, Apr 27, 2017 at 10:26 AM, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Ronald S. Bultje a écrit : > > Do we? Where is that documented? > > > > https://www.google.com/search?q=twos-complement+ffmpeg+site: > ffmpeg.org+-pipermail > > I think it is not documented anywhere but i

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Ronald S. Bultje a écrit : > Do we? Where is that documented? > > https://www.google.com/search?q=twos-complement+ffmpeg+site:ffmpeg.org+-pipermail I think it is not documented anywhere but in the head of various developers, but I remember at least one other instance

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Ronald S. Bultje
Hi, On Thu, Apr 27, 2017 at 9:56 AM, Michael Niedermayer wrote: > We require Twos-complement style definition for signed integers Do we? Where is that documented? https://www.google.com/search?q=twos-complement+ffmpeg+site:ffmpeg.org+-pipermail Ronald

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Explicitly address potential division by zero.

2017-04-27 Thread Michael Niedermayer
On Fri, Apr 21, 2017 at 12:01:01AM -0700, Lucas Cooper wrote: > Does this need any more work or explanation? The code looks duplicated twice, it should be put in a seperate function, also the indention depth of one of the added lines mismatches the existing code [...] -- Michael GnuPG finger

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Michael Niedermayer
On Thu, Apr 27, 2017 at 03:22:53PM +0200, Nicolas George wrote: > L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > > The code does use 16bit sized arrays later so larger deltas would not work > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/svq3.c | 2 +- > > 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > The code does use 16bit sized arrays later so larger deltas would not work > > Signed-off-by: Michael Niedermayer > --- > libavcodec/svq3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/svq3.c b/

[FFmpeg-devel] [PATCH 2/2] avcodec/svq3: Reject dx/dy beyond 16bit

2017-04-27 Thread Michael Niedermayer
The code does use 16bit sized arrays later so larger deltas would not work Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 3e35fd73d6..76a465b9c0 100644 --- a/libavcodec/svq3.

[FFmpeg-devel] [PATCH 1/2] avcodec/svq3: Increase offsets to prevent integer overflows

2017-04-27 Thread Michael Niedermayer
Fixes: 1280/clusterfuzz-testcase-minimized-6102353767825408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-04-27 Thread Nicolas George
L'octidi 8 floréal, an CCXXV, Michael Niedermayer a écrit : > I agree > in fact i added such a flag in 2011 (4d34b6c1a1254850e39a36f08f4d2730092a54db) > within the API of that time to avfilter It was not a bad idea, but it should not be limited to filters. A few comments. * First, the framequeue