Re: [FFmpeg-devel] [RFC] Reviewing merges

2017-04-23 Thread Aaron Levinson
On 4/23/2017 7:07 PM, Michael Niedermayer wrote: Hi all Should changes ported from libav (what we call merges) be reviewed before being pushed? I've asked about this on IRC (#ffmpeg-devel). The overall consensus there, at least at the time I asked it, is there is an expectation that such ch

[FFmpeg-devel] [RFC] Reviewing merges

2017-04-23 Thread Michael Niedermayer
Hi all Should changes ported from libav (what we call merges) be reviewed before being pushed? -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The educated differ from the uneducated as much as the living from the dead. -- Aristotle signature.asc Description: Digit

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/options: copy the coded_side_data in avcodec_copy_context()

2017-04-23 Thread Aaron Levinson
On 4/22/2017 10:26 AM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/options.c | 28 1 file changed, 28 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index b98da9378a..c721aa8d43 100644 --- a/libavcodec/options.c +++ b/libavc

Re: [FFmpeg-devel] fate/exr : add test for float negative value conversion

2017-04-23 Thread Michael Niedermayer
On Sun, Apr 23, 2017 at 06:04:07PM +0200, Martin Vignali wrote: > Hello, > > in attach patch to add a fate test for negative float value > > Need to be apply after patch in discussion : > Fate/exr : add test for piz uncompress > libavcodec/exr : fix float to uint16 conversion for negative value >

Re: [FFmpeg-devel] Fate/exr : add test for piz uncompress

2017-04-23 Thread Michael Niedermayer
On Sun, Apr 23, 2017 at 03:25:46PM +0200, Martin Vignali wrote: > Hello, > > Patch in attach for fate test of piz > > Sample can be found here : > https://we.tl/k1olNPK11t > > Need to be put inside ./fate-suite/exr uploaded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611E

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09'

2017-04-23 Thread James Almer
On 4/23/2017 7:00 PM, Michael Niedermayer wrote: On Sat, Apr 22, 2017 at 11:32:41PM +, James Almer wrote: ffmpeg | branch: master | James Almer | Sat Apr 22 20:08:42 2017 -0300| [bddb2343b6e594e312dadb5d21b408702929ae04] | committer: James Almer Merge commit '061a0c14bb5767bca72e3a7227ca4

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09'

2017-04-23 Thread Michael Niedermayer
On Sun, Apr 23, 2017 at 12:56:05PM -0300, James Almer wrote: > On 4/23/2017 10:30 AM, Michael Niedermayer wrote: > >On Sat, Apr 22, 2017 at 11:32:41PM +, James Almer wrote: > >>ffmpeg | branch: master | James Almer | Sat Apr 22 > >>20:08:42 2017 -0300| [bddb2343b6e594e312dadb5d21b408702929ae0

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09'

2017-04-23 Thread Michael Niedermayer
On Sat, Apr 22, 2017 at 11:32:41PM +, James Almer wrote: > ffmpeg | branch: master | James Almer | Sat Apr 22 > 20:08:42 2017 -0300| [bddb2343b6e594e312dadb5d21b408702929ae04] | committer: > James Almer > > Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09' > > * commit '061a0c14bb576

[FFmpeg-devel] [PATCH] avfilter: add lumakey filter

2017-04-23 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 16 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_lumakey.c | 174 +++ 4 files changed, 192 insertions(+) create mode 100644 libavfilter/vf_lumakey.c

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

2017-04-23 Thread Derek Buitenhuis
On 4/23/2017 4:28 PM, wm4 wrote: > Possibly you could CC the original author if you want to have more eyes > on it. I CC'd him on the other patch already, but I'll loop him in here. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ff

[FFmpeg-devel] libavcodec/exr : fix float to uint16 conversion for negative value

2017-04-23 Thread Martin Vignali
Hello, In attach a patch who fix this sample : https://we.tl/HWgF0SFEll This sample contain negative value in the red channel. Before this patch, negative red float are converted to max red instead of zero. The previous hack doesn't seems to work for float to uint so i add an explicit sign chec

[FFmpeg-devel] fate/exr : add test for float negative value conversion

2017-04-23 Thread Martin Vignali
Hello, in attach patch to add a fate test for negative float value Need to be apply after patch in discussion : Fate/exr : add test for piz uncompress libavcodec/exr : fix float to uint16 conversion for negative value Sample can be found here https://we.tl/HWgF0SFEll and need to be put inside f

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09'

2017-04-23 Thread James Almer
On 4/23/2017 10:30 AM, Michael Niedermayer wrote: On Sat, Apr 22, 2017 at 11:32:41PM +, James Almer wrote: ffmpeg | branch: master | James Almer | Sat Apr 22 20:08:42 2017 -0300| [bddb2343b6e594e312dadb5d21b408702929ae04] | committer: James Almer Merge commit '061a0c14bb5767bca72e3a7227ca

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

2017-04-23 Thread wm4
On Sun, 23 Apr 2017 14:08:18 +0100 Derek Buitenhuis wrote: > On 4/21/2017 4:40 PM, Derek Buitenhuis wrote: > > The WebM DASH spec states: > > The Initialization Segment shall not contain Clusters or Cues. > > The Segment Index corresponds to the Cues. > > > > Previously, it included the

Re: [FFmpeg-devel] [PATCH] Notify user when encode a CBR mp3 file without "-write_xing false". This may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it c

2017-04-23 Thread wm4
On Fri, 21 Apr 2017 22:59:41 +0800 sharp...@gmail.com wrote: > From: sharpbai > > Bug example: > > ffmpeg -i a.mp3 -c:a mp3 -ab 32k -ar 44100 -ac 1 b.mp3 > > The duration of the generated file b.mp3 is wrong on ios safari browser from > ios7 to ios10. > --- > libavformat/mp3enc.c | 7 ++-

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

2017-04-23 Thread wm4
On Sun, 23 Apr 2017 14:09:06 +0100 Derek Buitenhuis wrote: > On 4/20/2017 3:02 PM, Derek Buitenhuis wrote: > > --- > > libavformat/matroskadec.c | 14 +++--- > > 1 file changed, 11 insertions(+), 3 deletions(-) > > Ping. I don't think any active developer cares about it. Considering

Re: [FFmpeg-devel] [PATCH] This patch I add the check for venc->window_sequence[0], and set venc->log2_blocksize[0]=8 when venc->window_sequence[0] is the EIGHT_SHORT_SEQUENCE.

2017-04-23 Thread Michael Niedermayer
On Sun, Apr 23, 2017 at 03:27:30AM -0400, Ruyi Ji wrote: > Signed-off-by: Ruyi Ji > --- > libavcodec/psymodel.c| 1 + > libavcodec/vorbis_enc_data.h | 111 > +++ > libavcodec/vorbisenc.c | 68 +- > 3 files changed,

Re: [FFmpeg-devel] libavcodec/exr : fix piz uncompress on big endian

2017-04-23 Thread Martin Vignali
> > There is bswap dsp function that runs on array of bytes. > > Thanks for your answer New patch in attach, using bswapdsp. I only enable bswapdsp on big endian, no need for it on little endian. Martin 0001-libavcodec-exr-fix-piz-uncompress-on-big-endian.patch Description: Binary data

Re: [FFmpeg-devel] [FFmpeg-cvslog] Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09'

2017-04-23 Thread Michael Niedermayer
On Sat, Apr 22, 2017 at 11:32:41PM +, James Almer wrote: > ffmpeg | branch: master | James Almer | Sat Apr 22 > 20:08:42 2017 -0300| [bddb2343b6e594e312dadb5d21b408702929ae04] | committer: > James Almer > > Merge commit '061a0c14bb5767bca72e3a7227ca400de439ba09' > > * commit '061a0c14bb576

Re: [FFmpeg-devel] [PATCH] ffmpeg: do not report EOF on filters as an error.

2017-04-23 Thread Nicolas George
Le quartidi 4 floréal, an CCXXV, Paul B Mahol a écrit : > ok Thanks, pushed. Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-de

[FFmpeg-devel] Fate/exr : add test for piz uncompress

2017-04-23 Thread Martin Vignali
Hello, Patch in attach for fate test of piz Sample can be found here : https://we.tl/k1olNPK11t Need to be put inside ./fate-suite/exr half* files are probably already in fate-suite, but not the float file. (rgb_scanline_float_piz_48x32.exr) Can be test with make fate-exr SAMPLES=fate-suite/

Re: [FFmpeg-devel] libavcodec/exr : fix piz uncompress on big endian

2017-04-23 Thread Paul B Mahol
On 4/23/17, Martin Vignali wrote: > Hello, > > In attach a patch who i think fix decoding of piz file on big endian. > > I doesn't find a way to test it on mips qemu > but if i "enable" the HAVE_BIG_ENDIAN part on x86 > i have the same wrong crc previously reported in discussion : > https://ffmpeg

[FFmpeg-devel] libavcodec/exr : fix piz uncompress on big endian

2017-04-23 Thread Martin Vignali
Hello, In attach a patch who i think fix decoding of piz file on big endian. I doesn't find a way to test it on mips qemu but if i "enable" the HAVE_BIG_ENDIAN part on x86 i have the same wrong crc previously reported in discussion : https://ffmpeg.org/pipermail/ffmpeg-devel/2016-April/193471.htm

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

2017-04-23 Thread Derek Buitenhuis
On 4/20/2017 3:02 PM, Derek Buitenhuis wrote: > --- > libavformat/matroskadec.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Ping. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH] ffmpeg: do not report EOF on filters as an error.

2017-04-23 Thread Paul B Mahol
On 4/23/17, Nicolas George wrote: > Also print the error message in case of real error. > > Signed-off-by: Nicolas George > --- > ffmpeg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 70431e8808..bf04a6c683 100644 > --- a/ffmpeg.c > +++ b

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

2017-04-23 Thread Derek Buitenhuis
On 4/21/2017 4:40 PM, Derek Buitenhuis wrote: > The WebM DASH spec states: > The Initialization Segment shall not contain Clusters or Cues. > The Segment Index corresponds to the Cues. > > Previously, it included the cues if they were at the front. > > Signed-off-by: Derek Buitenhuis > -

[FFmpeg-devel] [PATCH] ffmpeg: do not report EOF on filters as an error.

2017-04-23 Thread Nicolas George
Also print the error message in case of real error. Signed-off-by: Nicolas George --- ffmpeg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 70431e8808..bf04a6c683 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2213,7 +2213,8 @@ static int ifilter_send

Re: [FFmpeg-devel] Match source video timestamp

2017-04-23 Thread Eran Kornblau
> Hi all, > > I'm trying to transcode some video file (MP4/h264 baseline vfr/AAC) with > ffmpeg, and I would like to have the > frame timestamps in the transcoded file perfectly match the source video. > This is in order to have them both > play together adaptively without issues (from my exper

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-23 Thread Muhammad Faiz
On Sat, Apr 22, 2017 at 4:27 PM, wm4 wrote: > On Sat, 22 Apr 2017 16:04:22 +0700 > Muhammad Faiz wrote: > >> Signed-off-by: Muhammad Faiz >> --- > > +1 to patches 1-7. As long as the accessors only trivially access > public fields, it's better (and less ugly) not to use accessors at all. add so

Re: [FFmpeg-devel] [PATCH] libavformat/mp3enc: Notify to add "-write_xing false" in CBR mode

2017-04-23 Thread Hendrik Leppkes
On Sun, Apr 23, 2017 at 6:11 AM, wrote: > From: sharpbai > > Encoding a CBR mp3 file without "-write_xing false" may result in > mp3 file duration incorect on ios safari browser and webview. > I try to fix it but it can’t be done as mp3 muxer don’t know > it is a CBR file until encode process fi

[FFmpeg-devel] [PATCH] This patch I add the check for venc->window_sequence[0], and set venc->log2_blocksize[0]=8 when venc->window_sequence[0] is the EIGHT_SHORT_SEQUENCE.

2017-04-23 Thread Ruyi Ji
Signed-off-by: Ruyi Ji --- libavcodec/psymodel.c| 1 + libavcodec/vorbis_enc_data.h | 111 +++ libavcodec/vorbisenc.c | 68 +- 3 files changed, 179 insertions(+), 1 deletion(-) diff --git a/libavcodec/psymodel.c b/l