Re: [FFmpeg-devel] [PATCH 1/2] avcodec/options: factorize avcodec_copy_context cleanup code

2017-04-22 Thread Aaron Levinson
On 4/22/2017 10:26 AM, James Almer wrote: Signed-off-by: James Almer --- libavcodec/options.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 7bdb0be5af..b98da9378a 100644 --- a/libavcodec/opt

Re: [FFmpeg-devel] [PATCH] Notify user when encode a CBR mp3 file without "-write_xing false". This may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it c

2017-04-22 Thread sharp bai
ios safari browser support the xing header, and the duration of the mp3 file with xing header is correct. But with "Info" replaced "Xing" in xing header in CBR mode, ios safari browser does not skip the first frame and using the first frame header(the bitrate in header has changed to enlarge frame

[FFmpeg-devel] [PATCH] libavformat/mp3enc: Notify to add "-write_xing false" in CBR mode

2017-04-22 Thread sharpbai
From: sharpbai Encoding a CBR mp3 file without "-write_xing false" may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it can’t be done as mp3 muxer don’t know it is a CBR file until encode process finished. And it’s hard to remove the first frame at th

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Hendrik Leppkes
On Sat, Apr 22, 2017 at 8:57 PM, Nicolas George wrote: > Le tridi 3 floréal, an CCXXV, Aaron Levinson a écrit : >> Then why have the accessors at all if the fields are public? > > To ensure ABI compatibility with the fork, which has been dropped. > To elaborate on that, the accessors existed prim

Re: [FFmpeg-devel] libavutil/thread.h: Fixed g++ build error when ASSERT_LEVEL is greater than 1

2017-04-22 Thread Marton Balint
On Fri, 21 Apr 2017, Marton Balint wrote: On Thu, 20 Apr 2017, Aaron Levinson wrote: On 4/19/2017 2:27 PM, Marton Balint wrote: On Mon, 17 Apr 2017, James Almer wrote: On 4/17/2017 5:39 AM, Clément Bœsch wrote: On Sun, Apr 16, 2017 at 05:20:02PM -0700, Aaron Levinson wrote: From 9e6a9e

Re: [FFmpeg-devel] [PATCH] ffmpeg; check return code of avcodec_send_frame when flushing encoders

2017-04-22 Thread Marton Balint
On Wed, 19 Apr 2017, Marton Balint wrote: On Tue, 18 Apr 2017, Michael Niedermayer wrote: On Tue, Apr 18, 2017 at 08:46:24PM +0200, Marton Balint wrote: On Tue, 18 Apr 2017, Michael Niedermayer wrote: On Tue, Apr 18, 2017 at 07:09:30AM +0200, Nicolas George wrote: Le nonidi 29 germina

[FFmpeg-devel] [PATCH] avfilter: add pixscope filter

2017-04-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_datascope.c | 218 +++-- 3 files changed, 213 insertions(+), 7 deletions(-) diff --git a/libavfilter/Makefile b/libavfilter/Makefile inde

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Aaron Levinson
On 4/22/2017 12:09 PM, Hendrik Leppkes wrote: On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote: On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi index 7a96c25..f3b8c0c8 100644 -

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Hendrik Leppkes
On Sat, Apr 22, 2017 at 9:07 PM, Aaron Levinson wrote: > > > On 4/22/2017 2:16 AM, Clément Bœsch wrote: >> >> On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: >> [...] >>> >>> diff --git a/doc/fate.texi b/doc/fate.texi >>> index 7a96c25..f3b8c0c8 100644 >>> --- a/doc/fate.texi >>> +

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Aaron Levinson
On 4/22/2017 2:16 AM, Clément Bœsch wrote: On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] diff --git a/doc/fate.texi b/doc/fate.texi index 7a96c25..f3b8c0c8 100644 --- a/doc/fate.texi +++ b/doc/fate.texi @@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate @float NOTE

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Nicolas George
Le tridi 3 floréal, an CCXXV, Aaron Levinson a écrit : > Then why have the accessors at all if the fields are public? To ensure ABI compatibility with the fork, which has been dropped. Regards, -- Nicolas George signature.asc Description: Digital signature __

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Aaron Levinson
On 4/22/2017 2:27 AM, wm4 wrote: On Sat, 22 Apr 2017 16:04:22 +0700 Muhammad Faiz wrote: Signed-off-by: Muhammad Faiz --- +1 to patches 1-7. As long as the accessors only trivially access public fields, it's better (and less ugly) not to use accessors at all. Then why have the accessors a

Re: [FFmpeg-devel] [PATCH v3 1/2] avfilter/interlace: change lowpass_line function prototype

2017-04-22 Thread Michael Niedermayer
On Thu, Apr 20, 2017 at 11:53:29PM +0200, Thomas Mundt wrote: > Hi, > > this patch set > 1) changes the lowpass_line function prototype in vf_interlace and > vf_tinterlace as suggested by James Almer. > 2) adds a complex (-1 2 6 2 -1) vertical low-pass filter to > vf_interlace and vf_tinterlace. >

[FFmpeg-devel] [PATCH 2/2] avcodec/options: copy the coded_side_data in avcodec_copy_context()

2017-04-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/options.c | 28 1 file changed, 28 insertions(+) diff --git a/libavcodec/options.c b/libavcodec/options.c index b98da9378a..c721aa8d43 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -190,15 +190,21 @@ void av

[FFmpeg-devel] [PATCH 1/2] avcodec/options: factorize avcodec_copy_context cleanup code

2017-04-22 Thread James Almer
Signed-off-by: James Almer --- libavcodec/options.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/options.c b/libavcodec/options.c index 7bdb0be5af..b98da9378a 100644 --- a/libavcodec/options.c +++ b/libavcodec/options.c @@ -188,6

Re: [FFmpeg-devel] fate/exr : fix pix_fmt for pxr24 half/uint32

2017-04-22 Thread Martin Vignali
> > How does it fix it ? > if it doesnt contain alpha but tests alpha thats a bit odd and may > test things that otherwise wouldnt be tested. > But "fix" sounds like theres something wrong, not just odd > Can you clarify/elaborate ? > > thx > > Hello, I made a copy and paste of a previous line whe

Re: [FFmpeg-devel] [PATCH] Notify user when encode a CBR mp3 file without "-write_xing false". This may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it c

2017-04-22 Thread Michael Niedermayer
On Fri, Apr 21, 2017 at 10:59:41PM +0800, sharp...@gmail.com wrote: > From: sharpbai > > Bug example: > > ffmpeg -i a.mp3 -c:a mp3 -ab 32k -ar 44100 -ac 1 b.mp3 > > The duration of the generated file b.mp3 is wrong on ios safari browser from > ios7 to ios10. > --- > libavformat/mp3enc.c | 7 +

Re: [FFmpeg-devel] fate/exr : fix pix_fmt for pxr24 half/uint32

2017-04-22 Thread Michael Niedermayer
On Sun, Apr 02, 2017 at 11:00:52PM +0200, Martin Vignali wrote: > Hello, > > In attach a patch to fix a fate test, the sample doesn't have alpha > > Martin > fate/image.mak |2 +- > ref/fate/exr-rgb-scanline-pxr24-half-uint32-13x9 |2 +- > 2 files chang

Re: [FFmpeg-devel] [PATCH] Fixed memory leaks associated with AVStream objects if FF_API_LAVF_AVCTX is defined

2017-04-22 Thread Michael Niedermayer
On Fri, Apr 21, 2017 at 06:05:12PM -0300, James Almer wrote: > On 4/21/2017 6:03 PM, James Almer wrote: > >On 4/21/2017 12:09 PM, Michael Niedermayer wrote: > >>On Thu, Apr 20, 2017 at 11:30:13PM -0700, Aaron Levinson wrote: > >>> From 4f27e910aca6dae6642b4d73cf07fa0d6c4b1618 Mon Sep 17 00:00:00 20

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-22 Thread wm4
On Fri, 21 Apr 2017 15:31:55 +0100 Amine kabab wrote: > Normally, all the streams > Wouldn't it be better to only consider the selected streams for this? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH] [UPDATE] HLS, add option to skip down streams,

2017-04-22 Thread Moritz Barsnick
On Fri, Apr 21, 2017 at 11:34:39 +0100, Amine kabab wrote: > +{"skip_down_streams", "continue playback of HLS when one of the variant > streams are down", > +OFFSET(skip_down_streams), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, > FLAGS}, "one" is singular, so this would be "... streams is d

[FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

2017-04-22 Thread Matt Oliver
Currently the find_things configure function will scan a code file (e.g. allfilters.c) and then create a list of pre-processor values to be added to configure. Unfortunately the way it currently does it is incorrect with what the original c code expects. For example the following exists in allfilte

Re: [FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

2017-04-22 Thread Matt Oliver
On 22 April 2017 at 21:09, Matt Oliver wrote: > Currently the find_things configure function will scan a code file (e.g. > allfilters.c) and then create a list of pre-processor values to be added > to configure. > Unfortunately the way it currently does it is incorrect with what the > original c

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread wm4
On Sat, 22 Apr 2017 16:04:22 +0700 Muhammad Faiz wrote: > Signed-off-by: Muhammad Faiz > --- +1 to patches 1-7. As long as the accessors only trivially access public fields, it's better (and less ugly) not to use accessors at all. ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] Added additional note to fate.texi to describe the importance of not checking out files from git with core.autocrlf set to true

2017-04-22 Thread Clément Bœsch
On Fri, Apr 21, 2017 at 04:48:27PM -0700, Aaron Levinson wrote: [...] > diff --git a/doc/fate.texi b/doc/fate.texi > index 7a96c25..f3b8c0c8 100644 > --- a/doc/fate.texi > +++ b/doc/fate.texi > @@ -77,6 +77,16 @@ FATE_SAMPLES=fate-suite/ make fate > @float NOTE > Do not put a '~' character in the

[FFmpeg-devel] [PATCH 2/7] avformat: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- libavformat/mux.c| 2 +- libavformat/uncodedframecrcenc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 3a5e876..4e21083 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@

[FFmpeg-devel] [PATCH 3/7] avdevice: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- libavdevice/alsa_enc.c | 2 +- libavdevice/lavfi.c| 10 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/libavdevice/alsa_enc.c b/libavdevice/alsa_enc.c index bddc61f..0bef625 100644 --- a/libavdevice/alsa_enc.c +++ b/libavdevice/alsa

[FFmpeg-devel] [PATCH 1/7] avcodec: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- libavcodec/ac3dec.c | 2 +- libavcodec/cpia.c | 8 +++ libavcodec/cuvid.c | 6 ++--- libavcodec/decode.c | 62 - libavcodec/encode.c | 2 +- libavcodec/exr.c| 2 +- libavcodec/

[FFmpeg-devel] [PATCH 4/7] avfilter: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- libavfilter/af_afade.c | 6 +++--- libavfilter/af_amerge.c| 2 +- libavfilter/af_apad.c | 2 +- libavfilter/af_aphaser.c | 2 +- libavfilter/af_aresample.c | 2 +- libavfilter/af_ashowinfo.c | 6

[FFmpeg-devel] [PATCH 7/7] tests: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- tests/api/api-flac-test.c | 4 ++-- tests/api/api-seek-test.c | 2 +- tests/api/api-threadmessage-test.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/api/api-flac-test.c b/tests/api/api-flac-test.c index 7b48059.

[FFmpeg-devel] [PATCH 6/7] examples: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- doc/examples/filtering_audio.c | 2 +- doc/examples/filtering_video.c | 2 +- doc/examples/transcoding.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/examples/filtering_audio.c b/doc/examples/filtering_audio.c index 679218c..9fc4f

[FFmpeg-devel] [PATCH 5/7] ff*: do not use AVFrame accessor

2017-04-22 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- ffmpeg.c| 10 +- ffmpeg_filter.c | 2 +- ffplay.c| 24 ffprobe.c | 22 +++--- 4 files changed, 29 insertions(+), 29 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 143322c..156cced 100644